- 08 Feb, 2019 40 commits
-
-
Yuwei Huang authored
Add API key for remoting to use during the signaling process. Note that this key is only used by Chrome Remote Desktop and will not be used in the Chrome browser. Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973 Bug: 927962 Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f Reviewed-on: https://chromium-review.googlesource.com/c/1450409Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#630352}
-
Vlad Tsyrklevich authored
Follow-up to https://crrev.com/629713. Bug: 930022, 912286 Change-Id: I04578b0c803fc7e43b5bf43079c797862fdff552 Reviewed-on: https://chromium-review.googlesource.com/c/1460864 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#630351}
-
Victor Vasiliev authored
The code in question already heavily relies on Linux specifics, so we might as well use them in order to avoid adding extra platform layers. Merge internal change: 232956193 R=rch@chromium.org Change-Id: I190deadc85fd55a717f8c78f373978112370146f Reviewed-on: https://chromium-review.googlesource.com/c/1460075Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#630350}
-
Dave Tapuska authored
Set owner as blink core owners with no expiry. Change-Id: I007688bfa75db013745032454a159a1fc306cf65 Reviewed-on: https://chromium-review.googlesource.com/c/1460868Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f2a3f5943e4c..a41c6858da8a git log f2a3f5943e4c..a41c6858da8a --date=short --no-merges --format='%ad %ae %s' 2019-02-08 robertphillips@google.com Move proxyProvider and singleOwner to GrImageContext 2019-02-08 mtklein@google.com remove a couple more jsoncpp deps 2019-02-08 jcgregorio@google.com docs - Trim down infra trooper docs. 2019-02-08 kjlubick@google.com Remove abandoned fSubdivisionsMax 2019-02-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a41c6858da8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I76b756788b771b352b7fa064af7b8fb7763294eb Reviewed-on: https://chromium-review.googlesource.com/c/1460978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630348}
-
Oskar Sundbom authored
Print the settings used to configure the WebRTC audio processing module to Chrome's WebRTC logs. Bug: 929119 Change-Id: I62d1c28c48da866d7c117fe5c47ba769c2541b8f Reviewed-on: https://chromium-review.googlesource.com/c/1461022Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#630347}
-
Raymond Toy authored
OfflineAudioContext.suspend rounds the time up to the next render quantum instead of down. It is sometimes confusing when suspend occurs before the given time, which is different from how everything else works in WebAudio. A few tests need to be fixed because they computed the boundary by rounding down instead of up. One test needed to be adjusted because the times were rounded to different boundaries instead of the same boundary. See also https://github.com/WebAudio/web-audio-api/issues/1822 Bug: 927895 Change-Id: Ie6685c620dd38eb2a059901d13b907764ba1a2db Reviewed-on: https://chromium-review.googlesource.com/c/1450536Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630346}
-
Avery Musbach authored
For the start and end of dragging the split screen divider, the specification indicates the tween type of the white handle animation as fast out and slow in, instead of fast in and slow out. Test: manual Bug: 929972 Change-Id: I41f61dd4bed4e94e59e9ed1cb310c95d8bad6e7d Reviewed-on: https://chromium-review.googlesource.com/c/1460308Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#630345}
-
Ehsan Karamad authored
The attaching logic and FrameNavigationHelper are now moved to another class (MimeHandlerViewAttachHelper). This CL removes the left over code. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: Ib67d21ab8104e957bf41df0d20ddf99a04dac3d3 Reviewed-on: https://chromium-review.googlesource.com/c/1460596Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#630344}
-
sahel authored
This is a reland of a6e16acd The reason for the leak was calling async middleClickAutoscroll() function without await. Bug:845960 Original change's description: > Add AUTOSCROLL scroll input source. > > With autoscroll being handled by browser side fling, there are GSU events > with AUTOSCROLL source device type. This cl fixes the assumption of not > wheel is equal to touch in input_handler_proxy and layer_tree_host_impl. > > Change-Id: Id5c54245aa10c6e958fe4e3a8ec7d338923101db > Reviewed-on: https://chromium-review.googlesource.com/c/1081163 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629598} Change-Id: I2fbeff1db64b233c3708c6425ef8f5e9571fff12 Reviewed-on: https://chromium-review.googlesource.com/c/1459808Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#630343}
-
Andrew Grieve authored
Useful to see what the .apk will look like for a specific android version. Change-Id: Ib294132e5c3382877d9f591751b8b58fedc12835 Reviewed-on: https://chromium-review.googlesource.com/c/1460482 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#630342}
-
Vlad Tsyrklevich authored
Follow-up to https://crrev.com/629713. Bug: 912286 Change-Id: I4a28b7d2dd6525cdcb36ac72691a75b8d1b4f67f Reviewed-on: https://chromium-review.googlesource.com/c/1460866 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630341}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc5de6a89d4e..56445ec1e273 git log fc5de6a89d4e..56445ec1e273 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 rsavitski@google.com Merge "initial heapprofd cts test for debuggable java apps" Created with: gclient setdep -r src/third_party/perfetto@56445ec1e273 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib3396c355eec4d1b52d837f8be8778a94c28018e Reviewed-on: https://chromium-review.googlesource.com/c/1460155Reviewed-by:
-
Benoît Lizé authored
Enabling a feature on trunk is required to ramp up the feature in stable. The feature was already enabled on bots, so this CL removes the bots configuration, but no behavior change is expected on bots. Bug: 877044 Change-Id: I6ce5c45934fe34e4e22dab4b916058297b86a217 Reviewed-on: https://chromium-review.googlesource.com/c/1458201Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630339}
-
Doug Arnett authored
Bug: 929501 Change-Id: Iedb98ca6909f8832caf5b387eca7a9e503ed006c Reviewed-on: https://chromium-review.googlesource.com/c/1457717Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#630338}
-
Mario Sanchez Prada authored
This is the first step to provide an AccountsCookieMutator instance to allow modifying the APISID cookie by adding and removing accounts, as per the "Porting GaiaCookieManagerService to IdentityManager" document [1]. This initial patch includes the interface AccountsCookieMutator and dummy concrete implementations that will be filled with methods in further CLs, as well as the required API in IdentityManager to return this new mutator. [1] https://docs.google.com/document/d/1bO7JsZE-xA8DSE18NeCZffbAnFZTo6vAtBCKsxaz4u8/edit# Bug: 926203 Change-Id: Id36c79de5b684afbafddbfff5d4b723d30f00796 Reviewed-on: https://chromium-review.googlesource.com/c/1454578 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630337}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I20e7502c8c87f434fcdc7605e2a31349180a7d7f Reviewed-on: https://chromium-review.googlesource.com/c/1459068Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630336}
-
danakj authored
Flakes locally and on try bots. R=erikchen@chromium.org TBR=jwd Bug: 731466 Change-Id: I85201eb31a56b553640f14a6a1cc9284231bedd8 Reviewed-on: https://chromium-review.googlesource.com/c/1459334 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630335}
-
Dave Tapuska authored
BUG=846858 Change-Id: I2a3be3971647967175b498c8546fa4177c61acdd Reviewed-on: https://chromium-review.googlesource.com/c/1459324 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630334}
-
Michael Lippautz authored
This reverts commit 5a47d400. Reason for revert: Maybe introduced breakage. See bugs. Original change's description: > DragController: Clear DragState in DragEnd > > DragState is a ScriptWrappable which can keep alive JavaScript upon > unified heap garbage collection resulting in a leak of the last Window > that used a drag event. Clear the state when the drag ended. > > Bug: 843903, 928781 > Change-Id: Id86a1a917fe772f56fb679e1d73ef3453785ce6d > Reviewed-on: https://chromium-review.googlesource.com/c/1456073 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629582} TBR=haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843903, 928781, 930044, 930079 Change-Id: I64722d3fb1757b805440e9840613601634c5d370 Reviewed-on: https://chromium-review.googlesource.com/c/1461019Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Tien Mai authored
Prevent the user from pressing on the submit button when another operation is pending: - While the GLS is running. - When user needs to update their password but the password field is empty. - Time between GLS completion and actual system sign in. Fix SaveAccountInfo not working properly when the user needs to update their password. The new password was not sent to SaveAccountInfo to use to sign in the user. Also SaveAccountInfo would be called before sign in was really successful on the system leading to cases where it may save data that is not valid. Now SaveAccountInfo is only called on a success during ReportResult. - Reduce the number of times GCPW tries to query if the user's password is valid. This will prevent the user from being locked out too quickly when the password they get from GLS does not match their Windows password. Bug: 929811 Change-Id: Ibbbfc2d648431100c521a9043dcb6a8f61d4d53e Reviewed-on: https://chromium-review.googlesource.com/c/1459075 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
Fan Yang authored
In QUIC, fix the places where assuming first received packet number is 1. Protected by gfe2_restart_flag_quic_enable_accept_random_ipn. Merge internal change: 232672236 R=rch@chromium.org Change-Id: Ibd0d7ec15aea0605a660bd03365cc712eb7ea364 Reviewed-on: https://chromium-review.googlesource.com/c/1459524 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
Before this patch, Autofill Assistant would only run in a Custom Tab. With this patch, Autofill Assistant can run in a normal tab. The UI is re-created when switching to a tab that has Autofill Assistant running. In practice, since Autofill Assistant can currently only be started from a Custom Tab, this means that an Autofill Assistant session can now follow a tab as it moves out of Custom Tab (by selecting the menu Open tab is Chrome.) The approach is described in go/aa-any-tab Still missing: reusing UI instances when switching from a tab with Autofill Assistant to another tab with Autofill Assistant. Bug: 806868 Change-Id: I8741c6f2d40d39a9e10d7526721d932608dea2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1458178Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630330}
-
Stephane Zermatten authored
Before this change, Client::Stop() was called from the UI layer when doing a graceful shutdown. This meant that a Controller without UI would not shut down. With this change, the shutdown procedure happens regardless of the UI layer. The UI layer is informed of an upcoming shutdown and reacts to it. The main change is that in a graceful shutdown, the Client deletes the controller immediately, but the UI elements, in Java, say up for a few seconds. Controller-initiated graceful shutdown: - UIController::EnterState(STOPPED) - Client::Shutdown +- Controller::Terminate | +- UIController::WillShutdown | | +- post delayed task calling AssistantCoordinator:destroy +- delete UIController +- delete Controller After this, the UI stays up, in STOPPED state. 5s later, the AssistantCoordinator::destroy, which makes the UI disappear. An immediate shutdown: - Client::Shutdown +- Controller::Terminate | +- UIController::WillShutdown | | +- AssistantCoordinator:destroy +- delete UIController +- delete Controller In the case where Controller::Terminate decides to delay termination, it still calls UIController::WillShutdown right away, so that the time the UI disappears isn't delayed: - Client::Shutdown +- Controller::Terminate | +- UIController::WillShutdown | | +- AssistantCoordinator:destroy [...] script shuts down - Controller::OnScriptExecuted(TERMINATE) +- client->Shutdown | +- Controller::Terminate | +- delete UIController | +- delete Controller The goal of this change is to support running Autofill Assistant inside of a tab, which means that, for inactive tabs, the Controller might run without UI. This is a refactoring. It should not have any visible effect. Bug: 806868 Change-Id: Iafa4a131de49e63909a0385a85a20f2c350c27d8 Reviewed-on: https://chromium-review.googlesource.com/c/1456071Reviewed-by:
-
Yuki Shiino authored
This is a quick fix to work around an issue reported at: https://github.com/webcompat/web-bugs/issues/25390 This patch makes readonly indexed properties not fall back to named properties. Coincidentally the condition only applies to CSSStyleDeclaration, where we have the issue above. Blink's implementation for indexed/named properties is outdated overall. General fix should follow. Change-Id: I418eaf04c61ac3680ff3bc75710489b526e36100 Reviewed-on: https://chromium-review.googlesource.com/c/1460588 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#630328}
-
Sebastien Lalancette authored
Added travel specific heuristics via travel_field, and parsed them with a higher priority than addresses or credit cards. This way we'll tag travel-related fields earlier, making sure addresses/credit cards don't get to tag them. For now, we're setting all travel-related field to UNKNOWN_TYPE, since we don't need to know beyond simply filtering them out. [i18n] Also fixed the "email" regex w.r.t. Spanish forms. Testing: Added the buggy website's i18n forms to from_structure_browsertests. Bug: 925402 Change-Id: I491ee8931cb457d8d7f948ae1891da57c1d0fa97 Reviewed-on: https://chromium-review.googlesource.com/c/1454221 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630327}
-
Tien Mai authored
Bug: 917155 Change-Id: I080666f15a1d352306a928116ce6ea37b837ded0 Reviewed-on: https://chromium-review.googlesource.com/c/1460605Reviewed-by:
-
Xida Chen authored
Right now the PlaybackParams takes an ImageProvider and a PaintWorkletImageProvider. This CL does a small refactor to create a DispatchingImageProvider which would decide which provider to use. In order to do that, we change the ImageProvider::GetDecodedDrawImage to instead return a ScopedResult which could either be a pointer to DecodedDrawImage, or to a PaintRecord, which is what we need for PaintWorkletImageProvider. Bug: 907897 Change-Id: I674a5466873d18f4c53a5e1db3c6e03bae0f88ed Reviewed-on: https://chromium-review.googlesource.com/c/1431016Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630325}
-
Jinho Bang authored
Before this patch, when calling updateWith() w/o total member in PaymentRequestUpdateEvent, it throws SyntaxError. This is a implementation bug and doesn't match behavior with the spec[1]. So, this patch makes the total member optional when updateWith() called. This isn't breaking change because existing implementation always required the total member whenever updateWith() called. [1] https://w3c.github.io/payment-request/#update-a-paymentrequest-s-details-algorithm Bug: 902291 Change-Id: I5dd99dd99b3f006feaf4fee66a16a7e4f46831de Reviewed-on: https://chromium-review.googlesource.com/c/1439456Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#630324}
-
Sylvain Defresne authored
The override of RegisterListPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty list (as there is an override doing this). If the list is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: Ib4e28e427c8ff31210aa40e1ee0d9398cebee1b1 Reviewed-on: https://chromium-review.googlesource.com/c/1454546 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
dpapad authored
The race condition manifested when transitioning from a subpage to another sibling subpage, and caused the showing-main-page event to erroneously be fired after the subpage-expand event. Bug: 928082 Change-Id: If66e0d0e62cda2d1310dddc067429ca6f7133368 Reviewed-on: https://chromium-review.googlesource.com/c/1459589 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#630322}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0c94a27a320..f2a3f5943e4c git log e0c94a27a320..f2a3f5943e4c --date=short --no-merges --format='%ad %ae %s' 2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 52d861bd49cc..cd4f1fbaabce (27 commits) 2019-02-08 borenet@google.com Roll third_party/externals/angle2 a54104803d72..52d861bd49cc (8 commits) Created with: gclient setdep -r src/third_party/skia@f2a3f5943e4c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I308a70c58e010ee4b62f7f04966221fb2b6fe1a6 Reviewed-on: https://chromium-review.googlesource.com/c/1460154Reviewed-by:
-
Stephane Zermatten authored
This change treats payment request as a Controller state change: an in-progress payment request is now available as a state on the Controller with its associated OnPaymentRequestChanged method on the UIController. To make that possible, this change groups all parameters of GetPaymentInformation into PaymentRequestOptions, which mirrors Java's AssistantPaymentRequestOptions. The goal of this change is to make it possible to attach the UI to a new controller. This is a pure refactoring. It should not have any visible effect. Bug: 806868 Change-Id: Ieaaf559450e28602ff8f25fa0878e5a833ed500e Reviewed-on: https://chromium-review.googlesource.com/c/1446667 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
Before this patch, when ShowProgressBarAction had no progress set or progress set to 0, the action would return without calling the callback. In this case, the script would just hang. This was broken in http://crrev/c/1445902 With this patch, scripts with 0 progress continue without changing the progress in any ways. This is guaranteed by Controller::SetProgress, which only takes progress increases into account. Also, with this patch, the message of ShowProgressBarAction is taken into account, even if the progress is unset or set to 0. Bug: 806868 Change-Id: Id48e43a2e418bfdf307596f93323ff8c873699eb Reviewed-on: https://chromium-review.googlesource.com/c/1460922Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#630319}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/545f0d025ef1..610a4c6ce76c git log 545f0d025ef1..610a4c6ce76c --date=short --no-merges --format='%ad %ae %s' 2019-02-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@610a4c6ce76c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If460df3108f279002e0fa355cc270803248d0c7f Reviewed-on: https://chromium-review.googlesource.com/c/1460976Reviewed-by:
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I59ec8ad468560f52b70d2d4859d72415a8336bff Reviewed-on: https://chromium-review.googlesource.com/c/1459697 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630317}
-
Rayan Kanso authored
Due to the scheduler handling multiple requests, there is an issue where the in-progress processed bytes are being overwritten. This CL fixes the test by not relying on that value. The underlying issue will be fixed in a follow-up CL. Bug: 929929 Change-Id: I48a1d7bb3899c441cdbf8dd2c13623204c1b9213 Reviewed-on: https://chromium-review.googlesource.com/c/1460924Reviewed-by:
Mugdha Lakhani <nator@google.com> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#630316}
-
Mohamed Amir Yosef authored
Legacy clients used to mangle with bookmark titles (e.g. by appending a blank space to an empty title) This CL makes sure that modern clients respect that when merging remote and local bookmarks hierarchies. In addition, this CL adds the unit test and integration test coverage for that scenario! Bug: 930124 Change-Id: Ia3907e22a651000e5d7645d614e0f7a482298503 Reviewed-on: https://chromium-review.googlesource.com/c/1459546 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630315}
-
Andrew Grieve authored
Bug: 928902 Change-Id: I8deed83f0d2ecfcfd01238e05f0f99bd231d7956 Reviewed-on: https://chromium-review.googlesource.com/c/1460481Reviewed-by:
-
Tien Mai authored
Base unit test has all the boiler plate code needed to run a fake gls from a unit test that derives from it. Added a helper function for creating fake users during GCPW unit test Fix timing of gls done event in unit test not being consistent when a gls run fails and when it doesn't. When the gls run fails, the completion event is sent too soon and causes some unit tests to start running and checking the results before they have been properly set. Change-Id: I3754d8fafc3ffce5c5b50eae71db007f980c872c Reviewed-on: https://chromium-review.googlesource.com/c/1458679 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
