GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4fe3de13..5ce57437

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic6188939a9cbae19b9887373430c1bcc7a05ae6c
Reviewed-on: https://chromium-review.googlesource.com/1174703Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583010}

Automates the VR Browser manual test for ensuring that permissions
granted to a site in 2D persist through reloads and VR entry.

Bug: 861941
Change-Id: I2f2ae07705713a97f8e428ec325e3d5412b37fbb
Reviewed-on: https://chromium-review.googlesource.com/1171600Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583009}

Bug: 845293
Change-Id: Ic41d3ac4a1925d6e6c175d00b8ded71f85a6fedc
Reviewed-on: https://chromium-review.googlesource.com/1089646
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583008}

Bug: 843745
Change-Id: I86c008448cc40004c45823f21cb4fff607208ed5
Reviewed-on: https://chromium-review.googlesource.com/1129630
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583007}

Removed unused methods.

R=lushnikov@chromium.org

Bug: none
Change-Id: I63d14fcbf504d7b39d1758c54df358c1d6bd1630
Reviewed-on: https://chromium-review.googlesource.com/1174857
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583006}

Previously, --reset-results removed the existing platform baseline
without recreating one if the fallback baseline doesn't exist.

Fix the issue by checking non-exist and non-missing condition
before removing the current baseline.

Bug: 845781
Change-Id: I7dbe46665d9574b310020c4ffc4041b6235d5570
Reviewed-on: https://chromium-review.googlesource.com/1173483
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583005}

"Cancel" was calling the form's submit event, which triggered the add
link flow.

Bug: 874018
Change-Id: Iad822d3884484f5dc0d9f3e6667c9d4c9e0a2728
Reviewed-on: https://chromium-review.googlesource.com/1174908Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583004}

The variable `kTweenType` was re-defined in another class. Renaming it to `kIconLabelBubbleTweenType`, and changed the other constants similarly to avoid future conflicts.

Original change introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1162862


Bug: 855186
Change-Id: I94d3ea5b4732bac586780e441804a3e98bb99bb0
Reviewed-on: https://chromium-review.googlesource.com/1174893
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583003}

If a RemoteFrameView is inside a throttled LocalFrameView with out-of-
date layout, then it's not possible to compute its viewport
intersection. In that case, just propagate an empty intersection (which
is probably correct, because a throttled frame is presumably off
screen).

BUG=711468
R=kenrb@chromium.org

Change-Id: Ie400c407871aab74561b4e34eefece17aa8c3e27
Reviewed-on: https://chromium-review.googlesource.com/1173345Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583002}

Minor change on custom link edit input label and text field background
color css setting according to GM2 webUI spec.

Bug: 873721
Change-Id: I6770ce6eedf4a4e5ec6cb273e34136d30ee17f58
Reviewed-on: https://chromium-review.googlesource.com/1174870Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583001}

When launching a process with admin rights we can't duplicate the
process handle with dwDesiredAccess == PROCESS_QUERY_INFORMATION.
But we don't need to - we just need the same rights we have to the
original handle. So we should instead set dwOptions to
DUPLICATE_SAME_ACCESS.

This is an update to correct the flaw added in crrev.com/c/1155498

Bug: 871522
Change-Id: Ib5e526c1a1dfef07e6bb5e6d4d64e12c2d4c3eed
Reviewed-on: https://chromium-review.googlesource.com/1173499Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583000}

Bug: internal b/112284077
Change-Id: I9b30669d0864f5f72369ae76e353200609108e5f
Reviewed-on: https://chromium-review.googlesource.com/1167970Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Andrei Pascovici <apascovici@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582999}

The keyboard shortcut dialog is a UI mojo app that runs in a separate
process and has its own AXTree. The code in AutomationManagerAura that
looks up the AXTree ID for a hit test was looking at the wrong
views::View to get the value, due to a confusing condition in how
views::Widget looks up contents views.

Added DCHECKs to make sure this looks up a proper remote AXTree id.

Bug: 872421
Test: Turn on select-to-speak, hit Ctrl-Alt-/, click in dialog
Change-Id: Id9aba72b1aa73b7677e0dc52d1a427c202db0a78
Reviewed-on: https://chromium-review.googlesource.com/1171261Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582998}

Bug: 874109
Change-Id: Id969b6a28a93e2aa595efcabf32666cae95fa46c
Reviewed-on: https://chromium-review.googlesource.com/1174964Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582997}

This reverts commit fd47d8d8.

Reason for revert: Collected sufficient initial crash reports.

Original change's description:
> [scheduler] Replace DCHECK for frozen and visible state with DumpWithoutCrashing
> 
> Changing the DCHECK that checks for the page scheduler being frozen when
> the page is visible to DumpWithoutCrashing to collect more crash dump data.
> 
> Bug: 873214
> Change-Id: I0f10ef13b0cf790cb38189273adf1ddc03030fc2
> Reviewed-on: https://chromium-review.googlesource.com/1172709
> Commit-Queue: Scott Haseley <shaseley@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582713}

TBR=altimin@chromium.org,shaseley@google.com

Change-Id: If15864678725a3939f5e0e03ddd4bcb97d220dcf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873214
Reviewed-on: https://chromium-review.googlesource.com/1175011Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#582996}

These tests are slow and only relvant to tools changes so there
is no point in running them all the time. These tests fail on
Windows, so this change prevents them from interfereing with
large-scale-refactorings done on Windows that don't affect the
tools.

Bug: 871754
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iccf6042665a027efb181848508128ef435cdd22b
Reviewed-on: https://chromium-review.googlesource.com/1172918
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582995}

Currently all available perception results are added to the perception
sample as entities. When there are no entities, we dont know if there
were no entities detected, or no detections were run at all.

BUG=872764

Change-Id: I18d4b0f1a0e285f030e5d6f64a4c62c0dc23ae07
Reviewed-on: https://chromium-review.googlesource.com/1169311Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Wei Guan <weigua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582994}

This CL is a trivial fixup of https://crrev.com/c/1076947; it deletes
some left-over code in ContentVerifier::BindURLLoaderFactoryRequestOnUIThread:
|network::mojom::URLLoaderFactoryParamsPtr params|.

TBR=rdevlin.cronin@chromium.org

Bug=844926

Change-Id: I493c29034ba61b59a99a4c9d2fd0ebd1a5717145
Reviewed-on: https://chromium-review.googlesource.com/1174654Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582993}

This is part of a larger project to measure page load times starting
at user input. One blocker for this is understanding how the
beforeunload dialog might affect this metric.

Bug: 750639
Change-Id: I7aef267a52353a6852dd82bad6c6c74a6fb82e51
Reviewed-on: https://chromium-review.googlesource.com/1162673
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582992}

PVer3 is the old specification of the protocol to download blacklist
updates and query full hashes from the Safe Browsing service.
PVer4 replaced this code in crbug.com/543161

Overall changes:
* Replaced the use of SafeBrowsingProtocolConfig with V4ProtocolConfig.
* Made TestSafeBrowsingService() the base class for a all derivatives of SafeBrowsingService in tests.
* Add CanCreateDatabaseManager and CreateDatabaseManager in ServicesDelegate::ServicesCreator
  to allow tests to create their own DatabaseManager, if they choose to.

TBR=tnagel
TBR'ing tnagel since the changes in annotations.xml are trivial: just deleting lines for files being deleted.

***************
Note to Sheriff
***************
If this CL breaks any builds or any tests, please feel free to revert immediately.

Reviewers, please review the changes in the following files:
rdevlin.cronin: chrome/browser/extensions/
ntfschr: android_webview/browser/aw_safe_browsing_ui_manager.cc
davidben: chrome/browser/net/trial_comparison_cert_verifier_unittest.cc, chrome/browser/prerender/prerender_test_utils.cc
tnagel: tools/traffic_annotation/summary/annotations.xml
qinmin: chrome/browser/download/download_browsertest.cc
bbudge: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

Bug: 754341
Change-Id: I889dfe42848b8579e26aed0ea92c86b38fdfb87a
Reviewed-on: https://chromium-review.googlesource.com/1153969
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582991}

Change-Id: Iad62e7101e9bf880e7101fb761a472f743b9f1f8
Reviewed-on: https://chromium-review.googlesource.com/1159225
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582990}

DownloadDB is based on levelDB, and we need to understand the initialization
failures

BUG=873735

Change-Id: I0408732645cdefbb94a9ce43df3f8053a5a5a024
Reviewed-on: https://chromium-review.googlesource.com/1173070
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582989}

https://chromium.googlesource.com/catapult.git/+log/193e9338017c..fc13545ed4c9


git log 193e9338017c..fc13545ed4c9 --date=short --no-merges --format='%ad %ae %s'
2018-08-14 benjhayden@chromium.org Reland Configure gae_ts_mon in chromeperf dashboard.


Created with:
  gclient setdep -r src/third_party/catapult@fc13545ed4c9

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iada7d9672650472169dad40849c64e0c422628bf
Reviewed-on: https://chromium-review.googlesource.com/1174792Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582988}

With DCHECKs on, these tests fail on ChromeOS.

Bug: 873851
Test: These are the tests.
Change-Id: I0f823918462dfb66c5fa8307e7d76150d8dacd6f
Reviewed-on: https://chromium-review.googlesource.com/1173506Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582987}

This CL removes the temporary definition from extensions/common
and uses the correct one from third_party/blink

Bug: None
Change-Id: Ic4e9f049055e6a442f42f351ab4c836a249c29cf
Reviewed-on: https://chromium-review.googlesource.com/1173734Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582986}

Changing more settings to a button that does not use the default styles
in print_preview/new/button_css.html removed the font: inherit styling.
Restore it.

Bug: 870645
Change-Id: Ic041c065f3d0f6d249a6817b740a8acaf963d38f
Reviewed-on: https://chromium-review.googlesource.com/1162079
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582985}

Renames the ContextualSearchRankerLogger interface to have a more
generic name, in preparation for using it in a more generic way: to
record outcomes that can later be sent to the server for logging and
offline processing.

The ContextualSearchRankerLogger is now the
ContextualSearchInteractionRecoder.

BUG=872902

Change-Id: Ic21bb32227c6587ba179509b369d8e1b48fc1d8e
Reviewed-on: https://chromium-review.googlesource.com/1169968
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582984}

This test is timing out (flaky 50%) on macOS 10.10 and 10.13.

TBRing rakina@ for review and sunyunjia@ (owner of bug).

TBR=rakina@chromium.org,sunyunjia@chromium.org

Bug: 827209
Change-Id: I2818f917ccc88d9275014ed8971edb6469638856
Reviewed-on: https://chromium-review.googlesource.com/1174901Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582983}

Changes:
Assign generic container role to SearchResultSuggestionChipView to
replace default button role, so that inner SuggestionChipView can be
found by ChromeVox.

Bug: 872943
Change-Id: I3a09dd9a76d11f9523b807fa5291f1aade38f84e
Reviewed-on: https://chromium-review.googlesource.com/1171598Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582982}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: Id545ccd53b49f2fd808c2d6ab32409de73c445d0
Reviewed-on: https://chromium-review.googlesource.com/1172127Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#582981}

In |window.print()| code path for Android, we have the call stack like
this:

  PrintJobWorker::GetSettingsWithUI() ->
  PrintingContextAndroid::AskUserForSettings() ->
  PrintingContext.showPrintDialog() (Java)

We have set |callback_| in |PrintingContextAndroid| to be
|PrintJobWorker::GetSettingsDone()|, but didn't call it in later stage
unless something fails.

This CL makes |PrintingControllerImpl| call
|PrintingContext.showSystemDialogDone()| no matter what happens. This is
because the first |GetSettingsWithUI()| for |window.print()| on Android
is only to wake up |PrintManager| to start printing job. We will set
the real settings in later |GetSettingsWithUI()| call.

Bug: 863297
Change-Id: I3be0a3dceab134db7a47e0c1b48ccd1802e74447
Reviewed-on: https://chromium-review.googlesource.com/1162754Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582980}

The fixes a hole that is present in the bottom toolbar when the
horizontal tab switcher is not enabled. It also makes it easier to
reach the new tab button which we expect to be more used than the
toggle button.

Change-Id: I7fa5bc192516d956a78704c4d90e2d656abd856c
Reviewed-on: https://chromium-review.googlesource.com/1170193Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582979}

This will enable:
 - New context menu UI for:
  - Application icons
  - Shelf context menus
  - Desktop context menus

Note:
 - Removed tests whose functionality were already being tested.
   - MouseContextMenu already tests whether the ink drop is being
     shown, so there is no need for
     ShelfButtonShowsInkDropHighlightOnMenuShow.

Bug: 871843
Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
Reviewed-on: https://chromium-review.googlesource.com/1170985Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582978}

Clear individual Gaia password hash by monitoring account removal events.
If it is the removal of a primary account (a.k.a chrome signin account),
remove all Gaia hashes, otherwise, just remove individual Gaia password
hashes.

Renamed a couple of functions in PasswordStore to make them more readable.
Changes in chrome_password_protection_service.cc are merely refactoring,
no behavioral change.

Bug: 844134
Change-Id: Idab2d375bb24ce2cdf568372b8b5ae283ac28169
Reviewed-on: https://chromium-review.googlesource.com/1171516
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582977}

Bug: 835029
Change-Id: I16d97c659054f135456131866962d78aa68e18ac
Reviewed-on: https://chromium-review.googlesource.com/1173319Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582976}

Grant screen access to web application and revoke it depending on
whether a web application can be shown on the screen. Only show a web
application when screen access has been granted.

Bug: internal b/112164384
Test: manual
Change-Id: I654f3a69395c1a84e33f38a84d52ba45060d96e2
Reviewed-on: https://chromium-review.googlesource.com/1164641Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582975}

If a fullscreen element was requested fullscreen user scrolling is
largely disabled on other layers. The overscroll would get reported
to java and it would attempt then to scroll the root layer. Add
checks whether the inner viewport scroll node is actually user
scrollable.

BUG=873626

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If527ae57641df19b683027f35a8494d3c482a066
Reviewed-on: https://chromium-review.googlesource.com/1173324Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582974}

This reverts commit e1b21dc7.

Reason for revert:
  1) No longer needed
  2) Slowing down omnibox

Original change's description:
> Add memory metric to trace event to investigate omnibox performance
>
> Adding estimated memory usage to the quick history provider.
> it is suspected to be slow and cause jank on UI thread when memory usage
> is high.
>
> These metrics will be received with slow-reports and will help to
> investigate some jank on UI thread.
>
> R=​mpearson@chromium.org
>
> Bug: 868419
> Change-Id: I344f84ec00f318fdb9db63c5b464b119a9d5e3eb
> Reviewed-on: https://chromium-review.googlesource.com/1156847
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579919}

TBR=mpearson@chromium.org,etienneb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 868419
Change-Id: I96785874209368579844e9c55052bc53de12a5a8
Reviewed-on: https://chromium-review.googlesource.com/1174692Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582973}

Add a toggle to the sound content settings page to toggle
unified autoplay. Also adds a pref to store the user's
preference.

BUG=865548

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8d2ac3ee3bb15d8daccef1f3a120b028b92e189a
Reviewed-on: https://chromium-review.googlesource.com/1145760
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582972}

This has been off by default since M67 and is actually dead in M69.

Tbr: thakis@chromium.org
Bug: 832676
Change-Id: Iba63da4b6c0d12fea4356bc5173b19ae46d4c510
Reviewed-on: https://chromium-review.googlesource.com/1172791Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582971}