GitLab

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I58a89ddc8eefee21a65e0d176f45300a64604638
Reviewed-on: https://chromium-review.googlesource.com/1026794Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553408}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9cad1d28a2827e5fcd07f0daa96667148f3b5fa2
Reviewed-on: https://chromium-review.googlesource.com/1009882
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553407}

BUG=762641
TBR=tbarzic@google.com

Change-Id: I9cc5bc27adfd1b26ff1054b5735f7747bc4638aa
Reviewed-on: https://chromium-review.googlesource.com/1027050Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553406}

Previously, URLLoaderFactoryGetter expects that the NetworkContext is ready when
it's initialized (URLLoaderFactoryGetter::Initialize()). However, when
ServiceWorkerServicification is on without NetworkService, the initialization
fails because URLRequestContext which is necessary to create a dummy
NetworkContext is not set at that point.
This CL splits the initialization process into two parts: creating valid
InterfacePtrs (URLLoaderFactoryGetter::Initialize()) and passing the
InterfaceRequests to the appropriate places
(URLLoaderFactoryGetter::EstablishConnection()).  NetworkContext is used only
for the latter, so EstablishConnection() is called after URLRequestContext is
set if ServiceWorkerServicification is on without NetworkService.

Bug: 829251
Change-Id: I5fbbaa2d48232965681fc96d802711369cd96528
Reviewed-on: https://chromium-review.googlesource.com/1025490Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553405}

CL deliberately skips running WaylandDataDeviceManagerTest unittests on
XDG_v5. ChromeOS/Linux builder runs on 14.04, which seems to have a
mis-functioning XDG v5 implementation.

Details: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7224

TBR=rjkroege@chromium.org

Will follow up to get this TODO fixed properly ASAP.

BUG=578890

Change-Id: I42de7d61633341c0593a118015c2a9eb99d033ff
Reviewed-on: https://chromium-review.googlesource.com/1027030Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#553404}

These are the last users of viz::internal::Resource on LTRP, replace
them with imported resources.

Bug: 738190
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iedea0ab36dfca892b25fb77c6336f88a820391d9
Reviewed-on: https://chromium-review.googlesource.com/1023159
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553403}

Some tests make use of /dev/null and /dev/zero , which was removed
by default as a consequence of turning off the "shell" permission.

This change re-adds those devices to the process' namespaces
by specifying them in the sandbox policy.

Added GN arguments for specifying different sandbox policies in
test and production executables.


Bug: 836341
Change-Id: If9bf9109e855ec7aa7a07672352be93160252a0c
Reviewed-on: https://chromium-review.googlesource.com/1026394Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553402}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/c6aed052aba9..ba32080311ac

$ git log c6aed052a..ba3208031 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 dalecurtis Force HAVE_EBP_AVAILABLE=0 for Windows ia32 builds.
2018-04-17 dalecurtis Add support for building the Windows ffmpeg configuration on Linux!
2018-04-16 dalecurtis Run pyformat over chromium/scripts directory.
2018-04-16 dalecurtis Comment out FFMPEG_CONFIGURATION to avoid long string in binary.

Created with:
  roll-dep src/third_party/ffmpeg

BUG=783021
TBR=liberato

Change-Id: Ic6f2fd6c9df5b83ff806f658eb4b4cf20062e310
Reviewed-on: https://chromium-review.googlesource.com/1026209
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553401}

Long, long ago we added a bunch of diagnostic logging to
run-webkit-tests to identify slow tests and slow directories.

I'm willing to bet no one has looked at that output in 6+ years,
but it still clogs up every run.

This CL removes all of that, and also restores the list of
failed tests at the end of the run that was removed in
r494598 (though this is a much simpler version of that).

R=qyearsley@chromium.org
BUG=619065

Change-Id: Idb81192f848a307cdf4bcc834199156d2fd2d563
Reviewed-on: https://chromium-review.googlesource.com/1023053
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553400}

There was a race in this test where chrome.send() from
chrome://history might have occasionally been processed on a pending
delete RenderFrameHost, right after a cross-process navigation.  This
revealed a real bug in WebUIImpl::OnWebUISend(), which incorrectly
killed the renderer before checking whether the RFH is active.  Fix
this by checking whether the RFH is active and dropping the IPC if not
prior to checking WebUI bindings.

Change-Id: I672e8457b7a4a167ad31e5afa4b2059b2c92b97a
Bug: 836211
Tbr: rdevlin.cronin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1026803
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553399}

This function returns device metadata associated with the current device
(i.e., the one on which the code is running).

Bug: 824568, 752273
Change-Id: I08e53e390cf2737bdaff154a9dff2cead9884db0
Reviewed-on: https://chromium-review.googlesource.com/1020069
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553398}

Makes ui/arc code run inside ash instead of the browser. The code
itself will be moved to //ash in follow-up CLs.

- ArcNotificationManager lives in ash::MessageCenterController;
- Arc bridge host forwards the NotificationsInstance mojo interface
  to ash via AshMessageCenterController interface;
- ArcNotificationSurfaceManager lives in ash::WaylandServerController;

Bug: 768439
Change-Id: Id3572a64cd4d8fac709cd2c22f86b392571d5041
Reviewed-on: https://chromium-review.googlesource.com/1011205
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553397}

Generated by:
  third_party/blink/tools/run_bindings_tests.py --reset-results

This updates the test results to include changes due to:
  https://chromium.googlesource.com/chromium/src/+/e7a16d44e33e3b57f25e218b19a6e16d2adbaded
  https://chromium.googlesource.com/chromium/src/+/d2fd2557e304d4037627e4012fe2e574a66c42e0
  https://chromium.googlesource.com/chromium/src/+/dbc5d3bb104037cbec6beed69fccdb97e962044f

Change-Id: I15a2755a2fc15018e419b97d1e30defecc67a775
Reviewed-on: https://chromium-review.googlesource.com/1026205Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553396}

This feature is not ready for M-67 stable.
This CL will be reverted shortly after merging it to M-67 branch.

Bug: 771466, 836109
Test: Manual testing on the device. Confirmed that the feature is disabled by default.
Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd
Reviewed-on: https://chromium-review.googlesource.com/1025352Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553395}

ExternalInstallErrorTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: I59bcbcaf0d1d15e6270e485398091f3e714f217b
Reviewed-on: https://chromium-review.googlesource.com/1024609Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553394}

The commitAutocomplete logic was assuming that the autocomplete span
was present and was trying to commit it, but when between onBeginImeCommand
/ onEndImeCommand, we have removed the span in onBeginImeCommand(), so
there is nothing to commit. We just need to commit the text, which does
not interfere with onEndImeCommand() logic.

BUG=810704

Change-Id: Iec7928d2154b6f4c4c8c6197293b6c84fde828f5
Reviewed-on: https://chromium-review.googlesource.com/1020064Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553393}

This reverts commit e3cf0f78.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable subpixel positioning on chrome os
> 
> Subpixel positioning was needed because text layout was performed at 1x
> device scale factor and then rastered to the final display device scale
> factor leading to glyph artifacts and inconsistent glyph positioning.
> With pixel canvas enabled on chrome os, the text layout is now always
> performed at the final display device scale factor. This, coupled with
> the replacement of ui scale with display zoom, the text on Chrome OS
> is now always rastered with the correct glyph positioning and it no
> longer requires subpixel positioning.
> 
> Bug:835187,824154,716662
> Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112
> Component: Text render, subpixel positioning, font
> 
> TBR=derat@chromium.org
> 
> Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112
> Reviewed-on: https://chromium-review.googlesource.com/1026636
> Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553353}

TBR=derat@chromium.org,malaykeshav@chromium.org

Change-Id: I22601786db33c0082480a09e9e7a3905a56a1383
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835187, 824154, 716662
Reviewed-on: https://chromium-review.googlesource.com/1026438Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553392}

Bug: 726476
Change-Id: Ifdbb411cc622ae29d38778030aa755bcc38eec2e
Reviewed-on: https://chromium-review.googlesource.com/1026849
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553391}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c9a04604fa3..355b11a31f0d

$ git log 2c9a04604..355b11a31 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 ehmaldonado bot_update: Patch on gclient by default.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:643346


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I77cbef26ba041a2bef9ab0c70eb80475c27e3433
Reviewed-on: https://chromium-review.googlesource.com/1026842Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553390}

This adds a 'MODE_OFFLINE_DEMO' enrollment mode, which locks the
device and applies the policy in the local installation. This
is the flow to setup the offline demo mode.

Currently the actual policy data is not yet available, so this
right now simply locks the device.

Bug: 827290
Change-Id: I6cdfec50049b017fc01d9875bd520f0655660031
Reviewed-on: https://chromium-review.googlesource.com/1000012Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553389}

This reverts commit 1a9c502d.

Reason for revert: Speculative revert to fix headless_browsertests hangs https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/79454

Original change's description:
> Do not block shutdown for process launch on Windows
> 
> Launching a process is racy with browser shutdown, and blocks it. So we
> see shutdown hangs when process launch takes a long time. This CL makes
> the process launcher use a CONTINUE_ON_SHUTDOWN instead of
> BLOCK_SHUTDOWN task on Windows where it's presumably safe to do so given
> no non-leaky globals are used, and based on local testing. This is not
> safe on Linux since the process launcher there uses SandboxHostLinux
> which is a non-leaky base::Singleton.
> 
> R=​brucedawson,gab
> BUG=830954
> 
> Change-Id: Ia8c5295924288819dcfdcc087d282a05e6ee7e55
> Reviewed-on: https://chromium-review.googlesource.com/1020720
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553294}

TBR=gab@chromium.org,sunnyps@chromium.org,brucedawson@chromium.org,piman@chromium.org

Change-Id: I4999a60d9f805fe441f416803dbb71fab8747f1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 830954
Reviewed-on: https://chromium-review.googlesource.com/1026437Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553388}

Now that Skia has its own list of workaround names, build the list of
workarounds from a combined list of Skia's and Chrome's.

Bug: 829614
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2d33190fba17421799aed6786f1e675a37601aed
Reviewed-on: https://chromium-review.googlesource.com/1026804Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553387}

R=abdulsyed@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic6ff163e35ed57bb87ec6a0c190bdd70ec59e4de
Reviewed-on: https://chromium-review.googlesource.com/1026973Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553386}

https://webrtc.googlesource.com/src.git/+log/70244d225207..2ff7b6adf0b1

$ git log 70244d225..2ff7b6adf --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:none


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie4f9029dea6fc59a59df8454a14cffc7674ccfd4
Reviewed-on: https://chromium-review.googlesource.com/1026841
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553385}

For some media, the container's |natural_size| is actually just an
aspect ratio, and therefore we should not use it directly as the
VideoFrame's |natural_size|. Instead it should be scaled based on the
|visible_rect| of the decoded frame.

FFmpegVideoDecoder already does this, this CL applies the same logic in
GpuVideoDecoder and VdaVideoDecoder.

Note: This change will make it possible for HW decoders to emit frames
of different sizes without a config change, which was not possible
before.

Bug: 766657
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7b263245c401c845bca30fa0683eb3e337ed6f81
Reviewed-on: https://chromium-review.googlesource.com/1022968
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553384}

BUG=833380
TBR=mcnee@chromium.org

Change-Id: I21f9aba5266d2f8c44e29c5cc3ed75ad0dd78cde
Reviewed-on: https://chromium-review.googlesource.com/1026846Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553383}

 - Move some styles from shared_style_css.html to paper_button_style_css.html.
 - Update paper-button styles per latest spec.
 - Collapse previously different types of buttons "primary" and "action" into a
   single button type.

Note this change is intentionally changing the shared styling for buttons. If a
certain WebUI page needs a different pre-MD refresh style, should be updated
individually to override (hopefully there are no such cases though).

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8558db8ffd121ad09b100f8ba6ab4d843022f73f
Reviewed-on: https://chromium-review.googlesource.com/1013330
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553382}

ExtensionSettingsUIBrowserTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679

Change-Id: Ib0d7f277f7c2d79a941c689962e84030d24fe5b7
Reviewed-on: https://chromium-review.googlesource.com/1026086Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553381}

This cl adds more ChromeLauncherControllerTest to test the internal app
window creation, close, and change of window property.

Bug: 824437
Test: New ChromeLauncherControllerTest.
Change-Id: I914b2aa931cfe8c3f845c1017b73025848fe29b3
Reviewed-on: https://chromium-review.googlesource.com/1023180
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553380}

Bug: 728219
Change-Id: I605f0a5897863c0059f0260598c2a4283e8e981e
Reviewed-on: https://chromium-review.googlesource.com/1024236Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553379}

This allows more complex expressions to be used without confusing the
compiler.

TBR=mkwst@chromium.org

Change-Id: I0b6d3a9526ac932bf1a8e3f7e9b3a76e3da34927
Reviewed-on: https://chromium-review.googlesource.com/1026805
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553378}

TBR=mariakhomenko@chromium.org

Change-Id: I78bd913572ebc8460b7f7c02d400636ac6cd02bd
Reviewed-on: https://chromium-review.googlesource.com/1026705Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553377}

TBR=mmoroz@chromium.org

Change-Id: I2250bc5a81f41b226bc2cadb6e24e083ef4a173d
Reviewed-on: https://chromium-review.googlesource.com/1026934
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553376}

Bug: 799482
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idce0482d4e8d2a2b0ac52769b73246850f1480a3
Reviewed-on: https://chromium-review.googlesource.com/1026207Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553375}

BUG=825854
R=bokan@chromium.org

Change-Id: Ic7533778665ce8e980b3f269d348aa0448f2bc3f
Reviewed-on: https://chromium-review.googlesource.com/1026529Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553374}

We used to have these checks in PpapiCdmAdapter, but they were lost when
we added media::CdmAdapter.

In summary:
- Only allow storage ID when |allow_persistent_state| is true.
- Only allow File IO when |allow_persistent_state| is true.
- Only allow platform challenge when |allow_distinctive_identifier| is
  true.

Also post tasks in CdmAdapter in failure cases to avoid reentrance into
the CDM instance.

this change. Filed crbug.com/836046 to refactor CdmAdapter and tests.

Test: The current CdmAdapterTest makes it harder to add unittest for
Bug: 510088,836046
Change-Id: I5a88c253a75a3af00f553681b65792198f31dba7
Reviewed-on: https://chromium-review.googlesource.com/1025220Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553373}

There was one crash report in this method, but the crash did not seem to include
local variables. Log the value of authentication_stage_ to capture it.

Bug: 820671
Change-Id: I82c25b8a58f0993a9eef94c497c2c3e06c48b255
Reviewed-on: https://chromium-review.googlesource.com/1015880Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553372}

Changes:
Show the context menu in home launcher in the same way as that in
wallpaper when the background is long-pressed or right clicked.

BUG=832993

Change-Id: I5f2d769884b2313a8a32254522428a73e13b9665
Reviewed-on: https://chromium-review.googlesource.com/1024728
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553371}

This change:

* Displays the generic avatar icon instead of profile icon when there's
  only one non-signed-in user. This matches the current AvatarButton
  behavior.
* Displays the guest badge instead of the generic avatar icon when the
  user is in guest mode.
* Replaces the avatar icon getter to use entry->GetAvatarIcon() instead
  of AvatarMenu::GetImageForMenuButton. The image retrieved for
  MenuButton was non-square and didn't fill the entire circle icon. Now
  the avatar profile icon is instead cropped and fills the circle. This
  matches the icons displayed in ProfileChooserView.

Bug: chromium:822070
Change-Id: I3599ca708e7f866d9c2f437f33c0d8cc141f5c13
Reviewed-on: https://chromium-review.googlesource.com/1026093Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553370}

This CL fixes some LoginPromptBrowserTest related to cancelling auth
request, in this case, LoginHandler::OnRequestCancelled() needs to be
called.

Bug: 783990
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id87ce38aec5191e40b3b282b4cde0304ea769d92
Reviewed-on: https://chromium-review.googlesource.com/1008846Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553369}