- 28 Apr, 2020 40 commits
-
-
George Steel authored
Fix DCHECK failure which occurred when attempting to serialize such an operation, which can occur due to the SVG transform presentation attribute and is unreperesentable in CSS. As there is currently no consensus on how to handle this case and there are no relatice lengths in such operations, I am computing them as matrix() values. See the CSSWG issue at https://github.com/w3c/csswg-drafts/issues/5011 to determine the correct way to handle this. I have proposed the approach used here. Add regression test (crashes without patch). Change-Id: Ia116ead6c451cafc6fb222be3bb52362123bae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163758Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#763427}
-
Matt Menke authored
The class has created confusion between the following: * URLRequestStatus(FAILED, ERR_ABORTED) * URLRequestStatus(CANCELED, ERR_ABORTED) * URLRequestStatus(FAILED, ERR_FAILED) * URLRequestStatus(CANCELED, ERR_FAILED) The class also obfuscates the difference between OK and ERR_IO_PENDING. These have confused consumers, and make the many state checks in the URLRequest code hard to follow. Also, the net error code is all we really need. Bug: 651119 Change-Id: Ic1dc5bc466a97ecfd040ad09cfaff2e1b535a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165149Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#763426}
-
Stephen Roe authored
Previously the amber repository only ran during initial package installation. Since 2020-04-08 it is required during the entire test run. Bug: 1033565 Change-Id: If21cfeefaf8de0a4680aedcd31f79ba35d3e9577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159372Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#763425}
-
Trent Begin authored
This change adds a basic mojo interface to query NetworkHealth for the cached active networks and devices. Bug: chromium:1057739 Change-Id: I5c7437a522535f8a3154e3ec74bc17d67f4b2dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161701 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#763424}
-
Andrew Grieve authored
And removes some obsolete flags Change-Id: Ia51b586f00c0c9eeb30d588f20f0743af5b2e395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169755 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#763423}
-
Richard Knoll authored
These instances were found by adding a CHECK to the WidgetObserver DTOR to ensure the observer is removed before destruction and then running all tests. Bug: 1055483 Change-Id: I83353f33962b00f0f922a21ebb0afb2131295482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165105 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763422}
-
S. Ganesh authored
There are cases where the elevation service may fail to install, for instance, if security software prevents installation. Bug: 1023080 Change-Id: Ibab20f2ee44395254ef702a460f8fad60836e682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168825Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#763421}
-
Etienne Pierre-doray authored
This CL removes StackCopier::Delegate::OnThreadResume and manually resets MetadataProvider in StackSamplerImpl::RecordStackFrames, and enables RecordMetadata() on android (more specifically StackCopiedSignal). |read_lock_| is only acquired: - before CopyStack() on the sampling thread. Since there is only 1 sampling thread per process, this won't have any contention. - in TryReclaimInactiveSlots() with |read_lock_.Try()|. Failing to acquire delays ReclaimInactiveSlots(). Since read_lock_ is only held during stack capture (compared to stack walking which takes ~3x as long), starvation is unlikely to affect TryReclaimInactiveSlots(). Bug: 1056283 Change-Id: I4f0ef3e8c3641ec7b7258da519c3fba519fb096b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154738 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80e9d2ce1c17..71c190060689 git log 80e9d2ce1c17..71c190060689 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 jacktfranklin@chromium.org Up e2e timeout to 5 seconds 2020-04-28 jacktfranklin@chromium.org Add support for `Platform.UIString` calls in GRDP parsing 2020-04-28 tvanderlippe@chromium.org Start with typechecking sdk/NetworkManager.js 2020-04-28 ankit.mishra131990@gmail.com Fix focus not being centered for inline buttons 2020-04-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-04-28 wolfi@chromium.org [issues] Add Mixed Content Issues to Issues Pane 2020-04-28 mathias@chromium.org Represent CSS property weights as a map Created with: gclient setdep -r src/third_party/devtools-frontend/src@71c190060689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1053468,chromium:1075871 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2b8a78c3280f5e4b85d0530caad474de980257a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763419}
-
Lei Zhang authored
Also fix IWYU lint errors. Change-Id: I814836a05639abab91b146a9559f84fff5278c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168806Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#763418}
-
Philip Rogers authored
BackgroundImageGeometry has complex logic for adjusting the background when painting the document element in the view's coordinate space. This logic can be moved into ViewPainter by reusing an existing offset (BackgroundImageGeometry::offset_in_background_). This offset is for the background image itself (similar to the background-position CSS property). Bug: 1071957 Change-Id: I0794a4f90bd8e98e6b257fdd30f1415d9e0f5484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166805Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763417}
-
Aaron Gable authored
This is a reland of https://crrev.com/c/2161689, which was reverted in https://crrev.com/c/2163254 due to breakages on the branch builders. The prerequisite changes have been cherry-picked to the currently active branches (m81 and m83), so this should be safe to reland. We've already shown this to work on Mac10.15 Tests on the FYI waterfall, so let's do this for the rest of the Mac triggered testers on the main waterfall as well. This will allow us to free up some Mac resources to do more important tasks (e.g. compile, run tests). It also makes these builders builderless, increasing our flexibility and improving our utilization. This CL also introduces a new ci.triggered_tester starlark function to enable easily specifying builders as "we don't care what OS you use", and to enable easily turning all of them into "thin testers" if/when we go down that path. Bug: 1061582 Change-Id: I31b80f76784cc909633056ff9c71e03ebaf31504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170416 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#763416}
-
Morten Stenshorne authored
NGFragmentItems::FinalizeAfterLayout() will typically update the bits after layout, but apparently not always. This should have been part of CL:2169929 This hopefully fixes: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/5530 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/102130 TBR=kojii@chromium.org Bug: 1075993 Change-Id: I53207183f6fa7f9c4ccd7db6b64fa8e5c755c332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170098Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#763415}
-
Brandon Jones authored
Implements https://immersive-web.github.io/webxr/#xrlayer-interface New interface added to serve as a common base class between the existing WebGL layer and the WIP layers module. No changes in functionality. Bug: 1074150 Change-Id: I695ff842cce5d38cf37b263acecf95dafc21d572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164146Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#763414}
-
Yury Semikhatsky authored
DevToolsBrowserContextManager::OnBrowserRemoved is called from Browser destructor and the destructor acesses the profile after notifying its observers. If the profile is deleted synchronously in the DevTools' observer it will cause use after free. This change restores the logic changed in https://chromium-review.googlesource.com/c/chromium/src/+/2141097 Bug: 1075664 Change-Id: I02b924d8a45fa6a74fdc2ccc2647033f5f86d904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168515Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#763413}
-
Mugdha Lakhani authored
A skeleton PageInfoControllerDelegateImpl is introduced for WebLayer. This also adds AutoCompleteSchemeClassifer impl for WebLayer, plumbs it into the existing C++ AutoCompleteSchemeClassifierImpl, and uses it to implement a PageInfoControllerDelegateImpl method. TODOs have been added for unimplemented methods of the controller impl. This class isn't used anywhere right now but is necessary to build Page Info UI for WebLayer. Bug: 1052375 Change-Id: Ie33e0f20e9068a0c382489553121022a84b3ada3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159433Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#763412}
-
Sergey Ulanov authored
Bug: 1067068 Change-Id: If88c4ff1a624e1d29b86181794e1bcd5b4aea792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166807Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763411}
-
Shik Chen authored
NOPRESUBMIT=true Bug: 1058325 Test: Manually Change-Id: I9864fd9e99d0987e27781602b98ef112adf4150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169427 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#763410}
-
Akihiro Ota authored
Bug: 1075752 Change-Id: I47236a717a46e26b8fb23fbe526ade65277ff21c Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168657Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#763409}
-
Vladimir Levin authored
This patch ensures that we properly handle situations where style causes us to be force-unlocked (e.g. display: inline) and cases where we no longer should be force-unlocked (e.g. going from display: inline to display: block). - Ensure to check if we need to be relocked in DidStyle for self. - Ensure that if we were unlocked in DidStyle for self, then we update the child style change to include any deferred dirty bits stored on the context. R=futhark@chromium.org, chrishtr@chromium.org Change-Id: Iba330be74ddbb705357cc99658797d900f800589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165447Reviewed-by:
-
David Van Cleve authored
Lily said that it's safe to use CookieManager on the main network sequence, so I'm removing this obsolete reference to the "IO thread," which scared me into thinking I'd need to PostTask to use CookieManager accessors. R=chlily, morlovich Bug: None Change-Id: I29b305406db253e10654a096f24ab310220eff1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166604 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c39e0c3432b..7b61d5985f4e git log 9c39e0c3432b..7b61d5985f4e --date=short --first-parent --format='%ad %ae %s' 2020-04-28 vapier@chromium.org cbuildbot: afdo: migrate to python3 only 2020-04-28 vapier@chromium.org toolchain_util: migrate to python3 only 2020-04-28 morg@google.com Enable skylab hw tests for RVC PFQ 2020-04-28 vapier@chromium.org cbuildbot: CollectPGOProfilesStageTest: rewrite cros_build_lib.run mocking 2020-04-27 cjmcdonald@chromium.org portage_testables: Make factory fixture for stacked overlays 2020-04-27 cjmcdonald@chromium.org Basic test fixtures for real Portage operations 2020-04-27 vapier@chromium.org unittests: drop python3-only tests 2020-04-27 tcwang@google.com afdo: Fix a typo for recipe AFDO builders. 2020-04-27 vapier@chromium.org cbuildbot: CollectPGOProfilesStage: use UTF-8 encoding when capturing output 2020-04-27 vapier@chromium.org replication_lib: migrate to python3 only 2020-04-27 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7b61d5985f4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I2f2373f0c2961c39e99aa56b9750d4e150f368cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170300Reviewed-by:
-
danakj authored
Gin/Javascript can be holding onto a reference to the object when the list of Persistents is cleared. They will be destroyed when the last reference goes away. R=avi@chromium.org Bug: 1074655, 866140 Change-Id: I62ce389e3dd84b04652a8724149cf4dd47274b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169765Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#763405}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80d3e268d2ec..1f9e2a8feb5a git log 80d3e268d2ec..1f9e2a8feb5a --date=short --first-parent --format='%ad %ae %s' 2020-04-28 jmadill@chromium.org Update .clang-format. Created with: gclient setdep -r src/third_party/angle@1f9e2a8feb5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I95e5a32c85538bdd6a567aa9d38ef27c810730f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170298Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/03fcfdd74f97..1e6581c46ce7 git log 03fcfdd74f97..1e6581c46ce7 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 fmayer@google.com Fix heap_profile for Python 3.x. 2020-04-28 treehugger-gerrit@google.com Merge "gn: Disable new GCC redundant move warning" Created with: gclient setdep -r src/third_party/perfetto@1e6581c46ce7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd7759672aa128b29d9eb680389d406a585703ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170296Reviewed-by:
-
Evan Stade authored
- move ChromeNotificationBuilder interface, PendingIntentProvider - split out Chrome specific bits (UMA) from NotificationBuilder and NotificationCompatBuilder into subclasses. The base classes are componentized. A few Android version conditionals are removed since we're no longer supporting KitKat. Bug: 1069894 Change-Id: Ibef6e2d1d8f82d6182a4e3430aa71d4c61608ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161420 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763402}
-
Finnur Thorarinsson authored
Bug: None Change-Id: I4fe754df508807cec90a8b39a4abb53f097d050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169997Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#763401}
-
sandromaggi authored
Set padding to info box and change ordering. Screenshots: Info text + Checkbox + Box: https://screenshot.googleplex.com/rAw40YXUW3P Info text + Box: https://screenshot.googleplex.com/uY0TWkYLv5D Info text: https://screenshot.googleplex.com/tNNzQUqchPb Checkbox + Box: https://screenshot.googleplex.com/1tHHc1XVg1b Info text (centered): https://screenshot.googleplex.com/FTtKYbWzUC8 Bug: b/154798286 Change-Id: Iac4f8f663107a39bde35e9105c7d44d78b50fb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162887 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#763400}
-
Kevin Babbitt authored
Apply page scale factor when passing values from CachingAsyncHitTest to HitTest for the background asynchronous hit test. Add a test covering the scenario and rename a few existing tests for consistency and clarity. Bug: 2140198 Change-Id: I2a2b592a76b9ffc96a174668e93ce0cc6fbc0400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146536Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Follows recommendations given by UI designer. Bug: 684762 Change-Id: I05613ba4039420ccbf603c82b1372a9cef81c16e Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168532 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
edchin authored
Many circular buttons require the same pointerStyleProvider, which gives a lift effect and is a circular shape. This CL introduces ios/chrome/common/ui/pointer_interaction_util.h/mm which provides reusable pointer interaction utilities. This CL intentionally spans across multiple folders and owners to demonstrate the usefulness of a reusable utility. Test: iPad-only. Enable pointer support flag. Check pointer hover effect on 1) omnibox voice search button in NTP 2) omnibox voice search button when omnibox is in top of screen 3) omnibox clear text (X) button 4) new tab (+) button in tab grid 5) new tab (+) button in toolbar in multitasking mode. Bug: 1073961 Change-Id: I013940946a72227ca8076ed7d4e5f1031be0e2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167004Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763397}
-
Pavel Feldman authored
Without this change, Emulation.setFocusEmulationEnabled(true) leads to a state where page is focused, but is considered background and hence throttled. Change-Id: I474fa4c3291db4a3b1f66a3e0f938ac6f50d96fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169573Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763396}
-
Travis Skare authored
Bug: 1072871 Change-Id: Id2dd5d796140df35110834c3ac66b9a7da45a15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158039Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Nate Fischer authored
This deprecates the WebView Log Verbosifier app in favor of the Dev UI flag. This app is incompatible with Android R, but the developer UI switch will be maintained going forward. Bug: 988200 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ibe0eb729f786a69b29ebedd051512341d3977ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169484Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3623f72383d9..c9bb56813821 Created with: gclient setdep -r src-internal@c9bb56813821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: Ib7129a3c67bee30713a312285b23730c33b859fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170297Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763393}
-
Akihiro Ota authored
Bug: 923068 Change-Id: Ic5a86144e3eee3d0f7314d308bcb01ff087cfe31 Relnotes: Launch ChromeVox voice switching feature. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165662Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#763392}
-
Ben Joyce authored
This removes the last double group edits to the android_deps/build.gn file which were made for the androidx update. Still need to remove a few jar_excluded_pattern edits. This downstream CL must land first. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2926879 Bug: 1067050 Change-Id: I64fcfc688ab145c68dd02689f0b3d24bfc29e0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166636Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#763391}
-
Victor Hugo Vianna Silva authored
The CL removes an unnecessary function call for desktop in the client and a duplicated forward declaration in the generation controller. Bug: None Change-Id: Ic1b805741722da112073f4a0b9001967c01b7000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162755Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#763390}
-
rajendrant authored
Once test file got removed in https://crrev.com/c/2166638/ This CL adds the test back TBR=sclittle@chromium.org Bug: 1074608 Change-Id: I2fca32d1e06c75c9be278838d6abd981578c2515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169012 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#763389}
-
Bruce Dawson authored
chrome.exe.manifest is unreferenced so this change deletes it. The manifest was added in this change in 2013: https://chromiumcodereview.appspot.com/19275010 Over time its functionality was split into separate manifest files and at some point it stopped being used, perhaps around the change to gn. Deleting it just finishes the transition. The separate manifest files which supply the common controls and requested execution levels which this (unused) file still contains are referenced from chrome_exe_manifest in chrome/app/version_assembly/BUILD.gn Change-Id: I263f4e7aca97c231c846cf264886d3745b22cb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163751 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
