- 21 Aug, 2018 32 commits
-
-
Joshua Bell authored
Fix in a string logged if a renderer sends a bad message. TBR=pwnall@chromium.org Change-Id: I02555b07c696d4f9f9f1bdc8a39dbc4423e428e2 Reviewed-on: https://chromium-review.googlesource.com/1182602Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584614}
-
James Cook authored
We need to distinguish between MultiProcessMash, SingleProcessMash and both (aka IsUsingWindowService). Clean up some usage in login and accessibility. Bug: 874468 Change-Id: Ibf9694f45114491bf54b232a906b6a5a390e3f05 Reviewed-on: https://chromium-review.googlesource.com/1180344 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584613}
-
Karan Bhatia authored
This CL bumps the Docserver version to 3.58.0. r578728 introduced the onActionIgnored event to the web request API. However, the documentation changes are not yet reflected in the extension docs (due to an underlying Docserver bug). Force a version bump for now, which should help reflect the new changes. BUG=513780, 111700 Change-Id: I5ef403922b4e5d0c4af0d136b9ea0b8fecf528bc Reviewed-on: https://chromium-review.googlesource.com/1182420Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584612}
-
Balazs Engedy authored
Bug: 847985, 849323 Change-Id: I818ab8eabac6dbb96edceefa5d28f6d28031d15f Reviewed-on: https://chromium-review.googlesource.com/1181574Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584611}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I37de43ae8e743f49b588a08417912a8993bff5e9 Reviewed-on: https://chromium-review.googlesource.com/1182459Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#584610}
-
Darren Shen authored
Two UMA metrics were added as cl/209072881. This patch adds corresponding histogram descriptions in Chromium. Bug: 856198 Change-Id: Ie987e261ec52d6750f1566f499726695e628f671 Reviewed-on: https://chromium-review.googlesource.com/1179103Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#584609}
-
Sergey Ulanov authored
Scenic Ozone platform doesn't support GL. InitializeGLOneOffHelper() was crashing in that case. Bug: 874533 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I696847b292f015030f2ae32a7044ba8234e0b6a5 Reviewed-on: https://chromium-review.googlesource.com/1178754Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584608}
-
David Bienvenu authored
With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to remove MSVC_DISABLE_OPTIMIZE; these functions were already marked as NOINLINE. Bug: 873359 Change-Id: I00995a17463572545933956cdec0e7e13825abe7 Reviewed-on: https://chromium-review.googlesource.com/1182302Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584607}
-
Andres Calderon Jaramillo authored
This CL creates a base::Feature flag in content to guard the implementation of decode acceleration of JPEG images (as opposed to camera captures) in Chrome OS using the VA-API. Bug: 868400 Change-Id: I103a78bc9547862620fea59fb423582226f03d59 Reviewed-on: https://chromium-review.googlesource.com/1180292 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#584606}
-
David Black authored
Conversation starters are suggestions that show when Assistant UI is launched. They transcend Assistant sessions in that they are pre-cached and held in memory until needed. To accomplish this, this CL: - Adds AssistantCacheController/AssistantCacheModel(Observer) - Adds support for conversation starters to SuggestionContainerView. Still TODO: - Limit to four conversation starters. - Conversation starters should be centered horizontally. - Conversation starters should be cached from the server. In the future, we can also use this new cache for engagement cards and other growth initiatives. See bug for mock/demo. Bug: b:111694337 Change-Id: Ic280d7e39a5b61c9400448f883fce147a889d908 Reviewed-on: https://chromium-review.googlesource.com/1179365Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#584605}
-
Peter K. Lee authored
Rolling both material_components_ios and material_internationalization_ios Bug: 873293, 785484 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If1e80bf46644a2f907b8fd2017f793f9e73d0f3c Reviewed-on: https://chromium-review.googlesource.com/1174556 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584604}
-
Tom Anderson authored
Fixes an error of the form: ../../chrome/common/media_router/discovery/media_sink_internal.cc:191:1: error: function 'media_router::DialSinkExtraData::DialSinkExtraData(media_router::DialSinkExtraData&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' DialSinkExtraData::DialSinkExtraData(DialSinkExtraData&& other) noexcept = ^~~~~~~~~~~~~~~~~ ../../chrome/common/media_router/discovery/media_sink_internal.cc:202:1: error: function 'media_router::CastSinkExtraData::CastSinkExtraData(media_router::CastSinkExtraData&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' CastSinkExtraData::CastSinkExtraData(CastSinkExtraData&& other) noexcept = ^~~~~~~~~~~~~~~~~ The code was ill-formed according to 11.4.2 (3.2): https://timsong-cpp.github.io/cppwp/n4659/dcl.fct.def.default#3.2 Change-Id: I8d54c83856ecbf427ea1e72c409c7df0d1147291 Reviewed-on: https://chromium-review.googlesource.com/1181761Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584603}
-
Xiaohui Chen authored
Bug: b:112780961 Test: locally build and change to allowed and not allowed locales Change-Id: Ie665c6547385b3c63636b55219a33a96c03dc27b Reviewed-on: https://chromium-review.googlesource.com/1180532Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584602}
-
Tiansong Cui authored
Bug: internal 112487374 Test: cast_bluetooth_unittests. BLE sanity check. Change-Id: I73b7ac38f523ccac04b34b8b4535e93ad022de2d Reviewed-on: https://chromium-review.googlesource.com/1180726 Commit-Queue: Tiansong Cui <tiansong@google.com> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#584601}
-
Gang Wu authored
Create JournalOperation and JournalMutation on C++ side. Bug: 875143 Change-Id: Ia473ef0f3f528ffe46372f2c8963ebff8ad5bf65 Reviewed-on: https://chromium-review.googlesource.com/1179380 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584600}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org, jamesr, fdegans Change-Id: I4b79da18923366853bf376e98e518c59b7394b5e Reviewed-on: https://chromium-review.googlesource.com/1182444 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584599}
-
Karan Bhatia authored
This CL simplifies the implementation of HasValidIndexedRuleset. It now leverages RulesetMatcher::CreateVerifiedMatcher. BUG=696822 Change-Id: Id12036183d01c1a533d010854590ace99dd2b946 Reviewed-on: https://chromium-review.googlesource.com/1152871 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584598}
-
Scott Haseley authored
We have a DCHECK and a NOTREACHED that fire when freezing a visible page, but the freeze will still succeed on release builds. This CL adds a check to ensure visible pages cannot be frozen by the embedder. Bug: 875995 Change-Id: I933c5e9377e0fa9670c60efa6deb2ced7ef1601b Reviewed-on: https://chromium-review.googlesource.com/1180503 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584597}
-
Eugene But authored
This replaces "session=" with constant in WKNavigationUtilTest Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaef19ec8ac48161e0915719eb6ee1477978e83ed Reviewed-on: https://chromium-review.googlesource.com/1179248Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584596}
-
Tetsui Ohkubo authored
IsValidChild(views::View* view) can be called during dtor of |view|, so first we have to check if the view is in the deleting list. TEST=manual BUG=875208 Change-Id: I5f936e34a6a88d327567611101647ca39c9864c8 Reviewed-on: https://chromium-review.googlesource.com/1180941Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#584595}
-
Daniel Erat authored
Move CrosDBusService::ServiceProviderInterface implementations and the corresponding D-Bus config files out of //chrome/dbus/services and into either //ash/dbus or //chrome/browser/chromeos/dbus (depending on where they're actually instantiated). Also move LivenessServiceProvider ownership from //chrome to //ash since it doesn't have any dependencies on //chrome. Bug: 843392 Change-Id: Iba80bd36d6db007260f2fe32b21709ef288f74c9 Reviewed-on: https://chromium-review.googlesource.com/1180608Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584594}
-
wutao authored
This cl adds more descriptive text to ChromeVox when pronoucing the suggestion chip of Continue Reading. Bug: 843839, 865051 Test: manual. Change-Id: I3b7bd36c1c69d43dcc79bde14ae0cbb1c6e78d66 Reviewed-on: https://chromium-review.googlesource.com/1176201Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584593}
-
Muyuan Li authored
Bug: b/112782291 Test: manual Change-Id: I6c9d29b2ec5c551cd5f86b24a0449eddfed4d92f Reviewed-on: https://chromium-review.googlesource.com/1182002Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584592}
-
Mike Wittman authored
Bug: 851163 Change-Id: I70938c74d799ca1377d2d368ed0be28090f1ad1f Reviewed-on: https://chromium-review.googlesource.com/1180527 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584591}
-
Steven Bennetts authored
ChromeKeyboardUI does a lot of things. This is just some small cleanup in preparation for separating the WebContents Delegate/Observer code from the aura::Window code. It also adds a very basic unit test (a unit test file exists but it contains no tests). Bug: 843332 Change-Id: I82096babb7d8e6c95ff2033c40841392893cfa0f Reviewed-on: https://chromium-review.googlesource.com/1182001Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584590}
-
Yoshifumi Inoue authored
This reverts commit 12164db3. Reason for revert: Compilation error below on official build. Please remove |#if !defined(OFFICIAL_BUILD)| at L30. 30 #if !defined(OFFICIAL_BUILD) 31 #include "base/base_paths.h" 32 #include "base/path_service.h" 33 #endif ompatible_applications_updater_win.cc /Foobj/chrome/browser/browser/incompatible_applications_updater_win.obj /Fd"obj/chrome/browser/browser_cc.pdb" ../../chrome/browser/conflicts/incompatible_applications_updater_win.cc(332,13): error: no member named 'PathService' in namespace 'base' if (base::PathService::Get(base::DIR_EXE, &exe_path) && ~~~~~~^ ../../chrome/browser/conflicts/incompatible_applications_updater_win.cc(332,36): error: no member named 'DIR_EXE' in namespace 'base' if (base::PathService::Get(base::DIR_EXE, &exe_path) && ~~~~~~^ Original change's description: > Don't warn about modules in the same directory as Chrome > > Bug: 876096 > Change-Id: I85a7d7d5529270a829d9849a8bb638d9d02b7813 > Reviewed-on: https://chromium-review.googlesource.com/1182341 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584586} TBR=chrisha@chromium.org,pmonette@chromium.org Change-Id: Id5c5647be399362929de2a7773bd581dbbe41633 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876096 Reviewed-on: https://chromium-review.googlesource.com/1182841Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584589}
-
Khushal authored
Its important for Canvas snapshots to have a constant PaintImage::ContentId to get a cache-hit in cc's ImageDecodeCache. The logic was missing the case where the CanvasResourceProvider has a valid ContextProvider but is still using software raster, thus creating bitmaps which were being allocated new ids. R=fserb@chromium.org Bug: 868369, 872117 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iadc76f35483c0aed9c31aba38a7808aee1dc8863 Reviewed-on: https://chromium-review.googlesource.com/1180423Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#584588}
-
Jennifer Apacible authored
TBR=dtseng@chromium.org NOTRY=true (disabling test) Bug: 876145 Change-Id: I689855e1c34de5735dde20e235bf1e8d09dbeb17 Reviewed-on: https://chromium-review.googlesource.com/1182784Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584587}
-
Patrick Monette authored
Bug: 876096 Change-Id: I85a7d7d5529270a829d9849a8bb638d9d02b7813 Reviewed-on: https://chromium-review.googlesource.com/1182341 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#584586}
-
Minh X. Nguyen authored
Now that the update client can return update service error details, this information can be used to understand more about what kind of service errors the update service may encouter when doing update checks. Bug: 869663 Change-Id: I10c693b05ebbe6c1f804606c4749acb0a178e7bd Reviewed-on: https://chromium-review.googlesource.com/1180076Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584585}
-
Xu Xing authored
Also refactor HasFallbackSurface to unify DelegatedFrameHost and DelegatedFrameHostAndroid. Bug: 859977 Change-Id: I5cea0013b4f52dbe4b6c8a6a9841bacc7b13e381 Reviewed-on: https://chromium-review.googlesource.com/1176970Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#584584}
-
Dmitry Gozman authored
TimeClamper is only used by Performance, so there is no need to put it as low as platform/. Change-Id: I531be082528f2e569bbff08a5ace42076d9bb845 Reviewed-on: https://chromium-review.googlesource.com/1157174Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584583}
-
- 20 Aug, 2018 8 commits
-
-
Christopher Cameron authored
When updating the views::View size, ensure that the NSWindow size be updated first (otherwise we end up with strange mismatches). Add a TODO about merging methods here. This requires access to the BridgedNativeWidget from BridgedContentView, so make BridgedNativeWidget store a pointer to BridgedContentView (from which it can access BridgedContentViewHost), rather than storing a pointer to BridgedContentViewHost. Also change one instance where we pulled the BridgedContentView from the NSWindow to use the pointer directly. Bug: 875776, 875731 Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75 Reviewed-on: https://chromium-review.googlesource.com/1181926 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584582}
-
gogerald authored
Bug: 806868 Change-Id: I60b3d97e7418a7b5eccc5c9f4ee96be8e6e0b187 Reviewed-on: https://chromium-review.googlesource.com/1182198Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#584581}
-
Martin Kreichgauer authored
This introduces PlatformAuthenticatorInfo as a parameter object to FidoRequestHandlerBase::SetPlatformAuthenticatorOrMarkUnavailable. The struct holds the existing std::unique_ptr<FidoAuthenticator>, which is the platform authenticator itself, and an additional bool indicating whether the authenticator has a matching credential for GetAssertionRequest. The bool is plumbed through to TransportAvailabilityInfo for consideration by the UI. Bug: 847985 Change-Id: Ice46685eef31eb29cb8fdcb0d471e4b40bfb97b3 Reviewed-on: https://chromium-review.googlesource.com/1179088 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584580}
-
Tibor Goldschwendt authored
This fixes a startup crash of the Chrome modern bundle where uncompress_shared_libraries was erroneously set to false for the Chrome modern base module. Bug: 875872 Change-Id: Ie9817ea350f4703950608eff35e5b6129cb9e508 Reviewed-on: https://chromium-review.googlesource.com/1181936 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584579}
-
Ned Nguyen authored
TBR=mythria@chromium.org, ulan@chromium.org NOTRY=true Bug: 875159 Change-Id: I3e8df16078427553a28a7df8daf7a798453e0dcf Reviewed-on: https://chromium-review.googlesource.com/1182481Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584578}
-
Jacob Dufault authored
Calling the shortcut may cause chrome to crash, as the chrome-side handler assumes the login screen is active. Bug: 875778 Change-Id: Ib297d5239c9198d0cd047bd2b5e240dbc1d49ca8 Reviewed-on: https://chromium-review.googlesource.com/1182184Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#584577}
-
Anders Hartvoll Ruud authored
When we inherit a set of custom properties, without modifying that set, we don't need to resolve those properties again. Also, we only need to resolve at all if any values with var()-references have been observed. This CL simply stores a flag which indicates whether the Style[Non]InheritedVariables instance contains unresolved var()- references or not. This fixes a performance issue where variables specified on :root would be re-resolved for all elements in the tree. Bug: 875123 Change-Id: I1f68b4c78465c1c09a2b4951207f8bf4eb855e45 Reviewed-on: https://chromium-review.googlesource.com/1180209 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#584576}
-
Tommy Steimel authored
This reverts commit 0c629790. Reason for revert: The crashes are still occurring and I realized I misinterpreted the initial crash reports. Going to land a different CL which fixes the actual problem. Original change's description: > [Media Controls] Prevent ComputedStyleRef crash in overlay play button > > This CL adds a check in MediaControlOverlayPlayButtonElement that > prevents a call to ComputedStyleRef is ComputedStyle is null. This > prevents a crash we're seeing in certain cases on Windows and Mac. > > Bug: 870490 > Change-Id: Ia45a7239084b267ce8a352fc0a825b5c992c5eea > Reviewed-on: https://chromium-review.googlesource.com/1173471 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583523} TBR=hayato@chromium.org,beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870490 Change-Id: Ied6ea0c564c478ade8f670f72c5369785bb4cacf Reviewed-on: https://chromium-review.googlesource.com/1181681Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584575}
-