- 28 Sep, 2017 40 commits
-
-
Yuwei Huang authored
This CL moves inline UIColors into RemotingTheme. Bug: 767121 Change-Id: Iffca58686eca9095389f7480b5ebda73e96ea12c Reviewed-on: https://chromium-review.googlesource.com/688478 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#505170}
-
Aaron Leventhal authored
Bug: None Change-Id: Ic4fc38a5486083030354ad6f2a7fac219380f3dc Reviewed-on: https://chromium-review.googlesource.com/687396Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#505169}
-
Sidney San Martín authored
- Move menu bar locking into ScopedMenuBarLock to get a stronger guarantee that the menu bar is left unlocked on exiting fullscreen. - Use a different test for whether there should be a tracking area. - Lock and unlock the menu bar from -[FullscreenToolbarMouseTracker mouseEntered:] and -mouseExited: directly. Also don't remove the tracking area in mouseExited:, this caused a case where the tracking area got removed while the menu bar was still visible. - Remove a couple of unit tests which mostly repeated existing tests but also tested assumptions that are no longer valid. It might be good to add an interactive UI test in the future, or a unit test for FullscreenToolbarMouseTracker. Background ---------- The menu bar and toolbar would get stuck if you enter fullscreen and either: 1. Move the mouse to the top of the screen, then move it down over the toolbar, then back up to the top of the screen, then down to the middle of the screen. Cause: the tracking was incorrectly removed in mouseExited:. 2. Move the mouse to the top of the screen, then open a menu, move the mouse down to the middle of the screen, and click to close the menu. Cause: The menu bar overlaps the window when it drops down. Moving the mouse over the menu bar fired mouseExited:, but the old code used -mouseInsideTrackingArea, which still returned YES because the mouse was technically inside the tracking area even though mouseExited: had already fired and wouldn't fire again. Bug: 762160 Change-Id: Ia15228be8d62e16a66a712f78bd1c8fe62dbef26 Reviewed-on: https://chromium-review.googlesource.com/688414Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505168}
-
Max Moroz authored
Bug: 764514 Original CL: https://chromium-review.googlesource.com/679619 R=dpranke@chromium.org Change-Id: I412ac11cbe2c73de9e7b724e2689a97144aad47e Reviewed-on: https://chromium-review.googlesource.com/688029Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505167}
-
Steven Valdez authored
Bug: Change-Id: I39704044591ece9c7c63131af067a15061625400 Reviewed-on: https://chromium-review.googlesource.com/690082Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#505166}
-
Tom Anderson authored
BUG=676220 R=peter@chromium.org CC=thestig@chromium.org Change-Id: I20a4a246b89f8be56bfdffcbfb7b7c38be203eaa Reviewed-on: https://chromium-review.googlesource.com/687887 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#505165}
-
Adithya Srinivasan authored
EnsureRareData has a call to ScriptWrappableVisitor::WriteBarrier which tries to access ThreadState::Current. Since, NodeRareData can only be created on the main thread, we can tag it as mainThreadOnly to skip a TLS lookup. Bug: Change-Id: I13b35237784dbb392b28f278de57b10dd31ebf7e Reviewed-on: https://chromium-review.googlesource.com/690244Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#505164}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: Ib984cd7094cf4e075863d692acb59722114e3990 Reviewed-on: https://chromium-review.googlesource.com/649528Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#505163}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=asvitkine@chromium.org Bug: 666525 Change-Id: Ic899f9f4a4c67104770271c5fcef27251f524510 Reviewed-on: https://chromium-review.googlesource.com/688768Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505162}
-
Xianzhu Wang authored
This reverts commit ebb73616. Reason for revert: The expectation was already correct before the CL. Adding "Debug" actually reduces the coverage of the expection, causing unexpected failure on non-debug builds. Original change's description: > Adding Debug to expectations > > No-Try: true > No-Presubmit: true > TBR: beccahughes > Bug: 769881 > Change-Id: If3a5a0a26b880907693d4906cfebdb42bd6f405e > Reviewed-on: https://chromium-review.googlesource.com/690624 > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505128} TBR=dmurph@chromium.org Change-Id: I63ee0115a56aebd82603b550d3d17251a55cdd06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769881 Reviewed-on: https://chromium-review.googlesource.com/691036Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505161}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b9dc069a4752..f8b2cb4efd8c $ git log b9dc069a4..f8b2cb4ef --date=short --no-merges --format='%ad %ae %s' 2017-09-28 sullivan Update catapult docs for Gerrit. 2017-09-28 simonhatch Dashboard - Add some logging surrounding sheriff assignment. 2017-09-28 benjhayden Sort overview chart in histogram-set-table-name-cell. 2017-09-28 benjhayden Remove JsonOutputFormatter from telemetry. 2017-09-27 joelaf tracing_agents: atrace: Stop trace before async dump 2017-09-28 benjhayden Add some slice titles to ChromeUserFriendlyCategoryDriver. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I15dd27deed1eb70e400a67d058fd5a55115c5c6d Reviewed-on: https://chromium-review.googlesource.com/690894 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505160}
-
Marijn Kruisselbrink authored
Like other CLs this only adds a mojo blob handle for lifetime purposes, but browser-side code still uses the separately passed UUID to actually access the blob data. Bug: 740744 Change-Id: I880db368d033473d4b923083b5e84be54e8e1716 Reviewed-on: https://chromium-review.googlesource.com/608744Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#505159}
-
Mohamad Ahmadi authored
Bug: 767855 Change-Id: I34191918ea1da657b6b2ae44d46393405368bbbe Reviewed-on: https://chromium-review.googlesource.com/690595Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505158}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09ea46b6..70abcb06 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifbf98aefbbbed43e97dde88e6c8533f59b11f1ee Reviewed-on: https://chromium-review.googlesource.com/690235Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#505157}
-
Tom Anderson authored
BUG=676220 R=peter@chromium.org CC=thestig@chromium.org Change-Id: I0890514c912963f7e8e0e159ab614545beb047da Reviewed-on: https://chromium-review.googlesource.com/687965 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Kenneth Russell authored
There are assumptions in many places that OrderingBarrierCHROMIUM is sufficient to ensure command ordering between producers and consumers in Chromium's pipeline. However, unless clients were carefully written, it was easy to miss a necessary glFlush, or put one in the wrong place. On macOS there is no implicit flush when switching contexts, though one exists on some other platforms (e.g. GLX), and exists implicitly when using virtualized GL contexts. Fix this at the lowest level in the GPU process by flushing when switching contexts on macOS. Also fix bug in command ordering between WebGL's DrawingBuffer and consumers; i.e., the compositor. BUG=769488 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I46faa7537a3e2e12e3094a6aba3a85378a677c3f Reviewed-on: https://chromium-review.googlesource.com/687832 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505155}
-
Dan Beam authored
Originally, the code did this: download.Manager = { insertItems_(index, items) { this.splice('items_', index, 0, items); this.updateHideDates_(index, index + items.length); // calls .set() } // Same general pattern in #updateItem_() and #removeItem_(). } Unfortunately, IronList#_itemsChanged() ends up ignoring the set() calls as the "physical item" (i.e. node) is scheduled to be created, but isn't yet. So, instead, this CL silently creates the right data model (by setting the data correctly and moving away from Polymer's mutation APIs), and calls notifySlices() when it's all done and the data is in a completely sane state. Simply wrapping the .set() call with this.async() would also work, but I don't like this because it: 1) re-renders templates (more work, potential flicker) 2) harder to cancel async() work or generally reason about its correctness BUG=768797 R=dpapad@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If164268687b2a34abe745e8d43fdcf74ad4ca09a Reviewed-on: https://chromium-review.googlesource.com/688814 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505154}
-
Bruce Dawson authored
Update the instructions to mention that VS 2017 and the 10.0.15063 SDK are required in order to build Chromium. Remove references to VS 2015 and earlier SDKs. Much simpler now! Bug: 683729 Change-Id: Ie101a835eb7fa72a3436e338f089d1efa29c9249 Reviewed-on: https://chromium-review.googlesource.com/688228Reviewed-by:
-
Yuwei Huang authored
On iOS 9, it seems the [self updateFABConstraintsAnimated:NO] call in viewDidLayoutSubviews and [self layoutIfNeeded] call in updateFABConstraintsAnimated causes an infinite layout loop, which crashes the app right after the HostViewController appears due to stack overflow. This CL fixes this problem by removing the updateFABConstraintsAnimated: call from viewDidLayoutSubviews. Bug: 769533 Change-Id: I311d9168db4bcae097455eb27a908c086de71572 Reviewed-on: https://chromium-review.googlesource.com/687829Reviewed-by:
-
Yuwei Huang authored
The desktop viewport will be used to map some points when handling gestures. If the viewport is not ready at that time, then we may end up getting wrong numbers (e.g. NaN) into the InputStrategy. This will cause subsequent issues in the viewport logic. This CL fixes this by always checking whether the viewport is ready before handling the gesture, and adding some DCHECKs to prevent similar things from happening. Bug: 769477 Change-Id: Ied121198559c8d401a66022d2f82663cd0a91dfc Reviewed-on: https://chromium-review.googlesource.com/688657Reviewed-by:
-
Xida Chen authored
It is discovered in the bug that when the device pixel ratio is 1.7 and the browser zoom is 1/3, the geometry of the background is 199*199 where it should be 200*200. There are two reasons: 1. The ApplySubPixelHeuristicToImageSize in BackgroundImageGeometry makes the fractional part lost. 2. The conversion from FloatSize to IntSize also has impact. This CL caches a logical_tile_size_ in the BackgroundImageGeometry, which is the tile size without applying subpixel heuristics. And then we pass this size all the way to the CSSPaintDefinition::Paint. Bug: 683789 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4a24d7afe5408d3fbfbef4b63e3c221f13ed1612 Reviewed-on: https://chromium-review.googlesource.com/678019Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505150}
-
Matthew Jones authored
Dom-distiller is moving to use gerrit and the dist-roll script references need to be updated. The github repos still exist and are mirrored versions of ones hosted by google. BUG=749769 Change-Id: I99404c9097bb22f3cca5f233d2d1e8fb658d9375 Reviewed-on: https://chromium-review.googlesource.com/687991Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505149}
-
Xida Chen authored
It is flaky on linux TBR=pfeldman@chromium.org NOTRY=true Bug: 769905 Change-Id: Ia2b1f4824399fc8f0c08a528f304f8272869d1b0 Reviewed-on: https://chromium-review.googlesource.com/690994Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505148}
-
Daniel Bratell authored
Several test classes in scheduler use the same name. As an alternative to renaming them, or some of them, use unique namespaces. This solves problems with MockTask and MockObserver. Bug: 745732 Change-Id: I56da313dbbfb116d28d45ccd5f261cdfbf48d188 Reviewed-on: https://chromium-review.googlesource.com/687674 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505147}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 666525 Change-Id: I25740f166c501b336a5782553a5be68fd3840f62 Reviewed-on: https://chromium-review.googlesource.com/689015Reviewed-by:
-
Lei Zhang authored
- Make more methods const. - Use range-based for loops. - Fix typos and nits. Change-Id: I3c642a625e11ddd739e3a3edb93f8f021ed6a3bc Reviewed-on: https://chromium-review.googlesource.com/688821 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505145}
-
xdai authored
Device wallpaper policy will be released in M61, not M57 as originally planned. Thus update it. Bug: 475998 Change-Id: I939c7fe0ec57ff2089a6bfb22f66d80077e72c18 Reviewed-on: https://chromium-review.googlesource.com/682636Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#505144}
-
Eric Roman authored
Reflects a change in the test file's format. Change-Id: Ic6f53822f6ded817bf0016049f3938be88cd7f3e Reviewed-on: https://chromium-review.googlesource.com/690621Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505143}
-
Reza.Zakerinasab authored
Currently, createImageBitmap color managed layout tests only load and test PNG files (opaque and transparent). This CL upadates the tests to load different image formats that can be decoded by Blink. TBR=junov@chromium.org,fserb@chromium.org Bug: 769847 Change-Id: I21ccb68db9a55860522901cb4332819fef2e83ad Reviewed-on: https://chromium-review.googlesource.com/690846Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#505142}
-
Daniel Murphy authored
No-Presubmit: true No-Try: true TBR: mcasas Bug: 769903 Change-Id: I9ed65862edbae1fd8da3022dd14b9181c192b18b Reviewed-on: https://chromium-review.googlesource.com/690975Reviewed-by:
-
Tom Anderson authored
A user on bug 676220 [1] had links showing up in the notification body like "<a href=...". We were already checking against the body-hyperlinks capability before adding the <a> tag, but I suspect that whatever notification server that is interprets 'body-hyperlinks' to mean that it will linkify the body, not that it will correctly handle <a>. This CL includes an added check for 'body-markup' when adding hyperlinks. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=676220#c89 BUG=676220 R=peter@chromium.org CC=thestig@chromium.org Change-Id: I66ec46c1a467317db3b31d9ba899b2258cb0fb97 Reviewed-on: https://chromium-review.googlesource.com/688111 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Mike Reed authored
related to https://skia-review.googlesource.com/c/skia/+/50980 Bug: Change-Id: I670b4f239cdbedd64892d6de5dd24232ba1ae8ac Reviewed-on: https://chromium-review.googlesource.com/685719 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#505139}
-
Justin DeWitt authored
This updates the "Network Prediction" setting text on Android only. Bug: 701939 Change-Id: I6fa2079204b00ca96aa6c8451afd523b5c3f6763 Reviewed-on: https://chromium-review.googlesource.com/689747Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#505138}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: Ib74387545eacb69e0d0f20feae2d83a8b8649733 Reviewed-on: https://chromium-review.googlesource.com/689023Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505137}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: Ifbc74b5399f1b05f40394789b5f0f248dbd03452 Reviewed-on: https://chromium-review.googlesource.com/689112Reviewed-by:
-
Theresa Wellington authored
BottomToolbarPhone#updateVisualsForToolbarState() is now called from BottomToolbarPhone#onAttachedToWindow(). We have crash reports indicating that for some users the bottom sheet is null when the toolbar is attached to the window. Adding null checks. BUG=769612 Change-Id: I6dc5e86851b8c054f50e798ac854fff0e3629d43 Reviewed-on: https://chromium-review.googlesource.com/690800Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505135}
-
Pavel Yatsuk authored
The problem that caused https://crbug.com/761476 is that signin flow didn't enable syncing in AndroidSyncSettings, but instead relied on sync engine initialization to implicitly update it. Because sync initialization takes time it was possible for untimely SyncController instantiation to propagate obsolete value of "sync automatically" flag and trigger sync engine shutdown. In this change I'm adjusting SigninManager to enable sync at the end of signin flow. This explicitly records intention to enable sync engine. If SyncController is instantiated by the time of this call then it would trigger ProfileSyncService.requestStart(). Otherwise it will propagate Android settings and start sync engine during normal initialization in GoogleServicesManager. BUG=761476 R=bsazonov@chromium.org Change-Id: I76c576afa3591cff105d4fb49caf1a938bf4efdd Reviewed-on: https://chromium-review.googlesource.com/688828 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505134}
-
Tom Anderson authored
Canonical's notification development guidelines [1] specifies that only '<', '>', and '&' characters should be escaped when the notification server supports the 'body-markup' capability. Previously, we were escaping single and double quote characters as well. On Cinnamon, this would cause the ' character to render as '. This CL only escapes the recommended chracters. [1] https://wiki.ubuntu.com/NotificationDevelopmentGuidelines#If_a_notification_uses_a_.2BIBw.3C.2BIB0_or_.2BIBw.26.2BIB0_character.2C_and_it_has_missing_or_wrong_text BUG=676220 TBR=peter@chromium.org CC=thestig@chromium.org Change-Id: I3e6f6ea60be52a9e4f406c728701f9f666362bc6 Reviewed-on: https://chromium-review.googlesource.com/688294Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505133}
-
Daniel Murphy authored
TBR: ericwilligers No-Try: true No-Presubmit: true Bug: 769879 Change-Id: I217c445a716c687e8942dee2fbdc8a59b7cef55b Reviewed-on: https://chromium-review.googlesource.com/690453 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Matt Mueller authored
With use_byte_certs, creating an X509Certificate does not use the platform certificate implementation. Bug: 769549 Change-Id: I23d7871ee3d3f52f72e2293c60cd231d658a2845 Reviewed-on: https://chromium-review.googlesource.com/690780Reviewed-by:
-
