GitLab

If a history navigation item occurs and the current NavigationItem is
transient item, it will get discarded in CRWSessionController's
|-discardTransientItem|.  This CL updates history navigation logic to
store copies of the current NavigationItem's information before calling
any CRWSessionController code that might deallocate it.

BUG=700319

Review-Url: https://codereview.chromium.org/2745653007
Cr-Commit-Position: refs/heads/master@{#456190}

BUG=697971

Review-Url: https://codereview.chromium.org/2745793005
Cr-Commit-Position: refs/heads/master@{#456189}

It looks like these get manually rolled.

TESTED=none
R=derat@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2743713004
Cr-Commit-Position: refs/heads/master@{#456188}

https://pdfium.googlesource.com/pdfium.git/+log/5c1961dfa0b1..6791295a4e8c

$ git log 5c1961dfa..6791295a4 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 npm Normalize channels when transforming CMYK to RGB

Created with:
  roll-dep src/third_party/pdfium
BUG=699459

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2746613002
Cr-Commit-Position: refs/heads/master@{#456187}

BUG=672263

Review-Url: https://codereview.chromium.org/2744803003
Cr-Commit-Position: refs/heads/master@{#456186}

The docs still need to be updated with more detailed instructions and
tips, but currently the docs don't even mention debugging in Android
Studio.

BUG=620034

Review-Url: https://codereview.chromium.org/2740353003
Cr-Commit-Position: refs/heads/master@{#456185}

EphemeralRange unit tests updated with better HTML and shadow-DOM
attached  explicitly. Previously few of the test cases introduced
extra dependency on the UA shadow DOM under <input>,
which was irrelevant to EphemeralRange.

BUG=697989

Review-Url: https://codereview.chromium.org/2738203002
Cr-Commit-Position: refs/heads/master@{#456184}

Darkening the shelf by 90% for the --ash-shelf-color experiment was too close to
black. Changing to 70% will make the color more visible.

TBR=sky@chromium.org

BUG=595010

Review-Url: https://codereview.chromium.org/2742833006
Cr-Commit-Position: refs/heads/master@{#456183}

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2747443002
Cr-Commit-Position: refs/heads/master@{#456182}

BUG=None
TBR=sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2746543003
Cr-Commit-Position: refs/heads/master@{#456181}

DelegatedFrameHost can no longer create a new local surface id on frame
eviction. This would normally break a few things but after
https://codereview.chromium.org/2736053004/ we should be good.

I tried testing this CL by setting the maximum number of saved
frames to 1 so that each new tab causes the eviction of the previous tab
and compared the current behaviour vs behaviour after this CL and did
not notice any difference. Without https://codereview.chromium.org/2736053004/
if you switch tabs fast enough DCHECKs will fail in SurfaceManager for allocating
a surface using a surface id that is already in use, but that CL fixes
this issue.

TBR=jam@chromium.org
BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731793002
Cr-Commit-Position: refs/heads/master@{#456180}

Merge ItemSelected and GetAppMenuItems mojo interface functions.
(return app menu items with the action taken from selection handling)
Remove the non-mojo ash::ShelfItemDelegate base class.

Remove some unused mash pinning and reordering functionality.
(it'll be fixed later, when mash and cash can use the same pattern)

Replace ShelfApplicationMenuItem with the MenuItem mojo struct.
Add ShelfAction and ShelfLaunchSource mojo enums and traits.

BUG=557406
TEST=No Chrome OS shelf item (or app menu) behavior changes; automated.
R=jamescook@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2718563008
Cr-Commit-Position: refs/heads/master@{#456179}

R=scottchen@chromium.org
BUG=none (that I know of)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743863002
Cr-Commit-Position: refs/heads/master@{#456178}

ComputedStyle::operator== excludes some data members in the comparison,
and it's not clear what members are compared and what are not. Ideally,
the equality operator would be replaced with a named method that better
describes which data members are compared.

BUG=628043

Review-Url: https://codereview.chromium.org/2740953003
Cr-Commit-Position: refs/heads/master@{#456177}

Use LayoutObject::visualRect() instead.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2745793004
Cr-Commit-Position: refs/heads/master@{#456176}

This CL updates role and aria-* attributes to get screen readers to
work.

BUG=697142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742833002
Cr-Commit-Position: refs/heads/master@{#456175}

With the experiment, we see the markers for a brief second before they are
immediately removed without any user intervention.  This CL fixes the race.

BUG=chromium:695236
R=luoe@chromium.org,lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2742653003
Cr-Commit-Position: refs/heads/master@{#456174}

BUG=699256

Review-Url: https://codereview.chromium.org/2740633002
Cr-Commit-Position: refs/heads/master@{#456173}

BUG=608869

Review-Url: https://codereview.chromium.org/2717543002
Cr-Commit-Position: refs/heads/master@{#456172}

BUG=700327

Review-Url: https://codereview.chromium.org/2743803003
Cr-Commit-Position: refs/heads/master@{#456171}

BUG=

Review-Url: https://codereview.chromium.org/2740223002
Cr-Commit-Position: refs/heads/master@{#456170}

This CL removes FetchRequest::mutableResourceRequest() calls that are
used to modify ResourceRequest created just before, i.e. replaces:
  FetchRequest request(ResourceRequest(foo), bar);
  request.mutableResourceRequest().baz();
with:
  ResourceRequest resourceRequest(foo);
  resourceRequest.baz();
  FetchRequest request(resourceRequest, bar);
To clarify what kind of modifications to ResourceRequest via
mutableResourceRequest() is needed (https://crbug.com/632580#c8).

BUG=632580

Review-Url: https://codereview.chromium.org/2740253002
Cr-Commit-Position: refs/heads/master@{#456169}

We are adding COMPONENT/TEAM information into OWNERS file
(UI>ProximityAuth related, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=tengs@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743073002
Cr-Commit-Position: refs/heads/master@{#456168}

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2736283002
Cr-Commit-Position: refs/heads/master@{#456167}

This is required for the existing subresource filtering and css scanning
page load metrics, as well as for the upcoming metrics for pages where
media is played.

In the render process:
* move policy decision about whether to process timing or metadata updates
  from blink to chrome/renderer/page_load_metrics code
* instantiate MetricsRenderFrameObservers for child frames
* track metadata updates for child frames
* send at most one update per second per frame over IPC to the browser process
  (this is the existing page load metrics IPC policy)

In the browser process:
* track child frame loading behavior flags
* notify observers whenever the loading behavior flags for a child frame
  are updated

In the SubresourceFilterMetricsObserver:
* consider the page to have filtered subresources if subresource filter loading
  behavior is observed in either the main frame or child frames

Note that we still do not track timing updates for child frames. This change
gets us closer to being able to do so, but given that there is no current
need, we don't do this for the time being.

BUG=699849

Review-Url: https://codereview.chromium.org/2737563007
Cr-Commit-Position: refs/heads/master@{#456166}

Fix SpdySessionPool::FindAvailableSession() to log the correct
NetLog event type and the correct Net.SpdySessionGet histogram
value when pooling to an existing HTTP/2 connection by IP
address every time, not only the first time.

BUG=700451

Review-Url: https://codereview.chromium.org/2739183005
Cr-Commit-Position: refs/heads/master@{#456165}

Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox (patchset #37 id:710001 of https://codereview.chromium.org/2729523002/ )

Reason for revert:
Layout tests still failing for mac and windows despite passing on the trybots. Example: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.9&number=43627

Original issue's description:
> Re-land WebVR compositor bypass via BrowserMain context + mailbox
>
> Implement compositor bypass for WebVR via mailbox copy:
>
> - Create a GPU command buffer GL context in the VrShellGl thread that's
>   backed by a native Surface. This is encapsulated inside the new
>   MailboxToSurfaceBridge class.
>
> - WebKit's VRDisplay sends a MailboxHolder for each frame (as drawn
>   via WebGL on the GPU process) as argument to the SubmitFrame mojo
>   call.
>
> - MailboxToSurfaceLayerBridge uses its GPU command buffer GL context
>   to draw the mailbox content to a Surface.
>
> - VrShellGl picks up the frame from the corresponding SurfaceTexture
>   and  proceeds with rendering as usual with its native GL context
>   as needed for the low-level GVR API.
>
> Also implements on-the-fly canvas resizing, the transfer surface and
> GVR renderbuffer are resized as needed to match the source canvas.
>
> Added frame number as an argument to various TRACE_EVENTs for timing
> analysis.
>
> It includes two separate modes for frame scheduling, the more
> aggressive one is conditional on
> chrome:://flags#enable-webvr-experimental-rendering since the
> framerate seems a bit less stable.
>
> BUG=698643
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2729523002
> Cr-Original-Commit-Position: refs/heads/master@{#455592}
> Committed: https://chromium.googlesource.com/chromium/src/+/6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74
> Review-Url: https://codereview.chromium.org/2729523002
> Cr-Commit-Position: refs/heads/master@{#456130}
> Committed: https://chromium.googlesource.com/chromium/src/+/9f86464794416e81abfe5921e9fac892716c610b

TBR=mthiesse@chromium.org,bajones@chromium.org,khushalsagar@chromium.org,dcheng@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698643

Review-Url: https://codereview.chromium.org/2742083002
Cr-Commit-Position: refs/heads/master@{#456164}

The CL implements peak detection in memory dump scheduler.
More discussion at https://goo.gl/0kOU4A.

BUG=607533

Review-Url: https://codereview.chromium.org/2737153002
Cr-Commit-Position: refs/heads/master@{#456163}

This patch fixes a bug in the TabbedEditorContainer's handler for
persistence binding.

As the binding comes in, we should retain selected tab no matter
what.

R=dgozman

Review-Url: https://codereview.chromium.org/2740053002
Cr-Commit-Position: refs/heads/master@{#456162}

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738893003
Cr-Commit-Position: refs/heads/master@{#456161}

There's a race condition causing the WebMediaPlayer to be destroyed
before MediaCustomControlsFullscreenDetector dispatches the final
change. This CL fixes the issue.

BUG=698034

Review-Url: https://codereview.chromium.org/2743573003
Cr-Commit-Position: refs/heads/master@{#456160}

To emulate <a> :focus styling, action-link adds .no-outline on
mousedown, but removes .no-outline on blur. This indiscreminate removal
disregard the edge case where source of blur is from outside the web
page (e.g., Alt-Tab). This CL add an extra check to remedy this.

BUG=698270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744893002
Cr-Commit-Position: refs/heads/master@{#456159}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/faa1c3e0aeca..aa4354795733

$ git log faa1c3e0a..aa4354795 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 jessimb Updating the Anomaly index to include end_revision, master, and benchmark.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2744903002
Cr-Commit-Position: refs/heads/master@{#456158}

https://pdfium.googlesource.com/pdfium.git/+log/52c73c24ab05..5c1961dfa0b1

$ git log 52c73c24a..5c1961dfa --date=short --no-merges --format='%ad %ae %s'
2017-03-10 npm Add public method FPDFText_GetTextIndexFromCharIndex

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2740013006
Cr-Commit-Position: refs/heads/master@{#456157}

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353

Review-Url: https://codereview.chromium.org/2742693003
Cr-Commit-Position: refs/heads/master@{#456156}

In the case of extension-controlled prefs, extensions like fillr use

  chrome.privacy.services.autofillEnabled.set({value: false});

To disable Chrome's native Autofill.

When this happens, code runs[1] in chrome to set a pref in the:

1) profile pref store
2) extensions pref store

We observe changes to the profile pref store.  So the order is:

1) set value in profile pref store
-> change happens
2) set value in extensions pref store

Unfortunately, we ask in the observer whether
pref->IsExtensionControlled()[2], which check which store the value comes from.

This will change on the next line of code, but isn't updated yet.

I considered just changing the order (which might be valid), but I think
asyncrifying potentially solves other types of observer order issues.

R=rdevlin.cronin@chromium.org
BUG=693226

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/preference/preference_api.cc?type=cs&q=passwordsavingenabled&l=448,446
[2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/settings_private/prefs_util.cc?q=prefs_util.cc&sq=package:chromium&dr&l=486,751

Review-Url: https://codereview.chromium.org/2742663002
Cr-Commit-Position: refs/heads/master@{#456155}

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds fd number to crash report when dmabuf mmap fails, because we think
fd limit may cause this crash.
It's follow-up CL of https://codereview.chromium.org/2710183005/

BUG=629521

Review-Url: https://codereview.chromium.org/2725813005
Cr-Commit-Position: refs/heads/master@{#456154}

On Linux, Video encoding is currently erroneously reported on chrome://gpu as "Hardware
accelerated". This CL fixes this by adding a blacklist entry.

BUG=641485
TEST=Open chrome://gpu on Linux and check that Video Encode is reported as
     Software only, hardware acceleration unavailable
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744683002
Cr-Commit-Position: refs/heads/master@{#456153}

This patch adds a Java wrapper for RenderFrameHost. It also adds a
getMainFrame method to WebContents.

This will be useful for Payment Request which needs to know
the exact (sub)frame issued the payment request.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2681933002
Cr-Original-Commit-Position: refs/heads/master@{#455635}
Committed: https://chromium.googlesource.com/chromium/src/+/67dd9f2795389cc3776481ff07740984b2389f43
Review-Url: https://codereview.chromium.org/2681933002
Cr-Commit-Position: refs/heads/master@{#456152}

See also https://codereview.chromium.org/2641123006.

BUG=700229

Review-Url: https://codereview.chromium.org/2741193003
Cr-Commit-Position: refs/heads/master@{#456151}