- 31 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4766bd88cf78..22b8657a5558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4c8837f0174f10b42ce2d829aadc6bfc24b5adb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793739}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..22b8657a5558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia1986094c5250cee6c31269be8bfb872640e433e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc6aebc6f315..37710e42bb90 2020-07-31 jalyn@microsoft.com Clarify missing shortcuts for screen reader users 2020-07-31 tjaneczko@google.com Add 'Copy message' context menu item for EventSource messages. 2020-07-31 janscheffler@chromium.org Migrate `front_end/security` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1111375,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I704c842d89f202a8b1c006fead31829d3a3de600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333097Reviewed-by:
-
Thomas Lukaszewicz authored
This CL introduces the following UMA histograms: TabSearch.WebUI.InitialTabsRenderTime TabSearch.WebUI.LoadCompletedTime TabSearch.WebUI.LoadDocumentTime TabSearch.WindowOpenDuration These histograms aim to measure various duration related metrics for the Tab Search feature. See the spreadsheet below for more details: https://docs.google.com/spreadsheets/d/15ygVicrrbJUJOzTn6IlnogxktExXJQzZ2PCSGMQFpWg Bug: 1099917 Change-Id: I9d9db7abe2554d682fb0211eceaa6a07a567ba24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321232Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#793736}
-
Behdad Bakhshinategh authored
This reverts commit 9bf3843a. Reason for revert: This CL was used to verify the reported UMA values. Original change's description: > Reporting latency metrics for UI > > This change is to verify the changes in latency metrics reported, and make sure there has been no other chanegs responsible for recent changes in the values of latency metrics. > > TBR=jonross@chromium.org > > Bug: chromium:1096661 > Change-Id: Iafac9541c2b773cba52c3693c61d8cfb0c184064 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317829 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791538} TBR=jonross@chromium.org,behdadb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1096661 Change-Id: I028144de4eb49964710355eb5a6d30f143367924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332683Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08057456d373..56387075825a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1111681 Tbr: pkasting@google.com,nicolaso@google.com Change-Id: I0936eec86bd73fc4032b99f916159b196c2f5328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793734}
-
Ana Salazar authored
When we enter cardified state, we need to make sure the apps grid pages are masked to the container of the background cards. Icon animations should not be displayed beyond these bounds. Bug: 1108642 Change-Id: Ic0e3f951cb221d95f99c89d66e4e2e398df9217c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321713Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793733}
-
Caitlin Fischer authored
For histograms without an appropriate primary owner, add either the placeholder text or add an appropriate individual. Note that this is enforced for only non-obsolete histograms. While this should encourage people adding new histograms to have an appropriate primary owner, it is still technically possible for them to list the placeholder text as the owner to get around this. I think this is okay because reviewers would presumably not approve this. Bug: b/147376752, b/162326579, b/160411669 Change-Id: I6a3df3d8326528572a4606a1baa0c2ddc8ea7f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329737 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#793732}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3d1b4c6fd29de0c08468b1a3178cdbb4cd7c2f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333096Reviewed-by:
-
David Bertoni authored
This test needs to be cleaned up so it can be run by a Service Worker-based extension. This cl removes the use of window.setTimeout and cleans up the tests to be clearer and more concise. Bug: 1093066 Change-Id: I738005fec7414ebd8967c84c6e56c6e1c82d20fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317771Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793730}
-
Mike Jackson authored
Add support to the manifest update tasks to account for changes to the display_override field. If the contents of the display_override field change, regardless of resolution, trigger an web app manifest update. Add tests to validate we detected a manifest change under the following conditions: - values change - both valid and invalid fields. - display_override added to manifest - display_override removed from manifest Added tests to validate we don't update manifest under the following conditions: - display_override added to manifest, but contains only invalid values - values change - but only different is new invalid values. Explainer: https://github.com/WICG/display-override/blob/master/explainer.md Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1092667 Change-Id: I1411ae6bb8685d9a4ddad44a0c8a5a73bc06bb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330338 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#793729}
-
chrome://app-disableddpapad authored
Bug: 1111690 Change-Id: Ie2385352cd31fc6261011eacd78fbaea6e038c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332047 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a 2020-07-31 primiano@google.com Merge "Update CHANGELOG for v6 release" 2020-07-31 aninditaghosh@google.com Move error handling into api instead of http for Python API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:162168559 Tbr: perfetto-bugs@google.com Change-Id: Ic9de702a79cf1d298476ce5e04908bc0e1052808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333093Reviewed-by:
-
Josh Nohle authored
We store a hash of the last successfully enrolled ClientAppMetadata. On startup, if we detect that the metadata has changed since the last successful enrollment, we force a re-enrollment. Note: We do *not* force an enrollment if the persisted hash has not been set. So, a user will need to enroll before this check takes effect. --- This is ClientAppMetadata change-detection CL [4/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: I6bb868e325498c91f90a3965fb31e3237eb0df65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300879 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Dale Curtis authored
Apparently JS can synchronously run during promise fulfillment, so we need to avoid doing that inside of an iterator they can invalidate. Since we didn't have any tests for ImageDecoder yet, this adds a bunch of basic ones and fixes the issues that arose from them. Specifically: - GIFImageDecoder allows decoding of any image SkCodec can decode. - There was no exception for empty image data. - MaybeSatisfyPendingMetadataDecodes() always satisfied regardless of whether or not the size was actually available yet. R=pkasting, tguilbert Fixed: 1108535 Test: New tests. Change-Id: I96d6d37fc7ba7b6bec409330c6c0e654fd3ff202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331131 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#793725}
-
ckitagawa authored
Like link rects in the prior CL subframe rects were not accounting for the total global transform position. This CL fixes that. See the bug for a HTML repro testcase. Bug: 1110227 Change-Id: Ib4a690be4b7a0f906f82d06aa4cdb363d0e5eb2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329931 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793724}
-
Ian Clelland authored
Blink Intent to Ship discussion: https://groups.google.com/a/chromium.org/g/blink-dev/c/Za159T1QOek/m/lewQUFlBCQAJ Bug: 1064579 Change-Id: I56ae6bc744dddf2dcc47f62dec9d1c9545115bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331742Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#793723}
-
James Cook authored
Don't check for /mnt/stateful_partition being executable, because that path doesn't exist on regular linux. Bug: none Test: can launch lacros chrome on gLinux and on device Change-Id: I54e0369c099f954f5b439ba966e07edcfbacca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332573 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793722}
-
Muyao Xu authored
- Log "LaunchSession Succeeds" message after receiving success response from the receiver. - Add logs when session is removed by the receiver. Bug: 687380, b/154273698 Change-Id: Ie12590c98a34d3743e4b78cd36b4da278b9dac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315249 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#793721}
-
Regan Hsu authored
* Renames CellularSetup Polymer component to PsimFlowUi. * CellularSetup now includes an IronPages element that can switch between the PsimFlowUi, EsimFlowUi (to be written), and SetupFlowSelectionPage (to be written). * Moves ButtonBar into new CellularSetup. Bug: 1093185 Change-Id: I69bc4fd331cedab6cc28b4068ed613a6ad097656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324068Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793720}
-
yilkal authored
This cl corrects the logic in AppServiceWrapper::IsHiddenArcApp. Bug: 1093072 Change-Id: I216107716c98a941790147773c907189291df0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333052 Commit-Queue: Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#793719}
-
minch authored
Bug: None Change-Id: I43a5853962dc49dc5e2da3ea88c26c4aa2004be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#793718}
-
Guillaume Jenkins authored
Moves ChromeBrowserCloudManagementController from chrome/browser to components/enterprise so it can be used on Android and iOS. Bug: 1092442 Change-Id: Ieb883dceebfeea74496eb38ad0546678f7823c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314760Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#793717}
-
Rakesh Soma authored
in the reauth flow. https://screencast.googleplex.com/cast/NDgxMTU5NjA4Nzk1MTM2MHxkODI0NThkYS00OQ Bug: 1111561 Change-Id: Ia54f09152ed57d1f16132c916d55ae58094e386d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330821Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#793716}
-
Oksana Zhuravlova authored
This change populates host_app_package_name field of the ChromeProcessDescriptor message. It will be used to match renderer and browser processes to host apps. Bug: b/159477965 Change-Id: I49316a2e0e82a67366fa452a03bd795579723be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311125 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#793715}
-
John Lee authored
Bug: 642982, 1084620 Change-Id: I397768b3cb48d3c357365e32ee2130ceed720523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323724Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#793714}
-
David Benjamin authored
As documented, the policy is to be retired after M85. This policy was a temporary workaround for potential compatibility issues due to buggy and insecure enterprise proxies. Bug: 1012400 Change-Id: Ia47e544b8f7ed546633351d7c55c40c366e1d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324170Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793713}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26d2e8aa289b..2cd291aae824 2020-07-31 bsheedy@chromium.org Clean up artifact implementation after tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111474 Tbr: rmhasan@google.com Change-Id: I1e81c6eadbd2b9445c57467b254fbd4232f9254a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333086Reviewed-by:
-
Rakina Zata Amni authored
Allows disabling of BackForwardCache through enterprise policy. Bug: 511340 Change-Id: I1d9830499dc25a8cb987165578d98bea8195bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329107 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793711}
-
harrisonsean authored
Refactor Safety check to use mediator and delegates for updating the view controller. Add safe browsing preference to mediator for safe browsing check. Change Safety Check rows to use SettingsCheckItem. Bug: 1078782 Change-Id: Ie4b38b1e617e56cb013a6ce18c8d6d2c62fd9e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287295 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#793710}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: I1c71844fa405689c7b0d24ead36cf188a9cccf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329916Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#793709}
-
Emily Stark authored
When the simplified domain field trials are enabled, ElideURL() is sometimes used to hide most of the URL except for (part of) the domain. This is implemented by using GetSubstringBounds() to find the portion of the string that should not be elided, and setting the display rect and offset to show only that portion. However, GetSubstringBounds() can return bounds that just slightly larger (+/- 1 pixel) than the actual string, due to internal rounding. This can result in small artifacts around the simplified domain, as shown in the screenshots in the bug. To hide these artifacts, this CL sets the hidden portions of the URL to transparent in ElideURL(). The hidden portions are already set to transparent when we use ElideAnimation to animate from full URL to simplified domain, because fading is part of the animation. So in this CL we only need to add transparency in ElideURL() which is called when an animation isn't necessary. Bug: 1108045 Change-Id: Ie146b3585a908067a722dfcec6b6e0c9d03071d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323721 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#793708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7c4f9d06425..6d3996c1f67e 2020-07-31 johnstiles@google.com Update gradient colorizers to take coords instead of colors. 2020-07-31 robertphillips@google.com Fix bug(s) in combining and chaining GrTextureOps 2020-07-31 brianosman@google.com Always write binary (eg, UNIX line endings) to sksl .c.inc files 2020-07-31 jmbetancourt@google.com configure attributes for SkottieView to be initialized from XML layout 2020-07-31 johnstiles@google.com Replace manually-implemented lerp with mix(). 2020-07-31 mtklein@google.com remove SkDescriptor API fuzzer 2020-07-31 jvanverth@google.com Use staging buffers for Metal uploads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108475 Tbr: borenet@google.com Change-Id: Ib0e04c9809bd5ab69fc8f7fdc712a0fcb76f27e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331927Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/343f63643b43..98b332f2dbbd 2020-07-31 saagarsanghavi@google.com Fixed relative path to work when presubmit run from any directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111829 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0885180cca0d56f7145e3945d1f31a61470e8fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331926Reviewed-by:
-
Omer Katz authored
This CL doesn't yet solve the root cause of the crash. This will only limit its effect to less HashMaps (the stacktrace mentions a map from weak member to int which we have no reason to trace as an ephemeron). Bug: 1110416 Change-Id: I0b349f44e90605c8cd6ec9dd3c8983301ead29b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332582 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793705}
-
Avi Drissman authored
Platform #if defined(OS_*) macros are generated from the .json5 file by uppercasing the platform name and prepending "OS_" to it. Switch to "Mac" in the .json5 file so that the macro generated is OS_MAC. Bug: 1105907 Change-Id: I4916c746d035fb1d35b1789092e36aa4a2c86faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330579 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Currently we only load from localhost. That will not work in production, so first try to access a graph from gs://clank-dependency-graphs, then fall back to localhost (which cannot GET from the bucket due to CORS). Bug: 1111056 Change-Id: Idf06dfeb6eb49047e7c4c54f60c99e156f0387d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327463 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#793703}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3186e69eb799..bc6aebc6f315 2020-07-31 brgoddar@microsoft.com Grid: Set default CSS grid setting to extended dashed lines 2020-07-31 sigurds@chromium.org Update DevTools Chromium DEPS. 2020-07-31 janscheffler@chromium.org Migrate `front_end/resources` to `devtools_entrypoint` 2020-07-31 janscheffler@chromium.org Migrate `front_end/network` to `devtools_entrypoint` 2020-07-31 janscheffler@chromium.org Migrate `front_end/sources` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1109215 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia83df8572552548eb917a0e057317bfda2c8601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332251Reviewed-by:
-
Eugene But authored
According to Session.WebStates.NavigationItem.SerializedPostDataSize histogram stored POST data can be quite large, which can have negative impact on stability. slim-nav based navigation can not restore POST data, so there is no point in storing this data. This also apply for Preload feature, which relies on session restoration and looses POST data. Bug: 1082279 Change-Id: Iedfdc247be8b8fd5e7872351f36529d4d10ce66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325208 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
Prabir Pradhan authored
- layout_mode should use the unsigned int type. - remote_shell should send the initial layout_mode after connecting to the client for the first time. BUG=None TEST=None Change-Id: I7f811a9afd72d0b889cb5cac5dded98018f4826c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317858Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#793700}
-
