Commits · c119f6b8eaaa14d188cd8e04782a2375118a3adc · eriksson monteiro / tangled

23 Apr, 2018 40 commits

[CrOS MultiDevice] Add SoftwareFeature enum and EnumTraits conversion. · c119f6b8

Kyle Horimoto authored Apr 23, 2018

The SoftwareFeature enum will be utilized in a follow-up CL.

Bug: 824568, 752273
Change-Id: Ideda29fe6569d9376014ac33ccfe22768af149b9
Reviewed-on: https://chromium-review.googlesource.com/1017346Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552816}

c119f6b8

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/previews · 17062182

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=dougarnett@chromium.org

Bug: 825327
Change-Id: I6e76633f91ff6f0eb37fbb0ef2e8802508906835
Reviewed-on: https://chromium-review.googlesource.com/1024252
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552815}

17062182

Network Service: Remove WorkerTest.SharedWorkerHttpAuth · 85ccead2

Jun Cai authored Apr 23, 2018

As discussed at:
https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/GWJCro1UnKw
The WorkerTest.SharedWorkerHttpAuth doesn't test what it means to test,
and what it means to test doesn't work with or without network service,
so this CL removes this test.

Bug: 783990
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8fa60dbd145926bfc3955fd9060c4105a733cf1c
Reviewed-on: https://chromium-review.googlesource.com/1024485Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552814}

85ccead2

[omnibox] Make sure zero suggest provider stops on input · 8642e616

Kevin Bailey authored Apr 23, 2018

Changed ZeroSuggestProvider::Start() to call Stop() when wouldn't have
started - not from Omnibox focus or invalid input.

Also added small unit test.

Bug: 825318
Change-Id: I962f1a858731e66e74a2dfb35128ac1cdabf2b81
Reviewed-on: https://chromium-review.googlesource.com/1022077Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552813}

8642e616

Update pretty print rules for actions and histograms. · 6ab4c526

Alexei Svitkine authored Apr 23, 2018

This addresses TODOs added in:
https://chromium-review.googlesource.com/c/chromium/src/+/1015293

For actions, names are now sorted in a case insensitive
way, to match histograms.

For histograms, suffixes are now sorted.

Both of the changes require reformatting of the relevant
XML file, which is also done in this CL.

Landing TBR to avoid rebasing/merge conflicts given this
changes histograms.xml extensively.

Bug: 835915
TBR: isherman@chromium.org
Change-Id: Ic8807f695206e2bc31a33440dd47c48f89224f00
Reviewed-on: https://chromium-review.googlesource.com/1024404
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552812}

6ab4c526

Change two expected-txt for animations on Mac · f8422e63

Xida Chen authored Apr 23, 2018

Two animation-types layout tests fails because the expected-txt is out
of date. This CL update it.

TBR=smcgruer@chromium.org
NOTRY=true

Bug: None
Change-Id: I6a37e9763bc7599356c1d9fe108edb8feb67bc06
Reviewed-on: https://chromium-review.googlesource.com/1024883Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552811}

f8422e63

[ios] Make dimension 'device_status' optional for clang_tot_device · 3c413711

Justin Cohen authored Apr 23, 2018

Since there is only 1 device at the moment, skip the health check.

Bug: 723764
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic06468c2c0669413ce5507abdc0aeb3b2181ceb7
Reviewed-on: https://chromium-review.googlesource.com/1024299Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552810}

3c413711

Rename u2f_parsing_utils.h to fido_parsing_utils.h · 19b944e9

Jun Choi authored Apr 23, 2018

Bug: 798573, 808637
Change-Id: I43d93e8b7ec295324901305e168e31506c1a547e
Reviewed-on: https://chromium-review.googlesource.com/1022831
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552809}

19b944e9

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/ui/views/tabs · 7546e359

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 825327
Change-Id: I6c014006f6e83d53a8cc1f57c3377163a89bba51
Reviewed-on: https://chromium-review.googlesource.com/1024245
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552808}

7546e359

Fix use-after-free in FileReaderLoader. · a261ea1c

Marijn Kruisselbrink authored Apr 23, 2018

Anything that calls out to client_ can cause FileReaderLoader to be
destroyed, so make sure to check for that situation.

Bug: 835639
Change-Id: I57533d41b7118c06da17abec28bbf301e1f50646
Reviewed-on: https://chromium-review.googlesource.com/1024450
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552807}

a261ea1c

Use accessible name in toolbar test · 72226aa9

Aaron Leventhal authored Apr 23, 2018

Accessibility checks from http://crrev.com/c/981937 fail in
ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks.

This adds an accessible name via the controller used in the test.

Bug: 819350
Change-Id: I64c95fbea582816c47d0215065fc8983f78a2bb7
Reviewed-on: https://chromium-review.googlesource.com/1023211
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552806}

72226aa9

Migrate MessageLoop::current() to MessageLoopCurrent in /components/services/heap_profiling · fa4f5015

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=erikchen@chromium.org

Bug: 825327
Change-Id: I1637b4694aa8bc4fed82436c554013b4d8dd96fd
Reviewed-on: https://chromium-review.googlesource.com/1024437Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552805}

fa4f5015

Migrate MessageLoop::current() to MessageLoopCurrent in... · 0d6b8919

Gabriel Charette authored Apr 23, 2018

Migrate MessageLoop::current() to MessageLoopCurrent in /third_party/blink/renderer/platform/scheduler/child

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rmcilroy@chromium.org

Bug: 825327
Change-Id: I4bbe57deb6fe22c898dcf4526ca5576bd461ef46
Reviewed-on: https://chromium-review.googlesource.com/1024295
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552804}

0d6b8919

Move SkImage::getTextureHandle to getBackendTexture in content media capture. · ee99af18

Greg Daniel authored Apr 23, 2018

In skia getTextureHandle is deprecated and this change moves to using the
new API.

Change-Id: I44d5b3b45dcee0420f475dd5b93c4f5337bbfb96
Reviewed-on: https://chromium-review.googlesource.com/1024292
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552803}

ee99af18

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/extensions/activity_log · 2b94633e

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 825327
Change-Id: I0fba6092e86514d3744298ecced1a82327be5181
Reviewed-on: https://chromium-review.googlesource.com/1024407
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552802}

2b94633e

[EoC] Add a "Send Feedback" footer link · a2e128e2

Theresa authored Apr 23, 2018

Add a link at the bottom the Explore on Content panel to allow users to
easily send feedback.

BUG=833965

Change-Id: Id8a94d5dbc9110abc503255e9e65051996d15d35
Reviewed-on: https://chromium-review.googlesource.com/1022260Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552801}

a2e128e2

Migrate MessageLoop::current() to MessageLoopCurrent in... · 2598a3a0

Gabriel Charette authored Apr 23, 2018

Migrate MessageLoop::current() to MessageLoopCurrent in /base/test/android/java_handler_thread_helpers.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=torne@chromium.org

Bug: 825327
Change-Id: I2fc1aeccf94e9db6175d8630eeec5a3a4f4345ca
Reviewed-on: https://chromium-review.googlesource.com/1024477
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552800}

2598a3a0

Creates WorkerAnimationFrameProvider and BeginFrameProvider · dbd9ed9d

Fernando Serboncini authored Apr 23, 2018

Both classes work together to provide RequestAnimationFrame to workers.


Bug: 833902
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I541b47355ed8ff8cafbb5f4f2b791b2ff16ff4c6
Reviewed-on: https://chromium-review.googlesource.com/1015288
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552799}

dbd9ed9d

[Chromecast] Reduce min timestamp stability time · d4191c2b

Chris Kuiper authored Apr 23, 2018

The original value of 1sec was needed to have sufficient time to establish an
accurate reference timestamp. With new audio HAL code provided by the SoM
vendor that improves timestamp jitter significantly, we can reduce the
stability time. This has the benefit of a faster playback startup time.

Bug: internal b/78129008
Test: playback tests and obverving startup times in logs
Change-Id: I2bf9a21b32dc5e6b0cf400d1d195099e56b517a7
Reviewed-on: https://chromium-review.googlesource.com/1024312Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552798}

d4191c2b

Mark http/tests/appcache/non-html.xhtml as flakily leaking. · fc81d445

Lei Zhang authored Apr 23, 2018

BUG=835943
NOTRY=true

Change-Id: I468b0d573bf5cda24e930e34ea7ae7a581202713
Reviewed-on: https://chromium-review.googlesource.com/1024758Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552797}

fc81d445

Add unit tests for home launcher · e6f66033

Weidong Guo authored Apr 23, 2018

BUG=835012

Change-Id: Ib59301c4ef4aece078daaa41aa3ce4fb0639e8c8
Reviewed-on: https://chromium-review.googlesource.com/1022710
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552796}

e6f66033

Reland "Webkit layout test runner: Add option for zero tests executed" · 3bed2ab7

Stephen Martinis authored Apr 23, 2018

This reverts commit dea64670.

Reason for revert: Re-landing CL

Original change's description:
> Revert "Webkit layout test runner: Add option for zero tests executed"
> 
> This reverts commit e3ce4282.
> 
> Reason for revert: Causing failures on webkit linux trusty leak bot https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17952
> 
> Original change's description:
> > Webkit layout test runner: Add option for zero tests executed
> > 
> > Adds --zero-tests-executed-ok, which makes the layout test runner exit
> > with an ok status if zero tests are executed. This is important for
> > re-running layout tests without patch, which we do on tryservers to
> > check if the test was being flaky.
> > 
> > Bug: 533481
> > Change-Id: I7d6bcd805b99818fdf82ecb88e71863ff72b72e7
> > Reviewed-on: https://chromium-review.googlesource.com/1018590
> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> > Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552426}
> 
> TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,jeffcarp@chromium.org,robertma@chromium.org
> 
> Change-Id: Ibfe5f1bc3c02354a975d058c5d6338d0762c6e34
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 533481
> Reviewed-on: https://chromium-review.googlesource.com/1022555
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Jesse Doherty <jwd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552470}

TBR=jwd@chromium.org,qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,jeffcarp@chromium.org,robertma@chromium.org

Change-Id: I76b1a0fdd188aa174eeb546d548aa4e4a751e4f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 533481
Reviewed-on: https://chromium-review.googlesource.com/1022556
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552795}

3bed2ab7

Implement the msaa_is_slow and avoid_stencil_buffers gpu capabilities. · 54605398

Geoff Lang authored Apr 23, 2018

These capabitilites were not implemented in the passthrough command decoder
which resulted in poor MSAA performace on Intel high DPI.

BUG=801659
BUG=800133
BUG=800011
BUG=799951

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2e1f0f3b4b8267421646279b6d3154223f8199b0
Reviewed-on: https://chromium-review.googlesource.com/1024282Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552794}

54605398

Use static variable instead of LazyInstance in base::Process::CanBackgroundProcesses(). · c4b34eca

Francois Doray authored Apr 23, 2018

Before this CL, base::Process::CanBackgroundProcesses() used a
LazyInstance to ensure that a bool was initialized only once. The same
result with less code using a static variable.

Change-Id: I00b5cea3619bd71701e48a8e5cc80b5fc0db10e8
Reviewed-on: https://chromium-review.googlesource.com/1024232Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552793}

c4b34eca

Migrate MessageLoop::current() to MessageLoopCurrent in /android_webview · 8190b579

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=torne@chromium.org

Bug: 825327
Change-Id: Id2340299ab2a3c4e3329b66a625d49f41a2e5443
Reviewed-on: https://chromium-review.googlesource.com/1024443
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552792}

8190b579

Switch to video master AV sync · de31a37f

Mina Almasry authored Apr 23, 2018

Audio master AV sync will not function for some of our use cases, so we
switch here to video master AV sync.

Currently only tested with manual testing, and it works great on that.
There are still some extraneous corrections but those are pretty minor
and not noticable, especially since we're adjusting the rate of playback
of the audio.

This CL makes the unittests now obselete. The unittests mocked the audio
pipeline, which is not what we want with video master AV sync. The
unittests still build, run and pass with this CL, but do not provide
meaningful results. They will be adjusted in a follow up CL.

Bug: b/74612005, b/73746352
Test: Manual, on device, unittests
Change-Id: Ic6b2eced95e794d646ad1ecc3f07e452c0bc96e6
Reviewed-on: https://chromium-review.googlesource.com/1011705Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552791}

de31a37f

[ios] Fixes UI egtests when the UIRefresh flag is enabled. · 662e96bd

Rohit Rao authored Apr 23, 2018

KeyboardCommandsTestCase.testKeyboardCommandsNotRegistered_AddBookmarkPresented
and ToolbarTestCase.testToolbarOmniboxTyping are updated with matches for the
correct elements.

ActivityServiceControllerTestCase.testActivityServiceControllerIsDisabled and
TabSwitcherTransitionTestCase.testRotationsWhileSwitcherIsNotActive are
disabled, because these tests are exposing UIRefresh bugs.

BUG=825431,835860,835871
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I805e4b29ce59b88eb63016d4d2687c9043c72f5b
Reviewed-on: https://chromium-review.googlesource.com/1023718
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552790}

662e96bd

Enable GPay branding on Android Upstream · 8603ada8

Lakshmi Kumar Dabbiru authored Apr 23, 2018

Enable GPay branding on Android Upstream

Change-Id: If22b0723f6cf515a79b85de08f61afc171e14625
Reviewed-on: https://chromium-review.googlesource.com/1020534Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#552789}

8603ada8

[Chromecast] Whitelist chrome://home for <webview> tag. · bab3c9c8

Stephen Lanham authored Apr 23, 2018

Add chrome://home to the list of webui urls whitelisted for <webview>
tag usage. This is used to safely display web content within the WebUI.

BUG=768526

Change-Id: Ia559fe32f2e45634c81d257ef5094e32e2b2cf52
Reviewed-on: https://chromium-review.googlesource.com/896579Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552788}

bab3c9c8

VR: Autofill - Remove transparency of the web content · 3da68538

Amirhossein Simjour authored Apr 23, 2018

Autofill shouldn't make the content quad transparent.

Bug: 835903
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I33a3dcd02c526a24beccd3d5504fc26840e734fa
Reviewed-on: https://chromium-review.googlesource.com/1024283Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552787}

3da68538

Migrate MessageLoop::current() to MessageLoopCurrent in /headless · b5d766c2

Gabriel Charette authored Apr 23, 2018

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=altimin@chromium.org

Bug: 825327
Change-Id: I87b81780f737a0be5087f319474f663a3aa89892
Reviewed-on: https://chromium-review.googlesource.com/1024481
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552786}

b5d766c2

Revert "Move notification_helper/ to chrome/notification_helper/" · b372f1d8

Xi Cheng authored Apr 23, 2018

This reverts commit 850001f3.

Reason for revert: <file://notification_helper/OWNERS is referenced in chrome/browser/notifications/OWNERS. After moving this folder, the file is gone which creates a deadlock for "git cl upload".>

Original change's description:
> Move notification_helper/ to chrome/notification_helper/
> 
> ... plus all the necessary code migration. A follow-up CL will be used
> to update relevant comments.
> 
> Bug: 734095
> Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b
> Reviewed-on: https://chromium-review.googlesource.com/1022957
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552762}

TBR=jam@chromium.org,chengx@chromium.org

Change-Id: Idc75aa458afeaf6c7fe5d36c85c76c60947c0687
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 734095
Reviewed-on: https://chromium-review.googlesource.com/1024590Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552785}

b372f1d8

viz: Remove sequence numbers from TransferableResource. · db774087

danakj authored Apr 23, 2018

These numbers are no longer used as SharedBitmapId registration happens
in the same mojo ipc stream as CompositorFrameSubmission. So they don't
need to exist anymore.

R=kenrb@chromium.org, pdr@chromium.org, piman@chromium.org

Bug: 730660
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I12fcb70963cfaeebc5ae439ab3eb74dab1486bcd
Reviewed-on: https://chromium-review.googlesource.com/1022294
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552784}

db774087

Disable MemlogBrowserTest.EndToEnd on chromeos · d4c322d7

Xida Chen authored Apr 23, 2018

In my previous CL here:
https://chromium-review.googlesource.com/c/chromium/src/+/1023980, I
didn't do it right, this CL does it right.

TBR=thestig@chromium.org
NOTRY=true

Bug: 835826
Change-Id: I96919dbe0dc3be285e44315753ffdb4bc87b862d
Reviewed-on: https://chromium-review.googlesource.com/1024537
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552783}

d4c322d7

[Presentation API] Final onion soup. · 3eb973ca

Derek Cheng authored Apr 23, 2018

This patch removes PresentationDispatcher and related WebPresentation*
interfaces.

PresentationReceiver now eagerly connects to PresentationService,
instead of waiting on document load signal, which isn't available in
Blink and is not necessary. PresentationReceiver itself remains
eagerly created, which causes some existing assumptions to be broken
on the browser side, but should be fixable with further browser-side
refactoring (added TODO).

Also reverts the BindingSet in PresentationServiceImpl back to a single
Binding since PresentationDispatcher no longer exists.


Bug: 749327
Change-Id: Ic8296471491088da283450a05a620005b2668ba4
Reviewed-on: https://chromium-review.googlesource.com/961525Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552782}

3eb973ca

Clean up the posix source files in mojo/ · 366a4d4f

Fabrice de Gans-Riberi authored Apr 23, 2018

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: Ica1adbaab55c9cc64edd4a1d4dc6b57ddae8f967
Reviewed-on: https://chromium-review.googlesource.com/1022189Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552781}

366a4d4f

Remove obsolete code from network quality estimator · 3f884c10

Tarun Bansal authored Apr 23, 2018

Remove code related to experimenting with different
statistical algorithms and ECT computing functions.
Those experiments have completed, and
there is no need to keep this code around.

Change-Id: I0016ba2fda758dae7f3952cc2b120645ef996638
Bug: 834119
Reviewed-on: https://chromium-review.googlesource.com/1023275Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552780}

3f884c10

Make ArcApplicationNotifierController aware of profile destruction. · fdc58a89

Evan Stade authored Apr 23, 2018

Also rename it: ARC implies Chrome OS so remove trailing "ChromeOS".

Bug: 833533
Change-Id: Iea3644a3b2bbbd2f63273a332f2ee71a4d856f5f
Reviewed-on: https://chromium-review.googlesource.com/1022125Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552779}

fdc58a89

Add a line of comment for disabling a test on win · 7d4ecf41

Xida Chen authored Apr 23, 2018

In my previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/1024202, I
disabled a test without proper comments. This CL adds a line of comment
referencing the associated bug.

TBR=thestig@chromium.org
NOTRY=true

Bug: 835865
Change-Id: I191efd833b6327d26fa2077b431a78fcc9eb8ce4
Reviewed-on: https://chromium-review.googlesource.com/1024377Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552778}

7d4ecf41

cros: Enable preview only when wallpaper app is in full screen · 9c9ad7a2

Wenzhao Zang authored Apr 23, 2018

Currently preview mode is always enabled on the new wallpaper picker.
Change it to only enable in full screen mode.

Bug: 834828
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a0f7934e1466f80fce5682ef116efd5fd2e4b20
Reviewed-on: https://chromium-review.googlesource.com/1023172Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552777}

9c9ad7a2