- 16 Aug, 2018 40 commits
-
-
Tessa Nijssen authored
Some TextSuggestionsTouchBarController unit tests were missing comments. Comments were added where necessary. Bug: 717553 Change-Id: I5e41114a5618899bba61d4867d17634ab151fcfc Reviewed-on: https://chromium-review.googlesource.com/1178575Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583886}
-
Yao Xiao authored
Previously on a non-Mac platform when JS dialog is dismissed by user closing the tab, |DIALOG_BUTTON_CLICKED| is logged. This change separates the case of the user replying to the dialog with the buttons vs rejecting it. Bug: 872795 Change-Id: I4b8781daeb3cead5ee4e975a67f79f94b7fa84e5 Reviewed-on: https://chromium-review.googlesource.com/1164647Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Jun Choi authored
Make WebAuthN UI modals appear after all fields of TransportAvailabilityInfo have been set by FidoRequestHandlerBase. Also, Add rp_id to TransportAvailabilityInfo struct as rp id is shown in the UI dialogs. Bug: 847985 Change-Id: I0c5341dfd98a192553ebd868461df405a5c0a5b1 Reviewed-on: https://chromium-review.googlesource.com/1176701Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583884}
-
Nico Weber authored
This reverts commit 7acc0647. Reason for revert: The builder seems to work now. (Note: It currently only compiles everything and doesn't run any tests yet.) Original change's description: > Remove win-asan from console view again for a bit. > > Getting bots for the builder is taking longer than expected, and having a > perma-purple bot on the main waterfall isn't so great. > > I'll revert this again once hardware for the builder has been allocated and > configured. > > Bug: 869973 > Change-Id: I702c4694eb13cc39cc07bc01f19a6f7871e9f47c > Reviewed-on: https://chromium-review.googlesource.com/1166170 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581400} TBR=thakis@chromium.org,dpranke@chromium.org,sergeyberezin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869973 Change-Id: Id4498b0cb964a22d33e5b7f76b135c8d560a7291 Reviewed-on: https://chromium-review.googlesource.com/1179001Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583883}
-
Wez authored
Defines a base::debug::WriteClangCoverageProfile() API which performs an explicit call to __llvm_profile_dump() in CLANG_COVERAGE builds, with locking to ensure thread-safety. This API is invoked in the base::debug::BreakDebugger() and base::Process::TerminateCurrentProcessImmediately() APIs, immediately prior to them terminating the process, to mirror the coverage-writing step that would be performed via an at-exit handler during a normal process-exit. This ensures that we get as complete coverage data as possible from processes which fast-terminate/break (e.g. EXPECT_DEATH() sub-processes, e.g. browser child processes, etc). Bug: 849369 Change-Id: I38262334bb5abf8d5ba40c2c32352b38096905ec Reviewed-on: https://chromium-review.googlesource.com/1172932Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583882}
-
Eyor Alemayehu authored
Bug: b:112645619 Change-Id: I572cfdf4e58cb102666f59eb931fa95337404f69 Reviewed-on: https://chromium-review.googlesource.com/1175079Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Commit-Position: refs/heads/master@{#583881}
-
David Black authored
Strings to appear on Assistant suggestion chips. Bug: b:111694337 Change-Id: Ia5bde63a25341e5083859329bade28648dd3df46 Reviewed-on: https://chromium-review.googlesource.com/1178934Reviewed-by:
-
David Tseng authored
Bug: 859052 Change-Id: Ic1113d8e4200f46bb3f49e1a2c72cbedaba1eef5 Reviewed-on: https://chromium-review.googlesource.com/1178890 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#583879}
-
Clark DuVall authored
Bug: 874658 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263 Reviewed-on: https://chromium-review.googlesource.com/1176725Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
WebLocalFrame::ReportFindInPageMatchCount and ReportFindInPageSelection are only called by plugin code. This CL changes the plugin code to call those functions on FindInPage directly and removes the functions. Bug: 819919 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5df288ac6ce934ec0f6b27b47c17025005a73bad Reviewed-on: https://chromium-review.googlesource.com/1176898Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#583877}
-
Felipe Salazar authored
Bug: 851163 Change-Id: I6a6aa135f9e1cab496ad6b7fe007bdc8e1ac94f0 Reviewed-on: https://chromium-review.googlesource.com/1178632Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Felipe Salazar <felipesalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583876}
-
Anna Offenwanger authored
Bug: 874758 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I31e474ab9736b96ed1da400dcca7206a650b87fb Reviewed-on: https://chromium-review.googlesource.com/1178936Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#583875}
-
Siddhartha authored
Change-Id: I47afa414206783dfaf18997578a953c3f630c3ff Reviewed-on: https://chromium-review.googlesource.com/1178742 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583874}
-
Tarun Bansal authored
Use network quality tracker instead of network quality estimator (NQE) in UKM page load metrics. Network quality tracker can provide network service when network service is enabled as well as when network service is disabled. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icffe39d2ae493934456ff911290bc50d53efab49 Bug: 819244 Reviewed-on: https://chromium-review.googlesource.com/1177199 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
Bug: 863441 Change-Id: Ida53af27cb6d43f5b750a80cdbfe82582e9548a9 Reviewed-on: https://chromium-review.googlesource.com/1161187 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Chris Lu authored
Removes the date for sync times that occur within the same calendar day. Replaces date with "Yesterday" for sync times that occur in the previous calendar day. Screenshot: https://drive.google.com/open?id=1uFZHxOgHytaARm97MWONgekuymVxRBvJ, https://drive.google.com/open?id=1ZZr5HR___1y_CuQKcoNP-5Umd2Lz5K3n Bug: 870043 Change-Id: Id6d4ecb424d5e709e66e48cd57d0c4add5683b1c Reviewed-on: https://chromium-review.googlesource.com/1177891Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#583871}
-
Kent Tamura authored
A FileSelectHelper instance handles at most one directory enumeration during its lifetime. - FileSelectHelper doesn't need to have |std::map<int, ActiveDirectoryEnumeration*>|. One |std::unique_ptr< ActiveDirectoryEnumeration>| and one |int request_id_| are enough. - We don't need DirectoryListerDispatchDelegate. FileSelectHelper implements net::DirectoryLister::DirectoryListerDelegate. This CL has no behavior changes. This CL is a preparation to mojoify FileChooser IPC. Bug: 869257 Change-Id: I19ecfbb49b54c2430f7f0358ca787e831c493e29 Reviewed-on: https://chromium-review.googlesource.com/1177082 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f956badf3dd2..d5e282648a08 git log f956badf3dd2..d5e282648a08 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 tsepez@chromium.org Remove optional bool bType from GetFillArgb() 2018-08-16 tsepez@chromium.org Replace optional bool bNotify with enum type. 2018-08-16 tsepez@chromium.org Remove default arg from CFX_BinaryBuf::EstimateSize(). 2018-08-16 hnakashima@chromium.org Allow PDF417 barcodes to reduce modules by shaving off padding. 2018-08-16 hnakashima@chromium.org If rows need to overflow in a PDF417 barcode, keep it to a minimum. Created with: gclient setdep -r src/third_party/pdfium@d5e282648a08 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7f2d03150bdcb0883ecdbb8ca18f84cba538ee2e Reviewed-on: https://chromium-review.googlesource.com/1178902Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583869}
-
Zhongyi Shi authored
Migrate back to the default network after handshake has been confirmed and the connection is originally created on the non-default network. Bug: 790547 Change-Id: Ia991d49e5c8197fca0a98224239e1bc412ca9005 Reviewed-on: https://chromium-review.googlesource.com/1176656 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583868}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efb38bb3d729..95fb6dc81034 git log efb38bb3d729..95fb6dc81034 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 vadimsh@chromium.org [cipd] Check CIPD client hash during updates on Windows. Created with: gclient setdep -r src/third_party/depot_tools@95fb6dc81034 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870166 TBR=agable@chromium.org Change-Id: Ie559e2b70ec74632248a8cefe5d7646d471fd1bf Reviewed-on: https://chromium-review.googlesource.com/1178542Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583867}
-
Lei Zhang authored
- Use a ThreadChecker member instead of inheriting from ThreadChecker. - Switch from a leaky Singleton to base::NoDestructor. Change-Id: I86f8f50f7776ceefa62ab3586314c5af3bacf7e7 Reviewed-on: https://chromium-review.googlesource.com/1178468Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG=873593 Change-Id: Ia8cf2340978bac68730a642e74977eac290edc16 Reviewed-on: https://chromium-review.googlesource.com/1178745Reviewed-by:
-
Marijn Kruisselbrink authored
Not hooked up yet, but implements the mojo interface in terms of the old implementation. Bug: 872460 Change-Id: Id33e4a8f732f4bda0a2ad866e85e210962b45a05 Reviewed-on: https://chromium-review.googlesource.com/1171518Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583864}
-
David Black authored
Previously, Assistant cards (WebViews) would consume any event that they processed. This prevented our container from scrolling effectively, because scroll gestures would be consumed. Now, we prevent the WebView from receiving anything other than mouse click related events. We need to give it those events because Assistant cards contain links. To also support link taps via gesture, we need to route taps back to the WebView's manually. We do this by converting tap gestures into mouse events. Bug: b:110039692 Change-Id: Id0d44af0651490ddf58b6e0e0c70c41fec3fa654 Reviewed-on: https://chromium-review.googlesource.com/1174961 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Kim Paulhamus authored
Bug: 678885 Change-Id: If95f75082e1ad44be008540aa93b59ec1f687cf8 Reviewed-on: https://chromium-review.googlesource.com/1176736Reviewed-by:
-
Paul Irish authored
Bug: 874982 Change-Id: I463cd1a8ea61407501732425a8dcb6363010bb87 Reviewed-on: https://chromium-review.googlesource.com/1178401 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Patrick Hulce <phulce@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#583861}
-
Greg Thompson authored
The data pointed to by a PE image's debug directory entries need not be contained in the sections that are mapped into memory. In such cases, the AddressOfRawData field of the debug directory entry is null. GetDebugId now handles this by skipping over such entries in its search for debug info. Additionally, PEImage::GetDebugId now returns the string length of the pdb_filename, with proper bounds checking. (Note: StringPiece would have been a nice fit, but pe_image.{cc,h} does not depend on other parts of base.) This change also adds some extra sanity checking to GetImageDirectoryEntrySize and GetImageDirectoryEntryAddr so that they return 0/null in case the desired directory entry is not present in the image. This should never be the case for well-formed images, but we should be cautious regardless. BUG=874044 R=brucedawson@chromium.org TBR=jwd@chromium.org,alph@chromium.org,hjd@chromium.org Change-Id: I45f8024054c0e3a998dd46bf1d4e9db345138865 Reviewed-on: https://chromium-review.googlesource.com/1175705 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#583860}
-
Matthew Jones authored
This reverts commit 0cdc1458. Reason for revert: Breaks ToastHWATest* on Marshmallow 64 bit Tester: [FATAL:persistent_histogram_allocator.cc(893)] Check failed: !subtle::NoBarrier_Load(&g_histogram_allocator). https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23305 Original change's description: > metrics: Initialize persistent metric allocator early. > > The PersistentMemoryAllocator in the gpu (and other) process is created > asynchronously. If any uma-histogram is reported before that time, then > those Histograms are not stored in the shared memory. This has some > implications: > . If the process crashes (which is common for the gpu process on > android), then these metrics are lost. > . If the process stays alive, then the metrics are reported > periodically, but because it is buffered, it doesn't match up > correctly with the other metrics that are reported in the shared > memory. > > The allocator is created in response to a message from the browser, > which includes the handle for the shared memory to use for the allocator. > The browser waits until the process has been launched and connected. > So this happens much later, compared to other messages which are sent > from browser over mojo without waiting for the connection to have > been established first. Therefore, change this so that the browser > immediately shares the shared-memory segment with the gpu process. mojo > takes care of waiting for the process-launch etc. > > BUG=865179, 778749 > > Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e > Reviewed-on: https://chromium-review.googlesource.com/1174709 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583673} TBR=avi@chromium.org,sadrul@chromium.org,bcwhite@chromium.org Change-Id: I65e9ad62e6613d0eaf08e834def5a988a60c4a19 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865179, 778749 Reviewed-on: https://chromium-review.googlesource.com/1179041Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583859}
-
Daniel Zhang authored
More testing of autocomplete behavior is needed. Placing AppList autocomplete behind a flag and updating tests to reflect this. Bug: 874133 Change-Id: I35f78089045efc65da3a4f524d7e0b613b854705 Reviewed-on: https://chromium-review.googlesource.com/1178577Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#583858}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ic2d0c573867b9c1e08e52febcd5211afe08c9e84 Reviewed-on: https://chromium-review.googlesource.com/1178758Reviewed-by:
-
John Budorick authored
This reverts commit 99255887. Reason for revert: added more machines, going to try out warm caching Original change's description: > cr-buildbucket-dev: use auto_builder_dimension for luci.chromium.ci. > > Bug: 868525 > Change-Id: I65aabb60d4823423d7f0bd4d5b51ea145c665658 > Reviewed-on: https://chromium-review.googlesource.com/1176471 > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583450} TBR=nodir@chromium.org,jbudorick@chromium.org Change-Id: If807d179cf51089c8332a627ae4d2de78468e79a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868525 Reviewed-on: https://chromium-review.googlesource.com/1178993Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583856}
-
Ned Nguyen authored
This reverts commit 520ce5d7. Reason for revert: breaking blink_perf.image_decoder/* tests BUG:chromium:874810 Original change's description: > Hold pre-decoded images until use or 250ms rather than 2 frames > > We currently unlock pre-decoded images after 2 frames of any type. This > doesn't always give callers a chance to use their images (if main thread > is a bit backed up). Instead we should wait for the caller to actually > use the image. Additionally, we drop images after 250ms to prevent > excessive growth if a user fails to use images in a timely manner. > > See the linked bug for example traces which show the benefits. > > R=khushalsagar > > Bug: 869491 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Icd94709aad5c076b1ba295495eaab24dc893ebdb > Reviewed-on: https://chromium-review.googlesource.com/1159203 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583171} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869491 Change-Id: Ia80ab26563bf1ccc0556d5638a483337acee972d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1178841Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583855}
-
Jacob Dufault authored
Caused by uninitialized memory so the color would be random. Change-Id: I49a306a426d723f2f75283b973c1b91e105f12c5 Reviewed-on: https://chromium-review.googlesource.com/1178896Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#583854}
-
Balazs Engedy authored
Screenshots for strings will be uploaded in a follow-up CL. This CL also improves the naming of some string constants, as well as deduplicates the two USB activation sheets (register/sign) into just one. Bug: 849323 Change-Id: I37709d65c6fe980dff18d1b98d070a66f4d90115 TBR: jcivelli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1178285Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583853}
-
Dirk Pranke authored
When we added LASTCHANGE.committime in r583420, we missed a case where we might not write it in the hook, and in that situation the build would fail due to the file being missing. TBR=thakis@chromium.org BUG=875039 Change-Id: I5c596f55fe90bc5f5175c74ba27e218f108f843b Reviewed-on: https://chromium-review.googlesource.com/1178892Reviewed-by:
-
John Chen authored
Currently, GetElementRect command expects all returned values (x, y, width, height) to be integers, but in reality they can be non-integer numbers. This CL fixes the implementation, and improves error messages. Bug: chromedriver:2545 Change-Id: I8c01f0d7f3de530e5e54b7e698a5583b050b68a3 Reviewed-on: https://chromium-review.googlesource.com/1178759Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583851}
-
Steven Bennetts authored
ShellDelegate::PreInit is now only used by WindowTreeHostManagerStartupTest.Startup which can effectively be tested by other means. Bug: 705713 Change-Id: Ieaa394db7603ab14ccaa79059303aff4011af5d0 Reviewed-on: https://chromium-review.googlesource.com/1169432 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#583850}
-
Ben Kelly authored
This reverts commit 74fd352e. Reason for revert: Moving behind experimental feature flag until web compat can be assessed. Original change's description: > Cache Storage: Check for duplicate entries in Cache.addAll(). > > This implements step 4.2.3 of the BatchCacheOperations algorithm: > > https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm > > Bug: 720919 > Change-Id: I679f786441b813ed816a183522021c417f4ab7b8 > Reviewed-on: https://chromium-review.googlesource.com/1162362 > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582738} TBR=jsbell@chromium.org,kinuko@chromium.org,pwnall@chromium.org,wanderview@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 720919 Change-Id: I08736e4ec638a65c48f329966f378698a6d9b045 Reviewed-on: https://chromium-review.googlesource.com/1178502Reviewed-by:
-
Fabio Tirelo authored
Bug: 874094 Change-Id: I246b33a817bb87357acb9b9426add41323cb2711 Reviewed-on: https://chromium-review.googlesource.com/1178748Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#583848}
-
Christian Fremerey authored
Adds a new secondary base::Feature for controlling whether or not the video capture service is enabled. This gets enabled by default and serves as a kill switch for groups of devices that force the primary switch enabled via command-line argument. Design Doc: https://docs.google.com/document/d/1n9I_DfuNGIA7PUWHOX2O2HVnI1d87q7W7lNTqVZkm0Y/edit?usp=sharing Bug: 870819 Change-Id: Idd861e838f12a72b54e1140bc3fc613ee5b53018 Reviewed-on: https://chromium-review.googlesource.com/1168001 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
-
