GitLab

When wrapping an invalid SharedMemoryHandle, we should always
just return a null ScopedSharedBufferHandle. Currently we return
a non-null ScopedSharedBufferHandle which wraps an invalid platform
handle. This will always fail to serialize and is generally bad.

Also fixes DiscardableSharedMemoryManager mojom to allow a null
shared buffer handle in the response to
AllocateLockedDiscardableSharedMemory. The existing client implementation
already handles the null case, so no additional code changes are required

BUG=674406

Review-Url: https://codereview.chromium.org/2583583002
Cr-Commit-Position: refs/heads/master@{#438955}

PngWriteStructDestroyer accesses info_ptr, so
info_ptr must have a wider lifetime scope. Otherwise,
the behavior of the problem is undefined.

The issue is found by AddressSanitizer with use-after-scope check enabled.

BUG=649897

Review-Url: https://codereview.chromium.org/2576823002
Cr-Commit-Position: refs/heads/master@{#438954}

https://skia.googlesource.com/skia.git/+log/344ec42f60fd..d85dd53e288e

$ git log 344ec42f6..d85dd53e2 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 brianosman Shrink the SkImageGenerator API
2016-12-14 stani Exclude complexclip4 GM tests from tile_rt config
2016-12-15 reed speedup dynamicwstream
2016-12-13 mtklein Port SkResourceCache to SkTHashTable
2016-12-15 reed remove unused dynamicwstream.snapshotAsData()
2016-12-15 kjlubick Update Pixel Cs -> NFM26H

BUG=429375

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2584513005
Cr-Commit-Position: refs/heads/master@{#438953}

This CL updates linux-sysroot-md to reflect the new steps required to
build and upload the sysroots after
https://crrev.com/4c8b67057de3ee3f6c4105a0dceebc0228d9832e.

R=dpranke@chromium.org,sbc@chromium.org

Review-Url: https://codereview.chromium.org/2579833004
Cr-Commit-Position: refs/heads/master@{#438952}

Also add a test.

BUG=673827

Review-Url: https://codereview.chromium.org/2577963004
Cr-Commit-Position: refs/heads/master@{#438951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/458e104e..2c88e4c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582633002
Cr-Commit-Position: refs/heads/master@{#438950}

animations/3d/transform-origin-vs-functions.html is failing on windows 7

BUG=674715
TBR=ajuma@chromium.org

Review-Url: https://codereview.chromium.org/2578283002
Cr-Commit-Position: refs/heads/master@{#438949}

Removed parameter that is always set to true.

Review-Url: https://codereview.chromium.org/2578093003
Cr-Commit-Position: refs/heads/master@{#438948}

BUG=674654
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2575323004
Cr-Commit-Position: refs/heads/master@{#438947}

Review-Url: https://codereview.chromium.org/2579833003
Cr-Commit-Position: refs/heads/master@{#438946}

This change adds plugin message in JingleMessage, which is an action indepenent
xml node, placed before or after other messages.

The plugin message will be used to send and receive host attributes and
experiment configuration.

This is part of host experiment framework.

BUG=650926

Review-Url: https://codereview.chromium.org/2567953002
Cr-Commit-Position: refs/heads/master@{#438945}

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Review-Url: https://codereview.chromium.org/2577903002
Cr-Commit-Position: refs/heads/master@{#438944}

This reverts https://codereview.chromium.org/2497373003, which caused
a significant crasher in canary builds (see crbug.com/674334).

TBR=edwardjung
BUG=635610, 674334

Review-Url: https://codereview.chromium.org/2579893002
Cr-Commit-Position: refs/heads/master@{#438943}

Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ )

Reason for revert:
Crashes.
BUG=674474

Original issue's description:
> [DevTools] Migrate ServiceWorker domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
> Cr-Commit-Position: refs/heads/master@{#438676}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2577233002
Cr-Commit-Position: refs/heads/master@{#438942}

http/tests/loading/preload-img-test.html is flaky on trusty

BUG=674720
TBR=alexclarke@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2576923004
Cr-Commit-Position: refs/heads/master@{#438941}

Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )

Reason for revert:
Speculative

Original issue's description:
> [DevTools] Migrate target domain to new generator.
>
> BUG=664683
> TBR=pfeldman
>
> Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> Cr-Commit-Position: refs/heads/master@{#438733}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2578303002
Cr-Commit-Position: refs/heads/master@{#438940}

BUG=654071

Review-Url: https://codereview.chromium.org/2571933002
Cr-Commit-Position: refs/heads/master@{#438939}

This CL moves filters and background filters from RenderPassDrawQuad to
RenderPass. Quads are stored in a ListContainer, which uses memcpy to
shift over elements when an element in the middle is deleted. Since
FilterOperations contain a vector, they're not safe to memcpy (and
this memcpy triggers crashes with http://crrev.com/2423483003).

BUG=664357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2543473004
Cr-Commit-Position: refs/heads/master@{#438938}

BUG=668341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2579433002
Cr-Commit-Position: refs/heads/master@{#438937}

This way you can run from the command line and it just works!

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2579863002
Cr-Commit-Position: refs/heads/master@{#438936}

This is a simple solution to avoid conflicting ILK filenames
generated by the linker, which apparently just strips the
output file extension.

BUG=673521
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2578183003
Cr-Commit-Position: refs/heads/master@{#438935}

BUG=653689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578813002
Cr-Commit-Position: refs/heads/master@{#438934}

https://skia-review.googlesource.com/c/6109/ (Add a deferred copy surface) rolled into Chrome at r438850 in https://codereview.chromium.org/2583513002 (Roll src/third_party/skia/ ebccb8268..625cd9e0c) so these layout tests can be rebaselined

BUG=674509

Review-Url: https://codereview.chromium.org/2585523002
Cr-Commit-Position: refs/heads/master@{#438933}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f87ce97ea1fa..98f5b96b79b3

$ git log f87ce97ea..98f5b96b7 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 fmeawad [TraceModel] Avoid duplicate cpuDuration for traces with an associated atrace and original thread times

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2585493002
Cr-Commit-Position: refs/heads/master@{#438932}

When the "Payment not secure" message is shown, the item below it should
be "Payment autofilling disabled" instead of the "Automatic credit card
filling is disabled..." message, and it should use the normal font
rather than the warning font.

This CL adds a new string and uses it for this warning
message when the form-not-secure experiment is enabled. See
https://bugs.chromium.org/p/chromium/issues/detail?id=672666#c2 for a
screenshot.

The new warning message is styled the same as the existing warning messge.
To match the form-not-secure mocks, for simplicity, I've removed the warning
font list and uses the normal font for the warning message, whether it is the
original or new wording.

BUG=672666

Review-Url: https://codereview.chromium.org/2576143002
Cr-Commit-Position: refs/heads/master@{#438931}

|needs_begin_frames| is a parameter that needs to be synchronized between the
browser and renderers. A logic mistake caused this parameter to be out of sync,
causing the browser to think that every extension required an infinite stream of
BeginFrame messages.

BUG=673021

Review-Url: https://codereview.chromium.org/2577953002
Cr-Commit-Position: refs/heads/master@{#438930}

The pref "history.deleting_enabled" was already present for supervised
users, so it was only a matter of wiring it to a new policy.

Written by pastarmovj@chromium.org http://crrev.com/2531623002
Improved by dbeam@chromium.org here.

BUG=401064
TEST=browser_tests,unit_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2581643002
Cr-Commit-Position: refs/heads/master@{#438929}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71aad116..458e104e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2577093003
Cr-Commit-Position: refs/heads/master@{#438928}

Remove enable_spdy31, use_alternative_services, npn_protos, and
protocol_negotiated parameters from spdy_view.html.  These parameters
are not generated for a long time now, they only stayed here for
compatibility with older netlogs.

This CL is a follow-up to the following CLs:
https://crrev.com/1268313004
https://crrev.com/1651123002
https://crrev.com/2151643003
https://crrev.com/2229693003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2579063002
Cr-Commit-Position: refs/heads/master@{#438927}

Made --use-test-scheduler as default; Ensure adb server is started before
copying files and showing config when running the harness. Also fixed a
bug where external dir wasn't used.

BUG=NONE

Review-Url: https://codereview.chromium.org/2576213002
Cr-Commit-Position: refs/heads/master@{#438926}

FIDO U2F defines initialization packets and continuation packets.
This adds class definitions for those packets, and for an
enclosing message class. The enclosing message class constructs
the initialization and continuation packets based on the payload
length, queueing them in a list format for consumption by a
device connection.

BUG=NONE

Review-Url: https://codereview.chromium.org/2502103002
Cr-Commit-Position: refs/heads/master@{#438925}

BUG=555865

Review-Url: https://codereview.chromium.org/2574583005
Cr-Commit-Position: refs/heads/master@{#438924}

We need to be able to do this in several places (soon including some
outside media/).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2565123002
Cr-Commit-Position: refs/heads/master@{#438923}

This CL observes WebContents visibility changes to record if a data use
entity (Chromium tab) is in foreground vs background. Further CLs will
record the histograms.

BUG=673820

Review-Url: https://codereview.chromium.org/2572823002
Cr-Commit-Position: refs/heads/master@{#438922}

The purpose of this CL is to add logging in an attempt to confirm
whether check_running_pid is called before a hang occurs when
shutting down wptserve.

BUG=669802

Review-Url: https://codereview.chromium.org/2569643002
Cr-Commit-Position: refs/heads/master@{#438921}

Rename OnOptInEnabled to OnArcOptInChanged (to make it
clearer that it's also called on opt-out), and add "Arc" to
other method names as well to make their meaning clearer
when implemented by non-ARC-specific classes.

BUG=633243

Review-Url: https://codereview.chromium.org/2577103002
Cr-Commit-Position: refs/heads/master@{#438920}

There are three types of media notifications and they each have a
different group. At the moment, only one of each can be shown.

BUG=674676
R=dfalcantara@chromium.org, zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2576393002
Cr-Commit-Position: refs/heads/master@{#438919}

Approved for m57 in crbug.com/666899.

BUG=603217

Review-Url: https://codereview.chromium.org/2418983004
Cr-Commit-Position: refs/heads/master@{#438918}

This CL adds an condition on "cronet_package" target to enforce that
Cronet is built with use_platform_icu_alternatives == true.

BUG=611621
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2573253002
Cr-Commit-Position: refs/heads/master@{#438917}

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2582523002
Cr-Commit-Position: refs/heads/master@{#438916}