GitLab

Speculation is that the signal isn't using our autoexpiring Signals().

BUG=106768
TEST=see bug


Review URL: http://codereview.chromium.org/8866005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113548 0039d316-1c4b-4281-b951-d872f2087c98

ANGLE commit message for 905:

'Guard against releasing NULL textures.

ANGLEBUG=265
TRAC #19196
Signed-off-by: Daniel Koch
Author: Nicolas Capens'

This should fix the referenced bug.

BUG=106748

Review URL: http://codereview.chromium.org/8862006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113547 0039d316-1c4b-4281-b951-d872f2087c98

This has no effect until the next clang roll. On linux, only 64bit is supported for now.

BUG=none
TEST=`clang -faddress-sanitizier test.c` works. Running the generated a.out reports memory errors if test.c contained any.
TBR=kcc

Review URL: http://codereview.chromium.org/8852008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113546 0039d316-1c4b-4281-b951-d872f2087c98

Rename the name to describe its role more precisely
Actual value ("settings.accessibility") is not changed

BUG=None
TEST=build success


Review URL: http://codereview.chromium.org/8800033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113545 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8865007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104000
TEST=see bug


Review URL: http://codereview.chromium.org/8873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113541 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8872006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8866007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79050


Review URL: http://codereview.chromium.org/8799022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106427


Review URL: http://codereview.chromium.org/8855007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113537 0039d316-1c4b-4281-b951-d872f2087c98

GtkThemeService injects themed images into SkBitmaps for theming. When I
started moving to the gfx::Image returning GetImageNamed() interface, I didn't
implement it at the GtkThemeService level.

BUG=106597,106060
TEST=No blue tabs in gtk-theme mode.


Review URL: http://codereview.chromium.org/8771052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113536 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8495038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113535 0039d316-1c4b-4281-b951-d872f2087c98

Using the "-profile-directory" switch didn't work if the browser was already running.

The problem was that we were ignoring the switch and just using the last used profile.

BUG=100461
TEST=Ran Chrome with the first profile open. Launched a 2nd instance with "-profile-directory" and verified that the correct profile window opened.


Review URL: http://codereview.chromium.org/8854001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113534 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r113422.  It looks like the test still times
out in some cases on Aura.

BUG=104384
TEST=none


Review URL: http://codereview.chromium.org/8874001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8872004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113532 0039d316-1c4b-4281-b951-d872f2087c98

And move the functionality into gfx::Screen.

BUG=101507
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8549008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113531 0039d316-1c4b-4281-b951-d872f2087c98

This is the first patch to get remove CHECK stmts from syncable layer.

BUG=100444
TEST=


Review URL: http://codereview.chromium.org/8804026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113530 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a reversion of the final patch set (#4) of this:
http://codereview.chromium.org/8395012

The reason is because tasks posted to the query thread can extend the lifetime of the D3D device such that it is destroyed on the query thread. The D3D thread must be destroyed on the thread it was created on though.

The suggestion was a good one and I might revisit it in the future.

I also added a missing lock and switched it to load the D3D9 DLL rather than assume it is already loaded by something else.
Review URL: http://codereview.chromium.org/8867005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113529 0039d316-1c4b-4281-b951-d872f2087c98

was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8869004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23898
TEST=go to chrome://os-credits and click on "show license"
Review URL: http://codereview.chromium.org/8869008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104645

Review URL: http://codereview.chromium.org/8826002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113526 0039d316-1c4b-4281-b951-d872f2087c98

Enable UndoRedo_CutCopyPasteTest

BUG=103988,97845
TEST=added new UndoRedo_BackspaceThenSetText, enabled CutCopyPasteTest


Review URL: http://codereview.chromium.org/8823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113525 0039d316-1c4b-4281-b951-d872f2087c98

Reducing the number of tests should speed up bots, and we are unlikely
to ever need to separately enable/disable these.
Review URL: http://codereview.chromium.org/8857003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113524 0039d316-1c4b-4281-b951-d872f2087c98

Call browser::CreateBubbleView instead of BubbleDelegateView::CreateBubble for ExtensionInstalledBubble and AvatarMenuBubbleView.

BUG=105023
TEST=No visible bubble changes.

Review URL: http://codereview.chromium.org/8833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106255
TEST=see bug for repro


Review URL: http://codereview.chromium.org/8823015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113522 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa
BUG=62897
Review URL: http://codereview.chromium.org/8862004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113521 0039d316-1c4b-4281-b951-d872f2087c98

We could convert these tests to use manifest_version 2, but it's not worth the
effort.  (After this patch, I believe all the tests will pass when we require
manifest_version 2 for unpacked extensions.)

BUG=62897
Review URL: http://codereview.chromium.org/8864002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113520 0039d316-1c4b-4281-b951-d872f2087c98

This test makes assumptions that the native code will run, which is at odds with how valgrind works.

BUG=None
TBR=siggi@chromium.org

Review URL: http://codereview.chromium.org/8882001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106796
TEST=none

Review URL: http://codereview.chromium.org/8866009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113516 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Bot redness. See http://build.chromium.org/p/chromium/builders/Mac10.6%20Tests%20%281%29/builds/15717

Original checkin notes:

This reverts commit bd45bd25.

TEST=ran webkit tests in DRT and webgl tests in chrome
BUG=103989

Review URL: http://codereview.chromium.org/8758026

TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/8865008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113512 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113470 - Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots.

BUG=104360
TEST=none

Review URL: http://codereview.chromium.org/8805033

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8873001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=plugin_tests makes a bit more noise in its logs.


Review URL: http://codereview.chromium.org/8341069

Review URL: http://codereview.chromium.org/8854008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106523
TEST=ui_unittests --gtest_filter=ClipboardTest.* and manual testing

Review URL: http://codereview.chromium.org/8801038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113502 0039d316-1c4b-4281-b951-d872f2087c98

This should turn some timeouts caused by a renderer crash into immediate failures.

BUG=106541
TEST=less timeouts


Review URL: http://codereview.chromium.org/8834012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113501 0039d316-1c4b-4281-b951-d872f2087c98

Since we're using the native spellchecker, this menu item is no longer needed.

BUG=None
TEST=Right click on a text field in web content, go to the "Spelling and Grammar" context menu. "Languages and Settings" should no longer appear as an option.


Review URL: http://codereview.chromium.org/8851010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113500 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113499 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that the crashes reported in M17 are because the SQLitePersistentCookieStore is closed while it was still loading.

This CL adds checks that should abort all tasks that access db_, if db_ is NULL.

R=rdsmith@chromium.org
BUG=106722
TEST=None


Review URL: http://codereview.chromium.org/8855009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots
TBR=bashi

Review URL: http://codereview.chromium.org/8854003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113497 0039d316-1c4b-4281-b951-d872f2087c98

trying to write to a socket.

Our old behavior caused network failures on servers that hang
up right after sending a file, but don't use
"connection: close".

BUG=105824

Review URL: http://codereview.chromium.org/8775044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113496 0039d316-1c4b-4281-b951-d872f2087c98