- 19 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6ed60e39dc5f..0a5ed896e2c4 git log 6ed60e39dc5f..0a5ed896e2c4 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 srte@webrtc.org Adds remote estimates to rtc event log. Created with: gclient setdep -r src/third_party/webrtc@0a5ed896e2c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Idd1030ed19a3d1b61a684926b1e8408c8ca37930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697987}
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::ResetPasswordHandler interface. Bug: 955171 Change-Id: I6c21b65dfc0ffd48d9f77909ab89e25e289d269a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807499 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697986}
-
Manuel Rego Casasnovas authored
This patch just mark as skipped the subgrid tests in TestExpectations because it's not implemented yet. BUG=1005519,618969 Change-Id: I89e0f6421a8e4157349797e4d2ae0079383fe96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813303Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#697985}
-
Friedrich Horschig authored
This CL introduces the PropertyModel that the controller code will modify and that the view code will render. Since there is no behavior added yet, no tests. Bug: 957532 Change-Id: Ic24442959201791a332f773bfb6a863ddd34a9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801755 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#697984}
-
Henrique Ferreiro authored
Convert the implementation and all users of the app_management::mojom::PageHandlerFactory, PageHandler and Page interfaces. Bug: 955171 Change-Id: Ieadae3496ff07e2a595cc07abd1a3e436f8a2a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806734 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#697983}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. Before this CL, ServiceWorkerContentSettingsProxy was kept as a member of WebEmbeddedWorkerImpl, and consumed when a new service worker thread starts. After this CL, the proxy is directly passed through WebEmbeddedWorkerImpl as a function argument. Keeping the proxy as a member was needed when asynchronous script fetch was done on the initiator thread. Now, script fetch is done on the worker thread, and operations on the initiator thread are synchronous. It's no longer necessary to keep it as a member. Bug: n/a Change-Id: Ibe7f53709291805f46e4489c47e7fa81fd60dd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813637 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697982}
-
Julie Jeongeun Kim authored
This CL converts NativeFileSystemTransferTokenRequest to new Mojo types. With this CL, NativeFileSystemManagerImpl forwards mojo::PendingReceiver<blink::mojom::NativeFileSystemTransferToken> to NativeFileSystemTransferTokenImpl and NativeFileSystemTransferTokenImpl owns mojo::Receiver<blink::mojom::NativeFileSystemTransferToken>. Bug: 955171, 978694 Change-Id: I8cba16dbae29478ca0909a05191412e7003d3f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777442 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697981}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I361c12d824917ce7c27b1fd484b276c71eb4efb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813517Reviewed-by:
-
Stepan Khapugin authored
Adds a SceneState observer protocol, and makes the SceneController be created by the SceneDelegate and listen to this protocol. Bug: none Change-Id: I10378f6034f13a4b47687fcbcec6a38d5c078666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789585 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697979}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc8396f2c0ee..c20a3c3641d3 git log fc8396f2c0ee..c20a3c3641d3 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 ahassani@chromium.org auto_updater: Use nebraska.py instead of devserver 2019-09-19 vapier@chromium.org Revert "De-parallelize UnitTestStage" Created with: gclient setdep -r src/third_party/chromite@c20a3c3641d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id943e305f5bc6b597499656854d2a2e646c29bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813060Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits that still use the old mojo types for mirroring::mojom::SessionObserver to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: I715380ce54a13b93b7da99202f42b3a02a3519e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807827 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697977}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/693bf1eea1e8..6ed60e39dc5f git log 693bf1eea1e8..6ed60e39dc5f --date=short --no-merges --format='%ad %ae %s' 2019-09-19 danilchap@webrtc.org Implement Dependency Descriptor writer 2019-09-19 terelius@webrtc.org Improve trendline estimator logging. Created with: gclient setdep -r src/third_party/webrtc@6ed60e39dc5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibd5940e7236786573bc6a510d210ad1ff8306eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813518Reviewed-by:
-
Friedrich Horschig authored
This CL adds the java-side of the bridge but doesn't use native calls yet. Bug: 957532 Change-Id: I0087ed5068d4cdafa07ffe1460f29e58604449c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803304 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL cleans up a minor weirdness in the code I've randomly run into. The CL introduces no behavioral differences. Bug: none Change-Id: I72c8306e948c20e2e5c67ac34a6465912cfa64c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812817 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697974}
-
Tim van der Lippe authored
This would prevent us from submitting CLs that would inadvertently break other code, even if we did not touch it. Bug: 1004860 Change-Id: I45f2fd8481b45c8d1bafc621965b9498d4dc80ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813320Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#697973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf4268a3963b..17eaec1dd6ff git log bf4268a3963b..17eaec1dd6ff --date=short --no-merges --format='%ad %ae %s' 2019-09-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 36c1c0e22fab..605c2e3c0ea7 (7 commits) Created with: gclient setdep -r src/third_party/angle@17eaec1dd6ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I0cbdd2c521eeec0caf127079c1794ba71ea9c187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813059Reviewed-by:
-
Omer Katz authored
ComputeContainerNode can return nullptr. Calling RootEditableElement with nullptr results in null dereference. Added a bail-out in case ComputeContainerNode returns nullptr. Bug: 1005108 Change-Id: Ida378b09ecb345ef8becd3b32d338ea906da5938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813319Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697971}
-
Carlos Caballero authored
Disable bfcache for SecurityHandler if cert errors are being handled as notifications might get lost while document is in the cache. Disable bfcache for ThreatDetails if a report is started as RenderFrameHostChanged will only be called on the main frame if the document goes into the cache so this component will wait for the children reports to complete while their frames are in the cache. Expose a public API to prevent documents from entering the bfcache. Main entry point for bfcache operations will be the BackForwardCache object. There is one instance of this class per WebContents. As the RenderFrameHost might be already gone when DisableForRenderFrameHost is called use GetGlobalFrameRoutingId instead of RFH* as parameter. Design for the new content public API https://docs.google.com/document/d/1brlmAs1mMumbGwgwdE_M_VGR81YbArzeViI0P-Uak14 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: I1cb218673b6dd982c2b23c1533010c765116e809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786449 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697970}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cf28d2b5. With Chromium commits locally applied on WPT: 13765318 "[WPT/common/security-features] Introduce iframe-blank source context" bda4c129 "Revert "Re-land: Fix `Referer` for descendant module scripts and worklets"" 55a477b6 "Implement word boundary matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I960b98ce3d25482b97e0919d2292b3000dcb1dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812917Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697969}
-
Miyoung Shin authored
This CL converts VibrationManager{Ptr, Request} in services and blink to the new Mojo type. Bug: 955171, 978694 Change-Id: Idaa3a0cdd1c3feec0868f14df93cd71f93fe9fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810448Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697968}
-
Thomas Tangl authored
The "Manage profiles" button is added as a profile shortcut feature button. Screenshot: https://drive.google.com/file/d/14OgB985dHUyEM18_peTN1dheH9fHnx7k/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: I5860c248945bc3e567f8d917320d86055c36fd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811219 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#697967}
-
Sergio Villar Senin authored
CalculateTimeToEffectChange() returns double which might take infinity as value. We could better replace the double by AnimationTimeDelta and use AnimationTimeDelta::Max() to represent infinities. Bug: 737867 Change-Id: I4b87d174f322f551196cc720715aa3c41e1a27e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809308Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#697966}
-
Olivier Robin authored
observer is CrashRestoreHelper which owns the InfoBarManagerObserverBridge. Bug: 1004699 Change-Id: Ie9fc241918ef45f8f91bde4dbf7091d816960afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807222 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697965}
-
Sylvain Defresne authored
There are two uses of ConnectionTypeObserverBridge by Objective-C classes (MetricsMediator and PreloadController) and both of them pass "self" as the observer. Since those classes also keep the ownership of the C++ bridge (via a std::unique_ptr<ConnectionTypeObserverBridge> ivar), this caused a retain cycle because "observer_" was strongly retained. Mark the observer as __weak in order to break the retain cycle. Bug: 1005152 Change-Id: Ief077e6ab97d7f6daa30951a3bed012308bb5369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813338 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Pauline Leitao authored
As GUIDs are immutable within BookmarkNodes, in the occasion one must be replaced we must completely remove the node containing it and create a new one with the same data except for a new GUID. This CL introduces this logic to change the GUID assigned to a certain bookmark while processing remote bookmark updates or merging bookmarks. In such a case, the GUID is replaced by the new value provided if it is valid, populated by the originator_client_item_id if it is missing (legacy client case) or ignored altogether otherwise, as it is understood that a valid GUID value is already stored locally and keeping that value is better than creating a new one arbitrarily. Bug: 978430 Change-Id: I8fcbd2a181dea7b09ac09cf3169b1e64d320d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783438 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
-
Pauline Leitao authored
This is a follow-up patch to CL 1724669 [1], which adds to the previously introduced UMA metrics keeping track of the reasons BookmarkSpecifics are being deemed invalid. This patch logs as well the case where an invalid GUID was found in the specifics. Bug: 988451 Change-Id: Ifd52a28d4646b6333c13de63827aa33294b880b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811254Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Cr-Commit-Position: refs/heads/master@{#697962}
-
Sylvain Defresne authored
IdentityTestEnvironment's method casts the PO2TS to a FakePO2TS but do not enforce this at compilation (in order to support IdentityTestEnvironmentProfileAdaptor). Add a DCHECK in IdentityTestEnvironment::Initialize() to check that the PO2TS is a FakeProfileOAuth2TokenService (required to add a new virtual method to determine this as Chromium builds without RTTI). Bug: 982751 Change-Id: I151a3e63f22b941d6be40151bba2e453e43be43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795602 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL adds the interface which will be implemented by bridge and coordinator. The build file currently doesn't add the public_java target to chrome_java since this would cause a cyclic dependency. The interface allows to request that the TouchToFill component shows a set of credentials and ensures that the delegate is notified when users dismiss the sheet without selecting anything. Bug: 957532,1004415 Change-Id: Icbba0471febb88dfb4f87d33a1ea4a53992767ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798707 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Ivana Zuzic authored
An interface called PasswordEditingDelegate has been created, so the PasswordEditingBridge can implement it in its production and in its test version. PasswordEditingDelegateProviders a singleton because it needs to provide a bridge to the password editing UI. The editing UI can't get the bridge any other way because it's an object and it can't be sent to the editing UI through arguments when the UI is started. Bug: 377410 Change-Id: Iaf46d3e02d089d7ad498257c7b14b6b801592e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809165 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd2426079126..693bf1eea1e8 git log bd2426079126..693bf1eea1e8 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 danilchap@webrtc.org Delete modules/rtp_rtcp local DivideRoundToNearest in favor on one in rtc_base Created with: gclient setdep -r src/third_party/webrtc@693bf1eea1e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib3f17b62190d9c0dba7fac8c73962d8ee79a981b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813178Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a77739404157..b1ba053d48b7 Created with: gclient setdep -r src-internal@b1ba053d48b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iad1d6d5c598a28d6fdda8157bf5a01319dc2a03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697957}
-
Mario Sanchez Prada authored
Convert the remaining bits that still use the old mojo types for mirroring::mojom::CastMessageChannel to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: I8ccd2d4a7c4e7954954200a2e7b09fd3f2c3ab6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807496 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Yuzu Saijo authored
This CL disables pending_lifecycle_state_ when bfcache is enabled so that the decision as to whether a frame gets frozen or not should not be overridden on the renderer side. The decision should be made on the browser side for bfcache. Currently as a temporary fix, we disable pending lifecycle state. This should be fixed though in the process of freezing re-architecure, since this behavior violates the spec. https://wicg.github.io/page-lifecycle/#update-document-frozenness-steps Bug: 1000324 Change-Id: I4cedb9122c7c6bc742aef81ad08c47b796d38385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797512Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cc117419eb52..fc8396f2c0ee git log cc117419eb52..fc8396f2c0ee --date=short --no-merges --format='%ad %ae %s' 2019-09-19 cjmcdonald@chromium.org De-parallelize UnitTestStage 2019-09-19 bgoodwin@google.com Add viking-poc2 board builder Created with: gclient setdep -r src/third_party/chromite@fc8396f2c0ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id1ef791fb041832787eb2c1b67f3b0c56b512233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812641Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/36c1c0e22fab..605c2e3c0ea7 git log 36c1c0e22fab..605c2e3c0ea7 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 dsinclair@google.com Add WebGPU SPIR-V Assembler in JavaScript. (#2876) 2019-09-18 dneto@google.com Android.mk: Add dependency from optimizer file to amd-shader-ballot-insts.inc (#2883) 2019-09-18 dneto@google.com Update SPIRV-Headers in DEPS (#2880) 2019-09-18 afdx@google.com Fix detection of blocks bypassed by new edge (#2874) 2019-09-18 afdx@google.com Fix CMake issue related to spirv-fuzz (#2877) 2019-09-18 afdx@google.com Add fuzzer pass to replace ids with synonyms (#2857) 2019-09-18 alanbaker@google.com Relaxed bitcast with pointers (#2878) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@605c2e3c0ea7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@chromium.org Bug: None Change-Id: I8e62659474e97f46f8ffb5cfe74a0eb941d8186f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812640Reviewed-by:
-
Christian Dullweber authored
Currently a <URL>,* exception can control whether cookies are deleted on exit. Exceptions that only specify a secondary pattern are ignored. While we don't know the top-frame-origin, it would still be useful to keep cookies from being deleted that match the url in *,<URL> pattern. Bug: 967668 Change-Id: I98ad6f1a2d77f53c39f7e04f160e40eec2e18b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807246 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#697952}
-
Marc Treib authored
TBR=rsorokin@chromium.org Bug: 992022 Change-Id: I7e2f543afc0b7fb1d757f6f702a91182a5379699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813317Reviewed-by:
-
Rune Lillesveen authored
Removed unrelated failing rebaselines in the original CL. Original description below: This makes us match how Firefox applies minimum font-size and makes us not break relative length computation when pages use a font-size less than the user's minimum font-size as a basis for widths, heights, margins, padding, etc. This is a behavioral change for relative lengths for the following cases: - minimum-font-size does not affect em lengths - minimum-logical-font-size does not affect em lengths - text autosizing does not affect em lengths - text scaling accessibility setting in Chrome for Android does not affect em lengths Test expectation changes and reasons: Text scaling no longer applies to relative lengths (text zoom set from testRunner): svg/zoom/text/zoom-hixie-mixed-008.xml svg/zoom/text/zoom-hixie-rendering-model-004.xhtml svg/zoom/text/zoom-svg-float-border-padding.xml Minimum logical font-size not applying to relative lengths (minimum logical font-size set to 9px when running layout tests): fast/backgrounds/background-position-parsing.html virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-0.5x.html http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm TBR=eae@chromium.org Bug: 308862 Change-Id: I8fb07c118eb2bf828ce5b391f7ed90254c0dbfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813077Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#697950}
-
Clemens Arbesser authored
This CL adds two new UMA histograms to autofill assistant. It also updates the expiry date for existing UMA histograms, since we still need them for some time longer. This CL also fixes a bug where an address would be considered complete even if it did not contain a billing postal code, which was required by the proto. Bug: b/140369065 Change-Id: Ie4348f441c865537e3321c6783b6bb901b5420d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806740 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697949}
-
Jérôme Lebel authored
Removing pre-unity code for SigninInteractionController since the unified consent feature flag is always on. Bug: 951313 Change-Id: I1e406a996baefb79a2a2a60942ff322657b65673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793182 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697948}
-
