- 07 Jan, 2020 40 commits
-
-
Matt Mueller authored
Bug: 973650 Change-Id: I10d86d2fa7a573f2f22abdb09878ceeca05a0411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985033Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#728744}
-
Tomasz Wiszkowski authored
This metric shows how frequently the native and java caches of Suggestions are out of sync when suggestion is selected. Lets take a second look at if there is anything we can do to reduce this further. Bug: 1036920 Change-Id: I42d8b359ee968808c907432246e8ab44aa2f35f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986334Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728743}
-
Theodore Dubois authored
Bug: 1026733 Change-Id: I464c643052a1c49ab90ad4a80e1b95c38542d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927037Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728742}
-
Kevin Babbitt authored
ExpandToEnclosingUnit for format units will call CreatePreviousFormatStartPosition on the starting position. That method will begin its search from the start of the node to which the position is currently anchored. But if that position happens to be at MaxTextOffset for its anchor, that should be treated as equivalent to offset 0 for the next text anchor. The result is that we would incorrectly expand the range backward if the node happened to be at a format boundary. The fix is to normalize the start position before doing any expansion. I also ensured that the unit test for ExpandToEnclosingUnit covers each of the cases enumerated in MSDN. Bug: 928948 Change-Id: I0eda71990b69800d5464560e1a08b8f5c387b907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970587 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728741}
-
Kurt Horimoto authored
This CL updates BadgeMediator to be constructed with a Browser in preparation for a follow-up CL where the mediator will observe the OverlayPresenter for the Browser in order to update the InfobarBadgeTabHelper for banner presentations and dismissals. This CL also cleans up and updates the mediator: - Adds readwrite property for the active WebState, allowing easy access to the WebState as well as facilitating idempotent updates via |-updateForNewWebState:oldWebState:|. - Adds a readonly property for the active WebState's InfobarBadgeTabHelper. - Since a Browser's BrowserState is constant over the Browser's lifetime, we don't need to check whether the newly-activated WebState is incognito. Instead, the incognito badge item is just created once upon initialization. - Updates order of protocol implementations to match declaration order. - Updates test fixture to use params so that both the incognito and normal browsing behavior can be tested. Bug: 1030357 Change-Id: If7a5b4761ea4fd8e558120d1cfc14eb806c75290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986860 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#728740}
-
danakj authored
Also gets some of chromecast/media/. Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. R=servolk@chromium.org Tbr: dcheng@chromium.org Bug: 1007648, 1007647 Change-Id: I5a5a7c6f00fb1462a0004620f01b6d60a81c1abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967930Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#728739}
-
Leon Han authored
Adds "const" modifier to all members of blink::NDEFRecord. Making members "const" can express clearly that these information are not expected to be changed over time, once they're set by Ctors they are just fixed. BUG=520391 Change-Id: I6358415be91b2d9f36dfe66778677a8b0d9233b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981259Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728738}
-
Hirokazu Honda authored
V4L2VEA prepends the latest SPS and PPS with IDR frame. V4L2VEA does so whenever there is an IDR frame. A single bitstream buffer returned by BitstreamBufferReady() may have two SPS and PPS, if one buffer returned by an encoder driver contains SPS, PPS and IDR frame. Bug: b:143672449 Test: android.hardware.camera2.cts.RecordingTest#testBasicRecording Change-Id: I559570df31de4684522f1b4b1db9a3277221f68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986690 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728737}
-
Hayato Ito authored
This CL is the part in a series of CLs, roughly described as follows: 1. Refactor SeriviceWorkerTimeoutTimer Unify normal events and pending tasks. 2. Rename SeriviceWorkerTimeoutTimer to ServiceWorkerEventQueue. 3. Further clean up ServiceWorkerEventQueue. 4. Support offline events in ServiceWorkerEventQueue 5. Support offline mode in ServiceWorkerGlobalScope (<= This CL.) - Mimic an internet disconnected environment in ServiceWorkerFetchContext. - Support dispatching offline-capability-check events in ServiceWorkerFetchDispatcher. 6. Provide a high layer API to check SW's offline capability on the top of ServiceWorkerFetchDispatcher (https://crrev.com/c/1900804/). The basic ideas are: - SW now has an offline-mode. If an offline mode is enabled, a fetch always fails, returning INTERNET_DISCONNECTED error, to mimic an offline environment. - A high layer API dispatches a *fake* fetch event, offline-capability-check fetch event, which is used to detect the offline capability of a SW. - SW becomes offline-mode while dispatching an offline-capability-check fetch event. - If a fetch event handler returns a 200 for an offline-capability-check fetch event, SW is considered as having an offline capability. The previous CLs implemented the basic functionality for *throttling* offline events and non-offline events so that they don't run at the same time in ServiceWorkerEventQueue. This CL implements other necessary parts such as: - Mimics an internet disconnected environment; offline-mode - Enter (or Exit) offline mode at the right timing - Support offline-capability-check fetch event dispatch in ServiceWorkerFetchDispatcher After this CL, we are adding a high layer API on the top of ServiceWorkerFetchDispatcher at http://crrev.com/c/1900804/. Note that NavigationPreloads are not handled yet in this CL. See crbug.com/1031950. Bug: 965802 Change-Id: Id47191ae30a9051683678159b581f2863c27702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900803Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728736}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba37867fd234..35435063fca1 git log ba37867fd234..35435063fca1 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 jbudorick@chromium.org devil: stop checking for /root in devices using system-as-root partitions. Created with: gclient setdep -r src/third_party/catapult@35435063fca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:922145 Tbr: nuskos@google.com Change-Id: I82093c918cd1d7e7c97ba952e326ea8489618a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728735}
-
Natalie Chouinard authored
Extract the Android resource-specific dependencies to a separate build target. Eventually, this target will include its own module's resource files too. Bug: 1035928 Change-Id: Ib63ff15ae817bfb782f49350881a706b3e161515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988851Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728734}
-
Kevin McNee authored
The tests which use an extra pinch gesture to test that a previous gesture did not cause a scale change could themselves not cause a scale change, which caused the tests to flake. This was likely due to not properly waiting for the gesture to finish. We now have these tests use the synthetic gesture mechanism to send events rather than directly creating and sending events, as the former is more robust about handling gesture completion. Also, it looks like a method for synchronizing threads was renamed to |WaitForJavascriptExecution|. This name is misleading, so we give it a more descriptive one and comment its use. We also add back a comment for a test which was deleted when the test was disabled. Bug: 1033907, 1021541 Change-Id: If05936b4a2077c6b0486afa3922545ddc898585d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983267Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#728733}
-
Mike Dougherty authored
Application wide breadcrumbs do not have an associated BrowserState, so the BreadcrumbManager logic needs to be standalone. This CL moves the storage of breadcrumb events out of BreadcrumbManagerKeyedService and into its own standalone BreadcrumbManager class. BreadcrumbManagerKeyedService has been updated to utilize this new class. There is no functional change in this CL. Bug: None Change-Id: Ib7aa33fa2a123156831302630e58dbd4d965ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984465 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Wenyu Fu authored
1. Using toString methods when comparing CharSequences in test, to avoid issues for android.text.SpannableStringBuilder#equals; 2. Merge testInflateFromXml with testCombinedRadioButtons and add more attribution checks Along with some misc fixes Change-Id: I2ebd08c88d29f9fa15066b0478c6c6184979a59d Bug: 1039039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988911 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#728731}
-
Esmael El-Moslimany authored
Bug: 1032302 Change-Id: If819434b4cbc2deef1113e50a5632e00e14d6236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969745 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728730}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1577704324-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307857-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If8de18d112da424a0f996c894050a879fd17ba67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989147Reviewed-by:
-
Wez authored
Verify that RunUntil*() calls are not returning prematurely, when the required conditions have not actually been met, e.g. due to Run() timeout. Bug: 1032620 Change-Id: Ia2d2b2028c494705bd4e9502f1d9c19257c58f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985605Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#728728}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.18-1577705382-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307131-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7b944506d5c9933c83a45504aad2898e7a8eee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987811Reviewed-by:
-
Philip Rogers authored
Several typos were landed in https://crrev.com/728635: * hisotgrams -> histograms * AddBackMisplacedHisotgrams -> AddBackMisplacedHistograms * hsitogram_suffixes -> histogram_suffixes There was also a recursive call to "FixMisplacedHisotgrams" that was renamed in a previous patchset to AddBackMisplacedHistograms. This has been updated to "AddBackMisplacedHistograms". The test has been updated with a comment node inside "<histogram-configuration>" to exercise this codepath. This has been manually tested by ensuring https://chromium-review.googlesource.com/c/chromium/src/+/1988857 can successfully run "git cl format". Bug: 1039447 Change-Id: I95097c0d4acd23301a7fad0d9d33521be405aa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988375Reviewed-by:
-
dalyk authored
If the host resolution process fails, the top level error code should now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be found in ResolveErrorInfo. Bug: 1016325 Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#728725}
-
James Forshaw authored
This CL updates the expiry date for sandbox launch warning histograms. Bug: 1037210 Change-Id: I552ccd2380b2a6c42aef23dead36da12bba88f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985811Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This disables 2 tests in PushMessagingTest across all OS levels, as we've observed flakiness on several testers. TBR=mvanouwerkerk@chromium.org Bug: 707528 Test: None Change-Id: I5fc8e4bea44f132771b65b5eda3e843adf708137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980267Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728723}
-
Alexandre Courbot authored
Do not specify the full path of Fourcc members when we are accessing them from Fourcc itself. BUG=None TEST=Chromium builds for arm-generic. Change-Id: I9ecd045f3c7835966e3a9b29c739e115a6c70d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986536 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728722}
-
Sammie Quon authored
Currently ends overview when changing shelf alignment since display area doesn't get updated on shelf alignment changes. The overview is ended when locking because self alignment changes from shelf bottom locked to shelf bottom. Detect this case and do not end overview. Change OnShelfAlignmentChanged to pass old alignment otherwise we would have to store and track the alignment in OverviewSession. Test: added test Bug: 1038705 Change-Id: I0a47967cb5685a9b5f4724340f800faf3337469f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988591 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728721}
-
Yuzu Saijo authored
base::Bind and base::Callback are deprecated in favor of either base::BindOnce/Repeating and base::Once/RepeatingCallback, depending on whether callback is invoked once or multiple times. Bug: 1007732 Change-Id: I6072508b5c2d7d7f0f157da3998c9f8f79183cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933863Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#728720}
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This includes advancing mock time now that the history backend tasks happen within the mocked time environment. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: Id3cd0dbf77bc18bd5a407174af3b7d9b743a5db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979153 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#728719}
-
Etienne Pierre-Doray authored
This reverts commit de5ec163. Reason for revert: Perftest regressions (see bugs). This should confirm this change is the culprit. Original change's description: > [base] Migrate the Mac/iOS MessagePump to DoSomeWork > > Recycling https://chromium-review.googlesource.com/c/chromium/src/+/1470938/13 > This CL also fixes DetachToBrowserTabDragControllerTest.PressEscapeWhileDetached > to make CQ happy. > > Bug: 885371 > Change-Id: I0b54ade1fd3481a9248c89ec2993738b20fce002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906337 > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722094} TBR=gab@chromium.org,rsesek@chromium.org,kylixrd@chromium.org,mark@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885371, 1032204, 1032188, 1032135 Change-Id: Ide06e03130a1fb420719bb1969e6aa901f8fb716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988985Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#728718}
-
Mitsuru Oshima authored
This allows drag-scrolling at px boundary. Bug: 1038998 Test: manually tested on device Change-Id: I6b5d87191bcc97ab5cf770c55fc48c36401b45fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987753Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728717}
-
nancy authored
This CL is pure refactor, to move ArcAppWindowInfo out of AppServiceAppWindowArcTracker to a separate file. BUG=1011235 Change-Id: I967c43b8a53d7ba57a78c0ca3ab4c8e47803091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986567Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6dbd7ff34a49..6ea680581fa6 git log 6dbd7ff34a49..6ea680581fa6 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 benjaminwagner@google.com Remove Win2016 jobs. 2020-01-06 bsalomon@google.com Remove SkIRect::EmptyIRect 2020-01-06 herb@google.com Move the exit code to a common switch 2020-01-06 brianosman@google.com Add a few more SkRuntimeEffect unit tests 2020-01-06 bsalomon@google.com Revert "Revert "Clean up GrSimpleTextureEffect."" Created with: gclient setdep -r src/third_party/skia@6ea680581fa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I5f1d2e11b9168b33c53ea2c1d89bb55c594973e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988694Reviewed-by:
-
Caleb Raitto authored
Example usage: $ autoninja -C out/Default generate_high_entropy_list $ cat out/Default/gen/third_party/blink/renderer/bindings/high_entropy_list.txt Example output: Keyboard.getLayoutMap VisualViewport.offsetLeft VisualViewport.offsetTop VisualViewport.pageLeft VisualViewport.pageTop VisualViewport.width ... Bug: 915620 Change-Id: I88543f614ea3082b0ff187846a338d6a45d63254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974895Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#728714}
-
Martin Kreichgauer authored
Add high-level methods for interacting with Touch ID authenticator credentials to the existing TouchIdCredentialStore class, and replace code in TouchIdAuthenticator and {GetAssertion,MakeCredential}Operation that currently interacts with the macOS keychain API directly. Also make TouchIdAuthenticator and the Operation classes hold a TouchIdCredentialStore member, rather than the AuthenticatorConfig that they previously required to perform operations on the Keychain API directly. The FindCredentialsInKeychain() and FindResidentCredentialsInKeychain() non-member methods in keychain.h are made obsolete by the new TouchIdCredentialStore member methods and deleted. This is mostly a refactoring, with a few minor functional changes: - When looking for credentials from |exclude_list|, MakeCredentialOperation now ignores credential descriptors with a transports() set that explicitly excludes platform authenticators (even if the descriptor's ID matches a known credential). This is equivalent to how allow_list is handled in GetAssertionOperation. - The new CredentialStore methods explicitly signal unexpected macOS Keychain API errors in the return value, whereas with Find{Resident,}CredentialsInKeychain() was indistinguishable from the case where no matching credentials were found. Hence, when encountering an error while querying an exclude list e.g. a MakeCredential operation would have previously been allowed to proceed, but now the authenticator will return a CTAP error to the request handler instead. Change-Id: Ib3a0a881d06fe0e20822281cbb0e3dac66b9399f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984468 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#728713}
-
Daniel Nicoara authored
Reason: Breaks Webview sizing. This reverts commit 35ac419d. Bug: b/147002958 Test: Manually Change-Id: Iee3eebcd2991036a0592ebf5b91ef7b18a11b0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987292Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#728712}
-
Xing Liu authored
This CL renames the feature name to be UseChimeAndroidSdk to be more specific to android, to avoid conflict with other platforms. TBR=dtrainor@chromium.org Bug: NONE Change-Id: I2b99573384b9bfb9986a15e5d12b6fe172622ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978855Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728711}
-
Lachlan Ford authored
Fixes: 1037975 Change-Id: I11fa5fd35989d468bbd364a549e1ee747aa9b95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982668Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728710}
-
Min Qin authored
For download service, it could issue multiple DownloadUrl() calls to the download system that have the same GUID at the same time. This CL fixes the issue by checking the GUIDs that are already pending or are already persisted in the DB, so that the same GUIDs cannot be used to create a new download. BUG=1029746 Change-Id: Ifc17167454b6eee4132fffa08b7d2666571cce35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980758 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Avery Musbach authored
Consistent with UpdateDropTargetBackgroundVisibility, RearrangeDuringDrag shall have a dragged item parameter rather than a dragged window parameter. OverviewWindowDragController has the item which is what RearrangeDuringDrag really needs in the first place, meaning it is unnecessary that OverviewWindowDragController gets the window from the item and then RearrangeDuringDrag gets back the item from the window. Also, when RearrangeDuringDrag calls SetBoundsAndUpdatePositions, for dragging from the top or from the shelf, ignored_items shall be {} instead of the confusing {nullptr}. Bug: None Change-Id: Ia724128f6dcaf0adc71fa69f4501309e3994c398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987827Reviewed-by:Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728708}
-
Pavel Yatsuk authored
- A few SearchEngineStatusIcon related values are passed through and shouldn't be retained - mVoiceRecognitionHandler made private and checks for null are removed as it is created in ctor. - LocationBarTablet uses cached mVoiceSearchEnabled instead of calling mVoiceRecognitionHandler - mUrlFocusChangeInProgress made private - SearchActivityLocationBarLayout explicitly sets the property to display mic button even when location bar is not focused instead of manipulating visibility through focus change percent R=pnoland@chromium.org BUG=1035210 Change-Id: I38435e0d7b5363e7ae05cb58f257af800a6ca0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972785 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728707}
-
Dave Tapuska authored
There is a downcast in resizing the segmented buffer into a single buffer. If it exceeds wtf_size_t it shouldn't be truncated but crash. BUG=1034491 Change-Id: I877b314277fb2b219ff59b11ea043da743948139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988512Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728706}
-
Carlos IL authored
MixedContentSiteSetting will launch to stable, this CL enables the feature by default and removes it from the fieldtrials_testing_config. Bug: 987294 Change-Id: I7967b5be2cb3abab712693f0d95881b36aa35784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967885 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728705}
-
