- 26 May, 2020 40 commits
-
-
David Grogan authored
Mozilla changed the test in their repo and it got pulled down as part of a wpt sync. Bug: 762679 Change-Id: Ief73dc47bf3f8f0bfe47de30d1be34f497018325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216280Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771936}
-
David Lechner authored
This implements the Web Bluetooth BluetoothRemoteGATTCharacteristic writeValueWithResponse() and writeValueWithoutResponse() methods. https://webbluetoothcg.github.io/web-bluetooth/#writecharacteristicvalue The writeValue() method is now deprecated and should continue to work exactly as it did before. New web_tests are just a copy of existing tests for writeValue(). New non-generated tests have been converted to async/await. The tests for writeValueWithoutResponse() have calls to setNextWriteResponse() removed since they do not receive a response. The getLastWrittenValue() method is modified to also return the write type of the last written value. This is used to confirm that the correct write type is requested. Bug: 672648 Change-Id: I0d8032fded0028eaa78a55afe3336f253c85c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159770Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771935}
-
Sophie Chang authored
The Optimization Guide server relies on the UpdateVersion histogram to ensure experimental models works e2e. The function ChromeDriver calls to get histogram data is not implemented for sparse histograms, so the values are all wrong there. Change-Id: I4118b2d056d1b3c3b34f91ba84884c3ae9cc5fc1 Bug: 990131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216319Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771934}
-
Mike Reed authored
Change-Id: I222183bcc3c958d633c9177bdb2f3e0d88d74a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213332 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#771933}
-
Toni Barzic authored
And extend the ones that expired. BUG=1063893,1059830 Change-Id: Id373ef4c1c74d8ddd19143128286f1c058b5e4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202140Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#771932}
-
Balazs Engedy authored
Extend ContextualNotificationPermissionUiSelector to show the quiet notification permission UI on sites with abusive permission request UX. Bug: 1081233, 1086512 Change-Id: I2120c4589f44b4d06a4f53dd4fb0ffd894fd1ad2 TBR: andypaicu@chromium.org, bcwhite@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215331Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771931}
-
Christian Biesinger authored
R=schenney@chromium.org Bug: 1086591 Change-Id: I5062fa76ed3522112eb8e6433ad29587c0c0d48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216278 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Nate Chapin authored
Currently, Documents that are never attached (created by DOMParser, XHR.responseDocument, etc.) have a context_document_, which is the attached Document that created them. If a Document is attached, it is its own context Document. The main use of context_document_ is to get at state that is shared across all Documents in a window. However, we can't have non-attached Documents hold a LocalDOMWindow, because there's already a dom_window_ member of Document for the attached window only. Therefore, hold an ExecutionContext, which is initialized for *all* Documents, in place of context_document_. For attached Documents, dom_window_ will always equal execution_context_. Bug: 1080735 Change-Id: I02d7280f6ceebdb18412dfc14165e4f611d38181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118850 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771929}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fac9f9e293cd..af27e58ea40a 2020-05-26 lalitm@google.com Merge "ui: fix annotations track query when counter table is empty" 2020-05-26 primiano@google.com site: improve layout of home page on mobile devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2f7d869ab10c13c0cf0b547020e97781781a5ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771928}
-
Peng Huang authored
For vulkan 1.1.0, VmaAllocator will use dedicated memory allocation for some big vulkan memory request, and free it when the allocation is released. Without this change, the VmaAllocator will allocate memory from self managed memory blocks for all vulkan memory request. And the memory may not be released when the allocation is released. VmaAllocator may keep the memory for later usage. It could be the reason for the memory regression in fuchsia. Bug: fuchsia:52463 Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771927}
-
Swapnil authored
The browsertests of HSTS policy are moved from policy_browsertests to a separate file. Bug: 1086438 Change-Id: If47a9def6da964428113b6ec7192d84df8f5f577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214954 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771926}
-
Varun Khaneja authored
This feature is now fully enabled via Finch. R=xinghuilu Bug: 963165 Change-Id: Ice9c1bcc95736b3cd8dffd57f8b92ba164c592d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216315 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771925}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e7c4b66..2b302be3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9de39a57b489d47d51acf5bf654b0d40b563dbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771924}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I08ba7c5f34d57a92e24480934cb6d2fc731fd6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213110Reviewed-by:
-
Nathan Zabriskie authored
With the new RasterInterface::WritePixels API we can now upload pixels directly to textures through RasterInterface without creating paint ops for mailbox backed shared images. This CL modifies existing code to prepare to use the new API. A follow up CL will actually hook up the new API for CanvasResourceProviderSharedImage. Bug: 1063725 Change-Id: Id5cd411e94d1fd8721d5491673f6120bcd6ed33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210738 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771922}
-
Ben Kelly authored
This CL fixes a small interop issue where chromium would always recompute the mime type for a response after reading it from cache_storage. This was incorrect because the mime type should be fixed at original response construction time even if its headers are later mutated. This CL also causes service workers to use the mime type originally computed for the Response instead of re-extracting the value from the content-type header. Bug: 938939 Change-Id: I941c1b1e3863e41da49128ce814ac0f1762dae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211949 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771921}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2ba55b7bb1507d01ac0ab7e6f9492c7bef8da820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216462Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 to 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7294724f84d1442dd72e2e9d1010c80bb243e35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216463Reviewed-by:
-
dpapad authored
compress="gzip" is (as of r761031) the default behavior for HTML/CSS/JS/SVG files, and therefore there is no need to explicitly specify it. Bug: 1068407 Change-Id: Id9dfb8ea5102991879b6799b061577aff958b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212885Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771918}
-
Mike Frysinger authored
This makes the externs util code easier to use by other presubmit tests by reducing a lot of boilerplate. This also enforces a rule that was being used in practice: the input & output names have to match (other than file extension). So instead of letting the code map "downloads.idl" to the externs "whatever.js" name, the output must now always be "downloads.js". If we ignore the Chromecast & app_shell forks of the Chromium project, this rule holds. Those forks cause problems by providing extensions to a few APIs and thus use duplicate source names. imo, those forks should be providing their own separate externs tree if they want to provide externs (which they don't currently), although I suspect the users are so few that no one will bother. Bug: 469920 Change-Id: Icb9d2ba4ad78c3c607a09402c82841fb745b4b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215901 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771917}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I018c0b1cdefb7336f67d13433b52a02c879e48ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216043Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771916}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 to 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9028e19a25dea52163a3c017601e07062546817b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216464Reviewed-by:
-
Tao Bai authored
Bug: 949555 Change-Id: I515e93c8394b00d135d36e4b02487b0cbf8315c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212673Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#771914}
-
Dmitry Gozman authored
This method is not used for a long time. Bug: none Change-Id: Idfdf78a4d2a63ba5470ecd1ff6893a34419225ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215379Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771913}
-
Ian Kilpatrick authored
Previously we cached at the preferred sizes level, this meant that whenever we called LayoutReplaced::PreferredLogicalWidths the (previous) PreferredLogicalWidthsDirty bit got cleared. However we now cache at the IntrinsicLogicalWidths level. The difference is that LayoutReplaced elements don't clear their IntrinsicLgoicalWidthsDirty bit. This meant that the innocent looking: if (!IntrinsicLogicalWidthsDirty()) SetIntrinsicLogicalWidthsDirty(); Was incorrect, as we were never invalidating the container chain. This caused the observed incorrect rendering in the bug. This patch changes this function to always invalidate the container chain for intrinsic sizes, and layout invalidations. Bug: 1086299 Change-Id: I8145a6276d4ec89c0c7acf91c1bf67714c127440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216373 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#771912}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. OffTheRecord profile API use in web_app_utils_unittest.cc are updated and new test cases for non-primary OTRs are added. Bug: 1060940 Change-Id: I4ae83207a1b971efa7aba5bf5e3bf351f2b107de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212121 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#771911}
-
Joe Mason authored
They can be un-pinned by dropping them outside their designated area. R=siggi Change-Id: I719d6be9509666f4387a4bba91946c3861b771eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214913Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771910}
-
Megan Jablonski authored
Bug: 1054643 Change-Id: Ib985d75905b0b496a1f784b6ff8490c2a5b5f848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204963Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#771909}
-
Vincent Boisselle authored
The bug contains more information on why we need to reduce the timeout. Basically, the IPH can go over UI elements sometimes in which case a user may want the IPH to dimiss quickly which doesn't dismiss on touch. Bug: 1086621 Change-Id: I5771bae257f444d627528f6d7094ffd9427ad52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216318Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#771908}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe6a353ce47a..adef79808a7d 2020-05-26 terelius@webrtc.org Enable triage alerts in rtc_event_log_visualizer by default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I43216620cf28d0270bc776249ee309d305f9c01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216455Reviewed-by:
-
Kevin Babbitt authored
This CL pushes stream-based parsing one level deeper in the stack for at-rules. The most notable difference is that at-rule handler functions are now responsible for tokenizing their own preludes and starting block handling if needed. Actual parsing for at-rule preludes is unchanged as of yet; the handler functions generate token ranges on their own and parse them as before. In future CLs we'll be able to convert each at-rule handler to make full use of stream parsing. Bug: 661854 Change-Id: Ia3345be73ab8cc9fce2537443e8a3ed9df017b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208812Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771906}
-
Elly Fong-Jones authored
This change moves most of the logic from BubbleDialogDelegateView into a new class, BubbleDialogDelegate. BubbleDialogDelegate implements the anchoring logic for bubbles, as well as some ancillary functionality around widget activity, anchor view highlighting, and so on. BubbleDialogDelegateView is now mostly a stub class that subclasses both BubbleDialogDelegate and View, and overrides some behavior of View. BDDV = BubbleDialogDelegateView BDD = BubbleDialogDelegate (doesn't yet exist) DDV = DialogDelegateView DD = DialogDelegate WD = WidgetDelegate V = View This CL is the second step in this process: 1. BDDV inherits from DD & V (landed in r770128) 2. Break BDDV into BDD (which inherits from DD) and BDDV (which inherits from both), like the current DD/DDV split 3. For each client class that subclasses BDDV, move that class to subclassing View and containing a BDD member, which is used when a BDD, DD, or WD is needed. 4. Delete BDDV itself 5. Repeat (3) for DDV instead of BDDV 6. Delete DDV itself 7. Remove any remaining subclasses of BDD or DD Change-Id: Ie300eebdeab59709e2bb437ed8c26ee29d0c2835 Bug: 1075649, 1011446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209374 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Roman Sorokin authored
follow-up of CL:2167271 Bug: 1084940 Change-Id: I00503059c781accacd1b1f6de905ca72f1365854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216216Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771904}
-
Charlie Hu authored
base/containers/flat_set.h included in feature_policy.h also caused flat_set being exposed and used in memory_managed_paint_canvas.h. Replace the usage with WTF::HashSet as base/.. is a illegal path to include in files under third_party. Change-Id: If4bc800ea30b3fda4d6ab2554a21c8c6ebf14a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211908 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#771903}
-
ssid authored
The agent was only created in renderer processes earlier. Change-Id: I7238a73d2c8d9b0ba1c5b52d9acfd4161c5cac91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208081Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#771902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61fc1e664eac..1f6c971abea1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com Change-Id: I79eedb583cb59790eb3dbfbb6f035d1a0767b7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771901}
-
Dan Harrington authored
FeedStreamApi changes - Added CreateEphemeralChangeFromPackedData, which moves responsiblity for deserializaing into the component. This required adding a proto file, since we don't already have a message that contains exactly what we need. - Added ProcessThereAndBackAgain and hooked it up to our uploading logic FeedStreamSurface changes - Implement LoadMore(), CommitEphemeralChange(), DiscardEphemeralChange() - Changed ExecuteEphemeralChange() to take a new serialized proto message Bug: 1044139 Change-Id: I5d3cf0f6dc87ec984593d3641baedd97535bccb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210907Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#771900}
-
bttk authored
Bug: 865801 Change-Id: I8025699a43df94a67991799983f03f0f242d7d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212996Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771899}
-
Yue Zhang authored
Currently, TabGridDialog component uses PopupWindow as a container which has shown some disadvantages as feature evolves (https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing) This CL removes the PopupWindow usage in TabGridDialog. Things happened in this CL: * Instead of using PopupWindow as a container, we insert the inflated view into the root view hierarchy and make all TabGridDialog instances share this same view. * Use the ScrimView in RootUiCoordinator instead of creating a new one. This gives us a bonus that the scrim now covers the status bar. * Tweaks in TabGridDialogMediator to make sure the component behaves the same before/after. * Fix tests to adapt to change that TabGridDialog is not in a separate window. Bug: 1069803, 1064140, 997239 Change-Id: I1da2db2bf7ef5b8f304782c4bcc95e951b23623b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119188 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771898}
-
Anders Hartvoll Ruud authored
The RuleSet of an ActiveStyleSheet can be nullptr for non-matching media (see StyleEngine::RuleSetForSheet), hence we can't DCHECK that it exists. Bug: 1085994 Change-Id: Iac7f746045f46ad7752b30cccce8b6f403cf19b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214537Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#771897}
-
