- 09 Aug, 2020 30 commits
-
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: I5e95537b9d194c83bbb483dc38a19358437c8a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339993 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#796274}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecdc9f6fa97..23d59f2f20fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I015890d5e8fc378ac7f4a0cab92a4890066df612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796273}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf785abd1ae4e64840d6dd9bede6eaf6dd221727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796272}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf362adbfd65..4ecdc9f6fa97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I8f79020ce1d16accdd855879f92d049d807bbf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345284Reviewed-by:
-
Clemens Arbesser authored
This reverts commit 42ccdaf3. Reason for revert: This CL breaks onboarding (crash after onboarding is accepted) Original change's description: > [Autofill Assistant] Remove intent validation for password scripts > > As password scripts have a confirmation step, we don't need to validate > an intent to change a password. > We still need to check whether a running script is a password script (if > yes, the password manager should be notified that a script is running). > For that, we will check whether |TriggerContext| has > PASSWORD_CHANGE_USERNAME param. (For convenience, this CL moves that > parameter's name and also kOverlayColorsParameterName to > trigger_context.cc). > > This CL also changes what origin is used for password store request. If > a password script is started from Settings, GetLastCommittedURL is not > set yet. So, we have to use the deep url provided. > > Bug: 1086109 > Change-Id: I7c38388b06f433dc51bce1a2b54a7d48bb322bfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332594 > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Milica Selakovic <selakovic@google.com> > Cr-Commit-Position: refs/heads/master@{#795844} TBR=kolos@chromium.org,arbesser@google.com,selakovic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1086109 Change-Id: Ifdeb001ae708abcbe22635299141a61923b7e852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345304Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#796270}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596951804-2e38ee79c378ef6490301a31a86a3e3f9ffa7699.profdata to chrome-mac-master-1596969922-273270c5768fa245d6eb486d3911a64a186d6010.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I408c82dc356f65b6ce8807e06a325fbfcbffba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345130Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7bbeb4dbdd7..cf362adbfd65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I17d4b51f8d4a7dea7a5bef6530514a12c6eb021b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345127Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb8faf172ef3..bcddb0efbf60 2020-08-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If37d1847c12068b57362029a2d3371cc3d61b2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345128Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae5d21e08bc1..b7bbeb4dbdd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9e6b20957d25b74c16ee55d3e1db1df3e9f5f506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345125Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/839b4bc4c1d6..eb8faf172ef3 2020-08-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic08a0e5e1b8460ce2be991e8b8492bfb3d0ce4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344932Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5084ad24221ff533c60e978583b8331b465a8108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345124Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596906920-d9c268cee334ba8e96e8c161b05d8af21fcc527d.profdata to chrome-mac-master-1596951804-2e38ee79c378ef6490301a31a86a3e3f9ffa7699.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9b630d1a32106aa63a5add9452fd3d7c96453593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344947Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e24a4c24c03..ae5d21e08bc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Idd1de121ff40e7a76e3e3035717486a1076a41bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344929Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.25-1595848892-benchmark-86.0.4208.0-r1 to 86-4183.39-1596449559-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9e937ab3ef19841430ffa2f29b898c3b160bffb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345086Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 to 86-4183.48-1596448621-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I99fa4b1d4cccde3f75fad56d027ca43f6d6fd626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344935Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.39-1595845830-benchmark-86.0.4208.0-r1 to 86-4183.48-1596451266-benchmark-86.0.4221.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0d2910a13e5803231303cbccb78daa6ed411aac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344934Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie6004b9a783db3f506d3aaea3ae2febd69cfbad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345007Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/19423f490a2c..839b4bc4c1d6 2020-08-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I756c1cb8046874c39d0cf279d5380f0876539d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344928Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/19410c19202c..1e24a4c24c03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie68a6f4b752fe605607f467086d616f6cc886917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344926Reviewed-by:
-
Daniel Hosseinian authored
In preparation for cloud print deprecation, users should not be encouraged to use cloud print if they aren't already signed on. Bug: 1113881 Change-Id: I5865f8b790de58210603e427ec7bda4b343367cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341762 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796255}
-
Lukasz Anforowicz authored
This CL removes hardcoded, path-based exclusions from the rewriter's source code and moves them into a filter file. This way, the exclusions can be updated (or experimented with) without having to recompile the rewriter. Bug: 1069567 Change-Id: I7f0151fb8fdeb595da44e44c063caef0c154c31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337393 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796254}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I082c79c002c4e50d878cceb08d0401d3495aa518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344502Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/defa9bc55594..19410c19202c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I5122da1b8b3b985e792453e57f55fa2f19da2b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344698Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I48a9ee98a10784fc7785ce36e7924507ad15f420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344697Reviewed-by:
-
Mei Liang authored
crrev.com/c/2314557 removes the OverviewModeController wrapper in ChromeTabbedActivity, and |mOverviewModeController| is null before native loads which leads to a NullPointerException. This CL fixes the crash by restoring the effective null checking in the OverviewModeController wrapper. Bug: 1112229 Change-Id: Ia62d9acdd267ed8c602fe61d85c2ecea8ac26747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337340Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796250}
-
Chris Harrelson authored
Instead of calling into BoundingBoxForCompositingInternal when filters are present, just account for them directly. The code was previously also wrong because it would recurse into children and stop the recursion at composited children, which means it depended on the previous compositing state. The code was added in 2013 (*) (*) https://source.chromium.org/chromium/chromium/src/+/ae7c13ecb7f34a7e31cab0ce9167d9c9744fabfa Change-Id: Id90d62adb7c0626135976110334805f76650f292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343507 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796249}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6e572f35b8bfe3eead5eff3b95b5bcc52c239202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344248Reviewed-by:
-
Xianzhu Wang authored
This reverts commit dab549a6. Reason for revert: Fixed crbug.com/1114414 by adding a missing null check. Original change's description: > Revert "Unify graphics layer traversal functions" > > This reverts commit 84afbfbd. > > Reason for revert: crbug.com/1114414 > > Original change's description: > > Unify graphics layer traversal functions > > > > This makes them consistent to use the same skipping conditions as > > what we do during PrePaint, to avoid access of null or stale layer > > states. > > > > Bug: 1110232 > > Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796152} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ia49d32ab65cb69a98dcb2a1c2374cea0f0cb0c6a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110232, 1114414 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344645 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796235} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1110232 Bug: 1114414 Change-Id: If9ef06657208a69c948a6558adfbf79913a651c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344646 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596884690-8c8737b7a1025f9118074613364b21f1ff90ef1f.profdata to chrome-mac-master-1596906920-d9c268cee334ba8e96e8c161b05d8af21fcc527d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I12f93739a48d8c19740719210097b1a296ee7dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344650Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b2ed7f21ff9..defa9bc55594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: Change-Id: I858c9546d2f2b1219293556ceaeaffb9a2edf2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344249Reviewed-by:
-
- 08 Aug, 2020 10 commits
-
-
Stephen Chenney authored
The paths for wavy, dashed and dotted paths are quite expensive to compute and are used in both bounds and painting. Cache them, recomputing when needed and resetting when any line data changes. No change in net behavior. Bug: 896295 Change-Id: If0e58f49e6ecc9246b95d4b883eec1ac7d006ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342641 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796244}
-
Kang Minchul authored
Remove use of base/macro.h and use explicit deletion instead Bug: 1010217 Change-Id: I74180731b700bdff4f2735111d8dede3ae4733b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342332 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796243}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596834937-d362a0fc8a27d2c9c7a6f73e739d7f96eafd2751.profdata to chrome-mac-master-1596884690-8c8737b7a1025f9118074613364b21f1ff90ef1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iba3a18ccb7b1b35050fa54d3bf601d41d9ce0efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344384Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I72ac91dd22cd7da2df6a2f4cb3de045e1e723e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344246Reviewed-by:
-
Matthias Körber authored
In the current implementation the structured address information retrieved from Sync is not available for voting because the profile passes through the SQL data base that does not handle the tokens. This CL fixes this bug by reading and writing the structured tokens to SQL. It implements eventual deletion consistency for legacy clients. The CL also renames the ADDRESS_HOME_FLOOR type to ADDRESS_HOME_SUBPREMISE because the type can also contain the apartment number and the staircase. Change-Id: I4e50341caafe7d5b0ca87ce6b394e582daa600e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344464 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#796240}
-
Hyunjune authored
This patch fixes up a crash relied on 'keySplines' of <animate*>. All values of 'keySplines' must all be in the range 0 to 1.[1] So this patch checks this ranges of the values. [1] https://svgwg.org/specs/animations/#KeySplinesAttribute Bug: 1114169 Change-Id: I1878842a5b07702743e5d59ada4a8c11a1cfed36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344426 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796239}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9044c9405838..2b2ed7f21ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia1294afc9be5828980261a34e41738525f0412f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344224Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f1b0dfbf1d4..19423f490a2c 2020-08-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66397c3f09c172b0c5046fe8a9d469771353b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344344Reviewed-by:
-
Mugdha Lakhani authored
A simple browser test has been added to verify creation logic. Bug: 1096088 Change-Id: I02ce454b16560d9bb5ee682d33a0c67cbbd3ee8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341127 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 84afbfbd. Reason for revert: crbug.com/1114414 Original change's description: > Unify graphics layer traversal functions > > This makes them consistent to use the same skipping conditions as > what we do during PrePaint, to avoid access of null or stale layer > states. > > Bug: 1110232 > Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796152} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ia49d32ab65cb69a98dcb2a1c2374cea0f0cb0c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110232, 1114414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344645Reviewed-by:
-
