- 30 Jan, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change removes CopyToString from base::BasicStringPiece's API. Similarly to the recently removed clear() and set() these APIs are not present on std::basic_string_view, and thus would block us from adopting string_view once we support C++17. Existing usages of `piece.CopyToString(&str)` are replaced by either `str = std::string(piece)` or `str.assign(piece.data(), piece.size())` depending on whether move assigning a temporary would result in an additional malloc or not. TBR=dcheng Bug: 752720 Change-Id: Ib70a183671d61bbbbf08c2c4a1c7eef573c3c446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027408 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736749}
-
Armando Miraglia authored
To make debugging and analysis easier, I am extending the lifetime of some statistics related to video capture related to frame handling. Bug: 1043514 Change-Id: I60378651dfdc0ee29cd8a7ecbe94b90d41f72ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026969Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#736748}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4328e928ef4d..25bcd6a6215e git log 4328e928ef4d..25bcd6a6215e --date=short --first-parent --format='%ad %ae %s' 2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 243744c2..fbfe7df1 (481 commits) 2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c3dc3581eaf..430def835f9f (7 commits) 2020-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2bc9cc12f0b0..ee07cb317579 (18 commits) Created with: gclient setdep -r src/third_party/skia@25bcd6a6215e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I9c1af36bb55acc641aaed4c0159b05b681b1fa66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736747}
-
Kenichi Ishibashi authored
The purpose of this change is to reduce ServiceWorkerStorage::NewVersionId() as much as possible so that we can make it async easily. See the planning doc [1] for the context. [1] https://docs.google.com/document/d/1j0WP5wsenJISViJzhngSJG3hKcIf39KbfRgCbzgWt5A/edit?usp=sharing Bug: 1046335 Change-Id: Id013cdbe3dd88a51fc3002466581c8224a4e22e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026528 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736746}
-
Koji Ishii authored
This patch fixes invalidations for first-line, by copying the logic from |NGPaintFragment|. Fixes 5 tests. Bug: 982194 Change-Id: I164fa59f2dfa080ec64fc0afe24ba83ba950ecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943080 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736745}
-
Rahul Arakeri authored
This CL adds more scrollbar invalidation tests. Bug: 1045808 Change-Id: I2a841fda4e8ebe584753fcdb70475ed28cf7f1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027209 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736744}
-
Kenichi Ishibashi authored
Before this CL, FindRegistrationForId() worked like the below: 1. Check if storage is initialized/disabled. * if not initialized, perform lazy initialization then go back step 1. * if disabled, abort registration lookup. 2. Check if there are stored registrations for the given origin. * if NOT exists, only checks installing registrations. 3. Check if there is a live registration for the given registration id. * if exists, return the found registration. 4. Check database. This ordering doesn't fit well for the Storage Service migration because step 1, 2 and 4 should be performed in the storage service (in the future) but step 3 should remain in content/. Keeping this ordering will require an additional IPC round-trip which is undesirable. This CL changes the above steps like the below so that we won't need extra IPC: 0. Introduce a new field in ServiceWorkerRegistration which tells that if the registration is stored in persistent storage. 1. Check if storage is disabled. If disabled, abort registration lookup. 2. Check if there is a live registration for the given registration id. * if exists and the registration is stored on storage or in installing state, return the found registration. 3. Initialize storage if needed. 4. Check if there are stored registrations for the given origin. * This is the same as the step 2 of the previous behavior. 5. Check database. The new behavior should be almost the same as long as we maintain the field which indicates if a registration is stored accordingly. This CL makes sure the condition by updating the field when a registration is created from ServiceWorkerDatabase::RegistrationData or ServiceWorkerRegistry::DidStoreRegistration() is called. Bug: 1039200 Change-Id: I9e351c04a2eaa516a75274757778f604eadf951a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021783 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#736743}
-
Dmitry Gozman authored
There are two problems which prevent features from being counted during navigation commit: - Document::Loader() does not return committing DocumentLoader during commit. This leads to use counters being immediately dropped. The fix is to expose committing DocumentLoader explicitly through DocumentInit::GetUseCounter. - UseCounterHelper::DidCommitLoad() is called before DispatchDidCommitLoad(). This leads to use counters being not reported to browser process. The fix is to call UseCounterHelper::DidCommitLoad() slightly later during commit. Bug: 1043018 Change-Id: I16b1d248aad194d4ada3aeb841cddae924510596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022348Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adc8d4cb9876..916bee6fe15b Created with: gclient setdep -r src-internal@916bee6fe15b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701,chromium:1044158 Tbr: jbudorick@google.com Change-Id: Ifb1b6ace0a1cbbb95a9a15f0240527c6ca69daf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736741}
-
Simon Zünd authored
Since source mapping will be async in the future, this test is changed to not race events, but instead print the single expected binding upon receiving the "BindingCreated" event. R=mathias@chromium.org Bug: chromium:1032016 Change-Id: I676cd279f7f606dacc94b6a6d82814c7187e677a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026974Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736740}
-
Sophie Chang authored
Bug: 1036490 Change-Id: Ibad8cdb5f84b2a3fbb1c85499b9c327cd8f2cb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029230Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736739}
-
Kenichi Ishibashi authored
This function isn't used. This CL also moves WriteToDiskCacheWithCustomResponseInfoAsync() to anonymous namespace in service_worker_test_utils.cc because it is only used from service_worker_test_utils.cc Bug: 1046335 Change-Id: I733b8332191293f75cebde317e51996e896e860c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029552Reviewed-by:
-
Rachel Sugrono authored
The delete from Quick View feature allows user to delete files via the Quick View, which means the number of selected entries can change, and onFileSelectionChanged_ will advise Quick View of that. That includes having no selected entries at all. And if there are no selected entries, Quick View should be closed if it is open. Otherwise, we need to ensure this.currentSelection_ is bounded by the selected entries length (to avoid out-of-bounds entries_ access). Bug: 803259 Change-Id: I8702b9422b0ea5b1ffc956aa8f2f999568fd82de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027008 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736737}
-
Yuki Shiino authored
This reverts commit c1f6f104. Reason for revert: Caused build breakage as crbug.com/1047073 Original change's description: > bind-gen: Build generated IDL enumeration in prod > > Builds the bindings of IDL enumeration generated with the new > bindings generator in prod, despite that the bindings is not > yet used. This patch makes it available for real use. > > Bug: 839389 > Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736356} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: If378fb06497f5782dd18a3c637c7f61df745fa5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389, 1047073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029556Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736736}
-
Kent Tamura authored
PositionIterator should have identical behavior for <input>, <select>, and <textarea>. We should remove kSelectTag branches later. This CL has no behavior changes. Bug: 697283 Change-Id: I5209d4ee59acf835310f8218b5c99305fef2573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028868Reviewed-by:
-
Darren Shen authored
Bug: 1034355 Change-Id: Id433020409786ba93822d03606b64f21a4d40953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026335 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#736734}
-
Julie Jeongeun Kim authored
This CL changes FrameMsg_IntrinsicSizingInfoOfChildChanged so that it is implemented in the RemoteFrame interface since it is only got through RenderFrameProxy. It introduces intrinsic_sizing_info.mojom to have the type used in IntrinsicSizingInfoOfChildChanged(). Bug: 1044304 Change-Id: I7bb41d53a415f4bd8a4eb87c270d23c28c83b27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015866 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736733}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/707a8742cabd..6ebcde89ed38 git log 707a8742cabd..6ebcde89ed38 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fancl@chromium.org Fix import path error Created with: gclient setdep -r src/third_party/catapult@6ebcde89ed38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ifa8f9e30e2ff21fb31912257bec8b5dc54933bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029462Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e58dfbd6..62aeb045 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2df4cfbc55eaa087ae21b7127d5f1ad09ee04f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028529Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736731}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f79f1d6d964c..4a6c9b66c515 git log f79f1d6d964c..4a6c9b66c515 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4a6c9b66c515 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id34a88dcf90967a46e191c009cbb69baffd2c13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029461Reviewed-by:
-
Ionel Popescu authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks! This CL changes the padding left and right for text related inputs to 2px in order to improve the visibility of the cursor. Prior to this CL the padding used on Windows was 0px while on other platforms it was 1px. Bug: 1045842 Change-Id: I99df568369d036dddbd54296b355f8c949ddf05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025953 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#736729}
-
Joseph Kim authored
demo_session and demo_setup controller currently have two separate lists of countries which are almost identical (other than US). Now demo_setup_controller sources the list of countries from demo_session, excluding US. Added unit tests to ensure that DemoSetupController::GetSubOrganizationEmail() functionality was maintained. Change-Id: I27595fc1da446150f86be050693d8d3976760b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018567Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#736728}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24ed75db12ba..4328e928ef4d git log 24ed75db12ba..4328e928ef4d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 csmartdalton@google.com Add a stencil/tessellation hybrid mode for path rendering 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4328e928ef4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I9a27530b5bb9f7a42fe2aca19fc17c5ab123f232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029279Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4859ae57bca..ee07cb317579 git log e4859ae57bca..ee07cb317579 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 jmadill@chromium.org Test Harness: Allow filter with sharding params. 2020-01-29 tobine@google.com Add GN arg to extract native libs in APK Created with: gclient setdep -r src/third_party/angle@ee07cb317579 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I065024344032daf129c575a49ba658ffdfb21621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029459Reviewed-by:
-
Martin Kreichgauer authored
Bug: b/148226006 Change-Id: Ib7f32c020286bd5ea6c971960f44e828133de1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029253 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#736725}
-
Thomas Guilbert authored
Currently, remotePlayback ignores TERMINATED state changes, and only properly resumes local playback when a CLOSED state change is received. For some reason, CafBaseMediaRouteProvider.handleSessionEnd() is now called earlier than it used to. This means terminateAllRoutes() terminates the route, before we can close it, and we never switch back to local playback of the video. This CL treats TERMINATED state changes the same way as CLOSED changes. Bug: 1043313 Change-Id: I16bd144c4c0eb47fb147e5e3f17a223e095f3833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008234 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#736724}
-
Xinghui Lu authored
Bug: 1046910 Change-Id: I18d16e0f6679920eefc477b67c04429675345261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029309 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736723}
-
John Lee authored
This CL updates 2 UIs: the drag image that is used as the ghost image following the finger during a drag session, and the placeholder of the tab group as the user continues to drag. Tab groups are resized to the size of a normal ungrouped tab to allow for easier dragging, as groups can otherwise extend the entire view. Tab groups are only draggable by their chip (color dot or title) to prevent tabs from shifting beneathe the pointer as the tab group is resized. Bug: 1027373 Change-Id: Ib4692389390b8ffea8545760b8308c0d3d20000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024124 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736722}
-
Charlene Yan authored
Records the amount of time in ms from the cursor entering the tabstrip to tapping on a tab to switch. Bug: 1040657 Change-Id: I438f53c3d3a83cead9a3feb0c62356e1322cf1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023396Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736721}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1a0daf728cae..e827b0f7ec9d git log 1a0daf728cae..e827b0f7ec9d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 sokcevic@google.com Adds support to edit description on git cl upload Created with: gclient setdep -r src/third_party/depot_tools@e827b0f7ec9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:739928 Tbr: agable@chromium.org Change-Id: I992da437a9ebbfa9b92511a84616b124eb8a593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029278Reviewed-by:
-
Kelvin Jiang authored
This CL adds a quota of 20 calls every 10 minutes to getMatchedRules (provided by QuotaService). This quota is not applicable if it has been disabled for tests, or if the getMatchedRules call is associated with a user gesture. Bug: 983761 Change-Id: I4b8d28761bcac924f67d0da3a7445ff4fcbbd2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015402Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736719}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/de679a2f8c60..1ac8524b6984 git log de679a2f8c60..1ac8524b6984 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 tsepez@chromium.org Avoid passing raw c strings in CBA_FontMap. 2020-01-30 tsepez@chromium.org Remove unused CPDF_NameTree::GetIndex() Created with: gclient setdep -r src/third_party/pdfium@1ac8524b6984 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icdec6bd4508e1e50da5408856cebd96c75caf037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029276Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically ensure that if a file uses cr.define(), then all of its contents reside within the cr.define() declaration. This is in preparation of running auto-generation tools for the Polymer 3 migration. Bug: 1026426 Change-Id: Idcd6d522613c8a1ecc4ab38af5c7de4f7d196502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029204 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#736717}
-
rbpotter authored
This is a dependency of settings_shared_css in the settings page. Bug: 1042558 Change-Id: Ibd7ec9f7a098787556bcdb1276732c94410781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028765 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Youkichi Hosoi authored
BUG=b:147917544 TEST=trybot Change-Id: I5e31ef997e7348b388f6a6fce9027b36e1a4fcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026534 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Auto-Submit: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736715}
-
Eric Karl authored
We allowed destruction on main thread for historical reasons. Update DCHECK to represent the real requirement, that we're always destroyed on the bound thread. Bug: 899395 Change-Id: I542ecbd2bbdb449b96bed2b7f747640873847e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029491 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736714}
-
Luciano Pacheco authored
Fix tests broken by the new structure in the directory tree. Enable some of the broken tests with FilesNG flag so they don't regress. Changed 2 let to const as pointed by presubmit. Bug: 1002790 Change-Id: I4b9c6e34d8f89df1b7f7ece002f8c121ca4eb3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029392 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Bo Liu authored
Useful for debugging binding related issues from logs. The message looks like this: bindings:WMS state:3 counts:0,0,0,2, Bug: 1045059 Change-Id: I4523494c08f2dcee94c5ee9ca337284dedfea6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028162Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141427882038..adc8d4cb9876 Created with: gclient setdep -r src-internal@adc8d4cb9876 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1040871,chromium:1046370,chromium:790886 Tbr: jbudorick@google.com Change-Id: I9fb2dde88a7812434fce8c15de50071c986ba32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029275Reviewed-by:
-
Kai Ninomiya authored
And temporarily disable use_dawn for the M81 branch point. This allows dawn's standalone tests to continue to be built for Chrome OS's testing during the branch period. Bug: chromium:985142 Change-Id: I9b2924276b65b628056f811008f3432be4ad5539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028649Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736710}
-
