GitLab

Cr-Commit-Position: refs/heads/master@{#288391}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288391 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288390}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288390 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
I misunderstood the outcome of the discussion surrounding this topic. We need to keep this code in order to not break google.com while gathering data about this feature.

Original issue's description:
> Enable HTMLMediaElement@autoplay on Android
> 
> This CL sets user_gesture_required_for_media_playback to false in Chrome for
> Android. Previously, we removed this requirement as a special case for the
> Google Search Results page. Now that this setting matches Chrome's behavior on
> other platforms, we don't need the special case for google.com and can remove
> the entire VoiceSearchTabHelper.
> 
> This CL leaves the user_gesture_required_for_media_playback WebPreference
> because that's used by android_webview.
> 
> R=klobag@chromium.org, darin@chromium.org
> BUG=178297
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288308

TBR=darin@chromium.org,klobag@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=178297

Review URL: https://codereview.chromium.org/453023002

Cr-Commit-Position: refs/heads/master@{#288389}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288389 0039d316-1c4b-4281-b951-d872f2087c98

This way I don't have to duplicate it across bots. I'll remove from
the other files once the recipe side has been updated.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/450403002

Cr-Commit-Position: refs/heads/master@{#288388}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383635

Review URL: https://codereview.chromium.org/445353003

Cr-Commit-Position: refs/heads/master@{#288387}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288387 0039d316-1c4b-4281-b951-d872f2087c98

Previously under resources/contextual_search/, now moving Roboto to its own directory. Also using Roboto2 now.

BUG=401100
R=dbeam@chromium.org, huangs@chromium.org
TBR=jam
TEST=Didn't break Contextual Search promo

Review URL: https://codereview.chromium.org/450433002

Cr-Commit-Position: refs/heads/master@{#288386}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288386 0039d316-1c4b-4281-b951-d872f2087c98

The title of the window widget should be the product name (Chrome/Chromium).

Added a "close" button to make the last bubble in the tutorial dismissible.

BUG=399698,399697
TEST=Start Chrome with --new-avatar-menu. Choose "Switch person" from the
avatar menu of a brand new profile. Once you go through all the slides in
the tutorial, the last bubble which points to the "Add Person" button
should have a little x button in the top right corner. Also, the title of
the window should be "Chrome".

Review URL: https://codereview.chromium.org/440713005

Cr-Commit-Position: refs/heads/master@{#288385}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401769

Review URL: https://codereview.chromium.org/449253002

Cr-Commit-Position: refs/heads/master@{#288384}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288384 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/456533002

Cr-Commit-Position: refs/heads/master@{#288383}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394220
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/456833002

Cr-Commit-Position: refs/heads/master@{#288382}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288382 0039d316-1c4b-4281-b951-d872f2087c98

Assign cmasone@chromium.org as the owner of the
Login.ConsumerNewUsersAllowed histogram.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/453723002

Cr-Commit-Position: refs/heads/master@{#288381}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400552

Review URL: https://codereview.chromium.org/448953002

Cr-Commit-Position: refs/heads/master@{#288380}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288380 0039d316-1c4b-4281-b951-d872f2087c98

Fills in ServiceWorkerFetchStores.  Adds a stub ServiceWorkerFetchStore class which will need to be filled in. Also adds some tests.

A CL to refactor ServiceWorkerFetchStores -> ServiceWorkerCacheStorage is upcoming.

BUG=392621

Review URL: https://codereview.chromium.org/424863002

Cr-Commit-Position: refs/heads/master@{#288379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342336
TEST=None

Review URL: https://codereview.chromium.org/448923003

Cr-Commit-Position: refs/heads/master@{#288378}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401928

Review URL: https://codereview.chromium.org/453943002

Cr-Commit-Position: refs/heads/master@{#288377}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288377 0039d316-1c4b-4281-b951-d872f2087c98

This moves AwWebContentsObserver to be a separate class so that
it can has it's own unittests.

BUG=None
TEST=AndroidWebviewTests

Review URL: https://codereview.chromium.org/445403002

Cr-Commit-Position: refs/heads/master@{#288376}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288376 0039d316-1c4b-4281-b951-d872f2087c98

-----------------------------------------------------------
1. filter expired suggestions before loading from cache
2. assign default expiry timestamps (now + 72 hours), to those ones which don't have expiry timestamps, before storing in cache

BUG=387926

Review URL: https://codereview.chromium.org/423133003

Cr-Commit-Position: refs/heads/master@{#288375}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288375 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the ability to do encoding/decoding of tokens in the audible range.
It also simplifies the parameters we send in to the whispernet pnacl wrapper.
All the parameters removed are now picked up as defaults in the wrapper itself.
There is literally no reason we'd ever touch those defaults hence it made no
sense to send them hardcoded from wrapper.js.

R=ckehoe@chromium.org
BUG=390393

Review URL: https://codereview.chromium.org/444373004

Cr-Commit-Position: refs/heads/master@{#288374}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288374 0039d316-1c4b-4281-b951-d872f2087c98

This was deliberately NOT done previously, because it indicates a likely
source of future problems.

> Changed PLOG to VPLOG
> 
> Moved recvmsg log to VPLOG
> 
> BUG=377403
> 
> Review URL: https://codereview.chromium.org/414243002

TBR=giji.g@samsung.com

Review URL: https://codereview.chromium.org/452973002

Cr-Commit-Position: refs/heads/master@{#288373}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288373 0039d316-1c4b-4281-b951-d872f2087c98

Use gfx::CrossProduct() instead of defining a new static function.

BUG=

Review URL: https://codereview.chromium.org/444983002

Cr-Commit-Position: refs/heads/master@{#288372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288372 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary measure until:
- we can disable the API only on Win8 Metro OR,
- we can make it work on Win8 Metro.

The API is currently broken on Win8 Metro and it is not trivial to
disable it on that mode only. Given the discussion with the Blink API
owners, disabling it on Win8 would be better than not shipping because
of the bug on Win8 Metro.

BUG=400846

Review URL: https://codereview.chromium.org/456623003

Cr-Commit-Position: refs/heads/master@{#288371}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288371 0039d316-1c4b-4281-b951-d872f2087c98

Move them from internal histograms.xml to chromium.org histograms.xml since they are/were referenced only in chromium.org code.

BUG=none

Review URL: https://codereview.chromium.org/449913002

Cr-Commit-Position: refs/heads/master@{#288370}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288370 0039d316-1c4b-4281-b951-d872f2087c98

Was a blocker on a P0 bug, http://crbug.com/380709, but not anymore.

After the tryserver split, the blacklisting doesn't trigger, so it is a no-op change. Consider it a cleanup.

R=phajdan.jr@chromium.org,stip@chromium.org
BUG=225464
TEST=git cl try -m tryserver.chromium.win -b win_chromium_x64_rel

Review URL: https://codereview.chromium.org/319983004

Cr-Commit-Position: refs/heads/master@{#288368}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371463

Review URL: https://codereview.chromium.org/421393002

Cr-Commit-Position: refs/heads/master@{#288367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288367 0039d316-1c4b-4281-b951-d872f2087c98

A regression was introduced in r275142 causing the permissions dialog to not
show permissions. Obviously very bad. Fixed, and added a regression test.

BUG=397900

Review URL: https://codereview.chromium.org/448883002

Cr-Commit-Position: refs/heads/master@{#288365}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398169

Review URL: https://codereview.chromium.org/428883013

Cr-Commit-Position: refs/heads/master@{#288363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288363 0039d316-1c4b-4281-b951-d872f2087c98

Fixes issues with EWDTAH lifetime. Now EWDTAH lives as long as there is a scoped_refptr referencing it or the worker is alive.

Split off https://codereview.chromium.org/349033009/

BUG=389454

Review URL: https://codereview.chromium.org/405603002

Cr-Commit-Position: refs/heads/master@{#288362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288362 0039d316-1c4b-4281-b951-d872f2087c98

Define charging attribute in terms of whether the device is
plugged in or not. Previously it was defined in terms of
BATTERY_STATUS_DISCHARGING property but some phones report
BATTERY_STATUS_NOT_CHARGING when the battery is not charging.
Also modified the tests accordingly.

TEST=http://jsbin.com/battery-status-test
BUG=360068

Review URL: https://codereview.chromium.org/451773002

Cr-Commit-Position: refs/heads/master@{#288361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288361 0039d316-1c4b-4281-b951-d872f2087c98

Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/447183006

Cr-Commit-Position: refs/heads/master@{#288360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288360 0039d316-1c4b-4281-b951-d872f2087c98

Intent.EXTRA_ALLOW_MULTIPLE is only available in JellyBean MR2 and
higher. So added missing check for same. To avoid warning at build
added @TargetApi annotation.

BUG=401333

Review URL: https://codereview.chromium.org/453963002

Cr-Commit-Position: refs/heads/master@{#288358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288358 0039d316-1c4b-4281-b951-d872f2087c98

Response headers that are not valid UTF-8 can't be stored in a
base::StringValue, which is always a UTF-8 string, so escape any non-ASCII
values to be safe. This prevents a DCHECK when dev tools' network request
inspector is open and we receive these headers.

BUG=299880

Review URL: https://codereview.chromium.org/453483002

Cr-Commit-Position: refs/heads/master@{#288357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288357 0039d316-1c4b-4281-b951-d872f2087c98

> Adding the VerifyModule function (and helpers) to safe browsing.
> 
> This function allows us to compare a module in memory with 
> its original on disk, and identify any differences (after 
> accounting for relocations).  The state of the module 
> (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
> returned along with a list of the possibly modified exported 
> functions of the module.
> 
> 
> BUG=401854
> 
> Review URL: https://codereview.chromium.org/406043003

TBR=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/458483003

Cr-Commit-Position: refs/heads/master@{#288356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/454883002

Cr-Commit-Position: refs/heads/master@{#288354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288354 0039d316-1c4b-4281-b951-d872f2087c98

When refactoring code it is easy to accidentally disregard the output of
base::StringPrintf. The code will still look superficially correct, and may even
pass code review (as happened with https://codereview.chromium.org/436133002/ ).

This type of bug can be prevented by annotating StringPrintf with
WARN_UNUSED_RESULT. Despite the name, this causes a compile error in our build
configuration (except on Windows, where it is ignored). This should ensure that
such errors are caught by the CQ if not sooner.

TEST=build all; base_unittests
BUG=400663

Review URL: https://codereview.chromium.org/440013003

Cr-Commit-Position: refs/heads/master@{#288353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288353 0039d316-1c4b-4281-b951-d872f2087c98

* Update chrome://settings Privacy section to change int kNetworkPredictionOptions
instead of bool kNetworkPredictionEnabled.
* Introduce code to migrate user setting (and only user setting).
* Per UI review, keep UI unchanged.
* Note that policy handler for these two preferences has already landed, see https://crrev.com/431493003.

BUG=334602

Review URL: https://codereview.chromium.org/421653006

Cr-Commit-Position: refs/heads/master@{#288352}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401906

Review URL: https://codereview.chromium.org/452063002

Cr-Commit-Position: refs/heads/master@{#288351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288351 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288350}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288350 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/acc125860053d0a65bc7b67dd1b886aa7932d292..b511042bb07a6a289b0d1146cb57f6e8b80580d6

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/456703002

Cr-Commit-Position: refs/heads/master@{#288349}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288349 0039d316-1c4b-4281-b951-d872f2087c98

The tests were crashing on the windows bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%283%29/builds/29877/steps/unit_tests/logs/VerifyModuleModified):

SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (run #1):
[ RUN      ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(43): error: Value of: mem_dll_handle_.is_valid()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(48): error: Expected: (static_cast\u003CHMODULE>(0)) != (*mem_handle), actual: NULL vs NULL
Backtrace:
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0278AD98+6714120]
	(No symbol) [0x01761388]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02493F49+3605689]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024940CE+3606078]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024946AE+3607582]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024943E9+3606873]
	IsSandboxedProcess [0x0465F878+12316280]
	IsSandboxedProcess [0x0465F5AA+12315562]
	IsSandboxedProcess [0x04683A62+12464226]
	IsSandboxedProcess [0x045801B7+11401143]
	BaseThreadInitThunk [0x74C0338A+18]
	RtlInitializeExceptionChain [0x77299F72+99]
	RtlInitializeExceptionChain [0x77299F45+54]

> Adding the VerifyModule function (and helpers) to safe browsing.
> 
> This function allows us to compare a module in memory with 
> its original on disk, and identify any differences (after 
> accounting for relocations).  The state of the module 
> (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
> returned along with a list of the possibly modified exported 
> functions of the module.
> 
> 
> BUG=401854
> 
> Review URL: https://codereview.chromium.org/406043003

TBR=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/452133002

Cr-Commit-Position: refs/heads/master@{#288348}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288348 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise it's possible to end up crashing when calling a null function
pointer, if a framebuffer does not have a color buffer attached.

This bug applies to at least some GLES3 platforms, where DrawBuffers
function is not bound (which is reasonable, since core version of the
function behaves subtly differently than DrawBuffersEXT in relation to
GLSL ES 1.0 shaders, if the EXT_draw_buffers extension is missing). Also
possibly GLES2 platforms which implement OES_depth_texture but not
EXT_draw_buffers.

BUG=401645
TEST=gpu_unittests, WebGL conformance tests

Review URL: https://codereview.chromium.org/448223002

Cr-Commit-Position: refs/heads/master@{#288347}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288347 0039d316-1c4b-4281-b951-d872f2087c98