- 13 Aug, 2019 40 commits
-
-
Shaojiang authored
CQ-DEPEND=chromium:1698490 Change-Id: I15d3ee4e0e5425c34fbbbccff63c937af2e1e4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733712 Commit-Queue: Shaojiang Zhong <sjzhong@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686473}
-
Matt Menke authored
|update_network_isolation_key_on_redirect| should only be set on navigation requests, and renderers are not trusted to set it. This CL introduces ResourceRequest::TrustedParams, which contains fields only the browser process is trusted to set, and an |is_trusted| bit that can be set when creating URLLoaderFactories. If TrustedParams are sent to a URLLoaderFactory without that bit set, the request will fail. Bug: 991736 TBR: alexilin@chromium.org Change-Id: Id3263e03e663b330ee9c21682a4d0de753c5331a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744926 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686472}
-
Shaojiang authored
Users from browswer side can call AddDataRestoreKey() in cryptohome_client so that the client will send D-Bus call to chromeOS cryptohome. The reply sent from chromeOS will contain the raw bytes of generated data_restore_key. CQ-DEPEND=chromium:1698490 BUG=chromium:969916 Change-Id: I671f826ac6795de021f9c93e093a7f04b7738730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736817Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Shaojiang Zhong <sjzhong@google.com> Cr-Commit-Position: refs/heads/master@{#686471}
-
Wez authored
The stuck-child timeout tests were using a 5ms timeout, which on some systems caused CoordinatorImplTest.TimeOutStuckChildMultiProcess to fail due to no "browser" dump being received within those 5ms. Remove the dependency on the speed of the system on which the test is running by using MOCK_TIME instead. Bug: 970819 Change-Id: I48fc6c8b8b6e7bc5c19179a01cd9e80ee40e8555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750405Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686470}
-
Stephen Nusko authored
This adds a global CHECK that ensures we hopefully won't miss new processes as they are added. This enables all processes to initialize system tracing as early as possible. Bug: 979576 Change-Id: Id9d841dad5980cf82e46586238fe682722558cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748886 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#686469}
-
Joe Mason authored
chrome_cleaner is built into a separate executable from chrome, so many of chrome's include_rules shouldn't apply to it. Also moves several common dirs to chrome_cleaner's main DEPS file so they're allowed in the whole chrome_cleaner project. The remaining includes that are only allowed in some subdirs are: * components/crx_file (only used in the component that unpacks CRX's) * mojo/core/embedder (only used in IPC setup, and by some tests - mojo/public is allowed everywhere) * net/traffic_annotation (only used in networking code) * third_party/crashpad (only used in the crash reporter) * third_party/zlib (only used in the unpacker component and zip_archiver) R=proberge Bug: 967728 Change-Id: I96dc59014ebb9be0e0483a190e000f42902b49da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749249Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#686468}
-
Elly Fong-Jones authored
This class now requires an anchor view (which in practice it always has) and does not support having an anchor point. Bug: 989080 Change-Id: I7c0b24e5cbe9794ef87c97ce5e6d174938192170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749308 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686467}
-
Takuto Ikuta authored
This helps to see what happened around DCHECK failure. Bug: 993249 Change-Id: I2f7dd76c63899599140f15149da761ac33b2d7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750539 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#686466}
-
Hans Wennborg authored
../../chromeos/services/secure_channel/ble_scanner_impl_unittest.cc:231:12: error: address of stack memory associated with local variable 'fake_bluetooth_device' returned [-Werror,-Wreturn-stack-address] return fake_bluetooth_device.get(); ^~~~~~~~~~~~~~~~~~~~~ I guess the test worked before because it didn't actually dereference the pointer. Bug: 992458 Change-Id: I82f189588644a63de1a9f16dbf158dfcdca5e5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751789Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#686465}
-
Yasmin authored
Bug: 992355 Change-Id: I9a61e2f21d7d0492763d444d228c13090d0d4262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751982Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#686464}
-
Sammie Quon authored
Test: added test Bug: 992223 Change-Id: I717921ba2a0cc428b934b57e247f54395691b907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750155Reviewed-by:
Avery Musbach <amusbach@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686463}
-
Kyle Horimoto authored
Bug: 966386 Change-Id: Ic3c7e2e5cc6848fabdb7f35a753024e75bfdd783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750090 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686462}
-
Victor Fei authored
This is a follow up change of CL:1667787, which introduced AutofillPopupControllerImpl::FireControlsChangedEvent for autofill popup accessibility. On Mac and potentially other platforms, when accessibility is enabled, upon invoking autofill popup and FireControlsChangedEvent we end up dereferencing a nullptr of AxPlatformNode due to Mac does not have a complete implementation of AxPlatformNode yet. This CL fixes the above by adding a check for AxPlatformNode in FireControlsChangedEvent. Changes: 1. Introduced a check for invalid AxPlatformNode in AutofillPopupControllerImpl::FireControlsChangedEvent to return early from firing event. 2. Added associated unit tests for FireControlsChangedEvent. 3. Exposed GetWebContentsPopupControllerAxId virtual to AutofillPopupDelegate.. Bug: 986587 Change-Id: I9a6ed49330a9ea9d7d4e5483c3ee06d5675919ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714297 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686461}
-
Peter K. Lee authored
It is enabled, but does not have a feature_configurations or finch configuration. I.e. it's really the same as disabled. Discussed with ghendel@. We have collected data for this Reading List promo which did increased usage, but not something that we want to run permanently. It's OK to leave this as disabled but keep the code in case we want to run it in the future. Bug: None Change-Id: Ie6ee6c8227985bda08af36964fe83f51a6bc77f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745401 Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686460}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ieb48da1f5ceea08f8b6f12ab283ae4fca193e849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686459}
-
Donn Denman authored
Adds tests to the Visual Viewport ScrollIntoView for fixed-position elements. BUG=986390 Change-Id: Id6a6838b948ce95efa2eee228303cd0325d2af50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746079 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686458}
-
Michael Thiessen authored
Turns out we don't really want to use the TabDelegate that WebAppActivity uses, as it does asynchronous tab loading, and fires an intent in order to launch the NTP, instead of just opening it in a tab. This is slightly complicated by some weird initialization ordering issues (why does CTA initialize the TabModels in initializeCompositor??) and that we still want new tab link clicks to open in CCT (to avoid breaking things that need multiple tabs alive at once, like oauth). Bug: 984019 Change-Id: Iea98cdc0936b374eb985643af8dbb040feeef946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742927Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#686457}
-
Xi Han authored
Fix ServicificationBackgroundServiceTest::testHistogramsPersistedWithServiceManagerOnlyStart fails on official bot. The test fails on the official bot due to the active field trial group size is 0. In this CL, we force a field trial "Foo/Bar" in the test. Thus, it guarantees at least there is one active field trial. Bug: 965482 Change-Id: Icdd84dd2e4ff22a17da3d7a7c9dd048529ac9ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752245Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686456}
-
Istiaque Ahmed authored
Move it under generic location so this can be reused in other places. Bug: 991464 Change-Id: I7cf9b227a04400ccf6dc92bffc72f2f493ac83ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725312 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686455}
-
Sky Malice authored
Bug: 992556 Change-Id: I6db46d4606948821a4faf30861e16180fff226c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752164Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#686454}
-
Tommy Li authored
This reverts commit 858d35cc. Reason for revert: Still seems to be causing issues: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak Original change's description: > Fix sending scrollend on main thread snap > > This CL sends scrollend event if GSE is being > handled on the main thread after the snap (if > the snap has started after GSE). It also takes > care of sending scrollend event for snap after > fling. > > This CL is exactly the same as previous CL that got reverted: > https://chromium-review.googlesource.com/c/chromium/src/+/1743253 > > with some modification to the test and input injection instrumentation > to solve the leak bots. > > TBR=bokan@chromium.org > > Bug: 907601 > Change-Id: I02f501573cb2021473df0b36f4c512b82e617fb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749790 > Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686424} TBR=bokan@chromium.org,nzolghadr@chromium.org Change-Id: I96aa049c04530fa392c79415fc6c2bb3b99af341 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752247Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686453}
-
Tricia Crichton authored
In W3C mode for ChromeDriver, the response format changed. Code was modified to extract sessionId from the new response format. Bug: chromedriver:3076 Change-Id: Iaf749fa480fcbe541d8b520357c4344c79241dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746787Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#686452}
-
Xida Chen authored
This class is using base::flat_map, which seems to be added by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 Notice that the flat_map.h is not included. It works fine for now, but can be a potential problem. For example, when I am working on my own CL: https://chromium-review.googlesource.com/c/chromium/src/+/1614120 There is a compilation error if flat_map is not included in this file. Bug: None Change-Id: I8d9be82945a322afba3d0a07bd8d79d7a9910495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746293Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686451}
-
James Cook authored
UX wants to show the GAIA avatar instead of the device account image. Bug: 990528 Test: added to browser_tests Change-Id: If56b065154b0690b7ce4ff9b3d520250575395cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750100Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#686450}
-
Thomas Tangl authored
This CL removes code paths of unused bubble view modes in ProfileMenuView and refactors related code. Bug: 966388 Change-Id: Icece4828989c61d8be9ac85de27874d934fa92ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751788Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#686449}
-
Lijin Shen authored
Update the color palettes so that Incognito and Dark mode share some same colors, including toolbars, text and icons. Bug: 985064 Change-Id: I512cfecf6774883bba935a20d56b03df8d2143a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742517Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#686448}
-
Shaojiang authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c267899484ba..7e90794dfac8 $ git log c26789948..7e90794df --date=short --no-merges --format='%ad %ae %s' 2019-06-24 alanlxl power_manager: Remove kScreenDimImminentSignal and kDeferScreenDimMethod 2019-07-15 zuan cryptohome: Add calls for obtaining RSUDeviceID to UserDataAuth and proxy 2019-08-02 victorhsieh system_api: rename BOOTLOCKBOX_ERROR_CANNOT_READ 2019-07-11 sjzhong system_api: Add AddDataRestoreKey and MassRemoveKeys in dbus-constants.h. Created with: roll-dep src/third_party/cros_system_api Bug: 977321 Change-Id: Id32afe66517a243302b90f7b1b182709e22b7562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750930Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Shaojiang Zhong <sjzhong@google.com> Cr-Commit-Position: refs/heads/master@{#686447}
-
Javier Ernesto Flores Robles authored
Use dynamic colors instead of static ones. Bug: 976675, 991209 Change-Id: I5750a55eb00de7ae510c9561c7bace2f1fac63c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749089 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686446}
-
Javier Ernesto Flores Robles authored
Looks like the original bug is fixed in MDC and these lines now are causing the opposite bug. Bug: 767428, 992935 Change-Id: I5604d5fdfd7b8225e4ef0cfd2a3eec629ff1d835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751329Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#686445}
-
Sigurd Schneider authored
Change-Id: I5022809873bb40787087d4b62d5cc3a412170a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751726 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#686444}
-
Yasmin authored
Bug: 988461 Change-Id: I2a4c6e5f64643db8349aaad4d54f15ac5961253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751790 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686443}
-
Mitsuru Oshima authored
Ash.WindowCycleController.CycleTime Ash.WindowCycleController.SelectionDepth Also added expiration date for other two to revisit on ms79. Bug: 975391 Test: NOne Change-Id: I1fa1ebebf85cf5f03e794c5cfec04567fe40b137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707551 Commit-Queue: Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#686442}
-
Christopher Thompson authored
Ask has confirmed that the suggest URL we had in our list is for legacy use only now and given us their new URL. (This new URL matches the hostname in the certificate served if you attempt to load the old URL over HTTPS.) Manually testing of the Baidu suggest URL shows that it now supports HTTPS, so this also updates it to use HTTPS in Chrome. Bug: 869453 Change-Id: I5f520f5e9abe0d08195d273847103757dd0309ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747980Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#686441}
-
Bruce Long authored
For Windows spellcheck, adding/removing word via language settings page should commit to platform custom dictionary. Fix is to make same calls to spellcheck_platform::AddWord and spellcheck_platform::RemoveWord that are performed when adding or removing a word using the spelling context menu. Bug: 993072 Change-Id: I97f9c91c0f5dfdce475f2f9e09fefc98efd44b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750105Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686440}
-
sczs authored
Bug: 979673 Change-Id: I82df2334bff60dd2867e336f7f7a89f9163ebd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750044Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686439}
-
Yuki Shiino authored
Exposed(A B, C D) is supported, but Constructors are not. Constructors will be supported separately. Bug: 839389 Change-Id: Ibc000c0c454478e006daa02a7246deae52da3f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752263Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686438}
-
Robbie Gibson authored
This CL also replaces the old uses of the Apple system colors with the Chrome-specific text colors. Bug: 976641 Change-Id: I1520252177ea0f12d18cd97d8b808e70af56b0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751330Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#686437}
-
Andrew Grieve authored
Change-Id: I3563d2fd96365635d9f9f623cddfb7dd5c881cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749003Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686436}
-
Caleb Raitto authored
Since the TestUrlRequestCallback used by the test uses the default encoding [1], the tests that use it should as well. [1] https://cs.chromium.org/chromium/src/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java?l=242&rcl=6970d0e3493e5aec7c655313ef717140e68f790a Change-Id: Ibdb32319a696fd9342a231c34eb235627712252c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747251Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686435}
-
Peng Huang authored
Bug: 974359 Change-Id: Idcc3c80eda39d4c94470c7f5542fea68dc65cc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751823 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686434}
-