GitLab

Without this Chrome is pushed out of the list of suggested apps
very soon after the profile creation and never comes back even
after it is launched.

Bug: 894898
Test: manual
Change-Id: I7d12958c1522336bf831d31b9288a6084cc5f974
Reviewed-on: https://chromium-review.googlesource.com/c/1338472
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612868}

Bug: 633246
Change-Id: Id6c302696c955401a991c0235d86f05d03019036
Reviewed-on: https://chromium-review.googlesource.com/c/1355045Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612867}

Bug: 875053
Change-Id: If25cd61692ec30ef590c8edf67c6960213196ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1351710
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612866}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b26f97ac1d28..2b881d5ca610


Created with:
  gclient setdep -r src-internal@2b881d5ca610

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:448088
TBR=mmoss@chromium.org

Change-Id: I1989164dfa570547ca9d40755e61bba8f3dc8867
Reviewed-on: https://chromium-review.googlesource.com/c/1357427Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612865}

Previously CacheStorage used some very large macros to record a number
of scheduler related histograms.  These macros produce a lot of code
bloat and are difficult to read.  This CL addresses those issues by
replacing the macros with functions.

Bug: 909894
Change-Id: Icc3adc91d72de2aeaac0f927c13f3e2bfb557e77
Reviewed-on: https://chromium-review.googlesource.com/c/1357400
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612864}

This reverts commit 8121da4a.

Reason for revert: Builder turned green while the revert was in flight, and the revert seems to have broken it.

Original change's description:
> Revert "[protoc] Use protoc's lite java plugin and runtime"
> 
> This reverts commit 8aa669ef.
> 
> Reason for revert: crbug.com/910759
> 
> Original change's description:
> > [protoc] Use protoc's lite java plugin and runtime
> > 
> > protoc the protobuf compiler now requires using a separate plugin for
> > compiling protos for the java lite runtime. The lite java runtime is now
> > also separate from the main java runtime and is distributed separately.
> > 
> > This cl switches java proto compilation for lite protos to this new
> > mode.
> > 
> > TBR=android_webview/BUILD.gn
> > 
> > Bug: 782237, 800281
> > Change-Id: I31c2d073bed51109dffeea133495679deef3186b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1340522
> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612720}
> 
> TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org
> 
> Change-Id: Ie2dce6e8c5ad03e6a75607a02e234c813f3072a5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 782237, 800281
> Reviewed-on: https://chromium-review.googlesource.com/c/1357571
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612826}

TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,oysteine@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org

Change-Id: Ia8b508fd7ab9c7c42cc976dc0827683da81a435f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 782237, 800281
Reviewed-on: https://chromium-review.googlesource.com/c/1357641Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612863}

If the same URL is suggested multiple times at once, it should only be added
once. I stumbled into this condition when using the test data for Feed.

Bug: 841516
Change-Id: I26b95e4c1b4e7ace1516e0a84187d9960d327aaa
Reviewed-on: https://chromium-review.googlesource.com/c/1351275
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612862}

This is a reland of d20781e1

The cl was reverted due to an internal dependency issue, which has been resolved. So TBR for the reland.
TBR=sammc@chromium.com, xiaohuic@chromium.com

Original change's description:
> Handle Open/Verify android apps for Assistant
>
> Bug: b/117793081
> Test: Manual Test
> Change-Id: If747d3317cb163715ff907839203e0c0eee57a1c
> Reviewed-on: https://chromium-review.googlesource.com/c/1352341
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612448}

Bug: b/117793081
Change-Id: I19268f1ad40deb7b77f68bb0f9a87e98154d55b9
Reviewed-on: https://chromium-review.googlesource.com/c/1356326Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612861}

Replace LearningTaskControllerImpl's do-nothing initial
implementation with one that:
  - constructs the training callback based on the learning task
  - collects training examples as they're added
  - re-train the model periodically.
  - record stats about model performance

Change-Id: I6a949e6188c71d00be5449dc9539508254c7d74a
Reviewed-on: https://chromium-review.googlesource.com/c/1355434
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612860}

Adds an inset when the shelf is auto hidden because we want the grid to
be centered as if the shelf is fully visible.

Test: ash_unittests WindowSelectorTest.GridBounds
Bug: 908679, 908982
Change-Id: Ibccfb0bab70d68a463c3325fa8ca3b7912d0dc65
Reviewed-on: https://chromium-review.googlesource.com/c/1354355Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612859}

Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.

Bug: 837753
Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03
Reviewed-on: https://chromium-review.googlesource.com/c/1357567Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612858}

The problem here is that between CachedImageFetcherImpl's FetchImage
invocation and completion, destroy was called on
InMemoryCachedImageFetcher. This causes an attempt to store the image
in a null bitmap cache. This just checks if the bitmap cache is null
before attempting to store an image.

Bug: 910080
Change-Id: I28b7aaee8588d883cfaf98328e2e58478d452375
Reviewed-on: https://chromium-review.googlesource.com/c/1355770Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612857}

This now searches for new-style URL and title pairs as well as
the old pboardtype.

BUG=851326

Change-Id: I00afe5ce5a3ca7e54648194bbf686b0fd85dad62
Reviewed-on: https://chromium-review.googlesource.com/c/1354259Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612856}

Previously the logging was done in ToolbarPhone. This meant that
Duet wasn't logging any of the new tab button clicks. This moves
the logging to the click handler.

Bug: 910682
Change-Id: I318ccdeffdb453e97cca8e3a203177b5db2f1791
Reviewed-on: https://chromium-review.googlesource.com/c/1357381
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612855}

It's not used any more.

BUG=none

Change-Id: I796312bbb32c0dcdef33ab0ea5b2c8472c7e853d
Reviewed-on: https://chromium-review.googlesource.com/c/1355612
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612854}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/020b59722ab0..b0ee5ee22d88


git log 020b59722ab0..b0ee5ee22d88 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 recipe-roller@chromium.org Roll recipe dependencies (nontrivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@b0ee5ee22d88

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I79c58b720add301baf7b40ab14c85cb50859ea35
Reviewed-on: https://chromium-review.googlesource.com/c/1357420Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612853}

This CL adds the functionality to have an aec group ID, which allow
Chromium to take actions that is specific for the echo canceller
parameter set that is being used in the Chrome Audio Server.

BUG=chromium:907917
CQ-DEPEND=CL:1349280,CL:1349353

Change-Id: I391fd0a65858a2635c8927dc2a8816dfb9cd4221
Reviewed-on: https://chromium-review.googlesource.com/c/1349260Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612852}

Change-Id: Idea90b5d7c13a961f9eeb0d144f0960f362b761f
Reviewed-on: https://chromium-review.googlesource.com/c/1357430Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612851}

Add uninstall menu option to Crostini apps that can be uninstalled from
the container.

BUG=chromium:822514
TEST=Apps from .desktop files associated with a package now have
'uninstall' on right-click menu; Apps from .desktop files I created do
not have 'uninstall'

R=timloh@chromium.org

Change-Id: If7bcd69c08a806b98a4200d2de7ca4f550c57c21
Reviewed-on: https://chromium-review.googlesource.com/c/1213519
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612850}

Change all PageVisibilityState enums to be just booleans of hidden or
not in the renderer side code. Prerender state is not needed any more
there for correctness. The only places that check explictly for
prerender are to generate strings, or in RenderFrameImpl in order to
pass a bool along. We can remove the former and pass along the bool
more explicitly in the latter case since RenderFrameImpl can query if
prerendering is taking place for the frame.

There are a few places that check for == kVisible or != kVisible. For
the == kVisible, prerendering is only used while the frame is not
visible per the comment being deleted in prerender_helper.h. So this
should not change behaviour as prerender == hidden from this
perspective.

For places that check == kHidden or != kHidden it could be a new
behaviour when it would have been kPrerender before:

Document::DispatchUnloadEvents() would if !kHidden then dispatch
a visibility change event. This would have occured if going to
prerender during unload. Since prerender is for pre-loading this
seems okay to not happen anymore.

LocalFrameView::ShouldSetCursor() would return true during prerender.
This is part of event handling which is after the page is transitioned
out of prerender state, so it should be okay to return false during
prerender now.

This also removes "prerender" from layout tests. Layout tests set a
prerender visibility state, which would just set to hidden internally,
and verify it works like hidden. Since prerender no longer exists in
the renderer, these tests would just be testing hidden twice, and
we can remove the prerender bits.

R=avi@chromium.org, dcheng@chromium.org, pasko@chromium.org
TBR=avi

Change-Id: I914f47f49b41cbf8080ff6271c2896c1a5dbf569
Bug: 908582
Reviewed-on: https://chromium-review.googlesource.com/c/1356120Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612849}

Previously the scheduler was being directly called by the
ChromeBrowsingDataRemoverDelegate when history was deleted. When this
happened, we cleared internal state and suppressed refreshes. This
sometimes coincided with when the FeedAppLifecycle cleared all stored
articles, but not very well. Particularly, when:
* Signing in
* Signing out
* Clear the cache

So instead, the scheduler is notified by the FeedAppLifecycle exactly
when all articles are cleared. A boolean is also passed along to inform
the scheduler which of the two states are we in. Did something get cleared
and we should suppress refreshing? Or do we now have no data and need to
refresh immediately.

Bug: 905959
Change-Id: I25c57022a0da52cc42746d265beae1c55f84d3ec
Reviewed-on: https://chromium-review.googlesource.com/c/1355994
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612848}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d5a8c686edd..f7efdde5887a


git log 1d5a8c686edd..f7efdde5887a --date=short --no-merges --format='%ad %ae %s'
2018-11-30 ahassani@chromium.org paygen: Do not run delta_generator in parallel


Created with:
  gclient setdep -r src/third_party/chromite@f7efdde5887a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifab5b57f51d8cb5afc26d67709399af9a9cdd0d7
Reviewed-on: https://chromium-review.googlesource.com/c/1357423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612847}

https://pdfium.googlesource.com/pdfium.git/+log/390ce238ca28..d60b5907958e


git log 390ce238ca28..d60b5907958e --date=short --no-merges --format='%ad %ae %s'
2018-11-30 tsepez@chromium.org Add WideString::CompareASCIINoCase().


Created with:
  gclient setdep -r src/third_party/pdfium@d60b5907958e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7dcd9654835963957f722e997cf7019fdd292e23
Reviewed-on: https://chromium-review.googlesource.com/c/1357426Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612846}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=jianli@chromium.org

Bug: 903957
Change-Id: I05eabae1bc94d675e26a59ba61d862d536a8513d
Reviewed-on: https://chromium-review.googlesource.com/c/1338394Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612845}

|display_id_to_renderer_| has dependency on aura. When used as
a mojo app, |aura_init_| provide aura and should be released
after it.

Bug: None
Change-Id: Ice4410def29166c77ebc8431fd62995c5dbe57f7
Reviewed-on: https://chromium-review.googlesource.com/c/1357082Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612844}

Change-Id: Ibb20b53b9e54e7612e7fe8b9c4c385eeb0f95741
Reviewed-on: https://chromium-review.googlesource.com/c/1357547Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612843}

Its pool currently has bots w/ a mix of core counts:
https://chromium-swarm.appspot.com/oldui/botlist?c=id&c=os&c=task&c=status&c=cores&f=builder%3ALibfuzzer%20Upload%20Mac%20ASan&l=100&q=cores&s=id%3Aasc

R=jbudorick

Bug: 790372
Change-Id: I0b5194a170c0e62b7768a0f7f05b6c4dde63b803
Reviewed-on: https://chromium-review.googlesource.com/c/1357526Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612842}

TBR=sebsg@chromium.org

Bug: 910627
Change-Id: Icb95e394739142d44f2c73a6408e7def8a03fa6f
Reviewed-on: https://chromium-review.googlesource.com/c/1357508Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612841}

Remove "options = {'story_tag_filter_exclude': 'is_4k,is_50fps'}"
This isn't really a good way to do this because of the following.

if you run the code like this:
$ ./tools/perf/run_benchmark run media.mobile --browser=android-chrome
then the filter will work:
   number of stories 22

but if you run the code like this then
$ ./tools/perf/run_benchmark run media.mobile --browser=android-chrome --story-tag-filter-exclude='other_tag'
then the filter will not work:
   number of stories 29 (which means the 4k stories and 50fps stories were not excluded.)
This is because the "options" simply sets the default "--story-tag-filter-exclude"
So when a user provides a different value, the default is overriden.

My change fixes this such that you can use that flag without side effects.
It also helps by making the other parts of the system be able to know
by default what stories are in the page_set. You can see that this is
true because the the autogenerated benchmark.csv file now has fewer
tags for media.mobile because of the filtered stories.


I am attempting to redesign this
system a bit for https://goo.gl/JZ2yZQ. I noticed this code.


Also remove
tag = 'android'
since it doesn't do anything.


Bug: 894254
Change-Id: Ibf5f90e83062c785934af334c8dd6bfde89cef25
Reviewed-on: https://chromium-review.googlesource.com/c/1356320
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612840}

This fixes a bug in the runner scripts which prevented SSH cred
generation for device boots, but allowed emulator run credentials to
be re-used. The issue only manifested on clean builds with no prior
emu runs.

Bug: 899285
Change-Id: Icfb2b734bf527b44cb671b08ee7d21563ae82a8c
Reviewed-on: https://chromium-review.googlesource.com/c/1355850Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612839}

The broken ordering of functions between AutofillClient and its five
subclasses has gotten out of hand.  This CL cleans them all up and makes
them consistent with each other (and between their own .h and .cc files)
so that we can keep them consistent as we move forward in this area.

This CL purely moves lines around, with the exception of one deleted
function prototype in chrome_autofill_client.h that I explicitly call
out.

This CL is diffbased on
https://chromium-review.googlesource.com/c/chromium/src/+/1351256.

Change-Id: I250600d555c064691d6c50fbd414ec85956fc6e7
Reviewed-on: https://chromium-review.googlesource.com/c/1352449Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#612838}

cmdevtools.css was looking for the dark theme class on the body in
order to apply its dark theme. When CodeMirror was attached
in a shadow dom, like in elements panel, this broke.

Bug: 901774
Change-Id: I67eab73721b8ba7642a862220bafa1cb0364146b
Reviewed-on: https://chromium-review.googlesource.com/c/1356231Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612837}

This change updates the people section to show a link to the Google
Account in case the current user is signed-in.

Bug: 907035
Change-Id: I51a5d4df2563a1c646377abba74d810f7a24a426
Reviewed-on: https://chromium-review.googlesource.com/c/1346049
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612836}

This CL resets |num_frames_at_client_| on surface set change to prevent
the previous state spilling over, as can be seen on e.g. [1] (trace
of crosvideo.appspot.com/?codec=vp9&cycle=true with two resolution
changes).

[1] https://i.imgur.com/wB7RI5V.png (https://imgur.com/a/eyhrbSq)

TBR=hiroh@chromium.org since the change is trivial and anyway
v_d_a_unit vp9 test work still on e.g. nocturne

Bug: 909926
Change-Id: Ifff5f2ec4538115320ea713b1b52709858da26a4
Reviewed-on: https://chromium-review.googlesource.com/c/1356898Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612835}

Allow one auth source that is passed in 'Authorization' header (it can
be: GAIA token, DM token or enrollment token) and one auth source that
is passed as query param (it can be OAuth2 token).
It will be further used to fetch child user policy with DMToken and
user OAuth2 token.

This is a part of larger change: passing credentials with child user policy
fetch.

Bug: 839025
Test: DeviceManagementRequestAuthTest/DeviceManagementServiceTest/DeviceManagementServiceIntegrationTest + manually
Change-Id: I84d77822452b6c1a320b30627cf7dfe54462f986
Reviewed-on: https://chromium-review.googlesource.com/c/1341063Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612834}

Bug: 910082
Change-Id: Ic3469bf58361ceafd39cc39bfc84450caa801dbb
Reviewed-on: https://chromium-review.googlesource.com/c/1356232Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612833}

Since the newer versions of VA-API are ABI compatible, relax the
version checks for VA-API, by using VA_CHECK_VERSION().
This will help in updating the libva to the latest releases,
while still supporting the old versions, till the new version of
libva is merged and picked by the builds. Thus ensuring that
hardware accleration is not broken while updating the libva.

Bug: 905814
TEST=libva-2.3.0 and libva-2.1.0 are able to do hardware acceleration.
Suggested-by: Alexandre Courbot <acourbot@chromium.org>
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Change-Id: I510549f72290d20676927eeeeb89a87199c062af
Reviewed-on: https://chromium-review.googlesource.com/c/1352519Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612832}

//build/config/linux/BUILD.gn is read by //build/config/compiler/BUILD.gn,
which means it is processed by both host and target toolchains.

Consequently, having the "atspi2" target there means "gn gen" can fail
because the host lacks atspi-2's development files even though they are only
needed by the target toolchain during the build.

Bug: 879147
Change-Id: I8780e6e4d3a2b3a44fdb2cbbb0862a1a669acdaa
Reviewed-on: https://chromium-review.googlesource.com/c/1356979Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#612831}

Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817
Reviewed-on: https://chromium-review.googlesource.com/c/1357513Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612830}

Bug: 909653
Change-Id: I3aeb33600e6cf01b2cccfd54d860830b04bff97b
Reviewed-on: https://chromium-review.googlesource.com/c/1355527Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612829}