GitLab

Ensure |blob_data_| is always initialized on successful codepaths even
when OnDataAvailable() is never invoked.

Bug: 863788
Change-Id: I08d0d73fa2a99c3d0b229c05f1c23377eb72f0b3
Reviewed-on: https://chromium-review.googlesource.com/1137956Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575507}

Most callers in chrome/browser/ui need just one helper:
GenerateApplicationNameFromExtensionId

All callers in chrome/browser/ui need just 3 helper functions from
chrome/browser/web_applications/web_app.h.
(See the CL code)

So let's move out these helpers. (No changes in behavior)

This change will allow us to break chrome/browser/ui dependencies on
chrome/browser/web_applications root target.

Also: this CL removes circular dependency between shell_integration_win.cc and
web_app.h

Next steps:
1) Remove web_app.h dependency in create_application_shortcut_view.h
2) Remove web_app.h dependency in shell_integration_linux.cc

Bug: 862049
Change-Id: I53242317d73cc3df5aae0bb61d17aa288fd51821
Reviewed-on: https://chromium-review.googlesource.com/1137953Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575506}

This moves CheckUserVerificationCompatible() from GetAssertionTask into
GetAssertionRequestHandler, and
CheckIfAuthenticatorSelectionCriteriaSatisfied() from MakeCredentialTask
into MakeCredentialRequestHandler.

These preconditions are now checked before dispatching a request onto a
FidoAuthenticator. This means, precondition checks now cover all types
of authenticators, not just FidoDeviceAuthenticator subtypes. The
FidoAuthenticator interface gets a new Options() method to support the
preconditions check (and an implementation for Touch ID is added).

Corresponding unit tests are moved from the FidoTask test into the
matching FidoRequestHandler test.

Also, remove AuthenticatorSelectionCriteria from the FidoTask class and
from the FidoAuthenticator::MakeCredential() signature, where it has
become superfluous due to this change.

Bug: 678128

Change-Id: I75259e63a8ef4fda4ecb0d8c9f8ff25f10c077a6
Reviewed-on: https://chromium-review.googlesource.com/1135601
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575505}

R=ericrk@chromium.org

Bug: 859635
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0afc80a877b5fdae5a4459bb5fa6f767ad842a7d
Reviewed-on: https://chromium-review.googlesource.com/1138750Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575504}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee72342a5342..9a962fc1e6e5


git log ee72342a5342..9a962fc1e6e5 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 dgarrett@google.com chrome_committer: Hardcode GCE service account.
2018-07-16 vapier@chromium.org lint: do not use yoda boolean statements
2018-07-16 tbrindus@chromium.org paygen: Clean up arguments in calls to delta_generator
2018-07-16 tbrindus@chromium.org paygen: Remove dependency on brillo_update_payload hashing
2018-07-16 tbrindus@chromium.org paygen: Remove usage of deprecated check_update_payload args


Created with:
  gclient setdep -r src/third_party/chromite@9a962fc1e6e5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifbf720f1ea1b067163a3c8c7925a6bad175c5ee1
Reviewed-on: https://chromium-review.googlesource.com/1139004Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575503}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8d3925b16482..fb734036f4b5


git log 8d3925b16482..fb734036f4b5 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 vadimsh@chromium.org [cipd] Update CIPD client to 2.1.0 (b9c4670197 -> 521b9b6477).


Created with:
  gclient setdep -r src/third_party/depot_tools@fb734036f4b5

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:794764
TBR=agable@chromium.org

Change-Id: I7f7b32f6845b0f30c32d1fe411c8c8e70a0ac705
Reviewed-on: https://chromium-review.googlesource.com/1138995Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575502}

This is a reland of [1] with a fix for animations not starting. This
patch adds a CompositorAnimationHost to LinkHighlights, similar to how
ScrollingCoordinator works, so that the link highlight timeline is
connected to an animation host. A basic test has been added.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1123315

Link highlights are currently owned by the WebViewImpl so their updates
(creation, deletion, layout, paint) happen entirely outside the main
LocalFrameView update lifecycle. In BlinkGenPropertyTrees we will need
to create foreign layers for link highlights which needs to happen after
the link highlight update (LinkHighlightImpl::UpdateGeometry) but before
blink does the cc update (PaintArtifactCompositor::Update). This patch
moves link highlights from WebViewImpl to Page which will let us manage
their lifecycle from the main blink lifecycle update.

This patch does not fix the issue of link highlights getting painted via
a cc paint callback, which will need to be fixed for SPV2, but this does
move us closer towards that goal.

Bug: 857501
Change-Id: I921594484f7b41844b3e2b49c6ef79458f0e7c5b
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1134413Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575501}

Bug: b:80186902
Change-Id: I64ff4ee52144ec15cfeedeeb1ab091aee18ea9e5
Reviewed-on: https://chromium-review.googlesource.com/1115512Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575500}

This class verifies that a MultiDevice host device (i.e., a phone) has
been enabled by listening for at least one of the known host features to
become enabled. If the host changes or if the host's features are
disabled, the device is no longer considered verified.

Bug: 824568
Change-Id: Ifa6ed67eb6eb5a77943fe0da3ebc653bb05a7370
Reviewed-on: https://chromium-review.googlesource.com/1136851
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575499}

This patch keeps all the assistant notifications in message center.

Bug: b/79493568
Test: manual.
Change-Id: If877634199fb1a0a7a269fe273d0cf6f3283cc15
Reviewed-on: https://chromium-review.googlesource.com/1137487Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575498}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e752946b94c..ed1bf6ade339


Created with:
  gclient setdep -r src-internal@ed1bf6ade339

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I84e351f08a398a52ab10f8fde0ff9d2c133b7f35
Reviewed-on: https://chromium-review.googlesource.com/1138997Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575497}

Makes XPositionForOffset and CharacterIndexForPosition support
return results inside a ligature glyph (while still not breaking ZWJs)
by using a character-based TextBreakIterator inside glyphs.

Bug: 473476
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I723cc8ba081958ff2d470d3e73ead6cbe327cf60
Reviewed-on: https://chromium-review.googlesource.com/1085554Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575496}

Bug: b/110219351
Test: Manual Test
Change-Id: I3ec437d4c7526c7b1b9187b4835870605268c7a9
Reviewed-on: https://chromium-review.googlesource.com/1136878
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575495}

Also update the component for bugs.

Bug: None
Change-Id: Ie14c76813048b360dbaab433ce81ac1dcfb3fdbd
Reviewed-on: https://chromium-review.googlesource.com/1131218Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575494}

In https://chromium-review.googlesource.com/c/chromium/src/+/991497,
calamity@ refactored this class such that it no longer derived from a
template base class.

However, that CL did not actually remove the template type from
MojoWebDialogUI, so this CL finishes that effort up. Additionally, since
the class is no longer a template class, I moved implementations of
functions from the .h file to the .cc file.

Bug: 824568
Change-Id: Ibabd6d4a282069f246821314ec71b4a5ac1c7bd4
Reviewed-on: https://chromium-review.googlesource.com/1138980Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575493}

BUG=762641
TBR=achuith@google.com

Change-Id: Idfabee601f9ca5639f0f40e50e8b8e69e2b29de6
Reviewed-on: https://chromium-review.googlesource.com/1138810Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575492}

https://chromium.googlesource.com/angle/angle.git/+log/242c4fe86801..e076a2327f0d


git log 242c4fe86801..e076a2327f0d --date=short --no-merges --format='%ad %ae %s'
2018-07-16 geofflang@chromium.org Vulkan: Fix ReadPixels checking the wrong FBO for flipping.


Created with:
  gclient setdep -r src/third_party/angle@e076a2327f0d

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I967a8af3dfb0aed055eb5811992cd3c314a0e6ee
Reviewed-on: https://chromium-review.googlesource.com/1138994Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575491}

This CL enables DetectingHeavyPages for android in
fiedtrial_testing_config.json.

Bug: 709493
Change-Id: I8896644a3838355b14b7fafb98815ddf968ae053
Reviewed-on: https://chromium-review.googlesource.com/1131687Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575490}

Currently, entering Picture-in-Picture multiple times from the same page
will reset the location of the window to the default location, or the
bottom right of the screen.

When the window has been moved, the user has indicated they want the
window positioned elsewhere. This change keeps the window origin, or
the top left corner coordinates, when the window bounds are updated.

Bug: 863710
Change-Id: I0cf0a23b549ef52bf06c78e28af6753e4735f186
Reviewed-on: https://chromium-review.googlesource.com/1137837
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575489}

Currently IME for phonetic languages such as Korean is pretty
broken in MacViews text fields. Even in stable, the last character
entered in a textfield ('ㅂ', say, from pressing 'q') will disappear
when pressing tab. A similar thing happens with the Return key in
the Omnibox. This is a huge dealbreaker.

Phonetic languages such as Korean and Vietnamese use an IME style
that doesn't _mark_ text while it is being composed. This breaks
some assumptions around how unicode insertText: events are attached
to ui::KeyEvents. It also comes with some weird behaviour from the IME
on macOS (e.g. sending 2 identical replaceText messages), adding extra
complexity.

The handling got extra bad after r565848 when attaching to a Tab key
could cause 2 focus changes while the IME was dismissing itself, causing
the input context to change again, thereby triggering an IME
dismissal recursively.

To fix these issues, only dispatch character events as a ui::KeyEvent
in insertText: when the character attached to the key event matches
the first unicode text given to insertText: (in addition to the other
checks). This prevents a tab keypress that dismisses an IME (and
inserts text) as being treated as a tab. But, for inline IME, we still
want to process that tab, so also leave it "unhandled" to be picked
up by the unhandled key event handler.

This also prevents recursive calls to updateWindows coming from known
client code. However, the badness is bad enough that we should also
protect against recursive calls. Add logic for that and test coverage
that simulates the IME interaction.

Test: Enable the "2-Set Korean" IME on Mac and interact with the omnibox.
E.g. pressing the return key should not cause the last character to
disappear (and not appear in the search result).

Bug: 860362
Change-Id: I04fc7d9590563413021de99921864ab079f9b044
Reviewed-on: https://chromium-review.googlesource.com/1128685Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575488}

This applies the same heuristic that Chrome uses to determine
whether a keyboard is showing before using the alternative sizing
path in the CompositorViewHolder introduced to handle keyboard
input while in fullscreen.

This is to avoid any further glitches when viewing video content.

BUG=852297

Change-Id: I2cf3372e8c607bee500ab31f8b876381b11fca7d
Reviewed-on: https://chromium-review.googlesource.com/1138853Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575487}

Bug: 790612, 815027, 790613, 790615, 790620, 790608
Change-Id: I6c772f051ed83d29e1a13c48cccf1c2f7b94e094
Reviewed-on: https://chromium-review.googlesource.com/1116185Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575486}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I33d2163e45e439d1ce109f17afeded9c11171381
Reviewed-on: https://chromium-review.googlesource.com/1136004Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575485}

This reverts commit 2f0772ee.

Reason for revert: Suspected to cause failure in AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping

Original change's description:
> Remove PlatformAccelerator.
> 
> ui::Accelerator had a member platform_accelerator() which was only used on
> macOS, and provided redundant information. This CL removes the member.
> 
> Change-Id: Ib3954a2c8ff7197606c946e207dd5d3bd75af66d
> Bug: 846893, 702823
> Reviewed-on: https://chromium-review.googlesource.com/1135644
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575429}

TBR=thakis@chromium.org,erikchen@chromium.org

Change-Id: I3f142628a1ab406028a5f64db7d6acdf13c4d41b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846893, 702823, 864272
Reviewed-on: https://chromium-review.googlesource.com/1139153Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575484}

When we make a request to a server that's different than the server that
delivered the NEL policy, we now have to "downgrade" the report to only
include information that's available during DNS resolution.

Bug: 862188
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ied45aecbab00d9041a77cf7cf1f6e830726f6716
Reviewed-on: https://chromium-review.googlesource.com/1136031
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575483}

Adds a callback to DRPRequestOptions which forwards the CP header to
DRPService via DRPIOData.

Bug: 864187
Change-Id: I3c326386986a73cdbad418fa06783de4e6f3b239
Reviewed-on: https://chromium-review.googlesource.com/1138979
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575482}

The test is consistently timing out on all Mac testers

Bug: 864250
Change-Id: I493aa756176c5df2b7333bd36beb84895e6e2711
NoTry: True
Tbr: miu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1139002Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575481}

This should make LogDog output much easier to read. Example:
https://build.chromium.org/deprecated/chromium.infra.codesearch/builders/codesearch-gen-chromium-chromiumos/builds/2959/steps/run%20translation_unit%20clang%20tool/logs/stdio

Change-Id: I22a2da16b248f5382822c78580f50a0e9ee13d23
Reviewed-on: https://chromium-review.googlesource.com/1137808Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575480}

For issue 817341, fuzzer tests were taking a long time due to calls to
std::vector<uint8_t>::resize(), as it initializes each element one by
one. Switching to std::unique_ptr<uint8_t[]> speed things up, as the
elements are not initialized. As VideoResourceUpdater allocates a
temporary buffer to hold a video frame, it could also benefit from the
improved execution time.

BUG=817341
TEST=media_unittests pass

Change-Id: I63c1afce3eb6b654c8863a555642ee3e05c1c883
Reviewed-on: https://chromium-review.googlesource.com/1137063Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575479}

When the context menu is closed, destroy the menu model asynchronously,
so that its command gets executed before the menu model is destroyed.

Bug: 861652, 861655
Change-Id: Id0bf068e600f13ab187c0ad137ca15979363c61f
Reviewed-on: https://chromium-review.googlesource.com/1130657
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575478}

Stores a mount call if host discovery is not yet complete and runs it as
soon as the first share names start coming back, indicating that host
discovery is complete.

The mount can be attempted before share discovery is complete because
mounting via a hostname is only dependent on host discovery for name
resolution.

Bug: 757625, 863178
Change-Id: If53ec9061c79a4f408278be4ddd990a7c9ca3791
Reviewed-on: https://chromium-review.googlesource.com/1136528Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575477}

WebRTC has replaced the metrics logging that uses
the MetricsObserverInterface with the RTC_HISTGORAM_* macros, and will
deprecate MetricsObserverInterface shortly.

Bug: None
Change-Id: I78c94e44f049e4e306fa64f87750c954ebcd841c
Reviewed-on: https://chromium-review.googlesource.com/1123682Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#575476}

This is for downstream usage.

Bug: 830062
Change-Id: I371a8050f186166bcdda818b5a8fd31b41799a67
Reviewed-on: https://chromium-review.googlesource.com/1137705Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575475}

This change fixes a bug when re-rendering the list of passwords after a
password store mutation. This bug could give the impression that a wrong
password was deleted.

Bug: 862119
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I13f42a18567f84e191e99a2beb6d00ee7e82e682
Reviewed-on: https://chromium-review.googlesource.com/1138233Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575474}

Revert "[IO] Only compute intersection observations if any property tree state has changed, and only for full-frame updates."

This reverts commit cdea59c0.

Reason for revert: Suspect of causing flakes in SitePerProcessBrowserTest.ChildFrameCrashMetrics_ScrolledIntoView

Original change's description:
> [IO] Only compute intersection observations if any property tree state has changed, and only for full-frame updates.
> 
> This avoids re-computing intersection observations when nothing has changed.
> 
> It is correct for IOv1 and also IOv2. It is correct for IOv2 because at present
> IOv2 and hit testing do not depend on paint output.
> 
> Bug: 831762
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I196ca3a64e26d2227bc8cbb6b73ea81c1adbb4b2
> Reviewed-on: https://chromium-review.googlesource.com/1134348
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574755}

TBR=szager@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831762, 863946
Change-Id: I30ab56ebce4cb3e677623f7663eb2795b0201274
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1138894Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575473}

This patch revives some overflow menu code from ye-olde days of Chrome
Home with a sprinkle of new-age technology
(see https://codereview.chromium.org/2821223004 for the original
patch). More specifically, AppMenuIconRowFooter, icon_row_menu_footer,
and app_menu_button_tint have been revived almost exactly as they
were.

Now, when Duet is enabled the icon row is placed at the bottom of the
overflow menu to make it easier to reach with one hand.

The major difference between this and Chrome Home's version is how the
bottom icon row is initialized. This patch adds
AppMenuPropertiesDelegate#onFooterViewInflated() which gives delegates
the opportunity to make changes to the view immediately
post-inflation.

This patch breaks the data-saver menu promo while Duet is enabled,
this will be fixed in a follow-up patch which places it at the top
of the menu.

Bug: 847632
Change-Id: Iac44bdc2880c118b97102ef074134a6f13b50da0
Reviewed-on: https://chromium-review.googlesource.com/1135892
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575472}

When the page transition is PAGE_TRANSITION_AUTO_TOPLEVEL, mark in the
referrer chain that this URL could have come from an external
application. This will have no false negatives, but could have false
positives, such as session restore.

Change-Id: I3ab11016021426447b8bbe1fca94b8133793b0e4
Bug: 862216
Reviewed-on: https://chromium-review.googlesource.com/1131686
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575471}

Adding a new attribute to the TextMetrics object to expose glyph
advances for a given text. This will be a list of pixel widths for each
glyph in the text measured in pixels from the text alignment origin in
the text direction (rtl or ltr).

Added some basic test and commented some edge cases that we still
need to resolve.

Bug: 853376, 277215
Change-Id: I7df30ce493c843032d974ca79ca793c89b318d82
Reviewed-on: https://chromium-review.googlesource.com/1134202Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575470}

Bug: 861996
Change-Id: Ie3d579b3d59ba230ceec5229b2aebb3921deeda2
Reviewed-on: https://chromium-review.googlesource.com/1138801Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575469}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: I83ee6e6280999c9e2b51a0ea3b1cee3d030cfd3f
Reviewed-on: https://chromium-review.googlesource.com/1128095Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#575468}