GitLab

BUG=417463

Review URL: https://codereview.chromium.org/636233004

Cr-Commit-Position: refs/heads/master@{#299444}

Based on a recent crash reports, there is a suspicion that PasswordAutofillAgent::provisionally_saved_forms_ gets NULL WebFrame pointers assigned as keys. That's likely happening in TextDidChangeInTextField(), when ProvisionallySavePassword() is called with element.document().frame(). That can be NULL, as the comment at blink::Document::frame() says.

This CL makes sure that forms for which we don't know the frame are not provisionally saved.

It is still unclear to me, how to reproduce this crash, so I have no idea how to reproduce it in tests. Therefore this CL does not add tests. There is a bug (400186) filed for making PasswordAutofillAgent observe frames directly, which should ultimately clean up this mess anyway.

BUG=420519

Review URL: https://codereview.chromium.org/649583003

Cr-Commit-Position: refs/heads/master@{#299443}

Revert of Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard (patchset #3 id:40001 of https://codereview.chromium.org/638663003/)

Reason for revert:
The if statement is incorrect. `if 'override' or 'final' in line` === `if 'override'`, because string constants are always true. This means that no one can upload patches, which is a bit annoying.

Please fix in a subsequent patch.

Original issue's description:
> Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard
>
> Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively
>
> BUG=417463
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/f6935316b438a3848141644c9d10098de3da0a2d
> Cr-Commit-Position: refs/heads/master@{#299435}

TBR=avi@chromium.org,maruel@chromium.org,mohan.reddy@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=417463

Review URL: https://codereview.chromium.org/659443002

Cr-Commit-Position: refs/heads/master@{#299442}

Revert of Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl). (patchset #4 id:50001 of https://codereview.chromium.org/621823003/)

Reason for revert:
Some sites become "unresponsive" i.e. they work but have no ui changes. and the user need to switch between tabs in order of getting the actual page.

Original issue's description:
> Making scheduler run ANIMATE after a COMMIT (instead of LayerTreeHostImpl).
>
> This moves the logic from the LayerTreeHostImpl into the scheduler which means
> only ScheduledActionAnimate now updates animation state.
>
> The further extends the work in http://crrev.com/206793003
>
> BUG=346230
>
> Committed: https://crrev.com/7fa5729cf6ac490cc3b257b7eb8093dcd1285e3a
> Cr-Commit-Position: refs/heads/master@{#298396}

TBR=ajuma@chromium.org,skyostil@google.com,brianderson@chromium.org,danakj@chromium.org,skyostil@chromium.org,mithro@mithis.com
NOTREECHECKS=true
NOTRY=true
BUG=346230

Review URL: https://codereview.chromium.org/653013002

Cr-Commit-Position: refs/heads/master@{#299441}

Cr-Commit-Position: refs/heads/master@{#299440}

Modifed the content api RenderProcessHostObserver::RenderProcessExited to remove the ununsed & invalid ProcessHandle parameter

ProcessHandle(pid_t) will be 0 when RenderProcessExited observer API called. There is no use for this parameter to be present as the value is 0 and none of the callers is using this parameter.
BUG=

Review URL: https://codereview.chromium.org/644473004

Cr-Commit-Position: refs/heads/master@{#299439}

Removed the no-longer-used Last Launched and Installed time from the App
Info dialog.

BUG=398717

Review URL: https://codereview.chromium.org/658443002

Cr-Commit-Position: refs/heads/master@{#299438}

This is only taking a long time on Debug, because of the additional iterator
validators running on all the stl objects being used.

BUG=101614

Review URL: https://codereview.chromium.org/647093002

Cr-Commit-Position: refs/heads/master@{#299437}

All calls to this were removed in
https://codereview.chromium.org/628823003/.

BUG=414363

Review URL: https://codereview.chromium.org/652123002

Cr-Commit-Position: refs/heads/master@{#299436}

Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively

BUG=417463
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/638663003

Cr-Commit-Position: refs/heads/master@{#299435}

The list of optional arguments is growing. Each new added one, required changes
in tens of places.

To resolve this problem, this CL creates a MountOptions struct. As a result
adding a new optional argument to mounting will not require updating all
callers.

TEST=unit_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/624903002

Cr-Commit-Position: refs/heads/master@{#299434}

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/646803005

Cr-Commit-Position: refs/heads/master@{#299433}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/67f2d3c..d2e7dfb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/658433002

Cr-Commit-Position: refs/heads/master@{#299432}

BUG=None
TEST=None
TBR=oshima

Review URL: https://codereview.chromium.org/657463002

Cr-Commit-Position: refs/heads/master@{#299431}

BrowserVersion's functionality has been supplanted by ChromeVersionInfo.

Review URL: https://codereview.chromium.org/637283003

Cr-Commit-Position: refs/heads/master@{#299430}

Fix command line flag passing to crash_reporter to be of the form
"--key=value" instead of "--key value", as crash_reporter now uses
base::CommandLine to do parsing, which doesn't support the latter
format.

BUG=422094

Review URL: https://codereview.chromium.org/649443002

Cr-Commit-Position: refs/heads/master@{#299429}

user_scrollable_x/y are used to suppress impl-side scrolling when the
page specifies overflow: hidden.  This has been disabled for a while
because of poor interaction with pinch zoom.  In the new pinch-virtual
model, this works better (outer viewport doesn't scroll so that the user
can't see parts of the page not intended to be seen, but pinch zooming
and moving around still works), so re-enable it when that setting is
active.

Note that I'm also planning to start using this for disabling scrolling
for fullscreen elements.

BUG=322223,175502,411072

Review URL: https://codereview.chromium.org/626403003

Cr-Commit-Position: refs/heads/master@{#299428}

This patch will work after https://codereview.chromium.org/620553012/ is landed.

BUG=372759
TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker
This must be executed after commenting out '@benchmark.Disabled' in tools/perf/benchmarks/service_worker.py.

Review URL: https://codereview.chromium.org/627593002

Cr-Commit-Position: refs/heads/master@{#299427}

Soon after CC initialization when the layer tree doesn't exist yet, the
top controls delta can still be set.  In that case, an early return in
LTH::ApplyScrollAndScale doesn't forward the value to Blink -- the
"sent_" value is misleading here, and this causes the delta to get
clobbered on the next commit.  Avoid this scenario by matching the
LTH-side early-return in LTHI.

NOTRY=true
BUG=423139

Review URL: https://codereview.chromium.org/647753004

Cr-Commit-Position: refs/heads/master@{#299426}

The motivation behind this merge is to create a single place
that manages the browser & tab state before running multiple
page, before running each page, after running each page, and
after running multiple pages. Next patches will refactor
this _RunState object to SharedPageState as planned in
https://docs.google.com/a/google.com/document/d/1on2ATPE8Y7a0SLcd4cl3nAiSthVpVLU6OoVZatEavEA/edit.

Besides the merging of PageState and RunState, this patch
also renames _RunPage -> _RunPageAndProcessErrorIfNeeded
and _PrepareAndRunPage -> _RunPageAndRetryRunIfNeeded to
clear up the distinction what each of these functions does.

BUG=418278

Review URL: https://codereview.chromium.org/652813002

Cr-Commit-Position: refs/heads/master@{#299425}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/07894c4..67f2d3c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/654783002

Cr-Commit-Position: refs/heads/master@{#299424}

This CL introduces RoutingIDIssuer which tracks issued routing
ID per RenderProcessHost and let the Host class verify
routing ids to get routed.

TEST=routing_id_issuer_unitteest.cc
R=jam@chromium.org, sky@chromium.org
TBR=mattm@chromium.org
BUG=381990, 415059

Review URL: https://codereview.chromium.org/643733002

Cr-Commit-Position: refs/heads/master@{#299423}

* Add enrollment status to proto
* Remove stages not handled by HostPairingController, and ControllerPairingController.
* UpdateScreen sends update status via remora_controller.
* EnrollmentScreen sends enrollment status via remora_controller.
* Remove auth_token_ from EnrollmentScreen.
* Rename to shark_controller and remora_controller in WizardController.
* Remove get_initial_status_ from BluetoothControllerPairingController.

Review URL: https://codereview.chromium.org/652743003

Cr-Commit-Position: refs/heads/master@{#299422}

r297913 introduced the bug that if another activation happens
during a page scale animation, it's clobbered by a null pointer.
Only copy into LTHI::page_scale_animation_ when the LTI has an instance
of it.

NOTRY=true
BUG=419450

Review URL: https://codereview.chromium.org/650353003

Cr-Commit-Position: refs/heads/master@{#299421}

Revert of [Easy Unlock] Port the BluetoothConnectionFinder class to native code. (patchset #4 id:320001 of https://codereview.chromium.org/633253002/)

Reason for revert:
Causes compile failure on mac:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/75518

Original issue's description:
> [Easy Unlock] Port the BluetoothConnectionFinder class to native code.
>
> A couple of pieces are left as TODOs for future CLs:
>   * Porting the "seek device by Bluetooth address" feature.
>   * Wiring up a screen lock state accessor.
>
> BUG=420946
> TEST=components_unittests
> R=tengs@chromium.org
>
> Committed: https://crrev.com/ac4df1c4df6fdc7c771eb0bdeb15dbd6f2dbb98c
> Cr-Commit-Position: refs/heads/master@{#299415}

TBR=tengs@chromium.org,isherman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420946

Review URL: https://codereview.chromium.org/651073002

Cr-Commit-Position: refs/heads/master@{#299420}

For every two problems that C++11 causes, it fixes at least one.

R=thestig@chromium.org,tsepez@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/647753003

Cr-Commit-Position: refs/heads/master@{#299419}

R=jochen@chromium.org,falken@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/653593003

Cr-Commit-Position: refs/heads/master@{#299418}

This adds several performance tests for CSS Transitions
initiated in various ways.

BUG=309981,421733

Review URL: https://codereview.chromium.org/399393002

Cr-Commit-Position: refs/heads/master@{#299417}

* Remove unneeded includes, using, etc
* Use base::debug::ConvertableToTraceFormat
* Fix up some comments
* Make const a global var

BUG=

Review URL: https://codereview.chromium.org/649683004

Cr-Commit-Position: refs/heads/master@{#299416}

A couple of pieces are left as TODOs for future CLs:
  * Porting the "seek device by Bluetooth address" feature.
  * Wiring up a screen lock state accessor.

BUG=420946
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/633253002

Cr-Commit-Position: refs/heads/master@{#299415}

This CL adds a new 'noUnderline' enum value in the segment style in
chrome.input.ime.setComposition().

BUG=407576
TEST=Verified on linux_chromeos with a test IME extension.

Review URL: https://codereview.chromium.org/639103003

Cr-Commit-Position: refs/heads/master@{#299414}

Previously, we just used ugly numbered names as the local names for modules in
JavaScript. Now we try to use a meaningful name based on the name of the
module.

There shouldn't be any behavior change.

R=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/653793002

Cr-Commit-Position: refs/heads/master@{#299413}

The only change since the previous revision is unconditionally using
static_assert in third_party/macros.h.  This gets rid of the old code that used
ALLOW_UNUSED and will ensure there are no conflicts of any kind as I change how
the version of ALLOW_UNUSED in Chromium works.

BUG=81439
TEST=none
TBR=jam

Review URL: https://codereview.chromium.org/654783003

Cr-Commit-Position: refs/heads/master@{#299412}

BUG=231160

Review URL: https://codereview.chromium.org/650293002

Cr-Commit-Position: refs/heads/master@{#299411}

Update the perf expectations for nacl_helper-data to reflect the
binary size improvements from the recent ICU work.

BUG=
TBR=maruel@chromium.org,govind@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/655683002

Cr-Commit-Position: refs/heads/master@{#299410}

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/656663002

Cr-Commit-Position: refs/heads/master@{#299409}

Tighten finch check a bit so that the missing trial is treated as disable.

BUG=423016

Review URL: https://codereview.chromium.org/649223003

Cr-Commit-Position: refs/heads/master@{#299408}

R=felt@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/656523002

Cr-Commit-Position: refs/heads/master@{#299407}

Currently, the lint warns at:
AccountsAdapter.java:29 Unconditional layout inflation from view adapter:
    Should use View Holder pattern (use recycled view passed into this method
    as the second parameter) for smoother scrolling: ViewHolder [warning]

This CL fixes the above lint error.

BUG=327768

Review URL: https://codereview.chromium.org/628133003

Cr-Commit-Position: refs/heads/master@{#299406}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef3851c..4c8283b

TBR=caseq@chromium.org,apavlov@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/653783002

Cr-Commit-Position: refs/heads/master@{#299405}