- 11 Dec, 2018 40 commits
-
-
Dave Tapuska authored
CSS Font Loading spec refers a font-loading task queue. Add a queue matching that name and update it to use that queue. Change-Id: I885962521f2a17f3b35b181d3dc1066cc86a4e6e Reviewed-on: https://chromium-review.googlesource.com/c/1370707 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615529}
-
Sami Kyostila authored
This patch fixes a problem in the Mac message pump where we kept calling Delegate::DoDelayedWork even if a previous call to Delegate::DoWork caused the runloop to quit. This matches the behavior outlined in message_pump.h[1] as well as that of the other platform-specific pumps. We also introduce a message pump unit test that verifies behavior across all message pump types. Bug: 891670 [1] https://cs.chromium.org/chromium/src/base/message_loop/message_pump.h?rcl=a28a6097182e739c4a8c600b538fcc07681fc7a3&l=58 Change-Id: I00ccb5c55ac8551259a2febd343ec64fdd55630d Reviewed-on: https://chromium-review.googlesource.com/c/1370367Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615528}
-
David 'Digit' Turner authored
This CL fixes compile_resources.py to ensure that it correctly includes missing localized strings into the final APK. The problem was that some android_resources() targets declared some Filipino resources under values-fil/ directories, and some Indonesian ones under values-in/ 'fil' is a 3-letter ISO 639-2 language code, that was not supported before Android 5.0/Lollipop. Hence, our script only tried to include strings from 2-letter locale qualifiers, excluding the -fil one entirely. Due to the problem above, most packages place their localized strings for Filipino are placed under 'values-tl/' instead, because 'tl' matches Tagalog, a related but lesser spoken language in the Philippines. Except a few packages that still use values-fil/, for examples see [2]. 'in' is a new 2-letter ISO 639-2 language code, but due to compatibility concerns, our script wants to use 'id' instead for the Indonesian language (see [1] for a little bit more details). A few packages provide their localized strings for Indonesian under values-in/, which was ignored [3]. This CL fixes the issue by renaming "newer" locale qualifiers to "older" ones. This is done by extracting the qualifier from values-<locale>, converting it to its Chromium version, then back to its Android version. In practice it also deals with BCP 47 codes, as in: values-fil/ -> values-tl/ values-in/ -> values-id/ values-b+en+US -> values-en-rUS/ The last example above is not relevant, but opens the door to supporting more locales in Chromium in the future. The end result is adding missing localized strings for Filipino and Indonesian for 30 string resources (listed below). This ends up increasing the size of MonochromePublic.apk by about 2000 bytes. BUG=921044 R=agrieve@chromium.org,estevenson@chromium.org,yfriedman@chromium.org,torne@chromium.org [1] https://developer.android.com/reference/java/util/Locale The section in the Locale() constructor that reads: * ISO 639 is not a stable standard; some of the language codes it defines (specifically "iw", "ji", and "in") have changed. This constructor accepts both the old codes ("iw", "ji", and "in") and the new codes ("he", "yi", and "id"), but all other API on Locale will return only the OLD codes. Older Android system releases could only read compiled resources from obsolete config locale qualifier (e.g. 'in' for Indonesian). [2] https://cs.chromium.org/chromium/src/third_party/feed/src/src/main/java/com/google/android/libraries/feed/basicstream/internal/viewholders/res/?q=values-fil&sq=package:chromium&dr [2] https://cs.chromium.org/search/?q=values-fil/&sq=package:chromium&type=cs [3] https://cs.chromium.org/search/?q=values-id/&sq=package:chromium&type=cs [4] List of affected string resources: back_button_content_description cancel_button dialog_button_got_it dialog_button_open_help_center dialog_message_incompatible_phone dialog_message_no_cardboard dialog_title dialog_title_incompatible_phone dialog_title_vr_core_not_enabled dialog_title_vr_core_not_installed dialog_title_warning dialog_vr_core_not_enabled dialog_vr_core_not_installed go_to_playstore_button go_to_vr_listeners_settings_button more_button_label no_browser_text no_suggestions place_your_phone_into_cardboard place_your_viewer_into_viewer_format settings_button_content_description setup_button snackbar_fetch_failed snackbar_fetch_no_new_suggestions suggestions_section_empty switch_viewer_action switch_viewer_prompt zero_state_text_afternoon zero_state_text_evening zero_state_text_morning To obtain this list, process the unoptimized resources archives (where resource names are not obfuscated) as follows: aapt dump resources \ out/Release/obj/chrome/android/monochrome_public_apk.unoptimized.ap_ | \ sed -e 's/d=0x[0-9a-f]*//g' > /tmp/A/Resources.txt Do this for the build before and after this CL is applied and compare the results. The 'sed' part is used to get rid of irrelevant differences in each resource allocation. Change-Id: I4a7d961d68de381106347072a69eda6751d1bf7f Reviewed-on: https://chromium-review.googlesource.com/c/1367730 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615527}
-
Justin DeWitt authored
This causes a lint error on the official builders. Bug: 894334,913755,913012 Change-Id: I9dbaa9932873755639d22618b3d758ef87c840cb Reviewed-on: https://chromium-review.googlesource.com/c/1370587Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615526}
-
Oleh Prypin authored
The Android test runner, when retries were enabled, previously would overwrite the isolated-script-test-perf-output JSON file with the latest try, which means that all previous results would be lost. Now it will still write to the provided 'file-name.json' first, but then for following tries it will write to 'file-name_1.json', 'file-name_2.json', etc., which can allow to salvage the results in post-processing. Unrelated change in behavior due to refactoring: --app-data-file previously used this naming scheme for outputs: ['file-name_0.ext', 'file-name_1.ext', ...]; now it's ['file-name.ext', 'file-name_1.ext', ...]. Bug: 755660 Change-Id: Id8ecb506ef91504b925178b433544faa3db8c476 Reviewed-on: https://chromium-review.googlesource.com/c/1371426 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615525}
-
Alex Clarke authored
As a temporary measure add an aliased variable to record the size of the queue. Bug: 912541 Change-Id: I874fcc7cb463b3b891fbe875d42539e72d771767 Reviewed-on: https://chromium-review.googlesource.com/c/1371809Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615524}
-
Maxim Kolosovskiy authored
According to metrics, 0.3% of forms have >100 fields (the current limit), increase the limit to 250 in order to cover all forms. Autofill throttling limits the number of queries/uploads are sent for a given form by a given user. Therefore, uploading huge forms wouldn't flood network. Bug: 857454 Change-Id: Ia92a3d6f2033159df121d8728a263c70ee7914f7 Reviewed-on: https://chromium-review.googlesource.com/c/1369772Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615523}
-
Friedrich Horschig [CET] authored
This test is consistently failing on Mac since the last wpt roll. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913932, 626703 TBR=robertma@chromium.org Change-Id: I071d68a9003edecf4b24b10b4adfe1c86cf7da61 Reviewed-on: https://chromium-review.googlesource.com/c/1371904 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615522}
-
Tim Schumann authored
Change-Id: I1b762a554913d0e3b3df0792c2ff845c4dde5a53 Reviewed-on: https://chromium-review.googlesource.com/c/1370365Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#615521}
-
Friedrich Horschig [CET] authored
This reverts commit d1317fc3. Reason for revert: SyncSchedulerImplTest is failing and this is the most likely culprit. More information in the linked bug. Bug: 913946 Original change's description: > [Reland #3] Use the SequenceManager in ScopedTaskEnvironment > > A reland of https://crrev.com/c/1324391 > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI and IO threads. > > RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing > mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems > to have fixed this. > > > TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1361863 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615496} TBR=wez@chromium.org,gab@chromium.org,fdoray@chromium.org,skyostil@chromium.org,alexclarke@chromium.org Change-Id: If5ff0362758b5270eb3113d2fd6eeeb7facc37c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341, 891670, 708584 Reviewed-on: https://chromium-review.googlesource.com/c/1371811Reviewed-by:
-
Andrew Grieve authored
These classes need to be the same across releases. Bug: 913116 Change-Id: I57dc8928f24944f0234863f5fcfc248886c6a7cc Reviewed-on: https://chromium-review.googlesource.com/c/1371244Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615519}
-
Florent Castelli authored
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/LXJUzctTVfM/p4J-WrzbBgAJ Bug: 908911 Change-Id: I8e82cc588fb991458e2372fe1dcb9db459cd36b5 Reviewed-on: https://chromium-review.googlesource.com/c/1363276Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615518}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c2ff12d419d..152255fcc745 git log 3c2ff12d419d..152255fcc745 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com Fix test failure on is_debug. Created with: gclient setdep -r src/third_party/perfetto@152255fcc745 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If77220fecdba346d3506e552c69fa9d8ed3ffeb8 Reviewed-on: https://chromium-review.googlesource.com/c/1371709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615517}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/757effd70e5f..84629852e33d Created with: gclient setdep -r src-internal@84629852e33d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic04ded354bf2c823a6c08eec6163ed351980325c Reviewed-on: https://chromium-review.googlesource.com/c/1371708Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615516}
-
Rayan Kanso authored
The handler uses the side data blob to store the request body if any. Bug: 774054 Change-Id: I14ec3e992543937bef7a601bcb603103842c6acf Reviewed-on: https://chromium-review.googlesource.com/c/1363205 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#615515}
-
Joe Mason authored
The logo now has a title attr in it for screen readers. But when it's set as the background of a <span>, or as an <img> src, screen readers don't look at the tags inside. For the screen reader to view the tag it seems the <svg> element must be part of the DOM tree. So after the <svg> element is loaded from a resource, add it directly to the page. R=hcarmona@chromium.org Bug: 767130 Change-Id: I1de73057ba59df114fdb142baab9fc66f210995f Reviewed-on: https://chromium-review.googlesource.com/c/1370833Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615514}
-
Marc Treib authored
Bug: none Change-Id: I8f0360e7f3ff166aa321a9041b6dd5865dcf5988 Reviewed-on: https://chromium-review.googlesource.com/c/1371425 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615513}
-
Friedrich Horschig [CET] authored
This reverts commit 05142837. Reason for revert: Added test flakes on most Mac versions. Bug: 913939 Original change's description: > Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3 > > The new test is similar to the existing PersonalDataManagerSanity test, > but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE > histogram. > Compared to PersonalDataManagerSanity, the new test skips the step of > adding a duplicate profile, since that seems to produce flaky results. > > Bug: 904390 > Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09 > Reviewed-on: https://chromium-review.googlesource.com/c/1369778 > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615461} TBR=treib@chromium.org,jkrcal@chromium.org Change-Id: I1da849dfe70d5523b8d211d0d6d592c101672456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904390 Reviewed-on: https://chromium-review.googlesource.com/c/1371888Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff281cc4..9a1b0e72 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3e47c4585c77e1d6a0a9a4a259a13889ec47031 Reviewed-on: https://chromium-review.googlesource.com/c/1371645Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615511}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 447dc435. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I42c4d57343eac3172b9e4a303d7cff1eac201f89 Reviewed-on: https://chromium-review.googlesource.com/c/1371644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615510}
-
Moe Ahmadi authored
- Removes dependency of :popup_menu_ui to the tools popup menu and navigation popup menu logic, i.e., PopupMenuCommands, coordinator, and mediator, allowing it to be reused in the new translate infobar for the language selection as well as translate options popup menus. - Moves reusable UI targets to ios/chrome/browser/ui/popup_menu/publicenu. Bug: 910994 Change-Id: I16229bd0d8d64ba4e20498bdb3ea283b780f0678 Reviewed-on: https://chromium-review.googlesource.com/c/1358114 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615509}
-
Arthur Hemery authored
This patch removes deprecated methods RenderFrameHostTester::SimulateNavigationError and SimulateNavigationErrorPageCommit as well as their remaining uses in unit tests. Bug: 728571 Change-Id: I8f1d6b825cf80aad0680c3fd95a283897b19ebe8 Reviewed-on: https://chromium-review.googlesource.com/c/1370175Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#615508}
-
Jakob Gruber authored
A spec change to simplify IsRegExp has been proposed: https://github.com/tc39/ecma262/pull/1318 This CL adds use counters for cases in which the spec change would alter behavior: 1. o[@@match] is trueish but o is not a JSRegExp 2. o[@@match] is falseish (but not undefined) and o is a JSRegExp This is the Chromium side of required changes. The V8-side CL: https://crrev.com/c/1360630 Bug: v8:8522 Change-Id: I2ec9b1a5f54f8e70a02e48f280a548871990aabd Reviewed-on: https://chromium-review.googlesource.com/c/1360730Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#615507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fed2cb39c320..52411ecf1fa5 git log fed2cb39c320..52411ecf1fa5 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 sortie@google.com Add windows .bat file for gsutil.py. Created with: gclient setdep -r src/third_party/depot_tools@52411ecf1fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5716ec83309d0687fc4897212381997e2374bac2 Reviewed-on: https://chromium-review.googlesource.com/c/1371706Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58b1f41bf2fc..757effd70e5f Created with: gclient setdep -r src-internal@757effd70e5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I72059db2c1ae9f356311302948e043da14b5e44d Reviewed-on: https://chromium-review.googlesource.com/c/1371705Reviewed-by:
-
Mikel Astiz authored
Unless something is done about it, there is a race between signin code trying to fetch "real" cookiejar information using GaiaAuthFetcher, and the test faking equivalent information and injecting it via ProfileSyncService::OnGaiaAccountsInCookieUpdatedWithCallback(). Usually, signin logic is fast enough to avoid test failures, but occasionally the fetching takes long and an empty list of accounts is injected at a last stage (after navigations to kURL2), interfering with test expectations. Bug: 789129 Change-Id: I95b0f691bd047216309888d345c68e1eb26ab869 Reviewed-on: https://chromium-review.googlesource.com/c/1371386Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bfb8c97cb567..3c2ff12d419d git log bfb8c97cb567..3c2ff12d419d --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com fuzzing: Do no copy unneeded data files. Created with: gclient setdep -r src/third_party/perfetto@3c2ff12d419d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:69150303 TBR=perfetto-bugs@google.com Change-Id: I7b09f0d39d545600624c2a319a0b853425bd030a Reviewed-on: https://chromium-review.googlesource.com/c/1371704Reviewed-by:
-
Sylvain Defresne authored
Add methods to find AccountInfo using either account id, email address or gaia id to IdentityManager. They are wrapper around the corresponding method of AccountTrackerService (with a call to GetAccountInfoForAccountWithValidRefreshToken to get the logic to deal with kSupervisedUserPseudoEmail). Add unit tests for the new methods. Bug: 912170 Change-Id: Ic7da17b0f22c85349b89cb44d272a3a6b4f6d573 Reviewed-on: https://chromium-review.googlesource.com/c/1365245 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615502}
-
Sylvain Defresne authored
The fixture made code more convoluted as the default test environment had to be created in the constructor (as the tests expected it) and then recreated afterwards for the ClearPrimaryAccount tests. Instead not using the fixture make the tests more straight-forward as the objects used by each individual tests are explicitly created. This adds some boilerplate, but logic of RunClearPrimaryAccountTest is now clear (previously you had to check in the test what the value of the account consistency method was, while now it is expliclty passed to the method). This follow the recommendation from the following tips of the week https://abseil.io/tips/122 that recommends avoiding fixtures. Bug: none Change-Id: Ia8af245f7b1a3bdeddb7a09fb9baa54a371b8512 Reviewed-on: https://chromium-review.googlesource.com/c/1363199 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#615501}
-
Moe Ahmadi authored
Instead of passing the id<LanguageSelectionHandler> to the ChromeIOSTranslateClient during construction which is prone to error due to dependency on the order in which ChromeIOSTranslateClient and the InfobarCoordinator are initialized, this CL modifies the LanguageSelectionCoordinator to observe the WebStateList and set/unset the id<LanguageSelectionHandler> on instances of ChromeIOSTranslateClient when appropriate. This fixes a DCHECK during ChromeIOSTranslateClient construction and helps make the feature more self-contained as the InfobarCoordinator/Mediator no longer needs to know about the languageSelectionHandler. TBR=rohitrao@ Bug: 912502 Change-Id: Id3769f10a0ed638821afdd9578bd263700768299 Reviewed-on: https://chromium-review.googlesource.com/c/1366467 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615500}
-
Rakina Zata Amni authored
The draft spec for Constructable Stylesheets has moved on from factory functions to normal constructors for CSSStyleSheets, with methods to replace the contents of a constructed stylesheet synchronously or asynchronously. This CL replaces the old factory functions to normal constructors, and implements replace and replaceSync method, the constructed flag, and the disallow modification flag. Not implemented in this CL: allow usage of constructed stylesheets in multiple Documents, FrozenArray instead of StyleSheetList for adoptedStyleSheets. Draft spec: https://wicg.github.io/construct-stylesheets/index.html Bug: 807560 Change-Id: I3c4ea296338d03585ede6332bf29d6732b71c816 Reviewed-on: https://chromium-review.googlesource.com/c/1347647 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615499}
-
Tim Volodine authored
This patch implements the initial bits for the custom URLLoader that reads from an android InputStream and returns the results (instead of fetching response from an actual network). The general idea is to have this custom AndroidStreamReaderURLLoader take care of a number of things: 1. provide response in the context of shouldInterceptRequest callback 2. allow to read special url like file://android_asset/ to obtain app resources and assets. This patch aims to provide support for the shouldInterceptRequest callback. In particular it makes sure the stream is opened, correctly positioned (range seek), response headers are initialized, etc... Going forward some bits will be implemented further: i.e. returning and writing the actual body response via mojo pipes. Approximately speaking the AndroidStreamReaderURLLoader is the network service counterpart of AndroidStreamReaderURLRequestJob (which is used by the current net/ code path). The patch also adds some relevant corresponding unit tests for the loader. BUG=893566,841556 Change-Id: I15247813f2b359445a2e9d45a18c8e595dfebdb2 Reviewed-on: https://chromium-review.googlesource.com/c/1363184Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#615498}
-
Kent Tamura authored
Form-associated custom elements: customElements.define() should check existence of 'value' property setter on a prototype chain This is a follow-up of crrev.com/613499. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I0c364d1f3031dde063d40867b5b93cde8a4bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/1370240 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615497}
-
Alex Clarke authored
A reland of https://crrev.com/c/1324391 This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI and IO threads. RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems to have fixed this. TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org Bug: 863341, 891670, 708584 Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 Reviewed-on: https://chromium-review.googlesource.com/c/1361863 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL disabled these flaky tests: TextFocusFeedback DoubleFocusAlertDialogFeedback ToggleOnKeyUp They have caused failures recently and show a history of flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxEventWatcherUnitTest TBR=dmazzoni@chromium.org Bug: 912390, 622387 Change-Id: If7647be13420ff98df3a51d0fa156635f181c074 Reviewed-on: https://chromium-review.googlesource.com/c/1371476Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fabd12d5c959..58b1f41bf2fc Created with: gclient setdep -r src-internal@58b1f41bf2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I46ffec1a5aec51a8d01717f847a1156fe3baac33 Reviewed-on: https://chromium-review.googlesource.com/c/1371504Reviewed-by:
-
Max Morin authored
The current code has two bugs. 1. PowerMonitor::RemoveObserver isn't called at destruction. Oops. 2. PowerMonitor::AddObserver is called from a task scheduler thread, which can race with the power monitor being destructed on the main thread. 1 is straightforward to fix but 2 isn't really. The power monitor isn't adding much value, so let's just remove it. Bug: 912922, 912997 Change-Id: I11cbc028d6ef4a9767096f2553d1cc340aa86e57 Reviewed-on: https://chromium-review.googlesource.com/c/1371390Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615493}
-
Friedrich Horschig [CET] authored
This reverts commit 3b3db143. Reason for revert: Strongest suspect for the last 40 failures of telemetry_perf_unittests and telemetry_unittests which failed being unable to find some shared libraries. Bug:913070 Original change's description: > Add RPATH to shared libraries > > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so > > R=thakis > > Bug: 911836,912366 > Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77 > Reviewed-on: https://chromium-review.googlesource.com/c/1362457 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614255} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836, 912366 Change-Id: Ief4c7258208a2903bb06685d4edc76f482f7a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1371385Reviewed-by:
-
Friedrich Horschig [CET] authored
In addition to timeouts, the mentioned test shows gpu crashes. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913865, 900641 TBR=gogerald@chromium.org Change-Id: Id1d59744cbd3fb50df822789e1332d77d778756e Reviewed-on: https://chromium-review.googlesource.com/c/1371444 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Thomas Tangl authored
All sync data type toggles are moved into one polymer element. Note: There is no structural change in this CL. In a follow-up CL the toggles are moved to a subpage which is accessible from the sync page. Bug: 912598 Change-Id: I7d07a7051d34840d94a1229c7dae92fa2c1e680c Reviewed-on: https://chromium-review.googlesource.com/c/1367648 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615490}
-
![Friedrich Horschig [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich Horschig [CET]")
