- 20 Jul, 2018 40 commits
-
-
agrieve authored
Change-Id: I5f84b1436b0cbecb4d545d0cd66de6304b40a1f0 Reviewed-on: https://chromium-review.googlesource.com/1145603 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#576983}
-
Helen Li authored
This reverts commit 41066e83. Reason for revert: This CL broke an internal app. See crbug.com/865958 Original change's description: > Convert Extensions TCP & TLS Socket APIs to mojo sockets > > This CL converts extensions TCP and TLS socket apis to network service's mojo > socket. > > - Remove combined_socket_unittest.cc because the test cases no longer apply. I > tried to write equivalent ones in tcp_socket_unittest.cc and > tls_socket_unittest.cc > - Add a ContentUtilityClient implementation for extensions_browsertests, so we > can inject a NetworkServiceTestHelper to the utility process in which network > service runs. > > Bug: 721401 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo > Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba > Reviewed-on: https://chromium-review.googlesource.com/1070434 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563390} TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 721401, 865958 Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6 Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1145340 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#576982}
-
mark a. foltz authored
This replaces usages of content::PresentationConnectionMessage with blink::mojom::PresentationConnectionMessagePtr, and removes the presentation.mojom typemap and traits which are no longer needed. This is the last step before we can move presentation.mojom to third_party/blink/public/mojom. It also updates relevant unittests to mock methods with move parameters directly, instead of using helper methods. Bug: 817903,851567 Change-Id: Ifc50db81108f78089e7f19a7a394069bb2b82b37 Reviewed-on: https://chromium-review.googlesource.com/1123175 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576981}
-
Philip Rogers authored
This patch unskips 6 more directories for blink gen property trees: virtual/scroll_customization virtual/threaded intersection-observer overflow scrollingcoordinator touchadjustment Bug=836886 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee8de29abd66832f3548f38a63d7d6d2f82cc133 Reviewed-on: https://chromium-review.googlesource.com/1145540Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576980}
-
Peter Kvitek authored
Change-Id: I38e1e14457f706566797fa89eff18641e1fd7105 Reviewed-on: https://chromium-review.googlesource.com/1145593Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576979}
-
Henrique Grandinetti authored
Bug: 860691 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic6cf61b88733c176423ce309571d28b502114234 Reviewed-on: https://chromium-review.googlesource.com/1140376Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#576978}
-
Martin Kreichgauer authored
Change-Id: I44e86df2e87e014b5b4477c894fafa2bd5f9c457 Reviewed-on: https://chromium-review.googlesource.com/1145488 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#576977}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b78ad257. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21626 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad garykac@chromium.org: external/wpt/keyboard-map garykac@chromium.org, joedow@chromium.org: external/wpt/keyboard-lock jsbell@chromium.org: external/wpt/encoding kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading mlamouri@chromium.org: external/wpt/mediasession nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents panicker@chromium.org: external/wpt/user-timing timvolodine@chromium.org: external/wpt/battery-status TBR=foolip No-Export: true Change-Id: Ibae77dc140a4a82a10fbc974f15e587c25eb6c25 Reviewed-on: https://chromium-review.googlesource.com/1145464 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576976}
-
Tessa Nijssen authored
On Safari, when there is text selected and not just a cursor in text, the NSCandidateListTouchBarItem collapses. This change checks if the selection range has a non-zero length, and if it does, collapses the created NSCandidateListTouchBarItem. The text suggestions are still accessible by clicking on the collapsed NSTouchBarItem. A unit test, CollapsedCandidateListTest, was written to test that the NSTouchBarItem properly collapses according to the length of the selection range. Bug: 717553 Change-Id: I25671450f43b4ba14197f76e431f9212d5494187 Reviewed-on: https://chromium-review.googlesource.com/1144300 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576975}
-
Yury Khmel authored
This reverts commit 34854861. Reason for reland: Crash fixed. Original change's description: > Revert "Create crostini app folder and add all Crostini apps to it" > > This reverts commit b5e1688a. > > Reason for revert: This CL seems to cause a crash when installing Terminal on Eve. > > Original change's description: > > Create crostini app folder and add all Crostini apps to it > > > > Bug: 822488 > > Test: Manually, simulate crositini app environment. > > Change-Id: I278a6ddfc709b5b48f923368aad07f047788bf40 > > Reviewed-on: https://chromium-review.googlesource.com/1143883 > > Commit-Queue: Renée Wright <rjwright@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#576703} > > TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@google.com > > Change-Id: I3104b7d7abbf885f100aedb223d31a4d73bed47c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 822488 > Reviewed-on: https://chromium-review.googlesource.com/1144500 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576714} TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@google.com,nverne@chromium.org Change-Id: I000b4ddbba75f11947570f4c2470332db3d80a11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822488 Reviewed-on: https://chromium-review.googlesource.com/1145563Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576974}
-
dpapad authored
The corner case of nested cr-dialog instances had not been accounted. Which resulted in 'close' events being caught and re-fired unnecessarily, which messes up the event's target. A potential future cleanup would be to use cr-dialog-close for the re-fired event, similarly to cr-dialog-open, but that would cause quite a bit of churn. Bug: None Change-Id: I7873439ac7e69d45065ec1ee5336406c67473256 Reviewed-on: https://chromium-review.googlesource.com/1144436Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576973}
-
Nicolas Pena authored
The bug was marked as fixed but the test is still disabled. Bug: 799106 Change-Id: I7d483a811a6edfad0db6150fd5e0faef895d1b56 Reviewed-on: https://chromium-review.googlesource.com/1143602 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576972}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b6704082f43c..c3bfa61aedfb git log b6704082f43c..c3bfa61aedfb --date=short --no-merges --format='%ad %ae %s' 2018-07-20 dgarrett@google.com config_lib: Revamp config_lib.isTryjobConfig. 2018-07-20 dgarrett@google.com cros tryjob: Stop verifying branched config names. 2018-07-20 dgarrett@google.com workspace_stages: Add clean/sync implementations. 2018-07-20 derat@chromium.org chromeos_config: Add bvt-tast HWTest suite. Created with: gclient setdep -r src/third_party/chromite@c3bfa61aedfb The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I61bf5c41ba9ebf5ebe4a38f9f77f4380f723e109 Reviewed-on: https://chromium-review.googlesource.com/1145601Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576971}
-
Devlin Cronin authored
Add extensions-runtime-hosts-dialog to allow the user to enter a new host that the extension is allowed to run on, and wire it up in the chrome://extensions page. Add tests for the same. Note: this only allows for adding new hosts; a followup will allow for editing and removing current hosts. Bug: 844128 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib42d1c461700fcb2aa4a7b360f26619a6dcd65d3 Reviewed-on: https://chromium-review.googlesource.com/1136868 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576970}
-
Becca Hughes authored
Mark some tests as flaky BUG=862728 Change-Id: I26df004ca5dda4539f56ad33240715170c44c4e9 Reviewed-on: https://chromium-review.googlesource.com/1145586 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576969}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d754eb5620ed..ba365939b90c git log d754eb5620ed..ba365939b90c --date=short --no-merges --format='%ad %ae %s' 2018-07-20 jmadill@chromium.org Rename angle::Format::ID to angle::FormatID. Created with: gclient setdep -r src/third_party/angle@ba365939b90c The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I455a4a7fda0e2447cb05f3c6229d6cdcb767b841 Reviewed-on: https://chromium-review.googlesource.com/1145602Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576968}
-
Alexei Svitkine authored
In DCHECK builds, users hit the existing limit of 10. Bug: 849597 Change-Id: I7925f1e4c58d7976ba7f18ea69c2ccee03c0badc Reviewed-on: https://chromium-review.googlesource.com/1138405Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576967}
-
Robert Liao authored
This change allows for the experimentation of Material Refresh versus the previous Material Design UI. BUG=865722 Change-Id: I1d6b18760433e5d286e282e54f370a074f375397 Reviewed-on: https://chromium-review.googlesource.com/1144627Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576966}
-
erikchen authored
This is the first step in implementing JankyIntervalsPerThirtySeconds. Future CLs will forward task and event execution latency to this class. Change-Id: Ib695f7761505a0ca9ac7911fef444d479f40574f Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1120754Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576965}
-
Alexandr Ilin authored
The handle returned from gfx::GpuMemoryBuffer::GetHandle() is either passed to CloneHandleForIPC immediately or used to obtain some handle metadata (type, GUID). This CL replaces GpuMemoryBuffer::GetHandle() with the new method GpuMemoryBuffer::CloneHandle() that is equivalent of calling CloneHandleForIPC(buffer.GetHandle()). This will allow to use scoped objects for all types of underlying platform handles, since no two GpuMemoryBufferHandles will refer to the same system resource. New methods are also added to access type/GUID of buffer. As a demonstration, this CL changes the type of the GpuMemoryBufferHandle::android_hardware_buffer from AHardwareBuffer* to base::android::ScopedHardwareBufferHandle. Bug: 854594, 863011 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0306f4295cf28113cf467dba3c2a2b1717ca2e67 Reviewed-on: https://chromium-review.googlesource.com/1126394 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#576964}
-
Robbie McElrath authored
This migrates DialRegistry from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859133 Change-Id: I123782968fe75b2eed3c1c7fc06355ae2d108afe Reviewed-on: https://chromium-review.googlesource.com/1123648 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576963}
-
Justin Novosad authored
This CL completes the initial implementation of Low Latency mode for 2d canvases Bug: 788439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9 Reviewed-on: https://chromium-review.googlesource.com/1145235 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576962}
-
Scott Violet authored
We only have one now. BUG=865689 TEST=none Change-Id: I6f5c0251f38e9f791923924cd0ccbc4cacfb365a Reviewed-on: https://chromium-review.googlesource.com/1145542Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576961}
-
Peter K. Lee authored
Bug: 831971 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id656f7fec7577080116e01c5883d9cbf21fd4ce8 Reviewed-on: https://chromium-review.googlesource.com/1128269 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576960}
-
Dave Tapuska authored
v8::Array's max length is UINTMAX and is uint32_t indexed. The ArrayValue wrapper used size_t as accessors which would cause a narrowing on access. BUG=596846 Change-Id: I0a309d9a3417f73a404f60ff3f6699025202bc2f Reviewed-on: https://chromium-review.googlesource.com/1145472Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#576959}
-
John Budorick authored
Bug: 861740 Change-Id: I82bd5187e73f26990f726ddebd315afd59217057 Reviewed-on: https://chromium-review.googlesource.com/1144241Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576958}
-
Patrick Monette authored
The feature was never meant to be enabled on other versions than Windows 10, but I accidentally removed the checks in https://chromium-review.googlesource.com/c/chromium/src/+/1099976. Bug: 717696 Change-Id: Ie52736de5dbf609fb702f6aff4a97f8ecac95267 Reviewed-on: https://chromium-review.googlesource.com/1144430 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576957}
-
Toni Barzic authored
Adds logic to register and load/unload components to fake image loader client, so it can be used to test code that depends on image loader client. Introduces SetMountPathForComponent that sets up mount points LoadComponent/LoadComponentAtPath return as component's mount point when called (if a mount point has not been set, the LoadComponent methods will fail). Implements logic to register/remove components - it keeps mapping from a registered component name to its version in memory. BUG=863162 Change-Id: Iffa3504fc92d495cc46a35caffd3acdd4b7038c8 Reviewed-on: https://chromium-review.googlesource.com/1145463 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#576956}
-
Tim Dresser authored
Bug: None Change-Id: Ie767d93e805cb463f1567d04df5f2d6e3602f01c Reviewed-on: https://chromium-review.googlesource.com/1143593Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#576955}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/213eaf4f79bc..c03be1848479 git log 213eaf4f79bc..c03be1848479 --date=short --no-merges --format='%ad %ae %s' 2018-07-20 dtu@chromium.org Revert "[pinpoint] Add --also-run-disabled-tests flag to Telemetry runs." Created with: gclient setdep -r src/third_party/catapult@c03be1848479 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie4930fddb38099b388029930973dbefd85c30256 Reviewed-on: https://chromium-review.googlesource.com/1145600Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576954}
-
Karan Bhatia authored
The |browser_context_| member of ExtensionMessageFilter is only supposed to be read on the UI thread, but is also read in OnMessageReceived which might not be invoked on the UI thread (for messages not handled by the ExtensionMessageFilter). This is racy and can lead to accessing the variable simultaneously on multiple threads. Remove the check for a valid |browser_context_| in ExtensionMessageFilter::OnMessageReceived. It's redundant anyway since all the message handler functions do already check for a valid browser context. BUG=862597 Change-Id: Ib34ac14b9a1ff609224a9fdf80202070098760e9 Reviewed-on: https://chromium-review.googlesource.com/1144606 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576953}
-
Yuwei Huang authored
This CL adds the session entry point info to the telemetry reported by the iOS client. This allows us to compare metrics on initial vs reconnect attempt, and reuse error breakdown dashboard without unchecking the SessionEntryPoint filter. Bug: 840556 Change-Id: I27b5fd644f024b10953b5bbf919047d8f370b753 Reviewed-on: https://chromium-review.googlesource.com/1141147Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#576952}
-
Mihai Sardarescu authored
This CL hides the "Make searches and browsing better" settings from the privacy settings when unified consent is disabled. Bug: 863950 Change-Id: Ia392cebae7eb8327b6dcea6427e504d84c11d17b Reviewed-on: https://chromium-review.googlesource.com/1145315Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#576951}
-
Gang Wu authored
Implement Content Storage API in Java and JNI bridge. Bug:828935 Change-Id: I6c70d18cfde0891f5c9533458bf453a891b4b2be Reviewed-on: https://chromium-review.googlesource.com/1137739 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#576950}
-
Nicolas Pena authored
The benchmark seems to be passing now. Bug: 853188 Change-Id: I0d502d1210540b8221afd5a90a5c59d63b93c3ad Reviewed-on: https://chromium-review.googlesource.com/1144123 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576949}
-
Aldo Culquicondor authored
This is a step towards making the GestureDetector detect gestures triggered by other buttons of the PlatformController. Bug: 865486 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifbdfc28b850fae81446e21caf42027506f7bf522 Reviewed-on: https://chromium-review.googlesource.com/1143712 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#576948}
-
Mitsuru Oshima authored
BUG=865977 TEST=Covered by unit test Change-Id: I444981ec98241d2a355d23d9711a961010a292c3 Reviewed-on: https://chromium-review.googlesource.com/1144628Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#576947}
-
Alexander Alekseev authored
Bug: 852034 Change-Id: Iac5c70336e3868521b8dbfd81c2238122438b466 Reviewed-on: https://chromium-review.googlesource.com/1144631Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#576946}
-
Scott Violet authored
It's been replaced by ws2. BUG=865689 TEST=none Change-Id: I86310a113750d350d24f7d11180b4411a5346d48 Reviewed-on: https://chromium-review.googlesource.com/1145052 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576945}
-
Dave Tapuska authored
The code was testing C++ to WebIDL type conversions. It should have not been using C++ long values since these are dynamic based on the architecture. Use the C++ type that maps correctly to the WebIDL type. This didn't cause a layout test failure because it was testing a roundtripped value. If the C++ interface returned a value that was out of bounds then it could have gotten truncated because on linux sizeof(long) == 8 but WebIDL long defines it as 4 bytes. BUG=596846 Change-Id: I92020c1cbbec0fff7c77b5fe0129eb91bbd70c7a Reviewed-on: https://chromium-review.googlesource.com/1145138Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#576944}
-