GitLab

Element::parseAttribute does nothing so there's no reason to have a
special case to call it for id, class and style attributes.

Review URL: https://codereview.chromium.org/236363005

git-svn-id: svn://svn.chromium.org/blink/trunk@171431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=apavlov,pfeldman

Review URL: https://codereview.chromium.org/236613003

git-svn-id: svn://svn.chromium.org/blink/trunk@171430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test looks flaky also in linux.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fimages%2Fwebp-partial-load.html

TBR=leviw@chromium.org
BUG=313846

Review URL: https://codereview.chromium.org/236793002

git-svn-id: svn://svn.chromium.org/blink/trunk@171429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Gardening: fast/workers/worker-multi-startup.html is crashing on Linux (https://codereview.chromium.org/226653003/)

Reason for revert:
passes again

Original issue's description:
> Gardening: fast/workers/worker-multi-startup.html is crashing on Linux
> 
> Appears to be from a v8 roll.
> 
> TBR=dcarney@chromium.org
> BUG=362146
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171291

TBR=dcarney@chromium.org,leviw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=362146

Review URL: https://codereview.chromium.org/236773002

git-svn-id: svn://svn.chromium.org/blink/trunk@171428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should avoid looking at the hash table of event handler attributes
for all attributes which don't start with "on", which is most attributes.

Review URL: https://codereview.chromium.org/228943008

git-svn-id: svn://svn.chromium.org/blink/trunk@171427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The checks in Length::blend for non-specified values were for the old
CSS animations/transitions code paths which have now been removed. We
should no longer get into Length::blend with non-specified values.

BUG=

Review URL: https://codereview.chromium.org/234413004

git-svn-id: svn://svn.chromium.org/blink/trunk@171426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tidy up some naming and layering split from the WebKit days.

Review URL: https://codereview.chromium.org/225023020

git-svn-id: svn://svn.chromium.org/blink/trunk@171425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was causing frames to be requested continuously when animations were paused.

Review URL: https://codereview.chromium.org/230503002

git-svn-id: svn://svn.chromium.org/blink/trunk@171424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use CORS-enabled fetch method for webfonts. If the CORS-enabled fetch
fails, make a second CORS-disabled request so that we won't break
existing webpages which don't honor the css3 font spec.

We also collect CORS failure counts.

BUG=286681
R=ksakamoto@chromium.org, japhet@chromium.org

Review URL: https://codereview.chromium.org/230383003

git-svn-id: svn://svn.chromium.org/blink/trunk@171423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No change to generated code, just cleanup.

This adds the flags:
lstrip_blocks=True
trim_blocks=True
...to the Jinja environment setup

This means we don't need {%- everywhere, and also allows us to indent control blocks.

(Other than that, a few consistency fixes of {{ foo() }} => {{foo()}} and " => ')

This CL does not change generated code, to simplify testing and review.
This turned up lots of minor whitespace errors or warts, which I've marked
with FIXME and will fix in a followup.

R=abarth

Review URL: https://codereview.chromium.org/236673002

git-svn-id: svn://svn.chromium.org/blink/trunk@171422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Three targets are missing correct Jinja template dependencies:
* MediaFeatureNames
* MediaFeatures
* MediaTypeNames
This fixes them, so they rebuild properly.

Also minor style/order fixes.

R=abarth

Review URL: https://codereview.chromium.org/235673007

git-svn-id: svn://svn.chromium.org/blink/trunk@171421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of pre-inflating all children in inflateTable(), this patch only
pre-inflates non-table children. This fixes a bug where nested tables
had their cell widths inflated with their parent table's multiplier but
ended up not being inflated at all--leading to extra wide cells.

This fixes a bug on codereview.chromium.org where people's names would
have extra space around them (http://pr.gg/tablewidth.png).

There is the potential for regressions with this change if a table has
enough text to autosize but where the width ends up being less than
100% of the containing <td>. The real world impact script showed no
changes on the top 100 websites and hackernews (the canonical nested-
table mess) renders fine after this change.

BUG=362930

Review URL: https://codereview.chromium.org/235943003

git-svn-id: svn://svn.chromium.org/blink/trunk@171420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/234863002

git-svn-id: svn://svn.chromium.org/blink/trunk@171419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ScriptPromiseResolverWithContext instead of a pair of
ScriptPromiseResolver and NewScriptState.
This CL doen't change the behavior in many cases: The only exception
is when the resolution / rejection happens on the suspended or stopped
ExecutionContext. In such a case, ScriptPromiseResolver suspends or stops
resolution or rejection.

R=ksakamoto@chromium.org
BUG=352552

Review URL: https://codereview.chromium.org/236123007

git-svn-id: svn://svn.chromium.org/blink/trunk@171418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were matching all the rulesets in a subtree even after finding a ruleset
that would invalidate the whole subtree which is wasted work. We were also
storing all the invalidation sets for an element even after one of them
would have invalidated the entire subtree.

This patch makes us only ever store one invalidation set for an element once
one of them would invalidate the whole subtree. It also removes the
foundInvalidationSet() bit since that's identical to just checking if the
Vector of invalidation sets is non-empty.

I also removed an ASSERT(renderer->style()), all renderers have a style, so
there's no reason to check this.

Review URL: https://codereview.chromium.org/233243003

git-svn-id: svn://svn.chromium.org/blink/trunk@171417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/234823003

git-svn-id: svn://svn.chromium.org/blink/trunk@171416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FrameSelection::setSelection() may cause some DOM events to happen synchro-
nously, which could free the frame and produce a dangling pointer to the frame.

This patch extends the lifetime of the frame object and fixes this use-after-
free.

BUG=357669

Review URL: https://codereview.chromium.org/225163004

git-svn-id: svn://svn.chromium.org/blink/trunk@171415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is required to create script wrappable objects which depend on
their execution context, such as EventTargets and ActiveDOMObjects.

BUG=349919
TBR=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/236133002

git-svn-id: svn://svn.chromium.org/blink/trunk@171413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On the Chromium side, there's a comment that this is unlikely to ever change.
And indeed it has never changed since the initial commit of webkit/ in 2008.

Thus this code is dead in Blink and should be removed.

Chromium CL: https://codereview.chromium.org/236163005/

BUG=362961
TEST=ManualTests/contenteditable-link.html

Review URL: https://codereview.chromium.org/236203005

git-svn-id: svn://svn.chromium.org/blink/trunk@171412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Appears to be causing crashes on Android perf bots.

BUG=362975
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/235993003

git-svn-id: svn://svn.chromium.org/blink/trunk@171409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current blink is delaying the creation of the backing store until drawing something.
When alpha is false, the backing store must be initialized to opaque black instead of transparent black.

BUG=352018

Review URL: https://codereview.chromium.org/200003002

git-svn-id: svn://svn.chromium.org/blink/trunk@171408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This field is never read.

BUG=362927

Review URL: https://codereview.chromium.org/236403002

git-svn-id: svn://svn.chromium.org/blink/trunk@171407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FastTextAutosizer::inflateTable pre-inflates table cells so that
the table layout algorithm has an upper bound for table cell sizes.
After inflateTable pre-inflates cells, the layout pass will come
around and correctly size cells through beginLayout(). This patch
fixes a bug where cells were pre-inflated without later being laid out.

The bug that affected codereview.chromium.org and amazon.com both
involved nested tables with images. When images load, they can
force a layout up their parent chain because their size can change.
During layout, we would then call inflateTable and pre-inflate the
entire table but only the image's cell would actually get laid out.

BUG=357299

Review URL: https://codereview.chromium.org/236033005

git-svn-id: svn://svn.chromium.org/blink/trunk@171406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL creates new types to better reflect screen orientation types. It
also simplify ScreenOrientation.cpp, following spec simplifications.
Finally, there are some changes related to |m_lockedOrientations| that
was a bit buggy by nature, assuming that only the current fram could
change the locking.

BUG=162827

Review URL: https://codereview.chromium.org/219463003

git-svn-id: svn://svn.chromium.org/blink/trunk@171405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scrollbar margin on the overlay scrollbar theme is used to distance
the thumb from the edge of the screen on all sides, not just the
widthwise side.  This was already computed properly in the theme's
TrackRect, but it wasn't communicated to the WebScrollbarLayer.

Also, shrink the margin to 3 DIPs on Android, which on closer inspection
better matches the system theme.

Chromium-side change at https://codereview.chromium.org/234603002/
NOTRY=true
BUG=361923

Review URL: https://codereview.chromium.org/234613002

git-svn-id: svn://svn.chromium.org/blink/trunk@171404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no big reason that NavigatorContentUtils should use RefCountedSupplement. This CL marks the NavigatorContentUtils to use Supplement instead of RefCountedSupplement. Additionally this cl adds a tracing method for supplement.

BUG=none

Review URL: https://codereview.chromium.org/235023003

git-svn-id: svn://svn.chromium.org/blink/trunk@171403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Certain type of resources must have their clients notified
asynchronously.

BUG=352043

Review URL: https://codereview.chromium.org/231873006

git-svn-id: svn://svn.chromium.org/blink/trunk@171402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems not to needed. 
The variable "paths" is not used.

Review URL: https://codereview.chromium.org/235933005

git-svn-id: svn://svn.chromium.org/blink/trunk@171401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chrome side is: https://codereview.chromium.org/231763003/

This isn't perfect (using the family name directly rather than
doing a name/style/etc. fallback based lookup), but it's simple
and works sufficiently for layout tests and local developer use
of custom fonts. If we want to in the future, the same interface
could be used in conjunction with some skia changes to support
custom font collections, which would get the full style matching
support.

TBR=dglazkov@chromium.org
R=eae@chromium.org
BUG=333029

Review URL: https://codereview.chromium.org/235553003

git-svn-id: svn://svn.chromium.org/blink/trunk@171400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of using SkTypeface directly which goes through the
default Skia FontMgr, pass ours through so that when enabling
DirectWrite we don't use the GDI one.

R=eae@chromium.org
BUG=362694

Review URL: https://codereview.chromium.org/235753003

git-svn-id: svn://svn.chromium.org/blink/trunk@171399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes some compositing chicken/egg work by deferring
updateCompositingRequirementsState until the compositing update. This CL is the
first step towards properly integrating this work with the rest of the
compositing update.

Review URL: https://codereview.chromium.org/235933002

git-svn-id: svn://svn.chromium.org/blink/trunk@171398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also moves a few static methods that don't make sense on WebFrame
to WebLocalFrame.

BUG=346764
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/232133004

git-svn-id: svn://svn.chromium.org/blink/trunk@171396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

run-webkit-tests normally is robust against trying to run invalid or
missing tests, but it turns out that when run with the --run-chunk
argument there was a code path that tried to divide by zero because
we didn't err out early enough.

R=thestig@chromium.org
BUG=362749

Review URL: https://codereview.chromium.org/235863005

git-svn-id: svn://svn.chromium.org/blink/trunk@171395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This SVG1.1[1] property has been removed from SVG2[2] and can be removed.

[1] http://www.w3.org/TR/SVG11/single-page.html#text-KerningProperty
[2] https://svgwg.org/svg2-draft/single-page.html

Review URL: https://codereview.chromium.org/234453002

git-svn-id: svn://svn.chromium.org/blink/trunk@171393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a performance test that emulates regions but does not actually use them.

This is a merge of http://trac.webkit.org/changeset/167022 by Zoltan Horvath <zoltan@webkit.org>.

NOTRY=true
BUG=349093

Review URL: https://codereview.chromium.org/231943002

git-svn-id: svn://svn.chromium.org/blink/trunk@171392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously it was running a number of concurrent operations, however none of those operations were using the same key.

Now each of the encrypt/decrypt/exportKey, sign/verify/exportKey sequences for a particular key are also run in parallel.

BUG=245025
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/224823003

git-svn-id: svn://svn.chromium.org/blink/trunk@171391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes HTMLImportRoot abstract class and merge it
into HTMLImportsController.

TEST=none
BUG=none
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/234063004

git-svn-id: svn://svn.chromium.org/blink/trunk@171390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're hitting an assert in requiresCompositingForScrollableFrame,
because it depends on layout information. With
http://src.chromium.org/viewvc/blink?revision=171366&view=revision,
we now try to update this state when setting forceCompositingMode,
at which point, layout is not necessarily up to date.

We can just early return here because this method will be called
again after we've done the layout. This does potentially expose
us to bugs from chicken-egg issues that depend on the
m_forceCompositingMode bit for subframes.

Review URL: https://codereview.chromium.org/236193002

git-svn-id: svn://svn.chromium.org/blink/trunk@171389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=171367

BUG=362078
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/236243002

git-svn-id: svn://svn.chromium.org/blink/trunk@171388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the internal WebCrypto API, WebCryptoDigestor can act as a superset of
digestSynchronous. It will simlify things to not have digestSynchronous anymore,
so as a first step, this removes its one use.

Review URL: https://codereview.chromium.org/235893003

git-svn-id: svn://svn.chromium.org/blink/trunk@171387 bbb929c8-8fbe-4397-9dbb-9b2b20218538