- 04 Dec, 2019 40 commits
-
-
Kamila authored
This cl sets a specific width for the promo, and modifies the promo label, according to the UX requirements. Before-after screenshots attached on the bug below. Bug: 986737 Change-Id: I59f8c183e95eac4ba67501c775a71e553ad5c559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950903Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#721638}
-
Johannes Kron authored
Change return type of GpuVideoAcceleratorFactories::IsDecoderConfigSupported() from bool to a tristate enum class Supported to be able to distinguish between supported (kTrue/kFalse) and not yet initialized (kMaybe). Bug: chromium:1029737 Change-Id: I2a70947f2bf37398aba5a9b9dc2db3080265163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945175Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721637}
-
Aran Gilman authored
Bug: 1027612 Change-Id: I924bde8462b459fad436ebcc1cc8afe645cb4276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931109 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721636}
-
Mikel Astiz authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1827368 after the underlying issues have been resolved in other patches and FieldTrialList is guaranteed to be instantiated on all platforms. Original change's description: > Revert "Send variation headers to sync server" > > This reverts commit c305a2ba. > > Reason for revert: DCHECK failures observed on ios. > > Original change's description: > > Send variation headers to sync server > > > > This information is already sent to other servers such as the one used > > for omnibox personalization, hence the patch doesn't upload additional > > information but allows measuring the impact variations have on the sync > > server and debug errors caused by client-side experiments. > > > > Bug: 887521 > > Change-Id: I3358956639bf96260bb5010279012195086eec37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368 > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#700678} > > TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 887521, 1011088 > Change-Id: I07fb576d156cf9efd334ce89617e9a823db61662 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844814 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703254} TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org Bug: 887521, 1011088 Change-Id: I1e7ee5d44d1137dfaa5bdc7dd063cfe8bd2b7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950947 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721635}
-
Bettina authored
Add Update and Get methods in compromised credentials table to be able to log metrics and also update rows when the signon_realm or username has changed. Get method allows checking of whether or not existing rows will be changed/removed. This CL also adds a check to make sure the database exists before performing actions on it. Bug: 1026006 Change-Id: I6792d135de7d74a5d7b0f83bdb8f4dc87a409628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943308 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721634}
-
Tommy Li authored
This CL makes the Remove button in the Views omnibox send accessibility data. This brings it to accessibility parity with the Tab Switch button, generally functioning the same way. I tested this with ChromeVox, but the implementation is independent of the platform. Bug: 1205 Change-Id: Ia25a8af74cad154c31ddc00b7b5401498c87f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951135Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#721633}
-
Takumi Fujimoto authored
Disabled on debug builds for flaky timeouts. TBR=michaelpg Bug: 1030782 Change-Id: Ib69e47f7c4ff72940de95fe092d2aec8effb62ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951326Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721632}
-
Josh Nohle authored
The CryptAuthKeyCreator now returns a null CryptAuthKey if key creation fails. The CryptAuth v2 Enrollment and DeviceSync flows look for null results and error out with result codes kErrorKeyCreationFailed and kErrorCreatingGroupKey, respectively. Previously, for v2 Enrollment, key-creation failures would be caught during key-proof computations, resulting in a misleading error code. This was particularly relevant considering the recent M79 platform bug http://crbug.com/1017858. It is not necessary to merge these changes into M79 since M79 is already in beta. The result is that key creation failures will be interpreted as key-proof computation failures until M80. Bug: 899080, 951969 Change-Id: I9682b1fe548e4b3c0c9a00aea06f415d0aedd924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932402 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721631}
-
Emily Stark authored
This CL loosens mixed content restrictions to omit mixed content warnings for external protocol URLs (a.k.a. non-webby URLs). Why? Native applications cannot return data to the browser via an external protocol URL, so a page that loads a frame or a subresource over an external protocol is not actually displaying or running mixed content. One might reason that external protocols should be treated as mixed content because sending data to a native application can be dangerous (because e.g. the website could send a malicious payload to a vulnerable application), but the website can already do so via a top-level navigation, and the external protocol dialog is supposed to ensure that users only accept these resource loads from websites that they trust. (The dialog is currently not very good and needs to be revised to communicate more of a warning message, but that's a separate issue orthogonal from mixed content warnings.) This change simplifies an M80 change to give passive mixed content (images, particularly) a more aggressive UI treatment in advance of autoupgrading+blocking them in M81 (https://security.googleblog.com/2019/10/no-more-mixed-messages-about-https_3.html). Forms that target external protocols are still treated as passive mixed content (this is the same as forms that target http:// URLs). This could probably be argued either way, but the reasoning is that we should downgrade the UI when we know that user data is explicitly being sent to a potentially insecure endpoint. Bug: 621131 Change-Id: Ie945f516db087a9a98cca294d6959d70bbf0dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946934 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721630}
-
Lei Zhang authored
I have not worked on Autofill in years, so I am giving up my ownership here. A bug has been filed for a TODO with my name on it. Bug: 1030490 Change-Id: I9afb96a4a8b4a7eefc97854e2c5f29746eb5b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949208Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721629}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 891670 Change-Id: Ic635324cffd0bc9113bf40e21b1d647cbf33c344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945170 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721628}
-
Sonny Sasaka authored
This reverts commit d85ee3b4. Reason for revert: b:145163508 Original change's description: > device/bluetooth: Enable the use of btdispatch by default > > This sets the feature flag kNewblue to be enabled by default. The effect > of this is that Chrome will by default communicate to Chrome OS' > Bluetooth dispatcher (btdispatch) instead of BlueZ. Currently, > btdispatch only forwards the D-Bus traffic to BlueZ without NewBlue > enabled. > > Bug: 999676 > Change-Id: I7089225726ef52c1b8465f3a67b3fdbf01b01882 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783719 > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693431} TBR=mcchou@chromium.org,reillyg@chromium.org,sonnysasaka@chromium.org,hansberry@chromium.org Bug: b:145163508,b:145317234 Change-Id: Iaa5ee6dd719ccc38bf31ce7adfd7ebfec1b08f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951128 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721627}
-
Brian Sheedy authored
Supports outputting the closest image known to Gold and its diff with the produced image when running the GPU pixel tests locally. This should improve the usability of the tests when debugging locally, as before they only output the produced image and a link to all images known to Gold for the test. Bug: 1030349 Change-Id: I55cd724541f86edf8d6de534bd921d70d03d6eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949727Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721626}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0eccc52635b4..1759c2d96833 git log 0eccc52635b4..1759c2d96833 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 fmayer@google.com Merge "Fix crash if send fails." 2019-12-04 eseckler@google.com Merge "proto/processor: Add typed TrackEvent args for three chrome messages." Created with: gclient setdep -r src/third_party/perfetto@1759c2d96833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f1aba9353d15f78b7970c674876b848ed414582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721625}
-
Owen Min authored
Record the timestamp when user request the extension for better UX on the server side. The timestamp will be stored in the Pref as a DictionaryValue with the format: { "$extension-id" : {"timestamp : "$java-time-as-string"}, } The pref type is chagned from list to dict. It's safe to do so because the only code path to set the value is behind a private API which is used by no one now. Also, allow ExtensionApiUnittest to pass TaskEnvironmentTraits to BrowserWithTestWindowTest so that we can pause the clock for the test. Bug: 1006899 Change-Id: I3c0463ed3847f6d14a14d31f6073355d6dc43716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940670 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721624}
-
Peter Kotwicz authored
This is unused as of https://chromium-review.googlesource.com/c/chromium/src/+/1382499 BUG=None Change-Id: I0ed23f05fe2630cdaa2ab2cf7c904f3b0cb53ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949859 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721623}
-
Ian Prest authored
As part of review for a previous CL, we identified several functions in |ax_role_properties.h| that take an |AXNodeData|. Logically, however, the functions in |ax_role_properties.h| should only require the |AXRole| enum. - The functions that require |AXNodeData| were removed from that header, and replaced with member functions on |AXNodeData| itself. - Tests of those functions were moved to their appropriate new home. - Other changes were made as required to compile. - Fixed common misspelling of 'invocable' in the moved functions, identified by Tricium. Bug: 1030414 Change-Id: I9e2037fcd5a0bae7a922c9da9529ad48656aeceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948376 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#721622}
-
Kyle Milka authored
Wire up the send-tab-to-self feature to the sharing hub. This requires some refactoring of the STTS code so that it's no longer dependent on being passed a ChromeActivity. Bug: 1009124 Change-Id: I7b0c0c9e4015d78d8727e6305324c663c4081095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925088Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721621}
-
Kevin McNee authored
Now that BrowserPlugin is being removed, there is no longer a need for the root to filter the gesture events in a child. Bug: 533069, 751782 Change-Id: I6b5684fdb0c4a296cfe94aabd931677800918839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944316Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721620}
-
Jasper Chapman-Black authored
Change-Id: I8cf3be77f4bd98e0516854de1f2056cb8777fa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949325Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721619}
-
danakj authored
This changes BluetoothDevice::ConnectErrorCallback to be a OnceCallback, then the Bind() call in content can become a BindOnce(). While doing so, the Pair() method is changed to take a OnceCallback as well. And callers to Pair() and Connect() are changed to use OnceCallbacks and BindOnce(), including in unit tests. R=reillyg@chromium.org TBR=sky Bug: 1007760 Change-Id: I2ec6dfd45c868cd49b898506f8495427b51448ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943941 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#721618}
-
Ian Kilpatrick authored
Previously we only had to consider "start" and "end" static-positions. If a OOF positioned element is a child of a flexbox which has align-content: center its static-position edge is the center. This adjusts: - StaticPositionStartInset - StaticPositionEndInset - the computed_available_size calculation ... to take "center" static-positions into account. Bug: 845235 Change-Id: Idfc4b301c95c93073e072f7ac53cd9510d887a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930689Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721617}
-
Yi Gu authored
QueryClientInternal was introduced to distinguish v1 and v2 query paths. It's no longer needed. Bug: 1029012 Change-Id: Ie7682848335b98a7a54052372b4509fda6cb1dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950707Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721616}
-
Ian Kilpatrick authored
This does a couple of things: - Removes a loop from within SwapOutOfFlowPositionedCandidates. - Moves the inline logic within SwapOutOfFlowPositionedCandidates to MoveOutOfFlowDescendantCandidatesToDescendants (picking up the inline_container logic). - Moves SaveStaticPositionFromLegacy out to the NGOutOfFlowLayoutPart. - Disables the relayout boundary for static-position OOFs (due to SaveStaticPositionFromLegacy change). Bug: 845235 Change-Id: I0a0995432f7a4e3e1323ea0c5558b6cf92ac910e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929972Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721615}
-
Maksim Moskvitin authored
Directory implementation stores keystore keys in sync prefs. Since missing keystore keys from the response are possible and can cause significant sync issues (such as infinite configuration sync cycles), it's worth to support their migration. Packed keystore keys are propagated through the bridge constructor and passed to SetKeystoreKeys() if following conditions satisfied: 1. There are some keystore keys in preferences. 2. There is no errors during unpacking keystore keys. 3. Bridge didn't yet received any keystore keys (i.e. they weren't restored from Nigori storage). Bug: 1030736, 922900 Change-Id: I4419da22dbe010e226dae61fdc4164d3a37b5e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950946 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721614}
-
Manu Cornet authored
Change-Id: I3fd60588ca4a85f0cd3488077b5ee46201d02bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949695Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#721613}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I169be83055526d06615f2002dd09a7f89ed6b8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947045Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721612}
-
Francois Doray authored
This CL adds a boolean argument to base::TaskObserver::WillRunTask(), to indicate whether the task that is about to run was at any point in a queue that was disabled, blocked by a fence or low priority. The purpose of this change is to allow the creation of an histogram that reports when tasks that were never blocked or low priority are queued for a long time. TBR=sky@chromium.org,avi@chromium.org,zmo@chromium.org,marq@chromium.org,mattm@chromium.org,jochen@chromium.org Bug: 1029137 Change-Id: If63e2a5cd5690e04663399643ba2a3f7d928cedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943538 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721611}
-
Daniel Hosseinian authored
Edit the templates of CloudPrintSubmitEnabled and PrinterTypeDenyList. Bug: 487875 Change-Id: I640d8e27451734b0129659e00a88758ca228087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945083 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721610}
-
yu han authored
This is a regression introduced by my fix to HTMLAnchorElement when the <a>, with embedded inline element, is placed inside a <summary> tag. https://chromium.googlesource.com/chromium/src/+/4eb4df63f17ee0f22cd17472fa6ae92311e49900 The regression is caught by fuzz test: https://clusterfuzz.com/download?testcase_id=4577041865113600. The fuzz test create a click event on the document object which gets handled by node.cc::DefaultEventHandler(). It creates an DOMActivate event and propagate down to HTMLAreaElement. However, the event target is set to NULL by dom/events/event_dispatcher.cc. https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_dispatcher.cc?q=event_dispatcher.cc&sq=package:chromium&dr&l=391 Comment indicates the reason is that the event is crossing the shadow DOM boundary. Eventually, inside HTMLAnchorElement::HandleClick -> HTMLAnchorElement::AppendServerMapMousePosition() expects target to be non NULL and Null dereference exception is thrown. The fix is to check the event target for null before handling the underlying event. I went through the call stack to ensure no other event members are needed. I verified that both newly created anchor test and fuzz test pass. Bug: 1029197 Change-Id: I19a3b2811c1d562f4c563bed54ae380d7849b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945852 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#721609}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ff7c98ede3e..1d23e728fb93 git log 7ff7c98ede3e..1d23e728fb93 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 perezju@chromium.org [devil] Update markdown docs Created with: gclient setdep -r src/third_party/catapult@1d23e728fb93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008 Tbr: sadrul@google.com Change-Id: I9d63436c0bb35eadeeb496aa0a14cf6dcdef0f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721608}
-
Yang Guo authored
Fixed: 1028931 Change-Id: Ib26155ca9769495458f4fa0e1a5ba0bfc77b8e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939288Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721607}
-
Ken Buchanan authored
RenderWidgetHostInputEventRouter sends a special MouseMove event with the kRelativeMotionEvent flag set to a frame if the mouse cursor is over it but another frame had been holding mouse capture. This allows the mouse cursor to update properly for the current location on the page. See https://crrev.com/693342. The test for whether the cursor is over a different frame can have false positives when HitTestRegions have the kHitTestAsk flag set, indicating that an asynchronous hit test is required. This CL provides a partial solution by preventing the extra MouseMove from being sent in that situation. In future it might be desirable to actually perform the asynchronous hit test when capture is being released at this point. Bug: 1021508 Change-Id: I59367f11e992a57203387ed8b9daccee57d0a414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944311 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721606}
-
Kurt Horimoto authored
This CL also adds no-op functions to return supported overlay coordinator classes. Bug: 1030357 Change-Id: I77c48fd1833509044a8c440d45e7f82218f06ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949288 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721605}
-
Samuel Huang authored
This CL move to the DFM 4 page totalling ~27.8 kB that are low-hanging fruits because they already have their own GRD files. Also taking the opportunity to reorganize: * Move the pages' grit() targets to separate BUILD.gn files. * Move chrome://invalidations resources to its own directory. Bug: 927131 Change-Id: Ic31bd86e09312c8137661432788b2b58eade0bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949056Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721604}
-
Joe DeBlasio authored
This CL adds a null check to autofill client's check of the page security. It was causing crashes. Bug: 1030482 Change-Id: Ie6a4bf4674b42c0f76994cc13cc22b22c38a6083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949207 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b3800c4..1e65162c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e21c85cd241cd71e4a7c77b25781764f91172bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950883Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721602}
-
Sorin Jianu authored
Some constexpr static class members still require definitions in C++14 but it is not clear why this build break occurred on Android only. Change-Id: I3e0d04d765f02ce37db2f7b4df90bb4d85fcab6d BUG: 1030716 Change-Id: I3e0d04d765f02ce37db2f7b4df90bb4d85fcab6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950749Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721601}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a213018b475..a06f9d0787ca git log 4a213018b475..a06f9d0787ca --date=short --first-parent --format='%ad %ae %s' 2019-12-04 halcanary@google.com SkQP: model-creation improvements 2019-12-04 mtklein@google.com work around GCC false positive warning? 2019-12-04 egdaniel@google.com Handle failures in submission of vulkan command buffers. 2019-12-04 mtklein@google.com replace SkIRect[1] with SkIRect 2019-12-04 bsalomon@google.com Fix for 420/422 chroma subsampling of odd dimension images when 2019-12-04 reed@google.com Reland "remove legacy SkPath enum guards" 2019-12-04 robertphillips@google.com Add onPrePrepareDraws to GrFillRectOp 2019-12-04 mtklein@google.com simpler tmp arrays in GrGLPath 2019-12-04 senorblanco@chromium.org Update dawn.h -> webgpu.h, dawn_cpp.h -> webgpu_cpp.h. 2019-12-04 rosasco@google.com Notes on how to build SKQP for Fuchsia. 2019-12-04 reed@google.com Revert "remove legacy SkPath enum guards" Created with: gclient setdep -r src/third_party/skia@a06f9d0787ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I2905b64641a8d83d471063cb75f3d8eb047a95be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721600}
-
Nate Chapin authored
This removes the need for special-case pausing/unpausing in Document, as well as custom Document::Shutdown() logic. Bug: 1029822 Change-Id: I2c9cda5bb3720626cdc1f3fcadb7876422ca375e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949275 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721599}
-