GitLab

Set kShowStateKey property from init params show_state so that
mus window is created properly.

BUG=714804
TEST=DesktopWindowTreeHostMusTest.CreateFullscreenWidget

Review-Url: https://codereview.chromium.org/2840903002
Cr-Commit-Position: refs/heads/master@{#467572}

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381

Review-Url: https://codereview.chromium.org/2842303002
Cr-Commit-Position: refs/heads/master@{#467571}

BUG=703403
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2846623002
Cr-Commit-Position: refs/heads/master@{#467570}

The test case fractional-scroll-offset-fixed-position-non-composited.html
is passing, so removing it from TestExpectations

BUG=417782

Review-Url: https://codereview.chromium.org/2839193002
Cr-Commit-Position: refs/heads/master@{#467569}

Revert of printing::Metafile:  Simplify OS_MACOSX-specific code path (patchset #3 id:40001 of https://codereview.chromium.org/2802093006/ )

Reason for revert:
Likely causing https://crbug.com/712309

Original issue's description:
> printing::Metafile:  Simplify OS_MACOSX-specific code path
>
>   - printing::Metafile
>       * move MacRenderPageParams to PdfMetafileCg
>       * remove virtual RenderPage()
>   - printing::PdfMetafileCg
>       * Add MacRenderPageParams
>       * RenderPage no longer an override
>   - printing::PdfMetafileSkia
>       * no longer implment RenderPage()
>       * code moved to printing::PrintedDocument::RenderPrintedPage()
>
> This will help isolate BUG=chromium:374359
>
> R=thestig@chromium.org
>
> Review-Url: https://codereview.chromium.org/2802093006
> Cr-Commit-Position: refs/heads/master@{#463828}
> Committed: https://chromium.googlesource.com/chromium/src/+/c843c89f3051e4b01cf032e52c478000f7ded0ee

TBR=halcanary@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2839323002
Cr-Commit-Position: refs/heads/master@{#467568}

This CL removes the bookmarks-sidebar element in and replaces it with
a root bookmarks-folder-node. This serves to specify the recursive nature
of the sidebar, and will allow for neater recursive behaviors such as
keyboard navigation.

BUG=692844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823053003
Cr-Commit-Position: refs/heads/master@{#467567}

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2840393002
Cr-Commit-Position: refs/heads/master@{#467566}

Remove media-remoting-encrypted flag since encrypted contents are not
supported by media remoting for now.

BUG=715853

Review-Url: https://codereview.chromium.org/2843263002
Cr-Commit-Position: refs/heads/master@{#467565}

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2838343003
Cr-Commit-Position: refs/heads/master@{#467564}

This CL:
* Removes the dependency on gdbus from NPBL and uses //src/dbus instead
* Handle notifications asynchronously on a dedicated task runner
* Modify NativeNotificationDisplayService to allow async initialization
  of the NotificationPlatformBridge (only on Linux)

BUG=676220
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2821533003
Cr-Commit-Position: refs/heads/master@{#467563}

The cast executables set RPATH. If shared_libraries set RUNPATH, this
can causes issues since the RUNPATH in the shard_lib suppresses the RPATH from
the parent executable, but libraries are placed such that the parent
binary RPATH will find them.

If RUNPATH/RPATH are not set on the shared_libraries, then the parent
RPATH gets used correctly.

BUG=internal b/37514052
TEST=build libcast_media_1.0.so
readelf -a libcast_media_1.0.so | grep PATH
RUNPATh and RPATH are not set

Change-Id: I3866ddd84ced393a3926b023160298054d9a4adb
Reviewed-on: https://chromium-review.googlesource.com/487827Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467562}

This patch generates the following fields as part of a group:
- background ('storage_only' of type FillLayer)
- background_color ('storage_only' of type Color)

Since both fields correspond to shorthands, we specify them in
ComputedStyleExtraFields.json5.

Diff of generated files:
https://gist.github.com/darrnshn/48a62d4ef7efe9f7a8c2b707eb57644f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2841433002
Cr-Commit-Position: refs/heads/master@{#467561}

CWVScrollView.

BUG=714543

Review-Url: https://codereview.chromium.org/2840013004
Cr-Commit-Position: refs/heads/master@{#467560}

Cr-Commit-Position: refs/heads/master@{#467559}

This is a preparation of collapsed border optimization
(https://codereview.chromium.org/2805103003/)
and bug fixing (later).

BUG=626748

Review-Url: https://codereview.chromium.org/2840903003
Cr-Commit-Position: refs/heads/master@{#467558}

Combine the base class and only remaining subclass. Simplify:
-Remove some unnecessary accessors for the subclass.
-Merge constructors, destructors, Init/OnInit, OnAppImageUpdated.
-Make some CLC base classes and functions private.
-Remove unused includes.

Rename test files and classes.

BUG=557406
TEST=No functional changes; refactoring only.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2839933005
Cr-Commit-Position: refs/heads/master@{#467557}

Revert of HttpCache::Transaction layer allowing parallel validation (patchset #33 id:800001 of https://codereview.chromium.org/2721933002/ )

Reason for revert:
Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/4271

Original issue's description:
> This CL is a precursor to allowing shared writing to fix cache lock.
>
> This CL allows transactions to continue to their validation phase even when another
> transaction is the active reader/writer. After the validation phase, if its a match
> the transaction might wait till the response is written to the cache by the active
> writer. If its not a match the transaction will doom the entry and go to the
> network. In a subsequent CL, the not matching case will create a new entry as well.
>
> BUG=472740
>
> Review-Url: https://codereview.chromium.org/2721933002
> Cr-Commit-Position: refs/heads/master@{#467426}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757849f76e8a808

TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472740

Review-Url: https://codereview.chromium.org/2847653002
Cr-Commit-Position: refs/heads/master@{#467556}

This CL processes the Expect-CT header when received on HTTP
responses. TransportSecurityState parses the header and, if valid and received
on a compliant connection, stores the Expect-CT state for the current host. (If
valid but received on a non-compliant connection, the header information is not
stored but a report is sent to alert the site owner of the misconfiguration.) A
follow-up CL will check the dynamic Expect-CT state on connection setup.

BUG=679012

Review-Url: https://codereview.chromium.org/2774763005
Cr-Commit-Position: refs/heads/master@{#467555}

DirtyStackingContextZOrderLists may try to call LayoutView::Compositor(),
which may be invalid during such times. In any case, DirtyStackingContextZOrderLists
is irrelevant during document shutdown.

BUG=715736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2840403002
Cr-Commit-Position: refs/heads/master@{#467554}

This is the equivalent of http://crrev.com/2835403002 for the Mac-specific
scrollbar opacity plumbing.

BUG=606395

Review-Url: https://codereview.chromium.org/2838513003
Cr-Commit-Position: refs/heads/master@{#467553}

Update the filter for mus_browser_tests used on Mojo FYI bots with more tests
that pass locally.

TBR=sky@chromium.org
TEST=mus_browser_tests
BUG=705716

Review-Url: https://codereview.chromium.org/2844853002
Cr-Commit-Position: refs/heads/master@{#467552}

This test was previously disabled without comment or explanation on all platforms.
It was fixed for non mac platforms but needs to remain disabled on Mac.

TBR=sky@chromium.org
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2843313002
Cr-Commit-Position: refs/heads/master@{#467551}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d4e9c7fe..822954dd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2841303002
Cr-Commit-Position: refs/heads/master@{#467550}

Based on step 3 of yosin's plan:
https://codereview.chromium.org/2812423002#msg7

This CL does the following:

- Introduces a DocumentMarkerList interface

- Introduces GenericDocumentMarkerListImpl, an implementation
  of DocumentMarkerList that works for all marker types and is implemented on top
  of DocumentMarkerListEditor

- Refactors DocumentMarkerController to use GenericDocumentMarkerListImpl instead
  of using DocumentMarkerListEditor directly

BUG=707867

Review-Url: https://codereview.chromium.org/2820633002
Cr-Commit-Position: refs/heads/master@{#467549}

Rename NodeLayoutData -> NodeRenderingData as it captures the idea
behind the object better.

See here for discussion: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/style-dev/iLGP_mMZdjE/w5K1t2NCBQAJ

BUG=595137

Review-Url: https://codereview.chromium.org/2830583002
Cr-Commit-Position: refs/heads/master@{#467548}

This ensures proper capability check. This is also the last domain
without proper model.

BUG=none

Review-Url: https://codereview.chromium.org/2843763004
Cr-Commit-Position: refs/heads/master@{#467547}

TBR=yzshen@chromium.org

Bug: 709815
Change-Id: Ia33e5034d373e773f4c0db6aa65aa5ef1d161110
Reviewed-on: https://chromium-review.googlesource.com/487604
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467546}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Bug: 709815
Change-Id: Id4f7681d1ea03a8e75e3cbaecc09a78976df87ac
Reviewed-on: https://chromium-review.googlesource.com/488121Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467545}

Reland of Don't allow a widget to send close notifications more than once. (patchset #1 id:1 of https://codereview.chromium.org/2844933002/ )

Reason for revert:
We will disable the failing test on Mac.

Original issue's description:
> Revert of Don't allow a widget to send close notifications more than once. (patchset #3 id:40001 of https://codereview.chromium.org/2834943002/ )
>
> Reason for revert:
> The enabled WidgetObserverTest.ActivationChange test seems to be flaky
>
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/17210
>
> Original issue's description:
> > Don't allow a widget to send close notifications more than once.
> >
> > Add a test to make sure this works. Also fix a couple WidgetTests that
> > were disabled.
> >
> > BUG=714334
> >
> > Review-Url: https://codereview.chromium.org/2834943002
> > Cr-Commit-Position: refs/heads/master@{#467171}
> > Committed: https://chromium.googlesource.com/chromium/src/+/bf25b17bd99b5dbeff92e62f8dddd289c335dc0a
>
> TBR=sky@chromium.org,estade@chromium.org
> NOTRY=true
> BUG=714334
>
> Review-Url: https://codereview.chromium.org/2844933002
> Cr-Commit-Position: refs/heads/master@{#467528}
> Committed: https://chromium.googlesource.com/chromium/src/+/efd8268f95f1c7a212e5b6edd521761dd8a00e31

TBR=sky@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714334

Review-Url: https://codereview.chromium.org/2839403002
Cr-Commit-Position: refs/heads/master@{#467544}

In http://crrev.com/448816 I removed this on the observation it was
unused on the device I tried and provided no useful information.  Crash
reports are now showing the Galaxy Note 3 does use it, so add it back.
Unlike in the previous implementation, it's just stashed at time of
request instead of doing a round-trip to Blink and back.

BUG=714877

Review-Url: https://codereview.chromium.org/2842653004
Cr-Commit-Position: refs/heads/master@{#467543}

This patch stores the ComputedStyle to be passed between recalcStyle
and rebuildLayoutTree on NodeLayoutData instead of storing it on the
HashMap on Document.

This potentially fixes the perf regression in crbug.com/700093 as it
removes the HashMap lookup in SharedStyleFinder and making it a free
operation again.

BUG=595137, 700093

Review-Url: https://codereview.chromium.org/2821193003
Cr-Commit-Position: refs/heads/master@{#467542}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6858510487e6..8062a5765bb7

$ git log 685851048..8062a5765 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 rnephew Rename WaitForTemperature to WaitForBatteryTemperature

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ieedf0c63fb0276c9dc2380174a9efabccbce07de
Reviewed-on: https://chromium-review.googlesource.com/487833
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467541}

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2839533002
Cr-Commit-Position: refs/heads/master@{#467540}

This function just wrapped simple logic and we can explicitly
call SetViewportBoundsDelta on the correct layer instead. This
is similar to https://codereview.chromium.org/2839533002 which
removed FixedContainerSizeDelta.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2843253002
Cr-Commit-Position: refs/heads/master@{#467539}

Sometimes when a text selection ends with the last word on a line
(for instance when just one word is selected) the generated text
for the selection range contains an extra trailing space.
This happens when a text node is split into several InlineTextBoxes
(e.g. a <span> inside a narrow table) and the last selected word
happens to be the last one in such text box.

The TextIterator algorithm restores the spaces between the text boxes
and will add a trailing space for this word. For the SurroundingText,
however, we need the length that corresponds to the visible selection.

This CL introduces a new text iterator behavior that prevents that
extra space to be added. This behavior is used in combination with
DefaultRangeLengthBehavior() for the selection range calculation
in the SurroundingText.

BUG=708329

Review-Url: https://codereview.chromium.org/2832123002
Cr-Commit-Position: refs/heads/master@{#467538}

Restore the alphabetical order in javascript.

Saves around 100k when gzip is used, but only 2k for brotli.
Intention is to have android_webview to use the same copy
of about:credits in a follow-up, in which case this optimization
becomes relevant.

BUG=688077

Change-Id: I24d62a81c61c2c53f5740f90d0c8094d3b04352e
Reviewed-on: https://chromium-review.googlesource.com/487725Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467537}

Passing via command line is still supported, and has priority over the variations server parameter.

Bug=712331

Review-Url: https://codereview.chromium.org/2842363002
Cr-Commit-Position: refs/heads/master@{#467536}

R=waffles@chromium.org
BUG=687231

Review-Url: https://codereview.chromium.org/2835803002
Cr-Commit-Position: refs/heads/master@{#467535}

And update name for the experimental Windows recipe builder.

R=dpranke@chromium.org
TBR=dimu@google.com, dpranke@google.com
BUG=418185,685794,715782

Review-Url: https://codereview.chromium.org/2841253002 .
Cr-Commit-Position: refs/heads/master@{#467534}

https://skia.googlesource.com/skia.git/+log/f6d7eb158e41..b8a1392b021f

$ git log f6d7eb158..b8a1392b0 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 brianosman Fix uncached getROPixels from GPU images

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I1b888cfafd2160c68ce07b5d37e46e80c29c3d25
Reviewed-on: https://chromium-review.googlesource.com/487909Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467533}