- 06 Aug, 2020 40 commits
-
-
Gauthier Ambard authored
This is making sure that the tests are passing when the flag to use the UserAgent of the WebClients is enabled or disabled. Bug: none Change-Id: If61994b6c6ec13327475e4f2f525a93ea121ed1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332606 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#795482}
-
Charlie Hu authored
This CL cleans up the remaining bits of layout-animations policy: - update enums.xml - migrate test composited-animations-allow.php Change-Id: I24450bb070d05466f88587d3e00427fc3f98110c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333491Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#795481}
-
henrika authored
Adds more details related to audio output device authorization (required e.g. when a device is switched, or SetSinkId is called). Example of new log output: https://paste.googleplex.com/4803560074117120 Added tag(s): RFAOSF See https://chromium-review.googlesource.com/c/chromium/src/+/2093443 for related work. Bug: 1017219, b/152054751 Change-Id: I568a3d02f41599dc3e564682761e602592048f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340908Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#795480}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I4c5b5068296a5d4f489f3245f7ee8387352fc40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340863Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795479}
-
Nohemi Fernandez authored
Removes duplicate Identity test APIs with similar intent, as well as duplicated code to create identities. Bug: 1103274 Change-Id: I2730287d5efe430dd0b9ef8dfb255648c5c82329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332673Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#795478}
-
Chris Hamilton authored
This adorns ScriptStates with a unique identifier, and adds lifecycle tracking instrumentation hooks. A further CL will wire this up in order to implement detached context tracking as part of the performance.measureMemory API. BUG=1085129 Change-Id: I4ddb84c547430a28615dea57e7fd346c9e27b1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327851 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795477}
-
Wez authored
This reverts commit 8b856148. Reason for revert: Appears to cause thread-local-storage related failures under handle-verifier stacks (see https://crbug.com/1112636, https://crbug.com/1111492), when Perfetto happens to FlushPendingCommitDataRequests() while recording a trace event. Original change's description: > Fix HandleVerifier trace events for static builds > > This CL is fixing the trace events of the HandleVerifier for a > non components build. > > For a static build, there are two instances of the HandleVerifier > 1) chrome.exe!HandleVerifier > 2) chrome.dll!HandleVerifier > > At chrome startup, chrome.exe!InstallVerifier set a global singleton > which start tracking ScopedHandle objects. > > After the initialisation, chrome.dll is loaded. The call of > chrome.dll::InstallVerifier() is fetching the singleton from 1) and is > storing it as a global singleton into chrome.dll. Calls to the > chrome.dll!VerifierTraits::StartTracking() and > chrome.dll!VerifierTraits::StopTracking are forwarded to the > chrome.exe!HandleVerifier instance. > > Since TraceLog is also part of base, there is also two instances > in each module. There are two instances of categories array that specify > which categories are enabled but only one is used by chrome tracing. > > A trace event executed in chrome.exe will never be enabled. This is > explaining why trace events from chrome.exe!HandleVerifier are not > emitted unless the build is a component build. > > To solve this issue, this CL is lifting the trace events before > entering the code that forward the call to chrome.exe. This way trace > events are using the right instance of TraceLog (e.g. chrome.dll). > > Bug: 1110507 > Change-Id: I61ee1e18b849d32f90d2430759da6d1c8666c854 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324873 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792764} TBR=gab@chromium.org,wfh@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110507, 1112636, 1111492 Change-Id: I30f956e4110a8ca008f2c290f3e0103374166f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339667 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#795476}
-
Patrick Noland authored
Bug: 1111296 Change-Id: I7f0609ee89c00362885cf9ab8df1b41d26ee453e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339703Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#795475}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If650993b533005bf17717c4e5c6788b59e38d19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795474}
-
Fabio Tirelo authored
This reverts commit 784ec9ef. Reason for revert: we suspect this is causing several browser_tests to fail on CrOS - more details at crbug/1113730 If tests don't go away, we will restart Skia roll-out and investigate it again. Original change's description: > Roll Skia from 1362c1eac458 to 7a171cca0ca4 (1 revision) > > https://skia.googlesource.com/skia.git/+log/1362c1eac458..7a171cca0ca4 > > 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC herb@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Cq-Do-Not-Cancel-Tryjobs: true > Bug: chromium:1104516 > Tbr: herb@google.com > Test: Test: Test: CQ > Change-Id: I11a7da040639041e1f7826d8f8847029b92ecc99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340929 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#795388} TBR=herb@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Id73d8938c14e8462ed474acceedbb4744e8cf4e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1104516 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341164Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795473}
-
James Vecore authored
This is a mock up of the Nearby Share on-boarding page. Specs/css strings, accessibility to be refined in another CL. This UI is gated behind the feature flag. Screenshot: https://screenshot.googleplex.com/hN3F6gjGFBJ The settings behavior wraps up the mojo interface into a Polymer property which can be passed down from the root object to the children to allow them to bind and edit settings. In this case, the app.js element hosts the settings object and passed it down to the on-boarding page with two-way binding. Change-Id: I2f1dbe25d0706597c94fc80393084570610424f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332988Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#795472}
-
Liviu Tinta authored
action.pointerMove requires integers as arguments. Change-Id: I3efad46da26fee54ab875e8d88b72a73c91c44c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332303 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#795471}
-
Tina Wang authored
When the settings are managed by enterprise policy, a "learn more" link should be shown in the popup bubble triggered by the information icon by the end of the settings item. Clicking "Learn More" will navigate to chrome://management page. Added access to settings below: - Settings -> Password -> Save password - Settings -> Payment Method -> Save and Fill Payment Methods - Settings -> Address and More -> Save and Fill Addresses - Settings -> Search Engine - Settings -> Content Settings -> Block Pop-ups Bug: 1109002 Change-Id: I4bdba99c1a4d2451a99ddeb8f048af77a2aaa334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337719 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795470}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae523ca9..f870c336 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7248052bf1505bb8a1ae4768e99ffdd99ae63ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795469}
-
Mark Cogan authored
The Clear Browsing Data flow uses the ChromeActivityOverlayCoordinator to block user interactions in the window in which it was triggered. To extend this to multiple windows, this CL adds an option to the activity coordinator to block all windows, implemented by triggering the blocking UI. that the blocking UI is shown in the other window. TEST: Opened two windows, opened History, chose Clear Browsing Data, saw Bug: 1045580 Change-Id: I8466cd8e67ddedce13c6db6580cd0d57b76b120d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339963Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795468}
-
Liviu Tinta authored
action.pointerMove requires integers as arguments. Change-Id: I6abacedba07090038aff38e9788eec5b0445d4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332330 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3545b42a10a..99f48c74ab76 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from bfe4f378aee6 to ef36eedb0d09 (1 revision) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8bc27a1cfbc1 to 5fd92a7e0c84 (5 revisions) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a4505d37ffe7 to a1c21580f50b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ibd5d730810955fb1fd9307a904a1c1263f59238b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341107Reviewed-by:
-
Ted Meyer authored
There is an upload warning for use of std::vector, with an attached note saying that it's acceptable at the blink/chromium layer, which I think this falls under. This CL should only be merged after the devtools frontend CL here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336204 This also adds a "Chapters" type to the enum used in TextTrackConfig because apparently that is a thing blink supports. Bug: 1090022 Change-Id: I19cd27b2c926bef1c36fed19efe8599c9d168386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337402Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795465}
-
Danila Kuzmin authored
Bug: 1113377 Change-Id: If0db3269c944955649caa486964dfcbdb1d2d329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339965Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#795464}
-
Greg Thompson authored
This metric provides a generally useful signal relating to enterprise report uploads. BUG=1097917 R=chromium-metrics-reviews@google.com, pastarmovj@chromium.org Change-Id: I010d212f97527e163180e85166bb3c94c44994f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339344Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795463}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/20d9bb09b493..fa830b464d9f 2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-06 jacktfranklin@chromium.org Tidy up type reference look-ups in bridges 2020-08-06 sigurds@chromium.org More comprehensive initiator tracking for developer resource loads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:974543 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I71e7012b90defa0086b4518ea77c7e5b85df8056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341113Reviewed-by:
-
Ewann authored
This CL prevents the Page Info view to be dismissed on device rotation. Fixed: 1112322 Change-Id: I11d5d4be1a5e3fbfedd94466c4dd5b1e9f3e1469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335286Reviewed-by:
-
Fabio Tirelo authored
TBR=agl@chromium.org Bug: 1104847 Change-Id: I661686203f8a652bde3c6094c6adff16675a877a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341142Reviewed-by:
-
Andreea Costinas authored
This CL starts the System-proxy worker which tunnels ARC++ traffic according to the |ArcEnabled| policy and forwards the address of the local proxy to ARC++ through the |ArcSettingsService|. It also introduces a new user preference that keeps track of the address of the local proxy worker and syncs with ARC when the address changes or System-proxy is disabled by policy. Bug: 1042639 Test: unit tests, browser test, manual test on DUT Change-Id: Ibe84d74353d5f75376393e7cd8745f63db073de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323521Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#795459}
-
Marc Treib authored
With password_manager::features::kEnablePasswordsAccountStorage enabled, there will be two PasswordStore instances, a profile-scoped one and an account-scoped one. This CL updates the setup of a few unit tests so they instantiate the account-scoped store in addition to the profile-scoped one. Without this change, the tests were hitting some DCHECKs when run with kEnablePasswordsAccountStorage enabled. Bug: 1098677 Change-Id: Ic31b5ff593139788b7ffbf8fd67a1d8edb401ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332602Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#795458}
-
Clovis PJ authored
Bug: 1109123 Change-Id: Ifa755c1d1a0325558f499ba0fc462559c9f47c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316209Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#795457}
-
Robbie Gibson authored
This reverts commit 6e145aaa. Reason for revert: Incorrect behavior when flag is enabled. Original change's description: > [iOS] Decouple Text Zoom flag from Dynamic Text size as default zoom > > Before, this happened by default. However, this was confusing, so now > there are two separate flags, so zoom can be enabled without changing > the default zoom level. > > Bug: 1113270 > Change-Id: I34e340c585c5ccccdfd278d96c21a53510b6a234 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339482 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795408} TBR=rohitrao@chromium.org,rkgibson@google.com Change-Id: I557c9410d721b27472bdb200f58462fa428fd8d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339987Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#795456}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcb6f8084e45..5d9552ef6987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icf82c3db86623988ccded4161790fa89b677df89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340639Reviewed-by:
-
Nela Kaczmarek authored
Bug: 1108279 Change-Id: I4984ea492a3274f02bca3b251cca1ff9014e36c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339661Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#795454}
-
Sergey Ulanov authored
After crrev.com/791485 GetSupportedFormatsMediaFoundation() was called with a null ComPtr<>, so the formats were not enumerated. As result DirectShow API was used instead of MediaFoundation. Fixed the call to make sure formats are enumerated properly. Bug: 1112947 Change-Id: I1beb0ee4c1d66826225efe8a27cb45eeb850d41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337635 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL does the following: - Adds text for the 'Add Space' button. - Unifies fonts based on mocks ~= 15px. - Fix ripple not visible for 'Add Space' button in dark mode. Screenshot: https://drive.google.com/file/d/1qY6jBrfHcAmj8wKBKqAxpo2roq0WcxDx/view?usp=sharing Bug: 1063856 Change-Id: Idfa836796975a4e9f8f1260173df9c2f266165ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339488 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795452}
-
Ewann authored
This Cl reoders custom actions according to the Design Doc. === 1. All Open Actions 2. All Actions that are unique to the feature (e.g. Mark as Read, Search for Image) 3. All Copy Actions 4. All Edit Actions (Edit and Move) 5. Share... 6. Delete (and in Red) === see: http://doc/18YOOXHNEYjiXMqVxC7mLKY54zopziHkpJovcIKB5Dp0 Bug: 1093302 Change-Id: Ib0e62dd6a5df1b81740a116861120caa8f7f5c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336833 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Jun Kokatsu authored
This change removes chrome://discards from NoTrustedTypesViolation test due to it being flaky. Bug: 1113446 Change-Id: Ie43141f203951d937f9aab105345a189eb181327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340782 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795450}
-
Clemens Arbesser authored
See also linked bug for more information. Bug: b/163024900 Change-Id: I608a35d636808f125c4f07c58c6b6a63ed1eaae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339468 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
nancylingwang authored
BUG=1083331 Change-Id: I91aa539a469d25dc283305def73287fdd34c114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308624 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795448}
-
Randy Rossi authored
Focus should only be set if the child tree is found. Otherwise, leave the focus set by the super method alone. This was causing the reader to lose focus on cast and webviews embedded in the display assistant's main tree. Bug: NONE Test: display assistant with youtube/weather app/page Change-Id: If82855ada00fa679806987e8f78332799d0e7015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339497Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795447}
-
Liquan (Max) Gu authored
Before: * PRImpl keeps the observer NativeObserverForTest as a local member, but the observer is set inconveniently with ComponentPaymentRequestDelegate. After: * PRImpl references the observer from ComponentPaymentRequestDelegate directly, no longer keeping it as PRImpl's own member. ComponentPaymentRequestDelegate does not need to help with setting the observer any more. Bug: 1102522 Change-Id: I2d35e498452441fbc696f12f76dcbd0e69eb31c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340227Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795446}
-
Xi Han authored
enabled. Without the check, it will trigger InstantStart code path and shows the overview list layout. A crash would happen since the overview list layout is null. Bug: 1110791 Change-Id: If8dfd07118effe71a001286fcf9cb0e7279c8f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336306 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795445}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a171cca0ca4..34949e35f006 2020-08-06 robertphillips@google.com Pull ShapeData into its own header file and rename to GrSmallPathShapeData If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I76913bc8661bc4effe28893bb10500b7376bb5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341108Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63 2020-08-06 fmayer@google.com Merge "Do not download t2t for --print-config." 2020-08-06 primiano@google.com Merge "Client Library: retry connections if traced is not running" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4fef4144b8cf7ef1e960932a15ecc851c91fb3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341104Reviewed-by:
-
