- 25 Oct, 2019 40 commits
-
-
Joon Ahn authored
tc/1073295953913769610 Bug: chromium:1005533 Change-Id: I8c1a688801b0b10a312a2e2ab1ad9a487123b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874015Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#709676}
-
Chris Lu authored
Since BadgeState is a mask, a direct equality comparison to BadgeState values for the BadgeItem properties is not the correct way to assess if a badge is accepted. To add testing support for this case, accepted a11y identifiers for BadgeButtons are created, and they will be properly set in setAccepted: in BadgeButton. This change is a relanding of crrev.com/c/1872938, which failed because iPhone SE's screen was not wide enough to contain all the view in Showcase. Changes were made in sc_badge_coordinator to create two rows instead of one. Bug: 976901, 1016793 Change-Id: Iadc7e3e42529ded0aa331da3845e8644e4cac9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881364 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709675}
-
Alex Keng authored
This CL adds a new flag, PasswordReveal, so the reveal button can be enabled later when ::reveal gets standardized. Bug: 1016844 Change-Id: Ic4d73b5e08c0ee2c9fc554f0f2e7331b4663e89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877141 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709674}
-
Ken MacKay authored
I am seeing component build failures on Chromecast unit tests; this CL fixes them. Change-Id: Ia2e1cc9d17fa9ef754a74483720cf82fd5d4140e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879318Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#709673}
-
Steven Bennetts authored
Bug: 965089 Change-Id: Ic2624b6f37686add1e6971503f46c74bfbfcf27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875522Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709672}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/91e3ebe46843..e95fc85cb76d git log 91e3ebe46843..e95fc85cb76d --date=short --no-merges --format='%ad %ae %s' 2019-10-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3c5165be..98ef1d68 (709394:709549) Created with: gclient setdep -r src/third_party/webrtc@e95fc85cb76d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie558201829f0b023ccf33ac25f76e30468a07692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709671}
-
Wei Li authored
The scroll style fix was due to a bug introduced from cl/270089435. Now they already fixed the bug in HaTS library code, so we can remove this hack. BUG=none Change-Id: I832dd33a10ad2091ae19e422e4f512b490af5fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880817Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#709670}
-
David Black authored
Currently we only check if Assistant is settings enabled, so the non-primary profile is able to see proactive suggestions despite being unable to use Assistant. Bug: b:143367826 Change-Id: I377b3c887ae9271dcf445866b65a45ddddc61f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880540Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#709669}
-
Martin Kreichgauer authored
This changes the chrome://settings/securityKeys credential management list layout from "website | username | checkbox" to "checkbox | website | username". Bug: 1008903 Change-Id: Id4f5b0b0e0a392dc3948f6f4ec49f076fc592888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872443 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Alex Cooper authored
The IsolatedXRGamepadProviderFactory was only used by WebVR. Since that has now been removed, we do not need to plumb the factory or create the gamepad provider to be considered a proper XRDevice. As a result of this the IsolatedGamepadDataFetcher is no longer used and can be removed. To better stage the cleanup, only the plumbing for the factory is being removed at this time. This will allow the runtimes to be refactored independently. When nothing implements the interfaces anymore they will be removed. Bug: 1017856 Change-Id: I87d92c6236ed547b16a32f507d6381636ef30a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880011Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#709667}
-
Stephen Martinis authored
Bug: 840252 Change-Id: I7181f1adde1d2b11b4ca5da6535210112f031317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877229 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709666}
-
Wei Li authored
The manual layout doesn't actually have any effect since View::Layout() is always called at the end to invoke layout manager to do the actual layout. BUG=1005568 Change-Id: I7821d5dcdc8aa6a4fd52c71a2847dd111e203094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867229 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709665}
-
Mason Freed authored
This CL was created (mostly) automatically with tools/perf/update_wpr script This updates the youtube 2019 story, which is necessary because the 2018 recorded story makes use of Polymer 1 and the deprecated (and soon to be removed) Web Components v0 features. This recording should not contain uses of those features, *except* for HTML Imports. That will likely require another re-record later. Bug: 911943 Change-Id: I1905308e0448ec85d6a581e7bccd72fe86b3bddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872157 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#709664}
-
Matt Menke authored
Currently an empty NetworkIsolationKey is always passed in in production, so this should not caching behavior yet. HostCache::GetAsListValue() and RestoreFromListValue() both read/write these fields now, so there will be a one-time loss of cached host entries. Also fix a pair of SerializeAndDeserialize tests that were looking at the HostCache the data was collect from, instead of the one that it was copied to. Bug: 997049 Change-Id: I16ac1247008b42398c23cd69a915e036a7c0ad7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880170 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#709663}
-
Thomas Lukaszewicz authored
Updated the find bar interface to specify a MoveWindowIfNecessary method without the need for an explicit selection_rect if not necessary given the context of the method call. Bug: 871419 Change-Id: Ia7dae9a1517a17fc0649885deca4aa223461b81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880076 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Avi Drissman authored
Bug: 1018333 Change-Id: I862c55482fabcdb1e8618f316969937957f1e9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880546 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709661}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66ce5c605a58..ddc6b4834534 git log 66ce5c605a58..ddc6b4834534 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 saklein@chromium.org portage_util: Verify tree_ids before populating ebuild. 2019-10-25 cjmcdonald@chromium.org Disable reverse dependency logic on full builders Created with: gclient setdep -r src/third_party/chromite@ddc6b4834534 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7924046d8ef23bd0d95fb1bd3601bd97c5b203b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881116Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie243b2e802c47623d7bc862b122dafd881fb55da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880465Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709659}
-
Nick Harper authored
Change-Id: I959d4f2699cafdfa9b9eae2c50ea4c0db89263ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880585 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709658}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a979b28cbbd0..7697476ad2d7 git log a979b28cbbd0..7697476ad2d7 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 emircan@google.com Disable async readback from protected memory 2019-10-25 herb@google.com Change from single prepareForDrawing to prepare[Mask|SDFT|Path]ForDrawing Created with: gclient setdep -r src/third_party/skia@7697476ad2d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8267e41f72318c92420fab0eec8837100662bb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881113Reviewed-by:
-
Tommy Li authored
In the status quo, all matches are culled if none of them have allowed_to_be_default_match() true. That's a bug, because there's legitimate exotic situations where truly none of the matches should be pre-selected: - DefaultSearchProviderEnabled policy == false - NTP on-focus suggestions (Enter should do nothing) It also removes a DCHECK that's not true. The DCHECK assumes that this can only occur for NTP on-focus suggestions. This also can occur for Enterprises that have disallowed by policy the default search provider. Note: Since we previously just culled all matches in the none-allowed-default case, it probably papered over some bugs. This CL is likely to expose those bugs, but I intend to fix them all as soon as we find them. If there's a crash bisected to this CL, don't revert this CL, message me instead. Bug: 1016845, 363656 Change-Id: I5b4333d3260f21d65500a5e49e3a5b77cd0735ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872485 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709656}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ibc9405d903008c5bebf04f558e1b2c42ba5ced4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879997Reviewed-by:
-
Min Qin authored
This CL moves DownloadInfo from chrome/android to chrome/browser/download. DownloadInfo.CreateOfflineItem() is removed as callers should now use DownloadItem.CreateOfflineItem() BUG=1013759 Change-Id: I71d9e8227a612830c2ce9a9e6c7c08fea3dcabd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879783 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#709654}
-
Etienne Bergeron authored
This CL is adding the support for decomposed unicode codepoint to the fallback fonts. An unicode string is made of sequence of codepoints. Some codepoints are not in the normal form (see below). It brings two issues 1) The Skia matchFamilyStyleCharacter(...) as no notion of decomposed codepoint and won't try to return a typeface for the decomposed codepoint. Harffbuzz that do the text shaping is performing the decomposition and is able to render text with a font that only contains the decomposed codepoint. Unfortunately, the previous code was not given a font for a given codepoint. Thus, we are adding the logic to call matchFamilyStyleCharacter(...) on codepoints and decomposed codepoints. 2) The logic to test that a glyph is part of a typeface rely SkTypeface API which is also not aware of character decomposition. To test if a typeface supports the codepoint, it must a) The codepoint has a corresponding glyph, or b) Every decomposed codepoint has a corresponding glyph see: https://en.wikipedia.org/wiki/Unicode_equivalence "" The standard also defines a text normalization procedure, called Unicode normalization, that replaces equivalent sequences of characters so that any two texts that are equivalent will be reduced to the same sequence of code points, called the normalization form or normal form of the original text. For each of the two equivalence notions, Unicode defines two normal forms, one fully composed (where multiple code points are replaced by single points whenever possible), and one fully decomposed (where single points are split into multiple ones). "" Example: U+fad4 Decomposed to U+4039 On windows, the font 'MS UI Gothic' doesn't contains U+fad4 but it contains U+4039 There is about 13k codepoints that has unicode decomposition. Bug: 1016641 Change-Id: I342f87ae7a05a99a9321b99e3728a6c1179eb1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879436 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709653}
-
Caleb Raitto authored
Change-Id: I95e0dc61710f1512a79b9329e8228e04c2899644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881508Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#709652}
-
Aaron Krajeski authored
It has become very flaky in the past couple of days. Bug: 1018336 Change-Id: Ieff3a1dfb16fdffde196d1192e752c912499c73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880543 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709651}
-
Ben Pastene authored
Similar to crrev.com/i/2022512, the public bots are creating SoM alerts. They likely shouldn't be since they're listed on the fyi milo console. This will make SoM aware that they're fyi. Change-Id: Ie849329d192fbc39e6c09c4e153d707de436183c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881353Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#709650}
-
Xianzhu Wang authored
We no longer mock non-overlay scrollbars. Still allow mock overlay scrollbars because overlay scrollbars may not be supported by the current platform native theme, but we want full test coverage of overlay and non-overlay scrollbars on each platform (especially when we are experimenting a feature on one platform (e.g. Linux) only). In web tests, we should either - Use native scrollbars. This is the most common case with this CL. - Use mock overlay scrollbars: When we want to test basic overlay scrollbar functionality. The blink mock overlay scrollbar theme override all functionality of the native theme, so it's platform independent. It's based on mobile overlay scrollbar which doesn't support hit testing. - Use --enable-features=OverlayScrollbar or --disable-features=OverlayScrollbar to force to enable/disable overlay scrollbars in both chrome and blink, if a test want to test the native overlay/non-overlay scrollbars. This might not work if the native theme doesn't support overlay scrollbars or non-overlay scrollbars, and we should disable the test on that platform. Some details: - Don't allow internals.settings.setMockScrollbarsEnabled and internals.runtimeFlags.overlayScrollbarEnabled. They are replaced by internals.useMockOverlayScrollbars(). - Remove another level of mocking in ScrollbarThemeAura when we are not using mock scrollbar in web tests. That level of mocking caused wrong button status in scrollbars. In a follow-up, OverlayScrollbarEnabled will be removed from RuntimeEnabledFeatures because it's blink-side only and setting it alone may cause inconsistent overlay scrollbar setting in blink and chrome. Will also apply the same mock overlay scrollbar policy on unit tests. R=pdr@chromium.org Change-Id: Ibd771c33c4c5c40d52d265f5f8ae0a9c9457030d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866913 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709649}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c29060c2..3c9b070c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I18163251ea8e3484c1673beff3609a6276394fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880960Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709648}
-
Sahel Sharify authored
This renames payment_method_change_response.idl to the more generic payment_request_details_update.idl name. payment_request_details_update.idl is the redacted version of updated payment details received from the merchant in case of payment method, shipping address, or shipping option changes. This redacted version is sent to the payment handlers to notify them about the changes in payment request details. The rename is needed since this is used for changes in shipping address/ option in addition to payment method. I will remove the stub mojo struct once the clank cl is landed: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2029744 TBR=mkwst@chromium.org Bug: 984694 Change-Id: I927f1fca7a58bcb640407544db4fc091f2ad7e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865469Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#709647}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86244d691364..4861444124e0 git log 86244d691364..4861444124e0 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 yura.yaroshevich@gmail.com Specify open file encoding explicitly. Created with: gclient setdep -r src/third_party/depot_tools@4861444124e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None Change-Id: I33b4d04f51d6b35a4fb4d09a065aea4977547ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879210Reviewed-by:
-
Dana Fried authored
For some reason, separator logic didn't always fill the separator when the resolution was not a multiple of 50%. It now fills the background. Spearators will still be 1 DIP rather than 1px. Bug: 1016760 Change-Id: I5cc8e9907c23d2db6ee519aa4298c2c99660cfb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880531Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#709645}
-
dalyk authored
Bug: 1018197 Change-Id: Id660174b4f96cb2c6103e04efeaf45ff1abf91bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880542Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4c954381ede93de6fd081c8295ba134130cbac58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881111Reviewed-by:
-
Ian Kilpatrick authored
These failures were primarily due to some missing logic within the NGBoxFragmentPainter for CAP. See: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8899518345262305936/+/steps/webkit_unit_tests__with_patch_/0/logs/Deterministic_failure:_All__x2f_BoxPainterScrollHitTestTest.ScrollHitTestOrderWithLocalBackgroundAttachment__x2f_1__status_FAILURE_/0 ... as an example of the failure. The additional CAP failure, also fails in the same way with: --blink-enable-features=CompositeAfterPaint --disable-blink-features=LayoutNG The code was effectively just lifted from BlockPainter. Bug: 988015 Change-Id: I8cf273e552b2e84246eef69910c8abace9a485b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869676Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
dalyk authored
Bug: 1018373 Change-Id: I9261f794749e250bd08265cf32596d6a2a766e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879204 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#709641}
-
Mohamed Heikal authored
This cl adds a new diff of class symbols in dex to the current diff of method symbols. Bug: 1012371 Change-Id: Ief062e055ad2eb96d22a4534fa4cfdfd8cbf8b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869835 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709640}
-
Ian Struiksma authored
4 password sites were failing on windows because the screen resolution was too small and thus the dynamic html was not consistent from recording (or linux replay). Update password captured sites cipd version to get thew new version of these sites. diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/capture_update_pass/nexon.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/capture_update_pass/nexon.test 44,61d43 < "selector": "//span[@data-v-5af1f5e3 and text()=\"My Account\"]", < "visibility": 7, < "context": { < "isIframe": false < }, < "type": "click", < "action_index": 5 < }, < { < "selector": "//nav/div[@data-v-5af1f5e3][1]/div[@data-v-5af1f5e3][2]/ul[@data-v-5af1f5e3]/li[@data-v-5af1f5e3][1]/a[@data-v-5af1f5e3 and @id=\"accountSetting\" and text()=\"Account Settings\"]", < "visibility": 7, < "context": { < "isIframe": false < }, < "type": "click", < "action_index": 6 < }, < { 66a49 > "force": true, diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/capture_update_pass/paypal.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/capture_update_pass/paypal.test 17,18c17 < < "selector": "//a[@href=\"/myaccount/settings/password/edit/\"]/span[text()=\"Update\"]", --- > "selector": "//div[@id=\"securityTab\"]/div/ul/li[1]/div[1]", diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/sign_up_pass/battle_net.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/sign_up_pass/battle_net.test 36,37c36,37 < "selector": "//div[@data-value=\"3\"]", < "visibility": 7, --- > "selector": "//div[@data-value=\"12\"]", > "visibility": 3, 43a44 > { "type": "PressEscape" }, diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/sign_up_pass/indeed.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/sign_up_pass/indeed.test 42c42 < "visibility": 7, --- > "visibility": 3, Bug: 984662 Change-Id: Ib82de8b9ca886bdedbcc0f217c5d3e576013f049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880016 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: -
ehmaldonado authored
Eexecuting tests with vpython on Windows fails like E:\chromium\src\out\debug_x64>git cl upload Running presubmit upload checks ... checking owners took a long time: 505ms** Presubmit ERRORS **ImportError raised: No module named win32pipe Traceback (most recent call last): File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 196, in main exit_status = run_checks(host, options) File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 154, in run_checks failures.extend(lint(host, options)) File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 44, in lint ports_to_lint = [host.port_factory.get(name) for name in host.port_factory.all_port_names(options.platform)] File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\factory.py, line 84, in get module = __import__(module_name, globals(), locals(), [], -1) File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\android.py, line 46, in <module> from blinkpy.web_tests.port import base File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\base.py, line 55, in <module> from blinkpy.web_tests.port import server_process File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\server_process.py, line 45, in <module> import win32pipe ImportError: No module named win32pipe Add pywin32 wheel to fix it. Bug: 1017410 Change-Id: Ic64fb6631fa113dfd5cce30a636daaa3be978d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876985Reviewed-by:
-
Sinan Sahin authored
These tests used to check if the ephemeral tab feature is enabled to add the context menu item to the expected items list. This CL updates them to use EphemeralTabPanel#isSupported() as #isSupported also checks if the device is low-end. Bug: 1018172 Change-Id: I7b05e7f736f3fbbfdfb4cd1d9df935497c1b4cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880958Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#709637}
-
