- 14 May, 2020 40 commits
-
-
Elly Fong-Jones authored
This change was generated with: find . -type f | xargs sed -i -e 's/\bDialogDelegate:://g' followed by some manual cleanup. Bug: None Change-Id: I042650c53bfd7e1d7fbab4cd963dced5a7a7aaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202141 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#768942}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd950196d58a..2c3d0672ade4 Created with: gclient setdep -r src-internal@2c3d0672ade4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,dfried@google.com Change-Id: Iecb0ca2b8891f02eac27f308c1e0845501b50eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768941}
-
zhaoyangli authored
This is in preparation for moving EG2 to CQ. These two form factors run in ios-simulator but not on any builder running EG2 tests. Adding these to catch any issue before moving EG2 to CQ. Bug: 1079456 Change-Id: I7a59250c87f9da7a76c74886fc39d3e6b15acc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186999 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#768940}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/90c7477737b9..8e272a6a2895 git log 90c7477737b9..8e272a6a2895 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tmathmeyer@chromium.org Don't word wrap long lines for titles and other properties. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8e272a6a2895 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1080571 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie959db328aa2cce9d9860eecafe56646a0e14439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768939}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: I0cd32b0a49c81efb02e862155aab6bf3d79d1c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197146 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768938}
-
phillis authored
This change makes the function name more specific for the web app installation dialog. Change-Id: Ia09e1d5bbd26ba24f2baaeb1c95bbb6feaba1592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202497Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#768937}
-
Tobias Sargeant authored
Test: Manual (added a dummy experiment to the shell and verified it was Test: set). Bug: 1066554 Change-Id: Idcb984615431693ed8277228d36a9f49f07339ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201766Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#768936}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9963e1930e93..25881af541ec git log 9963e1930e93..25881af541ec --date=short --first-parent --format='%ad %ae %s' 2020-05-14 cjmcdonald@chromium.org uprev_lib: Add richer return type to UprevChromeManager.uprev 2020-05-14 saklein@chromium.org commands.py: Disable eclean for factory install image. 2020-05-14 cjmcdonald@chromium.org pytest: Skip 'inside_only' tests when run with --no-chroot 2020-05-14 engeg@google.com cbuildbot: stop retrying builds 2020-05-14 shaochuan@chromium.org cros_mark_android_as_stable: verbose buildbot logging 2020-05-14 bpastene@chromium.org cros_chrome_sdk: Remove old items from the cache at every invocation. 2020-05-14 vapier@chromium.org chroot_lib: convert to python3 only 2020-05-14 vapier@chromium.org cros_sdk_lib: convert to python3 only 2020-05-14 vapier@chromium.org build_failure_message: convert to python3 only 2020-05-14 vapier@chromium.org build_summary: convert to python3 only 2020-05-14 vapier@chromium.org cidb/factory: convert to python3 only 2020-05-14 mmortensen@google.com Add GetBuildMetadata firmware/ec_firmware values and service method. 2020-05-13 henrysun@google.com octopus: shut down 11297.83 firmware branch builder 2020-05-13 inglorion@chromium.org cros_chrome_sdk: Enable use_goma_thin_lto when using Goma and ThinLTO 2020-05-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@25881af541ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Icdd2ca57da0435c8447a87ce1bf47f36e293161f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768935}
-
danakj authored
This is a reland of b7c7185e TBR=avi Original change's description: > Move InsertStyleSheet out of TestRunnerForSpecificView > > R=avi@chromium.org > > Bug: 866140 > Change-Id: I4684093db40f628b273c343352a74118830df824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202157 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768829} Bug: 866140 Change-Id: Icc9772b1380a0ecccafa992baa08e81f798cae0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202619Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#768934}
-
Nico Weber authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/5ed3c9cc..ab32747a ab32747a Make rebase_path("//foo", "//foo/bar/baz") return "../..". ac6cc95f Allow rlib linking into C++ targets. 07f614a8 Cease to specify extern dirs for proc macro deps. f8c5cf1d Fixing Rust targets depending on C source sets. 6523a5f8 Add script for finding unreachable targets 207400ce build/gen.py: Add --link-lib=LINK_LIB option. 16ab9cab Make "gn clean out/gn*" work. 6ed85ec5 Speedup --json=ide and --export-compile-commands=default 7c5d1002 Speed up generation of input files list. 14c9f946 Fix GCC compilation error edf6e8e2 Add StringOutputBuffer class. d2e84de8 Forbid Rust source_sets. 4cd7fe15 Avoid duplicating -Lnative rustc arguments. 4580b415 Remove duplicated -Ldependency arguments to rustc. 58af66ba Remove minor compiler warning 222ae505 rust-project.json support 56f058e1 Add support for Resources build phase to generated Xcode project 0695796d Modernize code in xcode_object.{h,cc} 6a6163c8 Fix formatting of PBXFileReference 3f916fba Set expected values by Xcode 11.4 d7a8d663 Fix formatting of PBXContainerItemProxy e858fe6f Sort test file references used for indexing XCUITest test cases 106738e2 Add filetypes for .xctest and .xpc files 2ca0e81b Fix formatting of COMPILER_FLAGS in generated project ec938dda Speed up label comparison d6131075 format: Don't crash on non-literal import a38ba1c8 README.md: Correct link to Quick Start guide 82d673ac format: Fix formatting not taking into account suffixes 5b7fa2a7 Fix incorrect line endings in win_util.h Bug: none Change-Id: I3b58ada2b8c92870e7ccce2dcf9f99014e3848b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202658 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#768933}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30ef5cb43761..053213d049fa git log 30ef5cb43761..053213d049fa --date=short --first-parent --format='%ad %ae %s' 2020-05-14 demorri@microsoft.com Add a pan-project presubmit check for commits in tree Created with: gclient setdep -r src/third_party/depot_tools@053213d049fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:869594 Tbr: agable@chromium.org Change-Id: Ibe6fb761006f232dbf04b85106af49536e13f5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768932}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I5a3c5446f8c1d225005605776f25880336518ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202519Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#768931}
-
Lukasz Anforowicz authored
The avoided conversion breaks compilation of string-literal based global initialization like the example below: struct MyStruct { int foo; CheckedPtr<const char> bar; } MyStruct g_foo = { 123, // Invokes CheckedPtr<char>'s constructor: "string literal" }; Bug: 1069567 Change-Id: I897a1fad9222b904ea6f70fd23bc508d253ff97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161146 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768930}
-
Regan Hsu authored
Before: https://screenshot.googleplex.com/2ougwchZvqU After: https://screenshot.googleplex.com/Xq9nNPQQaQA Fixed: 1081984 Change-Id: Ie7124973ade76e81f8a1559ca28e335347034a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200417Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768929}
-
edchin authored
crrev.com/c/2199891 introduces a reusable class for pointer interactions for non-button views. This class internally handles all the delegate callbacks. So usage is simplified to a single line. This CL should have no impact/change on the UI. Bug: 1073961 Change-Id: I219588b8354fc199d3e38f659c82010c001946fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199707Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768928}
-
Alice Wang authored
This CL ensures that the SettingsActivity is destroyed in SettingsActivityTestRule tearDown. This will reduce the flakiness once the signin mock environment teardown will be added in SigninTestUtil. Bug: 1004418 Change-Id: I52f1dd52f63ce02cc90a483efe9dca549c3b3f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184251 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#768927}
-
edchin authored
crrev.com/c/2199891 introduces a reusable class for pointer interactions for non-button views. This class internally handles all the delegate callbacks. So usage is simplified to a single line. This CL should have no impact/change on the UI. Bug: 1073961 Change-Id: I8d1f00801685267ca065b7e4565dbc08f77c07c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199728Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768926}
-
Clark DuVall authored
This version of initializeWebViewCompatibilityMode() is no longer used and can be removed. Change-Id: I15baa7245a1014562eba0152926f462e0facf2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202382 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#768925}
-
edchin authored
crrev.com/c/2199891 introduces a reusable class for pointer interactions for non-button views. This class internally handles all the delegate callbacks. So usage is simplified to a single line. This CL should have no impact/change on the UI. Bug: 1073961 Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768924}
-
danakj authored
On reply, run the v8 function in the frame that made the request, not the main frame. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: Ifcc67b8762a2b9160aea7091179c53f5c525739d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202166Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#768923}
-
Robbie Gibson authored
Bug: 1048193 Change-Id: I88197efee6176e72d9b4c6591bb17650158fdf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201599 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#768922}
-
edchin authored
crrev.com/c/2199891 introduces a reusable class for pointer interactions for non-button views. This class internally handles all the delegate callbacks. So usage is simplified to a single line. This CL should have no impact/change on the UI. Bug: 1073961 Change-Id: Ida7b1ae9e356d09a9faa666c0aaf4e39ef331b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200136Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768921}
-
Ahmed Mehfooz authored
Need to have the flag for events triggered by user set to true to ensure that accessibility events are triggered. Change-Id: I79ff64c3dc6f75b7040de77b3681498c471e5e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200629Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768920}
-
Ben Mason authored
This reverts commit fbbdb5fe. Reason for revert: Causing badging issue: crbug.com/1082741 Bug: 1082741 Original change's description: > Android: Use non-dummy multiprocessing in compile_resources.py > > Will be more relevant if we use more arsc filters. > Even so, speeds up command on my machine: 10.3s -> 7.7s > > Bug: 636448 > Change-Id: I9b3db23782282e3e13c613b0b64ff1375fb1422d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186756 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#766469} TBR=huangs@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 636448 Change-Id: I46916d8d8dbc4e00b004883734924bf49c01c1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202520Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#768919}
-
Fletcher Woodruff authored
Mark the ConverterResult histogram as obsolete because we no longer use a converter process for document scanning after crrev.com/c/2184871. Update the description of the ScanResult histogram to accurately reflect its existing usage. Update the owner of the ScanResult histogram to myself. Bug: b:155887488 Change-Id: I3f1285ab7546f7b1d071590acfa365f17b683962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199165 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#768918}
-
Patrick Monette authored
The members in ServiceWorkerClientInfo are currently redundant. First of all, the |process_id| and |route_id| are never used, because web_contents_getter is always valid for window clients anyways. In addition, it's possible to pass the frame_tree_node_id instead of the WebContents getter so that the previous users of the getter can call FromFrameTreeNodeId themselves, simplifying the class even further. Change-Id: I7418da9a1a3c11d4d6313dc00698bfaf4cef8e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173681Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#768917}
-
Mikel Astiz authored
Priority datatypes accommodate latency-sensitive features like SHARING_MESSAGE, so it's most appropriate to send commits in dedicated requests to minimize latency. This can make a noticeable difference if some other datatypes are busy uploading data, e.g. immediately after sync was enabled. Change-Id: Ia39557d245732ffb2f2ebaf0c1a9025ce4cc97ff Bug: 1056206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201598 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#768916}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4f3976e..204abd2 Bug: 1081973, 1018028, 1082448, 1056830, 1082455 Bug: 1082525, 1082533, angleproject:4242, angleproject:4417, 1060012, Bug: 1082559, 1082565, 1082592, 1082826 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I6230ee0916a0f105fe80e9b54ebdf6504bec5656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197156 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#768915}
-
Tomasz Wiszkowski authored
This CL addresses the problem where AutocompleteController sends unchanged list of suggestions to present. Bug: 1082619 Change-Id: I78a7fb2652f45eafadb891720131b355a0649a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202383 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#768914}
-
Greg Thompson authored
ImportantFileWriter has been leaking .tmp files in cases where third-party software prevents them from being used and/or deleted. This CL introduces ImportantFileWriterCleaner, an object in a browser process that cleans up any such .tmp files left behind by previous executions. BUG=1075917 R=gab@chromium.org Change-Id: I7516824bd7dfe884ca447642224bc340edfd3cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181276 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#768913}
-
Badhri Ravikumar authored
When user tabs over links and invokes context menu using Shift + F10, link related context menu items are not shown since link url under cursor value isn't set. This CL finds out the link url from the focused annotation and updates link under cursor value. Added unit test to test link under cursor value whenever focused annotation changes. Bug: chromium:994500 Change-Id: Iedb5db7fafcaeb47d1e1e5094b5f7e0553260cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173855 Commit-Queue: Badhri Ravikumar <bravi@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768912} -
Daniel Rubery authored
This CL adds logic to retry getting the FCM token when the result is ASYNC_OPERATION_PENDING. This fixes the use case of uploading multiple files at once. Fixed: 1078895 Change-Id: I36c1f04f54e2b3f0780d8d6be332300dd7944443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194352Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#768911}
-
Yoav Weiss authored
This CL turns on the feature flags for User-Agent Client Hints, as well as the Client Hints Feature Policy infrastructure. I2S: [1] One test [2] was impacted by a combination of this change and an issue related to the Client Hints infrastructure (but not to this change in particular). It is being tracked in [3] and fixed by [4], which we'll rebase and land once this CL lands (and both change the test). Bug: 928669 Change-Id: I0056827b739b0f6773a49fc8cffe456e5de21803 [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/A4wxFpvqUfA/g7iccl9ICgAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/2199266/8/chrome/browser/client_hints/client_hints_browsertest.cc#1879 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1082674 [4] https://chromium-review.googlesource.com/c/chromium/src/+/2201976 Change-Id: I0056827b739b0f6773a49fc8cffe456e5de21803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199266Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768910}
-
Justin DeWitt authored
This updates the bytecode verifier as well as the various android rules required to make this available to android_aar_prebuilt rules. Change-Id: I631c3133ef63e60c7d825c9ca2c5699e3b1c9c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199929 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#768909}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46b3bc6c24c2..2b7d96959916 git log 46b3bc6c24c2..2b7d96959916 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 handellm@webrtc.org RtpVideoSender: remove lock recursions. 2020-05-14 handellm@webrtc.org RtpSenderEgress: remove lock recursions. 2020-05-14 handellm@webrtc.org AudioProcessingImpl: remove lock recursions. 2020-05-14 titovartem@webrtc.org Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." 2020-05-14 titovartem@webrtc.org Revert "Revert back to using the task_queue_ for guarding access." 2020-05-14 danilo.bargen@threema.ch objc: Export RTCStatistics and RTCStatisticsReport 2020-05-14 tommi@webrtc.org Revert back to using the task_queue_ for guarding access. 2020-05-14 rgl@google.com Reland "Add an optional override for AudioRecord device" Created with: gclient setdep -r src/third_party/webrtc@2b7d96959916 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b9d23a21861b0794f3d966ab598cbb936f44872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768908}
-
Sammie Quon authored
This will improve fade in performance by delaying the creation of the heavy view until needed. It will transfer some delay to the tabbing animation but I think the tradeoff is worth it as, for example with 7 initially offscreen windows: 1) The performance drop will be split 7 ways (not exactly but rough estimate). 2) Fade in performance is about 3x worse right now and arguably more noticeable. Ran the test below (modified a bit) for 8 and 16 windows, 20 times each in a loop. Values are first fade in/average fade in/average container, machine is krane. Though would need to check the dashboards for the real truth. Before 8: 6/15/90 Before 16: 4/5/50 After 8: 18/61/89 After 16: 10/58/50 Test: Tast test ui.WindowCyclePerf Bug: 1078159 Change-Id: I2e7252089b7686b109cd5b196ba847eac29e97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197145 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#768907}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include HTML Imports tests, which appear to be fairly specific to testing the HTML Imports feature, and nothing else. The two folders that are moved here are: - fast/html/imports - custom-elements/imports This folder couldn't be moved because it relies on being in the http folder for served results: - http/tests/htmlimports Bug: 937746 Change-Id: I81949c567352054d9c3e1d90fc25018ed5ce6984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198460 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#768906}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/75ef5963b477..983211974bc4 git log 75ef5963b477..983211974bc4 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 enga@chromium.org Reland "Support depth32float sampling on D3D12" Created with: gclient setdep -r src/third_party/dawn@983211974bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iab4b702072843a48c5d6155a482b1685ced97716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768905}
-
Caitlin Fischer authored
Bug: 1047474 Change-Id: I51c040faeed7d94d5f9c5d15889fcd2517095e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198929 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#768904}
-
Ken Rockot authored
This introduces a new MojoDedicatedThread feature to Content which, when enabled, changes Mojo to use a dedicated background thread for receiving incoming IPCs rather than using Content's IO thread. The feature is disabled by default. Bug: 1082761 Change-Id: Ia68f288309a316be14b5254e9c4f006b6f8c74cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202143Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#768903}
-