GitLab

The search provider, home page and start pages override permission
messages each take a parameter describing the URL that the setting
can be changed to. This was being properly handed in
settings_override_permission.cc but not in the message formatters in
chrome_permission_message_rules.cc.

This change also removes the duplicate rules for these permissions.

BUG=496332

Review URL: https://codereview.chromium.org/1165553008

Cr-Commit-Position: refs/heads/master@{#333119}

BUG=chromedriver:1111
TBR=jbudorick@chromium.org

Review URL: https://codereview.chromium.org/1166633003

Cr-Commit-Position: refs/heads/master@{#333118}

Replace hardcoded variable sizes with sizeof.

R=eroman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1170493002

Cr-Commit-Position: refs/heads/master@{#333117}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/607696b0..f4760990

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1156273009

Cr-Commit-Position: refs/heads/master@{#333116}

BUG=493250

Review URL: https://codereview.chromium.org/1158033010

Cr-Commit-Position: refs/heads/master@{#333115}

This patch implements the basic functionality needed to make swarming
and isolates work w/ GN. It relies on GN's existing functionality
for dumping the runtime dependencies needed for a target, and adds
a new command to MB that will take the runtime deps for a target,
compute the command line needed for the target, and then generate
the .isolate and .isolate.gen.json files needed for the
'isolate.py batcharchive' command.

We still need recipe-side work for swarming to actually work, however.

In addition, the way to manage the command lines for a target is a total
hack that will need to be cleaned up in subsequent patches.

R=maruel@chromium.org, brettw@chromium.org
BUG=480053

Review URL: https://codereview.chromium.org/1168513006

Cr-Commit-Position: refs/heads/master@{#333114}

Android webview does not use chrome's concept of visibility. Treat
memory being set to 0 as signal to drop memory. And drop memory by
flipping the surface to invisible and back.

BUG=496057

Review URL: https://codereview.chromium.org/1164083003

Cr-Commit-Position: refs/heads/master@{#333113}

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=nick@chromium.org

Committed: https://crrev.com/422456f9d53f0bf936a64f21a1463fd0abd3df84
Cr-Commit-Position: refs/heads/master@{#333081}

Review URL: https://codereview.chromium.org/1159623009

Cr-Commit-Position: refs/heads/master@{#333112}

The latter is going away. Long live Implside painting. This
fixes cc/trees/layer_tree_host_unittest_animation.cc,
cc/trees/layer_tree_host_unittest_copyrequest.cc and
cc/trees/layer_tree_host_common_unittest.cc.

R=enne, vmpstr
BUG=413479
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1169643002

Cr-Commit-Position: refs/heads/master@{#333111}

This will allow us to use it in the Users page (and potentially others) for the
prefs where the checkbox being checked means the boolean pref is disabled, and
unchecked means enabled.

Example usage:

<cr-settings-checkbox
          pref="{{prefs.cros.accounts.allowGuest}}" inverted>
</cr-settings-checkbox>

BUG=495858

Review URL: https://codereview.chromium.org/1156783004

Cr-Commit-Position: refs/heads/master@{#333110}

Currently we only record non-root layer's position in the
associated TransformNode. In practice, root layer might always
be positioned at (0,0), so we might not be seeing the problem.
But in tests we can manually set root layer to have non-zero
position which will cause visible rects mismatch for property
tree verification.

One example is the unittest in this CL that root layer is positioned
at (60, 70, 100x100). Viewport size is (0, 0, 100x100) in target
space, so the visible rects of the root layer is clipped to be
size 40x30.

With the fix the unittest pass with property tree verification
turned on.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1159983010

Cr-Commit-Position: refs/heads/master@{#333109}

The corresponding valgrind suppressions have long since been removed, so match
the drmemory side. If they appear again, we should file new bugs and
investigate anew.

BUG=117427,79933

Review URL: https://codereview.chromium.org/1151883005

Cr-Commit-Position: refs/heads/master@{#333108}

BUG=494827

Review URL: https://codereview.chromium.org/1167063003

Cr-Commit-Position: refs/heads/master@{#333107}

This is to help the automation of converting tests to be isolated and run on
Swarming instead of locally.

R=jam@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1166993003

Cr-Commit-Position: refs/heads/master@{#333106}

BUG=465354

Committed: https://crrev.com/9c8e5d7259661cda32b698ee88254491e6984900
Cr-Commit-Position: refs/heads/master@{#333080}

Review URL: https://codereview.chromium.org/1160403005

Cr-Commit-Position: refs/heads/master@{#333105}

TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesForDesktopAreRecorded
TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenNullWindowWasActivatedLast
TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenADifferentPositionableWindowWasActivatedLast
TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenTheSamePositionableWindowWasActivatedLast
TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWhenANonPositionableWindowWasActivatedLast
TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNonPositionableWindowBetweenTwoPositionableWindowActivations
TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNullWindow
TEST=DesktopTaskSwitchMetricRecorderTest.ActivateNonPositionableWindow
TEST=DesktopTaskSwitchMetricRecorderTest.ActivatePositionableWindowWithNonInputEventReason
TEST=DesktopTaskSwitchMetricRecorderWithShellIntegrationTest.ActivatePositionableWindowWithInputEvent
TEST=DesktopTaskSwitchMetricRecorderWithShellIntegrationTest.ActivatePositionableWindowWithNonInputEvent

BUG=489813, 489814

Review URL: https://codereview.chromium.org/1153633006

Cr-Commit-Position: refs/heads/master@{#333104}

R=khorimoto@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1166003003

Cr-Commit-Position: refs/heads/master@{#333103}

The right branch of the ternary was an rvalue, so the entire ternary operator made a copy of the child to parent map. This is expensive and is unnecessary.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1156303013

Cr-Commit-Position: refs/heads/master@{#333102}

We always update the model refreshSelectedTab, but that should not
end up making any visual updates. In onPrimaryColorChanged we should
be checking the model for isUsingBrandColor.

BUG=497241

Review URL: https://codereview.chromium.org/1148323009

Cr-Commit-Position: refs/heads/master@{#333101}

When navigating cross-process, we use swapped-out RenderFrameHost as placeholders. The goal is to replace this with RenderFrameProxyHost, which is already the case for all subframes, but not the main frame. The code is far along that this can be done now for the main frame as well.

This CL starts the path to removing the swapped-out RenderFrameHost concept by deleting the RenderFrameHost for the main frame on cross-process navigations and only keeping a RenderFrameProxyHost around. It is doing this for --site-per-process only, so all details can be fleshed out. Subsequent CL will remove the --site-per-process restriction and enable it in all modes of Chrome.

BUG=357747

Review URL: https://codereview.chromium.org/1142123002

Cr-Commit-Position: refs/heads/master@{#333100}

BUG=426500

Review URL: https://codereview.chromium.org/1167563003

Cr-Commit-Position: refs/heads/master@{#333099}

"base/basictypes.h" in net/base/mime_sniffer*.

R=asanka@chromium.org
BUG=488550
TEST=none

Review URL: https://codereview.chromium.org/1151353005

Cr-Commit-Position: refs/heads/master@{#333098}

The stack doesn't make sense, so it could be a DrMemory bug or surprising
function merging.

TBR=bruening@chromium.org
BUG=487500

Review URL: https://codereview.chromium.org/1152053003

Cr-Commit-Position: refs/heads/master@{#333097}

R=bnc@chromium.org,cbentzel@chromium.org
BUG=382120
TEST=none

Review URL: https://codereview.chromium.org/1169603002

Cr-Commit-Position: refs/heads/master@{#333096}

This CL takes care of moving unittest file to cc/base. The
ListContainer class now gets tested using dummy classes of following
types -

1. DerivedElement - This has classes derived from it. This tests
classes created using ListContainer(size_t max_size_for_derived_class)
constructor.

2. NonDerivedElement - This does not have any classes derived from it.
This tests classes created using ListContainer() constructor.

BUG=492952
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1165653002

Cr-Commit-Position: refs/heads/master@{#333095}

Pulls methods from the Impl into the Interface so that
ChromeActivity can take in a generic TabCreator instead of
a ChromeTabCreator implementation.

This is prep work for making it so that document mode's TabDelegate is also a TabCreator, which will let it be
usable in webapp mode for handling window.open calls.

BUG=451453

Review URL: https://codereview.chromium.org/1163173002

Cr-Commit-Position: refs/heads/master@{#333094}

This test becomes invalid with the upcoming angle changes. This test
expects webgle_dot_emu to be always there in translated shader source
but with the constant folding implemented in ANGLE for built-in
'dot', 'dot' function call will be replaced by actual result when all
the arguments are constant expressions and webgl_dot_emu will no
longer be there in translated shader source.

R=zmo

Review URL: https://codereview.chromium.org/1161463013

Cr-Commit-Position: refs/heads/master@{#333093}

This found a bug in saturated_cast that was covered by ClampToInt tests
so it fixes that.

If you have a floating point value of MAX_INT, then comparing an
integer against it for equality with promote it to a float and
it will compare true. However if you cast the float to an int, its
actually outside the bounds of integer, so you can end up with a
negative int as a result. Added unittests to check this for
saturated_cast.

Review URL: https://codereview.chromium.org/1164063005

Cr-Commit-Position: refs/heads/master@{#333092}

This is a port of https://codereview.chromium.org/475273002 to gn.

Also add a comment that explains that the skia_opts target in the GN build
isn't correct.

BUG=491209,82385,496512

Review URL: https://codereview.chromium.org/1155243010

Cr-Commit-Position: refs/heads/master@{#333091}

We need a hook to customise how MediaPipelineDevice is created,
orthogonal to the vendor-specific aspect of creation.  Decided to
keep existing factory method for the vendor customisation so there's
no need to change vendor implementations for now (although this
will all get moved into libcast_media before long).  New hook is
in CastContentBrowserClient and can be substituted as the other
Platform* functions already are.

BUG=

Review URL: https://codereview.chromium.org/1168643004

Cr-Commit-Position: refs/heads/master@{#333090}

This way apps can make assumptions about orders of destruction of message loop, delegate, applicationimpl and it works the same across all apps.

Review URL: https://codereview.chromium.org/1154113007

Cr-Commit-Position: refs/heads/master@{#333089}

SSLConfigService::GetSSLConfig is not thread-safe. This should also resolve the
test flakiness; the policy change applies on a thread hop, so the value must be
queried on a subsequently scheduled hop.

Add a DCHECK to SSLConfigServicePref to catch this in future.

BUG=496872

Review URL: https://codereview.chromium.org/1164063004

Cr-Commit-Position: refs/heads/master@{#333088}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cb67414..b500ffa

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1164973005

Cr-Commit-Position: refs/heads/master@{#333087}

This reverts commit 422456f9.

TBR=zea@chromium.org
BUG=465354
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1170623003

Cr-Commit-Position: refs/heads/master@{#333086}

This CL fixes a bug where we were incorrectly building the
chrome_template_resources target with manifest_package = "org.chromium.chrome" for
internal Chrome builds.

This CL makes chrome_public_apk (which is not shared with the internal build)
depend on chrome_template_resources instead of chrome_staging_java (which is
shared with the internal build). This allows the internal build to depend on a
chrome_template_resources-like target which uses the correct package name.

BUG=495428
TEST=None

Review URL: https://codereview.chromium.org/1161833003

Cr-Commit-Position: refs/heads/master@{#333085}

Blink currently does this operation on its display item lists to remove
superfluous begin/end pairs. To port Blink's current display item list
operations, such an operation is required.

This is not possible when in "cached picture" mode, but Blink currently only
does this on the unmerged list (in blink::DisplayItemList::add), so this should
be sufficient (if unfortunately asymmetric).

BUG=484943
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1163803003

Cr-Commit-Position: refs/heads/master@{#333084}

Revert of ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (patchset #3 id:40001 of https://codereview.chromium.org/1160403005/)

Reason for revert:
Broke IOS_Device compile.
https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/8802

Original issue's description:
> ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs
>
> BUG=465354
>
> Committed: https://crrev.com/9c8e5d7259661cda32b698ee88254491e6984900
> Cr-Commit-Position: refs/heads/master@{#333080}

TBR=stuartmorgan@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465354

Review URL: https://codereview.chromium.org/1167533009

Cr-Commit-Position: refs/heads/master@{#333083}

This change addresses some concerns raised post-submit in my
previous CL: http://crrev.com/1151833003

BUG=480604

Review URL: https://codereview.chromium.org/1156573006

Cr-Commit-Position: refs/heads/master@{#333082}

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/1159623009

Cr-Commit-Position: refs/heads/master@{#333081}

BUG=465354

Review URL: https://codereview.chromium.org/1160403005

Cr-Commit-Position: refs/heads/master@{#333080}