- 08 Apr, 2019 40 commits
-
-
Yi Su authored
This CL fixes the layout defect of TableViewDetailIconItem, which causes an unsmooth animation when the labels' text are updated. The solution is to use AutoLayout constraints instead of calculating width of both labels during UIView.LayoutSubviews. It's hard to prove that the constraints are correct, but it works :D Screen shot: https://drive.google.com/open?id=1UJoZ81NXE0gPQab80cGBVQFOVHqh1BBm Bug: 927682 Change-Id: I516469c7bd1bcbdfeebd7d9ddfe492fa39cd28a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554354 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648602}
-
Ryo Hashimoto authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8ba4296f282c..4ebef283ecc4 $ git log 8ba4296f2..4ebef283e --date=short --no-merges --format='%ad %ae %s' 2019-04-03 hashimoto arc: Add ARC Custom Tabs experiment 2019-03-25 louiscollard u2fd: Send dbus signal when receiving WINK command Created with: roll-dep src/third_party/cros_system_api Bug: None Test: trybots Change-Id: I4431b2a9d6c8865407b6a5e659a47fcf6bcb82f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556870Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#648601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c93072d97d4..dcaab6056568 Created with: gclient setdep -r src-internal@dcaab6056568 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I8c672acc33dbacce5794cf4b3d7784041eaf27df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648600}
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/mediastream, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I3e86523a6f71145ba7d80cd2c8a1f4c4dcb55e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554357Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#648599}
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/loader/fetch, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I5f3ce00e79d24a9e9505332dcbef159ffc194e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554922 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#648598}
-
David Staessens authored
The default video can now be overwritten when running a perf test by calling: ./video_decode_accelerator_perf_tests <test_video>. TEST=ran new VDA perf tests on nocturne BUG=925714 Change-Id: If095dcb75f70df12852bdc95e2ba45e8dda7b3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550179 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648597}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/quota, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic4efd311ff18194e6794f91ab7a7dc1d080c3c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556864Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/serial, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I8fd18e5e047eadc90fd26652bfa180fad97314c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557661Reviewed-by:
-
Noel Gordon authored
Build with -s NO_DYNAMIC_EXECUTION=1, which prevents emscripten eval() and new Function() code generation. Add a test chrome extension that <script>-adds the generated wasm code in its background page, with a strong CSP policy that includes wasm "content_security_policy": script-src 'self' 'wasm-eval'; ... Add piex.cpp main() that prints a simple salutation. In developer mode one could load the unpacked extension from this directory, and see the salutation in the console by inspecting its background page. Eventually, we should add an automated test in image_loader, or above, to test the wasm loading. Bug: 935285 Change-Id: I00b684c1bfac82da39cb0be6e15da8fafd72bc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556961 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#648594}
-
Dominic Battré authored
This reverts commit afff956d. Reason for revert: Speculative revert for MSAN failures, see crbug.com/950433 Original change's description: > [mojo-core] Support pipe splicing > > This change allows message pipes to be "spliced" into other message > pipes, unifying their message queues while retaining their logical > independence for routing of written messages. > > This is supported by adding an array of per-handle options and flags to > MojoAppendMessageDataOptions. If a handle is marked with > MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, > sending that message will effectively cause the handle and its peer to > be spliced into the sending pipe. > > See bug for design doc link. > > Bug: 941809 > Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648579} TBR=rockot@google.com,oksamyt@chromium.org Change-Id: I8fe5e72cd831dbb60d3898a623068f87c77fccdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941809,950433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557015Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#648593}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 48a29708. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c91944 "Change XRRigidTransform inverse method to attrib" 421cce6c "Fix a lot of RTCDataChannel parameter checks" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874c "[WPT] Fix JSON decoding errors in referrer-policy on Safari" fcd2c80d "Parse values in feature policy declarations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a6eb64a5ffaf919897f3b2faf54b85a937a904c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557738Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648592}
-
Takashi Sakamoto authored
non_network_service_webkit_layout_tests is failing on Linux Tests(dbg): - http/tests/inspector-protocol/network/request-interception-request-id.js - virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/request-interception-request-id.js Bug: 950412 Change-Id: I94da5efa2851c7ae064ba6b2a5c2a7057ef46c60 TBR: beverloo@chromium.org Change-Id: I94da5efa2851c7ae064ba6b2a5c2a7057ef46c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556867Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648591}
-
Dan Elphick authored
Uses Context version of Object::Set and calls Check on the result as these are cases where it cannot fail. Bug: v8:7283, v8:8834 Change-Id: I3d8e619eded799f285604d049f0e2fb64f5d5500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553419Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e320433533..4c93072d97d4 Created with: gclient setdep -r src-internal@4c93072d97d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I97ae4d6a31febd3c3524c5276ec353281282042b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556443Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/peerconnection, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I76d92b5b1d8043189239d2b089283790f90acead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556960Reviewed-by:
-
Richard Li authored
Since conversion will be made between blink::ResourceRequest and network.mojom.URLRequest in the followed work, moving this function will make it available in both content/ and blink/ folder. Bug: 860403 Change-Id: I46553a072a17a19941a44fe9e05f2a48284a73f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548776 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#648587}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/media{_controls, capturefromelement, recorder, session, source, stream}, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. Additionally, this CL removed Foo::Create() in modules/installedapp as well. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibcfcd52bc8895fe2ca3eae146cc2b7a5083dfc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556957Reviewed-by: -
Hirokazu Honda authored
This enables LibYUVIP to convert RGBA image to NV12 image. Since there is no libyuv function to convert RGBA to NV12. We tentatively converts RGBA image to I420 image, and thereafter convert the I420 image to NV12 image. Bug: 944823 Test: image_processor_test Change-Id: I04933ce543a92154b756903080123c885608ac85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553049 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/navigatorcontentutils, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib186b8359fc5f72ea26ebfa8587813177d5f13a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556862Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/netinfo, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ica09e05246b9a8e830498c4fb2c5be5d836d59b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556958Reviewed-by:
-
Christopher Lam authored
This CL adds a completion callback for SynchronizeInstallApps similar to Install/UninstallApps. This is in preparation for adding a OneShotEvent to the SystemWebAppManager which will allow clients to start tasks once all System Web Apps are installed. To test that the callback is run at the correct time, TestPendingAppManager now installs/uninstalls apps asynchronously (which more realistically simulates the production control flow). TBR=khorimoto@chromium.org Bug: 836128 Change-Id: I755a0a716554e27baa6e894a5b8b02635118c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545370 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#648582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff7e80ae..e3b2feb3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia866135a0f9b0696f98f536090f92b69b2723f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557736Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648581}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4fe0db08d90..731eaa372a59 git log a4fe0db08d90..731eaa372a59 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fb201c5e208d..90b1865e2a8b (10 commits) 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3e2882be..afd96fdc (504 commits) Created with: gclient setdep -r src/third_party/skia@731eaa372a59 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I37717d46b9ac429c77e368755e5b5ed21e6f0edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648580}
-
Ken Rockot authored
This change allows message pipes to be "spliced" into other message pipes, unifying their message queues while retaining their logical independence for routing of written messages. This is supported by adding an array of per-handle options and flags to MojoAppendMessageDataOptions. If a handle is marked with MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, sending that message will effectively cause the handle and its peer to be spliced into the sending pipe. See bug for design doc link. Bug: 941809 Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648579}
-
Yu-Hsuan Hsu authored
The OutputDevice will try to connect to CRAS server when it is created. If we create the OutputDevice too early, CRAS server may not be ready yet so that the connection will fail. It causes this audio dispatcher turns to use fake device. To fix this problem, we can make the OutputDevice created when starting playing. Bug: 847212, 948806 Change-Id: Ib06f0d2db659f3081df28e2c5c40793a25e988b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556655Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Auto-Submit: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648578}
-
Tina Wang authored
Add "Send Link to Your Devices" option to link context menu. - Add item before "Save Link As..." option. - Add separator to make it a separate section. - Add icon to the option works both in light mode and dark mode. The option will be enabled when the link url is valid (When it is http or https, not chrome native page). Add Histogram metrics. Screenshots: https://screenshot.googleplex.com/kNDVRRnFQpw https://screenshot.googleplex.com/6wChJm0ijkA https://screenshot.googleplex.com/0NpXU25vzY0 Bug: 939512, 945988, 948817 Change-Id: I31e3d2d1ffb579ceeee516300a7e367d7667dd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547938 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#648577}
-
Frank Liberato authored
This reverts commit 58ec016f. Reason for revert: crbug.com/950384 Original change's description: > MCVD: Remove shared image pool. > > Remove shared image pool which was used to manage shared image > destruction when video frame is destroyed/released or command buffer > stub is destroyed. This pool used to observe command buffer stub > destruction to clear the shared images. > > With this CL, shared image stub will now destroy the shared images on > video frame release callback. There is no need to observe command buffer > stub destruction or do anything on shared image stub destruction since > shared image stub destruction causes all shared images to be destroyed > in its destructor. > > Bug: 900963 > Change-Id: Ib03af245b6feb3d54d0f4e38a94a2700c600fd5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546360 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648432} TBR=liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950384 Change-Id: I1fa29a92435a649a11141b7cdf970b4152874cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557735 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#648576}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/951182bd19dc..a4fe0db08d90 git log 951182bd19dc..a4fe0db08d90 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0e3d328ac338..4ba1911b2d7f (14 commits) Created with: gclient setdep -r src/third_party/skia@a4fe0db08d90 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I75061c5d4689cf17a0ad2156debf8527efcd79bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556442Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/201a148bbf47..10e320433533 Created with: gclient setdep -r src-internal@10e320433533 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I3ebd12bd89734a45b3ee92592d1deb81eeee7094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556441Reviewed-by:
-
Samuel Huang authored
This reverts commit 07619eb1. Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions. Original change's description: > Clear inapplicable disable reasons for component extensions > > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set. > > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated. > > Bug: 946839,947305 > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens. > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648464} TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946839, 947305 Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648573}
-
Takashi Sakamoto authored
This reverts commit f8d4ff98. Reason for revert: This patch causes components_unittests failure on Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/16055 PaymentRequestSpecTest.ShippingOptionsSelection PaymentRequestSpecTest.ShippingOptionsSelection_NoOptionsAtAll PaymentRequestSpecTest.UpdateWithNoShippingOptions E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916905883293367392/+/steps/components_unittests/0/logs/Deterministic_failure:_PaymentRequestSpecTest.ShippingOptionsSelection__status_CRASH_/0 Original change's description: > Reland: [Payment Request] Add optional promise to show(). > > Originally landed in: https://crrev.com/c/1496920 > > Reverted in: https://crrev.com/c/1552254 > > Reason for revert: Browser test > PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress sometimes > times out on Windows and Mac build bots. > > Justification for reland: Disabled the flaking test on the affected > platforms. > > Original patch description: > > > Spec change: > > https://github.com/w3c/payment-request/pull/672/files > > > > Intent to implement and ship: > > https://groups.google.com/a/chromium.org/d/msg/blink-dev/Lc2qCQgqqqk/NKOqwNweBQAJ > > TBR=danyao@chromium.org, yusufo@chromium.org, kenrb@chromium.org > > Change-Id: If4add36348ede9933c60b444a65a13a27ab7287e > Bug: 817073 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553170 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648493} TBR=kenrb@chromium.org,rouslan@chromium.org,yusufo@chromium.org,danyao@chromium.org,danyao@chormium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817073 Change-Id: Ic8698f290ec7aaf0ebead6aa598fffbc0f31bf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556857Reviewed-by:
-
Joel Hockey authored
* Add share-with-plugin-vm and manage-plugin-vm-sharing commands These commands call through to the related FMP crostini commands and set vmName to PluginVm rather than termina. * Refactor crostini_share UI test to work for either crostini or Plugin VM Bug: 946273 Change-Id: I66a2610f0fffc33c08ccedf38ca8a7efd0e9a678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556815 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 935285 No-try: true Change-Id: I4149d97f8bf845dc6c7e5d38e047340c4841de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556658Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648570}
-
Takashi Sakamoto authored
E.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32600 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916783451242005184/+/steps/unit_tests/0/logs/Deterministic_failure:_ComponentLoaderTest.AddOrReplace__status_FAILURE_/0 TBR=jorgelo@chromium.org,leecy@chromium.org,stephenlin@chromium.org,abutzier@google.com Change-Id: Ib1011c9ef7b678795bf90a42c39441b419d50ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556817 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 37ca4422. Reason for revert: This patch causes content_browsertests failure on Linux MSan Tests bot: SitePerProcessBrowserTest.PageScaleFactorPropagatesToOOPIFs SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/0 TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/1 E.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/16056 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916784244150440112/+/steps/content_browsertests/0/logs/Deterministic_failure:_SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest__status_CRASH_/0 Original change's description: > Throttle Pinch-Zoom Re-Rastering in OOPIFs > > This CL implements pinch-zoom re-raster throttling for OOPIFs by making > OOPIF compositors aware of when the main-frame is active in a pinch > zoom gesture. > > It achieves this by receiving |is_pinch_gesture_active| via the > FrameVisualProperties sent to the FrameConnectorDelegate and appending > it to the VisualProperties synced from the browser process to subframes. > Then is is plumbed into the compositor along the same route as > |external_page_scale_factor|. > > An existing test for propagation of PageScaleFactor to subframes has > been enhanced to verify the value propagates from mainframe to > subframe, and from subframe to sub-subframe. Another test verifies > the flag makes it into the compositor when VisualProperties are synced > to the RenderWidget. > > Bug: 924336 > Change-Id: Ie6ed3be5e2a6c2e7fcfa2eb25a2ae40e2421fc99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483734 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648489} TBR=danakj@chromium.org,kenrb@chromium.org,alexmos@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 924336 Change-Id: Ie2b31a7b970b02f95e002778177442304274097d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557476Reviewed-by:
-
Kush Sinha authored
Please check the attached bug for context. Bug: 950258 Change-Id: Ib05f8e2c41ea07c95e639c240660af6a588af5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556833Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#648567}
-
David Staessens authored
Introduce media/gpu/test/OWNERS and media/gpu/linux/OWNERS to have more granular control over ownership. BUG=None Change-Id: I124e61e80361bd72a29b7a1daadc3b23aab4258a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553123Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#648566}
-
Noel Gordon authored
Bug: 935285 Change-Id: I567328d12eb84f721227eca4cadfc451baccd8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556956 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
The golden file contained null bytes, which made it look like a binary file. Strip null bytes from the result strings that caused that (maker and model). With that change, the command % file images.golden.hash reports ASCII text, rather than binary data. Remove images.golden.hash herein (will re-add it as text in a future change). Bug: 935285 Change-Id: Ifef49b40a8c00bc5d64f67b2a4e0728e1492f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557474Reviewed-by:
-
Katie D authored
Bug: 943703 Change-Id: I8e65b251aac54c7e70e503bb7eea4e6513b6b35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555008Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#648563}
-
