- 26 May, 2020 40 commits
-
-
Charlie Hu authored
base/containers/flat_set.h included in feature_policy.h also caused flat_set being exposed and used in memory_managed_paint_canvas.h. Replace the usage with WTF::HashSet as base/.. is a illegal path to include in files under third_party. Change-Id: If4bc800ea30b3fda4d6ab2554a21c8c6ebf14a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211908 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#771903}
-
ssid authored
The agent was only created in renderer processes earlier. Change-Id: I7238a73d2c8d9b0ba1c5b52d9acfd4161c5cac91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208081Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#771902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61fc1e664eac..1f6c971abea1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com Change-Id: I79eedb583cb59790eb3dbfbb6f035d1a0767b7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771901}
-
Dan Harrington authored
FeedStreamApi changes - Added CreateEphemeralChangeFromPackedData, which moves responsiblity for deserializaing into the component. This required adding a proto file, since we don't already have a message that contains exactly what we need. - Added ProcessThereAndBackAgain and hooked it up to our uploading logic FeedStreamSurface changes - Implement LoadMore(), CommitEphemeralChange(), DiscardEphemeralChange() - Changed ExecuteEphemeralChange() to take a new serialized proto message Bug: 1044139 Change-Id: I5d3cf0f6dc87ec984593d3641baedd97535bccb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210907Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#771900}
-
bttk authored
Bug: 865801 Change-Id: I8025699a43df94a67991799983f03f0f242d7d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212996Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771899}
-
Yue Zhang authored
Currently, TabGridDialog component uses PopupWindow as a container which has shown some disadvantages as feature evolves (https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing) This CL removes the PopupWindow usage in TabGridDialog. Things happened in this CL: * Instead of using PopupWindow as a container, we insert the inflated view into the root view hierarchy and make all TabGridDialog instances share this same view. * Use the ScrimView in RootUiCoordinator instead of creating a new one. This gives us a bonus that the scrim now covers the status bar. * Tweaks in TabGridDialogMediator to make sure the component behaves the same before/after. * Fix tests to adapt to change that TabGridDialog is not in a separate window. Bug: 1069803, 1064140, 997239 Change-Id: I1da2db2bf7ef5b8f304782c4bcc95e951b23623b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119188 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771898}
-
Anders Hartvoll Ruud authored
The RuleSet of an ActiveStyleSheet can be nullptr for non-matching media (see StyleEngine::RuleSetForSheet), hence we can't DCHECK that it exists. Bug: 1085994 Change-Id: Iac7f746045f46ad7752b30cccce8b6f403cf19b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214537Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#771897}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea71aeab0bfb..603989e2c0d6 2020-05-26 andreas@apap04.com add clarification for Python 3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7eb7d7e97cd2f47c3a48a3309597f00207d2b540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771896}
-
Matt Menke authored
We want to be able to DCHECK that all requests have a non-empty IsolationInfo, and it's safest to just separate out these fetches, rather than reuse something else's IsolationInfo. Bug: 1082280 Change-Id: Ib734910cc16a555673e4127317d05d80ca119f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212442Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771895}
-
Wan-Teh Chang authored
ITU-T H.273 (Coding-independent code points for video signal type identification) Section 8.3 (Matrix coefficients) says: - Otherwise, if MatrixCoefficients is equal to 8, the following applies: - If BitDepth_C is equal to BitDepth_Y, Equations 44 to 46 apply: Y = Round(0.5 * G + 0.25 * (R + B)) (44) Cb = Round(0.5 * G - 0.25 * (R + B)) + (1 << (BitDepth_C - 1)) (45) Cr = Round(0.5 * (R - B)) + (1 << BitDepth_C - 1)) (46) NOTE 4 - For purposes of the YCgCo nomenclature used in Table 4, Cb Cb and Cr of Equations 45 and 46 may be referred to as Cg and Co, respectively. ... In Table 4, MatrixCoefficients value 8 is YCgCo. Change-Id: Id597cdfba8b0550dbbf05975e744e2ba31ecb623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211925Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771894}
-
Michael Spang authored
As of skia d8fd0bf574 ("Remove deprecated flush calls.") flush() is flushAndSubmit(). Change-Id: I34a1a72bc8857a994e8a35858950882841a96a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213336Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771893}
-
Alexander Dunaev authored
This CL converts the ui::FilenameToURLPolicy enum into enum class. No change to any logic is done. Bug: 1070138 Change-Id: I595e3050cef597a1eb30bae5433eafc7698458c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212171 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#771892}
-
Jeremy Roman authored
Change-Id: Ib6994252e9cf8d620149e4feda128ac98c984c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176931Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771891}
-
Xianzhu Wang authored
TL;DR, with this CL: - We no longer update custom scrollbar part position during paint; - We avoid unnecessary ScheduleAnimation when painting custom scrollbars; - CustomScrollbar::*Rect() methods no longer have side effects; - Some FIXMEs are fixed. Details: Previously LayoutCustomScrollbarPart::FrameRect() stored different values at different document lifecycle stages: - Before paint, its location was always zero, and the size was not the actual size for some parts, but the minimum size calculated from the style, not based on layout, though updated in UpdateLayout(). UpdateLayout() was called not during layout (as a scrollbar part is not in the layout tree), but anytime we wanted the minimum size from const methods of CustomScrollbar. - During paint, as the FrameRect() calculated during UpdateLayout was not the real frame rect, we updated the frame rect to make sure they would be painted correctly. This caused unnecessary SetShouldCheckForPaintInvalidation when the FrameRect changed and unnecessary ScheduleAnimation(). This CL contains the following changes: - Removes LayoutCustomScrollbarPart::UpdateLayout(). Adds ComputeThickness() and ComputeLength(), and lets Margin*() get style directly, to replace the original UpdateLayout() (which called SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of CustomScrollbar. This removes the dependency of the const methods on the temporary incorrect FrameRect(). - Adds CustomScrollbar::PositionScrollbarParts() to set the correct FrameRect() for scrollbar parts. It's called from several places that position of scrollbar parts can change. This replaces the Set* called from CustomScrollbarTheme::Paint*. Bug: 856802 Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771890}
-
Daniel Hosseinian authored
This reverts commit 146b9f1b. Reason for revert: These tests were actually failing because death tests weren't working on win-asan. That problem has been fixed as of r771124. Also win-asan is not accurately named as it does not define ADDRESS_SANITIZER. Original change's description: > [Sheriff] Disable SQLDatabaseTest on Windows ASAN because they are flaky > > Bug: 1027481 > Change-Id: I7fc1806eada39c58f3f6035736bf9d5c595fbb0b > TBR: pwnall@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946331 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720463} TBR=guidou@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027481 Change-Id: I91ab2178d555e7ee852d7a8bf6bb5b0ca90f806d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216358 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771889}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: Id2c599da0d3699312d667833238a86d7ef259ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212392Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771888}
-
Miyoung Shin authored
This reverts commit cb7f6c5d. Reason for revert: Enable whole Flash suite since the crash issue was fixed at https://crrev.com/c/2210488. Bug: 1081782 Change-Id: I655f846cd78f79b6c7451a87f6bad66d060e4742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214592 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#771887}
-
sauski authored
CL extends the representation of managed states for the newly introduced CookiePrimarySetting generated pref to cover all supported states. Bug: 1063265 Change-Id: Ib19b5bd82bf5c7b1acddd70e07e5e145ee16d144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209071 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#771886}
-
Finnur Thorarinsson authored
The video player has two large play buttons, one in the player itself and one in the zoomed in view on the tiles screen. They should be the same size. Bug: 895776, 656015 Change-Id: I193234b2619f27c5546df11a64e04eb9c8d6726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215815 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771885}
-
David Bertoni authored
The ExtensionSettingsApiTest.OnChangedNotificationsFromSyncCheck was disabled for flakiness and became stale. This CL fixes the test and cleans up the JavaScript code. The test passed 3000 iterations on the bots. Bug: 101110 Change-Id: Ia969ba620900382395d09ec28e8d8ea379c79d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211079 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#771884}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 24 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-22. TBR=chromium-metrics-reviews@google.com Change-Id: I50a46e6f34284184a0956e528b9b3dc8de022831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212323Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#771883}
-
Toni Barzic authored
The test was timing out waiting for the auto-hidden shelf to get shown while hovering the mouse pointer over it. This changes the test to use swipe up gesture to show the shelf (which is used in other tests). BUG=1000463 Change-Id: I4270215be79239eb2861bb08bfae0fd3fc386f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214610Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#771882}
-
Olga Gerchikov authored
- Enabled pause(), reverse() and updatePlaybackRate() APIs for scroll animations. - Provided temporary fix for play animation procedure to accommodate reverse() and replaying finished animation cases. The fix reflects pending https://github.com/w3c/csswg-drafts/pull/5059. - Ported wpt/web-animations/timing-model/animations tests that exercise the APIs. - Implemented scroll animation specific tests. Bug: 916117 Change-Id: I689e7a6d1f220ee12e7f7a6f90e54340eaa33aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194586Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771881}
-
Mikel Astiz authored
The metric has served its purpose to monitor potential regressions during the rollout of the new implementation of bookmark sync (USS-based), and is no longer necessary. Change-Id: Iadd561e48d97d496e86df67cee5f25047e288894 Bug: 1070237,1017731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213565Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#771880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b5a24e66f12..fac9f9e293cd 2020-05-26 ilkos@google.com Merge "Add unique_session_name to the metadata" 2020-05-26 primiano@google.com Merge "infra: Add redirect for {www,docs}.perfetto.dev -> perfetto.dev" 2020-05-26 ilkos@google.com Merge "Downgrade ringbuffer overruns to info" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I604d9d293736cb56acb7e730f5b0fc6912137c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216351Reviewed-by:
-
Kevin Babbitt authored
Introduce unit tests validating the offsets generated by CSSParserImpl for dev tools These tests will ensure that upcoming refactoring to make further use of stream-based parsing does not change these offsets. Bug: 661854 Change-Id: I1461bdff5782d23921041a80d6ade6018e6f0983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209960Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771878}
-
Roger Tawa authored
Bug: 1069037 Change-Id: Id0144b4719af238dfee3070b55b93b612693afe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216272Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#771877}
-
Jongmok Kim authored
Change-Id: If8d7d91b9c5684d41bfaf2366a040f029bc191d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214865Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#771876}
-
Xing Liu authored
This CL does a minor clean up for TileManagerTest. Bug: 1078163 Change-Id: I453c8aab836ad09a5cb97f360cee16d379f695cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212514Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771875}
-
Tao Bai authored
Also included a refactorying to grouped all autofill features together. Bug: 949555 Change-Id: I9b72005db703677d71d03ff01f0e4c3322a4b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212758Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#771874}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c33eeab2ca42..fe6a353ce47a 2020-05-26 philipp.hancke@googlemail.com fuzzers: fix isax typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd962d156b5113fe0d5b9ba4884a1394102c42ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216355Reviewed-by:
-
Alexander Yashkin authored
Looking at suggest fuzzer code coverage I encounered that a lot of code is not covered at all. This is due to suggest answer being JSON with hardcoded expected structure. I have added several types of suggest server answers to seed corpus and locally it greatly enhanced coverage. I made sure that no personal info is contained in this data. Suggest parser coverage is here https://chromium-coverage.appspot.com/ reports/763373_fuzzers_only/linux/chromium/src/components/omnibox/ browser/search_suggestion_parser.cc.html Change-Id: Id025c80102747bdd4fb9a417fa42ed4db9811dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212170Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#771872}
-
Mike Klein authored
This guards https://skia-review.googlesource.com/c/skia/+/291876 for Blink rebaselines. Bug: skia:10000 Change-Id: I42b2318dff80c38de51ab0c87ed91266401171d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216350 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#771871}
-
Navid Zolghadr authored
This patch cleans up the early long press activation that so far can only be caused by a stylus button on CrOS with clear conditions. It adds the according checks to the logic to only run it for stylus pointers. So it should have no functional change. This helps to add a similar mechanism for touch pointers on Android in the later patches. Bug: 1086263 Change-Id: I0a4c5a802505ac22b6186b88d343143472850d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216310Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771870}
-
danakj authored
Pointer locking is a property of the widget, not a specific frame, nor the process. So we move it to the EventSender which is the per-widget web test javascript interface. This removes the last usage of TestRunnerForSpecificView, and we remove the class and all pointers to it. The pointer lock implementation is made a bit more clear and robust, tracking the state of pending locks/unlocks, as well as the final locked state. We use the default task runner, as these actions are tied to the widget and IPC, rather than to the requesting frame. R=avi@chromium.org TBR=dcheng Bug: 866140, 1069111 Change-Id: I90e6bfd336b4647fdead185012bf9b84b6617af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212928 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771869}
-
haozhe authored
By adding a type check for the sample interpolation, we handle the InvalidtableInterpolation type. Bug: 1084688, 1086167 Change-Id: Ifd2d04bdd298d239813c9f87772efdfcba9b227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210678Reviewed-by:
-
James Cook authored
SplitSettingsSync sometimes makes an untitled Play Store icon appear in the shelf due to app pin syncing code. This doesn't happen in production, but causes test failures in: ArcUserSessionServiceTest.FiresIntentOnSessionActiveTest AutotestPrivateApiTest.AutotestPrivate Pinned app sync isn't relevant to these tests, so skip it. Do this with a global because ChromeLauncherController initialization happens before the test runs SetUpOnMainThread(). Bug: 1085597 Change-Id: Iebd4e299872f1e79bdd388253256f1d7cec0dd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212931 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771867}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 1 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-22. TBR=chromium-metrics-reviews@google.com Change-Id: I919739afc43d4a2f4cbae9b28cc308a35bb5d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212393Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata to chrome-win32-master-1590508570-0988b56e609cb55046e696ff8ca55766d5b1565c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8a6462ffac6a46ea5602c57bc4d924e1bae0c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216450Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590465515-28d774c5c7210687b1a5c5f3f06bd85a638d1e44.profdata to chrome-win64-master-1590508570-56b410f167fcfdeb6392e467837742983549ce30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I268bcd3ab819f31efa46328e041d88318c61fe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216451Reviewed-by:
-
