- 16 Jan, 2020 40 commits
-
-
Min Qin authored
Finch experiment is already 100% on stable, so enabling the feature by default for now. Will remove the flag if no more bugs are reported. BUG=971366 Change-Id: I2323f995dc6e0bca68f2028be0c3014d260b5d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004068Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732515}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/872b953d1955..ba0d9547be17 git log 872b953d1955..ba0d9547be17 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 jettrink@chromium.org flash_ap: add dedede command support 2020-01-16 ahassani@chromium.org auto_updater.py: Be more gracious on AppID mismatches 2020-01-16 mmortensen@google.com Update generated proto api for goma changes in sysroot and common. 2020-01-16 achuith@chromium.org cros flash: Fix cros flash for public builders. 2020-01-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-15 mmortensen@google.com Support stats and counterz file in goma_lib.LogsArchiver. 2020-01-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-15 kinaba@google.com Drop gandof and veyron_tiger from android-nyc-pfq. 2020-01-14 saklein@chromium.org depgraph_common_inheritance: Add script to explore generated depgraphs 2020-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-14 yueherngl@google.com servo: add 12768.B firmware branch builder 2020-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-14 mmortensen@google.com query_build_logs: Improve checking of target string. Created with: gclient setdep -r src/third_party/chromite@ba0d9547be17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If5aae7421e236fdf8d809840c6718f4d621ff0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732514}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sorin@chromium.org Bug: 1041419 Change-Id: Ic82a4501826f479afc5e84ac855350bc6d4edf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997716 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732513}
-
Avi Drissman authored
Collect basic information as to whether the Mac is joined to a domain, or if it is controlled by MDM. Fixes: 1040630 Change-Id: Ie8de61e83dc6a4174311970a59798b451335b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994122 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#732512}
-
Sammie Quon authored
Test: none Bug: 1006973 Change-Id: Id1d113a806bbe91dded98392076753f4c76e6398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002000Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#732511}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ejcaruso@chromium.org Bug: 1041419 Change-Id: I03455b79948c4206b30450bb7b7d0a35e8c04784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997911 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732510}
-
Mikhail Khokhlov authored
Bug: 1042644 Change-Id: Ib7e935618641a13999bf045646ac6a94682f5b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003858Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#732509}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/df0e683b5835..f53792645f06 git log df0e683b5835..f53792645f06 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 rharrison@google.com Use the correct comparison when checking for not MSL (#960) 2020-01-15 dneto@google.com Support Vulkan 1.2 (#958) Created with: gclient setdep -r src/third_party/shaderc/src@f53792645f06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I350e0a47d5324cc8b24b5ab6ecc2b0f2efb8d7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003756Reviewed-by:
-
Sajjad Mirza authored
When coverage instrumentation is enabled the compiler generates extra symbols that are irrelevant to resource whitelisting. These should be ignored so that they are not passed to llvm-undname, which cannot parse them. Bug: 1041689 Change-Id: Ia54300cc3b65c40ab4c20caa7a76623822fa97c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004328Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732507}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/631f4258a1ac..f70786126c8b git log 631f4258a1ac..f70786126c8b --date=short --first-parent --format='%ad %ae %s' 2020-01-16 rharrison@chromium.org Rolling 4 dependencies for Vk1.2 support integration Created with: gclient setdep -r src/third_party/dawn@f70786126c8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8c6631e74f135d53c66a8f97e8c417e7cd256d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004371Reviewed-by:
-
Jae Hoon Kim authored
Currently installation of PluginVM DLC will block if dlcservice doesn't support PluginVM DLC - this verfies that PluginVM DLC is enabled for callers that go through PluginVM usage workflow. Temporary fallback: Rootfs resident PluginVM is alongside PluginVM DLC, allowing dlcservice errors other than |dlcservice::kErrorInvalidDlc| to passthrough until the case of pure PluginVM DLC. Bug: chromium:145814572 Test: unit_tests --gtest_filter=PluginVm* Change-Id: I0e024811e800f2aacdeed6514f62e0cc116d1ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001942 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#732505}
-
Nick Burris authored
Extend TextFragmentAnchor metrics until the end of 2020. These metrics will continue to be useful through the launch of the feature and subsequent changes. Bug: 1037336 Change-Id: Ia920cf2b5a3bd7dabff703c263f6a45f27efa013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001067Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6ca908f48c88..4c1086a36ade git log 6ca908f48c88..4c1086a36ade --date=short --first-parent --format='%ad %ae %s' 2020-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 374f209d..7356cb88 (732255:732376) 2020-01-16 kron@webrtc.org Add processing time to VideoFrame 2020-01-16 hbos@webrtc.org Improve DTLS logging. 2020-01-16 jonaso@webrtc.org Make it possible to inject IceTransport in pc quality test fixture 2020-01-16 danilchap@webrtc.org Remove higher_spatial_layers from RTPVideoHeader structure as unused. Created with: gclient setdep -r src/third_party/webrtc@4c1086a36ade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011581,chromium:1024965 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I57f216814bbff3445e9c7d27a3930bc61696f425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004899Reviewed-by:
-
Daniel Rubery authored
This CL encapsulates the process of scanning a download and reporting the result to the download UX. This will be shared between APP scanning and the new enterprise scanning. Bug: 1020418 Change-Id: Iacb702e0829df8cf03228ede64bcea6a5726d585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993627 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732502}
-
Ken MacKay authored
At low sample rates, errors due to float->integer rounding can be significant when converting from frame count to microseconds. This CL fixes the rounding to be more accurate. Bug: internal b/147111664 Change-Id: I77f8eab4fa8a25ec50c7617b8910f51db47741f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003925Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#732501}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5722304fcfc..57a0ce4db871 Created with: gclient setdep -r src-internal@57a0ce4db871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jbudorick@google.com Change-Id: I14c7a43f035158bae5865b5ff0d9ef79a7953c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732500}
-
Wez authored
This target is broken with the latest Fuchsia SDK. Since we do not currently run the tests it contains, and the compilation will take some time to resolve, disable compile until it can be fixed, and the tests re-enabled. Bug: fuchsia:44191 Change-Id: Ia2325d6e0536bbf7599a06983a65d2833207cba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002822Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#732499}
-
Mounir Lamouri authored
Bug: None Change-Id: I9c7704b09d56adcd68de6da1587566148f505e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975888 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732498}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=glider@chromium.org Bug: 1041419 Change-Id: I1eb878817e27ccfb5811a4aacd9b68d374fbe10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997002 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732497}
-
Dan Beam authored
CL generated with: $ git ls-files 'chrome/browser/ui/webui/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g' $ git ls-files 'chrome/browser/ui/webui/*.js' | xargs -I{} tools/web_dev_style/eslint.py --fix {} $ git cl format --js Bug: 720034 Change-Id: I7b0e24eaba3f8c87dbf6abcb22b34afb13e88106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003640 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732496}
-
Jimmy Gong authored
- Gives shared access to the findDifference function. Bug: 1015628 Change-Id: I25fe0954df1e3a6aa784cce9611f2f14086e1f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004008Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#732495}
-
Yue Zhang authored
This reverts commit 315f9a8f. Reason for revert: The new plus button doesn't work as expected. http://crbug.com/1042606 Original change's description: > Use NewTabButton for new tab variation in GTS > > Bug: 1042015 > Change-Id: Ic1ad4c0902725bc0a096b72f05f5fab92ef9d4d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001265 > Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731803} TBR=twellington@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042015 Change-Id: I7069b577daa0a0b5ab271e08b481599a422db253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003621Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732494}
-
Mei Liang authored
The crash happens when a tab updates after model switched. The updated tab does not exist in the current TabModel, therefore a null is returned when we try to locate the selected tab. The simple fix is to null check before we access the tab. This CL also hides the onUrlUpdated logic behind the TabGroupsContinuation flag. Change-Id: I81090666328158f8a5a5e37459c54e48d0ef6325 Bug: 1035301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996130 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732493}
-
Xida Chen authored
In our PaintRenderingContext2D, there is a effective_zoom_ which captures the device_scale_factor + browser zoom. The transform matrix in the rendering context need to integrate the effective_zoom_ such that when all the drawings could do the transformation correctly. This is why currently the implementation of setTransform has effective_zoom_ explicitly included. The problem is resetTransform, where the base class version just set the transform matrix to identity. This is wrong for PaintWorklet because we need to account for the effective_zoom_. Now we can not explicitly put the effective_zoom_ in the resetTransform. This about the following JS call: resetTransform(); setTransform(2, 0, 0, 2, 0, 0); In this case, we will have resetTransform that integrates the effective_zoom_ once, and setTransform integrates it again. So the solution is remove the integration of effective_zoom_ in the setTransform and put that integration in the resetTransform. This is fine because setTransform in the base class calls the resetTransform, and so this makes sure that the effective_zoom_ is integrated once only. Bug: 1029360 Change-Id: I1a143884803b2e831e26af34386aa3f5532f2c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999285Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732492}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the ToolbarSecurityIconTestunittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: I9e397ff1260cce9fca375af212dbac9e360e31f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997640 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Stephen Chenney authored
No obvious reason why it only fails on Win 10 and Mac. TBR: fs@opera.com Bug: 1042453 Change-Id: Ie983b8a1e8668bd8396640ff6fd35a7b413622e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004950Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732490}
-
Stefan Zager authored
The presumptive scenario is remote iframe inside a throttled iframe inside an active top document. The top document runs a lifecycle update, which succeeds (i.e., the return value from LocalFrameView::UpdateAllLifecyclePhases is 'true'); but the middle frame is throttled and doesn't update, so we can't do a hit test on it. In that case, just give up on trying to compute occlusion information. BUG=1041252 R=chrishtr@chromium.org Change-Id: If7fadc9daf033bceda9f8a01edc6c3cabf71c066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003259Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#732489}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5bddf6a45982..b446206d9331 git log 5bddf6a45982..b446206d9331 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 mathias@chromium.org Make sort test work as intended 2020-01-16 mathias@chromium.org Simplify regular expressions in utilities.js 2020-01-16 tvanderlippe@chromium.org Migrate workspace_diff/ to ESM internally 2020-01-16 tvanderlippe@chromium.org Remove Puppeteer installation Created with: gclient setdep -r src/third_party/devtools-frontend/src@b446206d9331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561,chromium:848823 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id793bdb8aa8b1d1a0e42c607711072864d614fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004898Reviewed-by:
-
Markus Handell authored
This change brings the MediaRecorder onstart behavior to spec compliance, as per https://github.com/w3c/mediacapture-record/pull/190. The change carries updates to web tests related to the following: - PeerConnection MediaRecorder tests have been added to cover the both spec wording related to avoiding transcoding and the normal transcoding use cases. - A test that shows that audio recording cannot happen without a sink tag has been added. - With this change, Chrome passes all the mime type tests. Bug: 1013590 Change-Id: I0001673fce20e995a3fe67336a7c9e87d70adc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893855Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#732487}
-
yilkal authored
This cl updated supervised user error page strings. Bug: 850328 Change-Id: I5d4f888cbb81e3da137c82a48837c882a6b3cb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002681Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#732486}
-
Wenyu Fu authored
Two of the files are serving as util classes to the rest of of the components, merging them into one for the visibility and less redundancy. Change-Id: Iec5a039d7caeaa9ef78f7e7dfcb1b82caef63117 Bug: 1042487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003923 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732485}
-
Dmitry Gozman authored
When we have created incognito profiles managed by DevToolsBrowserContextManager and did not explicitly close them before shutdown, we keep these profiles and their browser windows open. This leads to forceful renderer process terminations and crash notifications shown to the user. To fix this, we manually close all browser windows when original profile is gone. Bug: none Change-Id: I3befc91e6c8ed6ab7baf9b4af0ef92377bf38ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001262Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732484}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 1041419 Change-Id: I3d2049d684bba4a4a5bb99837af05479793564b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997704 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732483}
-
gogerald authored
This CL also fixes the new tab button is missing on start tab switcher surface. Screenshots: https://drive.google.com/a/google.com/file/d/1R4_oyeIz6_VuwMellLzPI7zQ2ef04AWX/view?usp=sharing https://drive.google.com/a/google.com/file/d/1R0ASrrY8v50Z9E2bbGI-al_kKrjlI16p/view?usp=sharing Bug: 1042006 Change-Id: Ie9663daf6cc0cb32c63975d65adfce9bb990ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003289Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#732482}
-
Francois Doray authored
This histogram will be used to assess the impact of window occlusion, which is not shipped yet. Fixed: 1037420 Bug: 1037420 Change-Id: Iaa565ef3ef0b57b16bc9c83b6f9b81030a49b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002941 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732481}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=palmer@chromium.org Bug: 1041419 Change-Id: I412b3025323df87cc68c59dfd79d5c2f83e5c242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997997 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732480}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=aleventhal@chromium.org Bug: 1041419 Change-Id: Iac2cd6da8c44de88fadf500b6cd3f34ba5016a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993856 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Prevents focus from advancing inside a portal frame from the renderer process, and adds an security check in the browser process. Bug: 1030838 Change-Id: I1e82d2163142ba357aa4d7adb4f0b66d0fb5b676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951767 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
This reverts commit 7e9c0cd6. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1042758 Original change's description: > Optimize disabling ARB_texture_rectangle > > In https://crrev.com/c/1991969 I added a new, faster way to disable > ARB_texture_rectangle support in ANGLE's shader translator. This change > starts using it in Chrome, replacing the earlier change introduced in > https://crrev.com/c/1842223 > > Bug: angleproject:3770 > Change-Id: Ica718828581b49efc34230f9f53f28fdec77eb67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732221} TBR=geofflang@chromium.org,kbr@chromium.org,jdarpinian@chromium.org Change-Id: If28e90472d21c3f3f1dbfb01abdd8102dc413258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003030 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#732477}
-
Ionel Popescu authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL adds an inner 2px padding to the focus ring in order to improve its visibility. For now the inner padding is used for all elements, but this is going to be refined based on feedback. Bug: 1026553 Change-Id: I890118cce5f86c53ae410316bbf315ee1a2874c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995887 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#732476}
-
