GitLab

Removing redundant names introduced for input type checkbox with menu as parent and aria role menuitemcheckbox

In this CL https://codereview.chromium.org/589383004/, a redundant name was introduced
for input type checkbox with menu as parent. Rather the role defined for aria
role menuitemcheckbox can be used for input type checkbox with menu as parent.

Review URL: https://codereview.chromium.org/649073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=422432

Review URL: https://codereview.chromium.org/649563003

git-svn-id: svn://svn.chromium.org/blink/trunk@183589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently -webkit-transform-origin is a shorthand while transform-origin
is not. This patch makes the vendor-prefixed property behave the same as
non-prefixed property. This has minor changes to serialization, which
the test changes document.

In doing so we fix a crash in parsing some invalid values.

BUG=405323

Review URL: https://codereview.chromium.org/649153002

git-svn-id: svn://svn.chromium.org/blink/trunk@183588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183585

BUG=407079
TBR=apavlov@chromium.org

Review URL: https://codereview.chromium.org/650813002

git-svn-id: svn://svn.chromium.org/blink/trunk@183587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following r183582, RefCountedGarbageCollected<T>::m_refCount is left as
0. This is incompatible with the derived SVG objects which have a base
object (SVGPropertyBase) that's a RefCountedGarbageCollected<> object,
but the derived objects are all exposed as if they were deriving from
a RefCounted<T> base.

Adjust the ref count upon construction of SVGPropertyBase to provide
that illusion.

TBR=haraken,oilpan-reviews
BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/650033002

git-svn-id: svn://svn.chromium.org/blink/trunk@183586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=422846, 407079
TBR=cbiesinger

Review URL: https://codereview.chromium.org/650803002

git-svn-id: svn://svn.chromium.org/blink/trunk@183585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=416182
R=ojan@chromium.org
CC=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183431

Review URL: https://codereview.chromium.org/633983002

git-svn-id: svn://svn.chromium.org/blink/trunk@183584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn Widget into a GCable object, along with its derived objects
(PluginView, FrameView, Scrollbar, PopupContainer).

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/603193005

git-svn-id: svn://svn.chromium.org/blink/trunk@183583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

adoptRefCountedGarbageCollected is no longer needed. When creating a RefCountedGarbageCollected object, we can just use 'new RefCountedGarbageCollectedObj()'. Even if a GC is triggered between when the object is created and when the object is adopted, there is no issue because our conservative scanning finds the object and traces it.

This CL also removes ThreadSafeRefCountedGarbageCollected because it is now unused (WebAudio was the only user of ThreadSafeRefCountedGarbageCollected, but we already shipped Oilpan for WebAudio and removed the need).

BUG=340522

Review URL: https://codereview.chromium.org/614373007

git-svn-id: svn://svn.chromium.org/blink/trunk@183582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327471

Review URL: https://codereview.chromium.org/644223002

git-svn-id: svn://svn.chromium.org/blink/trunk@183581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Remove "needkey" event and add it's replacement, "encrypted"."

This reverts commit ad09c3ed1914691ee4a089cfe95988892ed42407.

BUG=
TBR=sandersd

Review URL: https://codereview.chromium.org/647383002

git-svn-id: svn://svn.chromium.org/blink/trunk@183580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With revision 183577 several virtual gpu pixel expectations were
updated with obviously incorrect images. This appears to be due to
some sort of race in Release which needs to be investigated.

The new baselines in this change are obviously required, and the Debug
bot is correctly failing, but the Release bot appears to believe the
old baslines are ok, which they are not.

git-svn-id: svn://svn.chromium.org/blink/trunk@183579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With Chromium commit c3f2a80d
FreeType is updated to the version in Ubuntu Precise.

Revision 183577 rebaslined most of the affected pixel tests.
This cleans up the remaining changes.

git-svn-id: svn://svn.chromium.org/blink/trunk@183578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With Chromium commit c3f2a80d
FreeType is updated to the version in Ubuntu Precise.
This rebaslines most of the pixel tests which are affected.

git-svn-id: svn://svn.chromium.org/blink/trunk@183577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417774

Review URL: https://codereview.chromium.org/648913002

git-svn-id: svn://svn.chromium.org/blink/trunk@183576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Earlier only ctrl+C is handled, I have added key for Ctrl+Insert also
So if their is any selection then it will get copied like that happen
in case of Ctrl+C, That is selected text get copied to clipboard.

BUG=390837

Review URL: https://codereview.chromium.org/629823002

git-svn-id: svn://svn.chromium.org/blink/trunk@183575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With g++, the scope of the per-element local variable currently
(g++-4.8.1) and incorrectly extends over the generator/range
expression also,

  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430

Rename the loop variable in CachedMatchedPropertiesHashTraits's
traceInCollection() to avoid running into the bug.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/646013002

git-svn-id: svn://svn.chromium.org/blink/trunk@183574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL depends on CL: https://codereview.chromium.org/646913002/

This CL disables async main thread HTML parsing code path by:
- forcing HTMLParserOptions::useThreading to be true
- making all pumpTokenizer calls ForceSynchronous

HTMLDocumentParser has three parsing modes:
- Synchronous main thread parsing
- Asynchronous main thread parsing
- Asynchronous background thread parsing

Asynchronous main thread parsing is a historic feature before
asynchronous background parsing. Now all use cases that required
asynchronous main thread parsing are gone, we can disable
the code path so that we only have two parsing modes.

The HTMLParserOptions::useThreading had comment about where the
flag was used to force synchronous parsing behavior, but it is
obsolete as of now:
- The about:blank url itself does not use HTMLDocumentParser.
- javascript: urls use about:blank url, but synchronous behavior
  is not controlled by this useThreading flag, but call to
  pinToMainThread from DocumentLoader::replaceDocumentWhileExecutingJavaScriptURL.
- core/inspector/DOMPatchSupport also explicitly call
  pinToMainThread to force synchronous parsing.

This CL also removes the last asynchronous main thread parsing
case where:
- document.write caused recursive document.write via script, and
- the suspended document.write was resumed asynchronously.
However I think this behavior was a bug, as the suspended
document.write should have resumed synchronously.
To fix this, HTMLDocumentParser::resumeParsingAfterScriptExecution
is changed to resume parsing synchronously when background thread
doesn't exist.
This codepath is tested on fast/loader/external-script-URL-location.html

TEST=fast/loader/external-script-URL-location.html
BUG=421289

Review URL: https://codereview.chromium.org/644573002

git-svn-id: svn://svn.chromium.org/blink/trunk@183572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using subtree invalidation is a current consequence of adjacent
combinators. Using "adjacent" as a feature should be more understandable.

Also tried to make the code more readable for the combinator handling in
general.

R=chrishtr@chromium.org,esprehn@chromium.org

Review URL: https://codereview.chromium.org/641583002

git-svn-id: svn://svn.chromium.org/blink/trunk@183571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, synchronized parsing for forceSynchronousLoad
substituteData was not enforced. The flag was simply ignored in parsing
code path.

This bug has not surfaced because all substituteData which required
synchronized loading were used against about:blank URL, and
HTMLDocumentParserOptions had a special casing that about:blank urls
required synchronous parsing.

This CL explicitly enforces synchronous parse for forceSynchronousLoad
substituteData, so that flag is actually used.
This is also a step toward removing special casing against about:black
URL in HTMLDocumentParser.

BUG=421289

Review URL: https://codereview.chromium.org/646913002

git-svn-id: svn://svn.chromium.org/blink/trunk@183570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves forwardInputEvent to WebRemoteFrame and fixes a few uses of
RemoteFrames.

BUG=346764
TEST=Input events work in out-of-process iframes.

Review URL: https://codereview.chromium.org/642203002

git-svn-id: svn://svn.chromium.org/blink/trunk@183569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The RenderWidget is an old abstraction that isn't needed any longer. We are
down to a single subclass, RenderPart. This CL folds RenderWidget into
RenderPart and updates its users.

BUG=416436

Review URL: https://codereview.chromium.org/625073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As suggested at https://codereview.chromium.org/637103002/#msg9

BUG=None

Review URL: https://codereview.chromium.org/651433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/642383002

git-svn-id: svn://svn.chromium.org/blink/trunk@183566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch cleans up a case where paddingBoxRect computing
client{width,height} used content{width,height} and then added the padding.
This was silly because content{width,height} is just the
client{width,height} minus the padding.

Review URL: https://codereview.chromium.org/642823003

git-svn-id: svn://svn.chromium.org/blink/trunk@183565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=251382

Review URL: https://codereview.chromium.org/606703003

git-svn-id: svn://svn.chromium.org/blink/trunk@183564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Floating point values inside MQs should not be round down/up
to match the integer dimensions of the viewport. That is in order to align our behavior with the way Gecko are doing that.
This CL fixes that issue.

BUG=422234

Review URL: https://codereview.chromium.org/644813005

git-svn-id: svn://svn.chromium.org/blink/trunk@183563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, we tweak the computed code path in several places to force
kerning & ligatures handling via the complex path. These checks
are identical and can be handled in codePath() instead.

The refactoring preserves existing logic.

R=eae@chromium.org,jbroman@chromium.org,dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/642863005

git-svn-id: svn://svn.chromium.org/blink/trunk@183562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This new event is of type MediaEncryptedEvent, which has initDataType instead of contentType (but this CL just renames one to the other, without translation), and changes the type of initData from Uint8Array to ArrayBuffer as per the WD EME spec.

Also in this CL:
  - Start renaming keyNeeded() to encrypted() by renaming the it on HTMLMediaElementEncryptedMedia.
  - Remove unused contentType argument from createWebkitNeedKeyEvent() (good thing it's unused or the contentType to initDataType change would be a lot harder).
  - Fix prefixed/encrypted-media-events.html test to test the prefixed needkey event instead of the unprefixed one.

BUG=224786

Review URL: https://codereview.chromium.org/600143005

git-svn-id: svn://svn.chromium.org/blink/trunk@183561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=405591
NOTRY=true

Review URL: https://codereview.chromium.org/603293002

git-svn-id: svn://svn.chromium.org/blink/trunk@183560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Please manually rebaseline the test.
Rebaseline-o-matic doesn't support rebaselining harness tests with
passing results.

BUG=388375
TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/651473002

git-svn-id: svn://svn.chromium.org/blink/trunk@183559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn off LCD (subpixel AA) text while recording the DisplayList used
for image filters, since we don't know about the opacity of the
destination playback canvas (and using the recording canvas's
opacity is wrong).

BUG=422176

Review URL: https://codereview.chromium.org/645993002

git-svn-id: svn://svn.chromium.org/blink/trunk@183558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These methods have nothing to do with service worker based tests, and are just
as useful in normal testharness based tests, so move them to a separate file.

Additionally rename worker-test-harness.js to worker-testharness.js for consistency.

Review URL: https://codereview.chromium.org/647493002

git-svn-id: svn://svn.chromium.org/blink/trunk@183557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With this change, TypeBackForward will only occur once at the top level navigation, and sub-frames that are created along the way will get TypeInitialInChildFrame.

BUG=416184
TEST=as in bug

Review URL: https://codereview.chromium.org/640663003

git-svn-id: svn://svn.chromium.org/blink/trunk@183556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417774

Review URL: https://codereview.chromium.org/641733004

git-svn-id: svn://svn.chromium.org/blink/trunk@183555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=421033

Review URL: https://codereview.chromium.org/633093002

git-svn-id: svn://svn.chromium.org/blink/trunk@183554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=apavlov@chromium.org

Review URL: https://codereview.chromium.org/647083002

git-svn-id: svn://svn.chromium.org/blink/trunk@183553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The complexity of the CL is in granting an exemption to same-origin content, which implies applying the same tests to an href attribute that formerly only applied to src attributes.  But we don't want to give a pass to all href attributes irrespective of tag, so we need more flags.

BUG=421166

Review URL: https://codereview.chromium.org/644663003

git-svn-id: svn://svn.chromium.org/blink/trunk@183552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=na

Review URL: https://codereview.chromium.org/642233002

git-svn-id: svn://svn.chromium.org/blink/trunk@183551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/StkI3k4Pm5U
saw multiple calls for more public/OWNERS. I volunteer as tribute.

"git shortlog -s -n public/" says I've been the 5th most frequent committer to
public/ in the last 18 months with 38 changes.

BUG=

Review URL: https://codereview.chromium.org/646783002

git-svn-id: svn://svn.chromium.org/blink/trunk@183550 bbb929c8-8fbe-4397-9dbb-9b2b20218538