- 03 Apr, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iebc6543337143e0c74fe04cd142672eed2554635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756255}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I1efa42cacfc40ddfa3642a9c2ef5deda7b26e70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135372Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756254}
-
Omer Katz authored
This is to address flaky timeouts of these tests. Bug: 986235 Change-Id: I82658d97947ea1314290f9ffbd40b6529b80e04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134253Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756253}
-
kylechar authored
Two checks about the DrawQuad rects were added as deserialization errors. Add equivalent DCHECKs during serialization so the errors are caught closer to the source in debug builds. Bug: 1066139 Change-Id: I69665dd200d7ee2028fac6e55bd0264967ed9216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134609Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756252}
-
Daniel Rubery authored
When recording metrics for malware deep scanning, every verdict that is not VERDICT_UNSPECIFIED is a success. But SCAN_FAILURE should count as failure. Change-Id: I961f19d4a719be53ab04d6f39caf083f919a392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134914 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756251}
-
Wez authored
Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. TBR=jbudorick Bug: 1050703 Change-Id: I1ba54308f2f2f6fc0f0b305dab2b9c927a38b21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094989 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756250}
-
Christos Froussios authored
TBR=rsorokin Bug: 1067461 Change-Id: Ieae7074a542b9addfafc8be773ee4d8343b785a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135613 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#756249}
-
Anastasiia Nikolaienko authored
This change is limited to Chrome OS and is not related to Win7 Tests failure. This is a reland of 0a948617 TBR=xiyuan@chromium.org Original change's description: > Add EDU login flow: CSS fixes > > Address comments to UI implementation - update margins and logo size. > New screenshots: > http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI > > Bug: 1054798 > Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756012} Bug: 1054798, 1067443 Change-Id: I2dc2c9345808be2f3e84a3c4c91c3a1db6076a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134015 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#756248}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 123ddc4d. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icc1850715a23dcb51b9a1da88c5df1ae3fd3e6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135706Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756247}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I65e2e168c67edd2ffd2363479164f1a4e027c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135646Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756246}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47cd4085b978..52e2dbf1c115 git log 47cd4085b978..52e2dbf1c115 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mbonadei@webrtc.org Add voip_unittests to gn_isolate_map.pyl 2020-04-03 jonaso@webrtc.org Don't trigger OnNetworkChange when changing from 3G to 4G 2020-04-03 jonaso@webrtc.org Add new AdapterTypes to android sdk 2020-04-03 deadbeef@webrtc.org Temporarily increase DTLS buffer size to 2. Created with: gclient setdep -r src/third_party/webrtc@52e2dbf1c115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063834 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b31577b50d696823ed779dd6613cf98dc78c43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135601Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a prerequisite to allow DeviceAccountInitializer to be used on desktop to fetch authcodes for invalidations registration. Bug: 1026261 Change-Id: I9db6fbe4c420b34b5cc734207d728cc67045a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134188Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756244}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaef4f9e9baf735635e2b763bb246749fd0cc55e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134005Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ica922d40136c54683d995e134cdc3df0ea6d8dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135667Reviewed-by:
-
Stephen McGruer authored
This rolls testharness.js, idlharness.js, and webidl2.js to WPT SHA 39b27a7875 (https://github.com/web-platform-tests/wpt/commit/39b27a7875). The primary purpose is to consume the assert_throws/promise_rejects API removals. It does not roll to WPT HEAD as shortly after this SHA an API change occurs in the assert_throws_dom/promise_rejects_dom APIs that will require work in Chromium to consume. Some fixes done alongside: * One use of assert_throws fixed in payment-request-interface.html * Three expected files that reference line numbers in testharness.js updated for the new version. Bug: 1051932 Change-Id: I9cc1c8235ce88262a6a7a2905d0996ba64fe9866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129897Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756241}
-
Hans Wennborg authored
After 61e89737, libc++ no longer supports linking against the system libc++abi. We never cared about linking the library anyway, we just want the headers. This lets us do that; see bug for discussion. Bug: 1067216 Change-Id: Ib6265cf9c6c58d25e72f8f43ae994d9ec6da69a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133967Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#756240}
-
Elly Fong-Jones authored
Sometimes, users of MenuModel add items whose command ID is the same as their string ID, thus conflating command IDs with string IDs. Normally this is done because there is no matching IDC constant available. While this "works" it is dangerous: 1) IDS_FOO and IDC_FOO are from separate namespaces, and there is no reason they wouldn't overlap; 2) A common pattern is for MenuDelegate::Execute() to turn around and pass the provided command ID to CommandUpdater::ExecuteCommand(), which really does expect an IDC_* constant as the command ID; 3) Since it looks like a bug at first reading *and* many IDS_FOOs have a corresponding IDC_FOO, it is prone to being erroneously "corrected" to IDC_FOO, which breaks the menu. This change: 1) Introduces an enum Textfield::MenuCommands for the commands exposed via TextField's context menu, and uses these as command IDs for that menu instead of using the IDS constants; 2) Introduces an enum Label::MenuCommands for the commands exposed via Label's context menu, and uses those as command IDs too; 3) Introduces an enum OmniboxMenuCommands for the omnibox context menu's commands, and uses that; 4) Removes a bunch of special-purpose logic from ReloadButton that was only required because of using IDS constants for command IDs; in this instance there already exist available IDC constants, and using them allows removing a translation layer; 5) Updates a handful of tests to use the new constants; 6) Adds a DCHECK to SimpleMenuModel to forbid adding a command whose command ID is equal to its string ID. Change-Id: I5647f978f9bd7006e3e8f3332b289792c2c1418b Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132587Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756239}
-
Corentin Wallez authored
TBR=bajones@chromium.org Bug: angleproject:4539 Change-Id: I7e05c18e09ac1e62ce631dfa66deef4aa3fe1f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133978Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756238}
-
Corentin Wallez authored
TBR=bajones@chromium.org Bug: chromium:951628 Change-Id: I0fe1062e575e42d9e803bb3290218b877569afc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133934Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e6c0ac0b11d..56f8fb61b9d5 git log 2e6c0ac0b11d..56f8fb61b9d5 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 dberris@chromium.org Dashboard: Stop batching histogram processing Created with: gclient setdep -r src/third_party/catapult@56f8fb61b9d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067531 Tbr: nuskos@google.com Change-Id: Id8fce7cb4fc7735c364cb0b3f704a858ca13e226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135594Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f954babacc6c..31665eb818aa git log f954babacc6c..31665eb818aa --date=short --first-parent --format='%ad %ae %s' 2020-04-03 btolsch@chromium.org Get test data path by exe path Created with: gclient setdep -r src/third_party/openscreen/src@31665eb818aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic971a2d1e5e063cc6380b1ab167ab7858a28270d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135593Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b24fab368ae..c00163ba0925 git log 2b24fab368ae..c00163ba0925 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 hao.x.li@intel.com Return error instead of crash if compile shader failed on D3D12 Created with: gclient setdep -r src/third_party/dawn@c00163ba0925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If19f8b58ca6d8dda0d600653ef49b562351d7e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135587Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fca03eaabd52..331b83f63756 Created with: gclient setdep -r src-internal@331b83f63756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I72da591568ba549309fe8baad825d667b0c1047b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135592Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756233}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1cc49bb2e230..93040c8d0d4a git log 1cc49bb2e230..93040c8d0d4a --date=short --first-parent --format='%ad %ae %s' 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src ba07fa0be82c..bb74deab0a4d (1 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 0b66fa3b62cb..b5757b95005b (1 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader cb58662302c8..f99302c4efe6 (7 commits) 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src f20c0d7971c6..e95fbfb1f509 (7 commits) Created with: gclient setdep -r src/third_party/angle@93040c8d0d4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I650b2f23d83c6f5dde51b9bea36b8b208a0875cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135600Reviewed-by:
-
Armando Miraglia authored
Fixed: 1055395 Change-Id: Ibd095646a7ef14277d14f99657515ab0bacca62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132326Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#756231}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a10679ba4c58..76336cdd0411 git log a10679ba4c58..76336cdd0411 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 alexei.rudenko@gmail.com Set background color for scrollbars in dark mode 2020-04-03 alexei.rudenko@gmail.com Make TreeOutline in Changes not focusable until there is content Created with: gclient setdep -r src/third_party/devtools-frontend/src@76336cdd0411 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048986,chromium:953677 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I623e490e14768ebd1e00afb8d39eee6d36fdf0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135599Reviewed-by:
-
Joseph Kim authored
This work builds upon 2086358: Demo Mode: Display progress bar rather than spinner during Demo setup https://chromium-review.googlesource.com/c/chromium/src/+/2086358 Now Demo Mode setup progress is displayed to the user as a list of steps with individual progress indicators (not begun, in progress, complete). This is hidden behind the `ShowStepsInDemoModeSetup` flag, disabled by default. Bug: b:148753805 Change-Id: I5bdfe643e80f291755df64e28d671f5fc7069e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114014 Commit-Queue: Joseph Kim <josephkimsh@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756229}
-
Aya ElAttar authored
Bug: 1067528 Change-Id: I4aa1eb71244e082dabfa1ff9667ca6ab59fc5ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134288Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#756228}
-
Rune Lillesveen authored
The generated method also returns a const Vector<String>&. Change-Id: Ib2754f596881009d249d70509ee7d196f86180ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134254Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756227}
-
Rune Lillesveen authored
We allowed calc expressions combining numbers and lengths, numbers and percentages, and even a combination of numbers, percentages, and lengths. None of those are allowed per the CSS Values and Units spec, and it made it possible to combine user units, lengths, and percentages into the same calc() for certain SVG CSS properties and attributes. See also: https://github.com/w3c/csswg-drafts/issues/4874 This improves SVG interop with Firefox. Firefox does not support calc() for numbers, though. Bug: 1061714 Change-Id: I9e5c492122242e51064310a40e28a233530e357c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134251 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756226}
-
Rob Buis authored
Implement the <munder>, <mover>, <munderover> elements and add a layout algorithm [1] covering all three elements. This patch does not yet cover all details of the algorithm (accent, stretchy operators) to keep the patch simple, however FIXMEs are added. [1] https://mathml-refresh.github.io/mathml-core/#underscripts-and-overscripts-munder-mover-munderover Bug: 6606 Change-Id: I8a20bb3105b733ef57413114aed0e6b536597c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119538 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#756225}
-
Aya ElAttar authored
-Fixed ExtensionApps::Connect to check the app disable reason before publishing instead of publishing as always disabled by user. -Fixed ExtensionApps::OnSystemWebAppsInstalled to check the app status before publishing instead of always publishing as ready. -Added ExtensionApps::OnExtensionStateChanged to publish the app in case it got disabled by a policy. Bug: 1063404 Change-Id: Ia09d4dee1600e268d118d05000e53a905482bc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127211 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Ilya Nikolaevskiy authored
The logging messages are propagated along the pipeline until they reach browser process, which already knows how to forward them to the WebRTC log in a renderer. Added callback from CaptureOracle to FrameSinkVideoCapturer to forward log messages. All the debug logging is behind the chrome feature so it can be enabled for a fraction of users. Bug: webrtc:11461 Change-Id: I0005950670e1efb96b86857f1494894e1253f339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126986Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#756223}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5109d9f9628..f5a94cc6837a git log b5109d9f9628..f5a94cc6837a --date=short --first-parent --format='%ad %ae %s' 2020-04-03 primiano@google.com Service: Add QueryCapabilities method Created with: gclient setdep -r src/third_party/perfetto@f5a94cc6837a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:141917389,chromium:150960749 Tbr: perfetto-bugs@google.com Change-Id: I02b39c9360e6327bcc8c4c5f6549cdfd18081abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135598Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f20c0d7971c6..e95fbfb1f509 git log f20c0d7971c6..e95fbfb1f509 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 afdx@google.com spirv-fuzz: Transformation to add OpConstantNull (#3273) 2020-04-02 afdx@google.com spirv-fuzz: Handle isomorphic types property in composite construction (#3262) 2020-04-02 afdx@google.com spirv-fuzz: Limit adding of new variables to 'basic' types (#3257) 2020-04-02 afdx@google.com spirv-fuzz: Only replace regular ids with synonyms (#3255) 2020-04-02 afdx@google.com spirv-fuzz: Introduce TransformationContext (#3272) 2020-04-02 afdx@google.com spirv-fuzz: Add validator options (#3254) 2020-04-02 alanbaker@google.com Update dominates to check for null nodes (#3271) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e95fbfb1f509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I50aec0564dc212ec9e0526419805d6f2e237c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135465Reviewed-by:
-
Manuel Rego Casasnovas authored
We fixed a bug in "outline-offset" computed style at r755943. This is just a follow-up patch to remove the custom getter from ComputedStyle as it's not longer needed. Bug: 1005372 Change-Id: I5bb76ee60444fc772a0a95139f6fd16b25604bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134144Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#756220}
-
Stepan Khapugin authored
Makes tests use SceneState and SceneController directly, bypassing the MainController. Cleans up the Guts protocol accordingly. Note that we should probably get rid of all these test helpers anyway, but it's not a priority right now. Bug: 1045660 Change-Id: Ia02a80ad287b915a79e19fbca070b803d5379c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132139 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#756219}
-
Christoph Schwering authored
This CL also shows the bulk check banner to users who are signed in but do not sync. Bug: 1047726, 1067560 Change-Id: I6f2dd091c541d67c2f1fa895df0a332e23d5f363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134827Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#756218}
-
Wez authored
This reverts commit e2eb7388. Reason for revert: Broke test_runner.py to not be able to run without the --system-log-file parameter being set. Original change's description: > [fuchsia] Collect Fuchsia system logs from Chrome-Fuchsia tests. > > The Fuchsia system logs contain more detailed information than the Fuchsia kernel logs. > > Currently only Fuchsia kernel logs are collected. The kernel logs are: > - written to the swarming task output log along with the actual test output > - optionally written to a "system_log" file in the test isolate output > > This CL will: > - optionally write the Fuchsia system log to a "log_listener_log" in the test isolate output > > The Fuchsia system log will be written if the kernel log is written. > > The Fuchsia system log is written to "log_listener_log". The name "log_listener_log" was used because the Fuchsia kernel log contents are already saved in "system_log". > > Bug: 1042512 > Change-Id: I900b5dfe9f6587f1901c19612060b979fae4da99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130679 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#756118} TBR=wez@chromium.org,kmarshall@chromium.org,steveroe@google.com Change-Id: I40d0b3030a86856717d53434ac58d7f85dce6fb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135686Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756217}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I063d45ca3749e68751daa6d38f7e38080b333872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131971 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
