- 11 Dec, 2018 40 commits
-
-
Hiroki Nakagawa authored
For cleanup, this CL moves SharedWorkerRepositoryClientImpl from core/exported/ to core/workers/, and merge it to SharedWorkerRepositoryClient. Change-Id: I694198b596ef572f064fa0638e82251e53decc0f Bug: 911415 Reviewed-on: https://chromium-review.googlesource.com/c/1369757Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615417}
-
Joel Einbinder authored
Change-Id: I4821b09569a302f8a3039a864f2dddac445bfcf3 Reviewed-on: https://chromium-review.googlesource.com/c/1370887Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615416}
-
Kent Tamura authored
Also, update symbols and comments around them. This CL has no behavior changes. Bug: 843412 Change-Id: Ic1c2381e5d431fdedf5978d510cc9018e101d70d Reviewed-on: https://chromium-review.googlesource.com/c/1370157Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615415}
-
Yue Cen authored
Bug: 912321 Change-Id: Ibfddb6628b06fe5111f873cf7716a210d47deb36 Reviewed-on: https://chromium-review.googlesource.com/c/1370369Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615414}
-
Alex Moshchuk authored
This is a followup to https://crrev.com/c/1365982, which introduced a new filter file for Site Isolation Android content_browsertests, but forgot to add it to BUILD.gn. Change-Id: I33d9626562886bd5b5b7eec051a40bc9169ed627 Reviewed-on: https://chromium-review.googlesource.com/c/1371197Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615413}
-
Dan Beam authored
This reverts commit 14d25fb9. This is a roll-forward with a fix to the URL of an iconset to load (see the diff between patchsets 1 and 2). NOPRESUBMIT=true # existing issue in destination.js Bug: 855259, 912678 Change-Id: I3aeb26263de682ecb2f0596e336ec20ab5c19807 Reviewed-on: https://chromium-review.googlesource.com/c/1371079 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615412}
-
Erik Luo authored
Screenshot: https://imgur.com/a/33LFGai Bug: 894341 Change-Id: I90abb517bb08358fa932335648be15ca0e9cab2b Reviewed-on: https://chromium-review.googlesource.com/c/1367108Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615411}
-
Pavel Feldman authored
Bug: 649657 Change-Id: I76bae556b1196336b9da03cf924e31d97a1e238f Reviewed-on: https://chromium-review.googlesource.com/c/1371210 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615410}
-
Sungguk Lim authored
When new value is updated by StorageArea.set(), chrome.storage.onChanged callback and newly added StorageArea.onChanged callback would be called at the same time. Bug: 863277 Change-Id: I9076fdf1c55f5c2d5e913e3c671aab6630cee304 Reviewed-on: https://chromium-review.googlesource.com/c/1329802Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#615409}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/762a25693faf..fed2cb39c320 git log 762a25693faf..fed2cb39c320 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brucedawson@chromium.org Fix ucrt source path when packaging the Windows toolchain Created with: gclient setdep -r src/third_party/depot_tools@fed2cb39c320 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I89fe17d53ed093db892056b008df969759be0f85 Reviewed-on: https://chromium-review.googlesource.com/c/1370651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615408}
-
Xianzhu Wang authored
When an object has multiple fragments, the original method in BoxPainter::BackgroundIsKnownToBeOpaque() didn't work because the object's VisualRect is the bounding box of all fragments' visual rects, which is likely to cover areas that are not covered by painted background. Now Let BoxPainter::BackgroundIsKnownToBeOpaque() return false if there are multiple fragments. BTW, rebaseline multicol tests containing composited contents. The old baselines expect single fragment for the composited contents which is a SPv1 quirk. CompositeAfterPaint can correctly fragment composited contents. Change-Id: Icdabe2a0eabdf2e1541481f5c09b796c33a9370a Reviewed-on: https://chromium-review.googlesource.com/c/1370276Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6d522d4fe25f..768c73895b2f git log 6d522d4fe25f..768c73895b2f --date=short --no-merges --format='%ad %ae %s' 2018-12-11 zhuohao@chromium.org rammus: add mapping for factory-rammus-11289.B 2018-12-11 lamontjones@chromium.org cros_build_lib: Return a list from GetImageDiskPartitionInfo Created with: gclient setdep -r src/third_party/chromite@768c73895b2f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5be6b9a157429c7b29b50992592c793a7b94b50f Reviewed-on: https://chromium-review.googlesource.com/c/1371194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615406}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15640698497a..a10494c302e6 git log 15640698497a..a10494c302e6 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org remove legacy switch Created with: gclient setdep -r src/third_party/skia@a10494c302e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843966 TBR=ethannicholas@chromium.org Change-Id: I317bbc0e19278427b380be8160c6e46d1f9c302c Reviewed-on: https://chromium-review.googlesource.com/c/1370650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615405}
-
Robert Ma authored
`fetch_results` is only used to fetch results from a specific run, so we should be able to safely assume that builder_name and build_number are not None. The same check is also added to `get_step_name` to prevent misuse. On the other hand, `fetch_layout_test_results` may be used to fetch the latest accumulated results, where URLs are constructed from `results_url`, so we don't add the check to either of these functions. Bug: 913687 Change-Id: Ie8b96fd22ea8e7edc804296689b11411e36ae82a Reviewed-on: https://chromium-review.googlesource.com/c/1371021 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615404}
-
Donna Wu authored
This CL is a preparation for W3C Serial API implementation in Blink. Several Serial Mojo interfaces have been renamed: * SerialDeviceEnumerator --> SerialPortManager. * SerialDeviceInfo --> SerialPortInfo. * SerialIoHandler --> SerialPort. * SerialDeviceControlSignals --> SerialPortControlSignals BUG=908833 Change-Id: Ie95722f9f368d049006da8cfe19ec15159895b9d Reviewed-on: https://chromium-review.googlesource.com/c/1365075Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#615403}
-
Simon Que authored
This CL updates the LUCI Milo config to show links/tabs for the new builders, which will be added in a separate CL. Existing staging builders are explicitly categorized as "staging". BUG=913249 Change-Id: Iad29427c8673a592eb5fd074211980910cbc983c Reviewed-on: https://chromium-review.googlesource.com/c/1368849Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#615402}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1ccf890a09a3..f4f8cc56aacf git log 1ccf890a09a3..f4f8cc56aacf --date=short --no-merges --format='%ad %ae %s' 2018-12-11 thestig@chromium.org Roll third_party/binutils/ 4110e0919..2be73f7fb (1 commit) Created with: gclient setdep -r src/third_party/pdfium@f4f8cc56aacf The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:718157 TBR=dsinclair@chromium.org Change-Id: I8d4b53f64fabc8647349c3766852e89947b22ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1371193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615401}
-
Kelvin Jiang authored
Currently, the activity log API filters the api_name field using case sensitive string equality if a filter for api_name is provided for chrome.activityLogPrivate.getExtensionActivities. This CL changes the matching scheme to be a case insensitive prefix match, similar to what is used for the page_url and arg_url fields. This should make the activity log easier to use when a user is filtering by specific api calls. Bug: 832354 Change-Id: I725542657a5879141426f621631ec69ccd88af9e Reviewed-on: https://chromium-review.googlesource.com/c/1371187 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615400}
-
Scott Violet authored
ClientSurfaceEmbedder was being created any time Window::SetEmbedFrameSinkId() was being called. ClientSurfaceEmbedder is *only* needed if Embed() was also called on this window. This patch makes it so ClientSurfaceEmbedder is only created if Embed() is called. BUG=none TEST=none Change-Id: I463458abb1248f1661358d4062389fa9a21f9446 Reviewed-on: https://chromium-review.googlesource.com/c/1369098Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615399}
-
yoshiki iguchi authored
This CL enables the lock screen notification which was behind the flag. Bug: b/111391270 Change-Id: I5d3776c9c5c39f8ce488ec26d80af967f73126b8 Reviewed-on: https://chromium-review.googlesource.com/c/1370145 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#615398}
-
Rob Schonberger authored
Add syslogs when failing. Change-Id: I86487b8047fa75ae10707701cfb7f2055d47a1bf Reviewed-on: https://chromium-review.googlesource.com/c/1369490 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615397}
-
Ken Rockot authored
This cleans up service executable support in the client library and its usage around the tree. Namely: - The GN service() template is renamed to service_executable() - The public/cpp/standalone_service directory is renamed to public/cpp/service_executable - The code in aforementioned directory is simplified and unused switches deleted - Unused dependencies on the above stuff have been removed TBR=sky@chromium.org Bug: 911217 Change-Id: I08244059ef9e473df2f4a33303e3b3979efeb933 Reviewed-on: https://chromium-review.googlesource.com/c/1367087 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#615396}
-
khmel@chromium.org authored
This adds set of new function to autotest API related to ARC app launcher in order to be able to write comprehensive autotests that are closer what actual user does for ARC. TEST=Together with crrev.com/i/727872. Extra browser tests added. BUG=b:120623980 BUG=b:120280395 Change-Id: Iac747f811a1f2d9f59a62a417e2cb2d77a593ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1368825 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615395}
-
Erik Luo authored
Users expect pressing 'Escape' to hide dialogs in DevTools, except when used with another modifier, e.g. 'Shift-Esc'. Bug: 854548 Change-Id: I33f5052c44c70cacd2a4197161a502ac9c69fcee Reviewed-on: https://chromium-review.googlesource.com/c/1366485Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615394}
-
Regan Hsu authored
Removing kMultiDevice flags and associated code paths that will no longer occur. Bug: 912743 Change-Id: Iabb917876b570b8df953f22a30eb05787a5ef1ef Reviewed-on: https://chromium-review.googlesource.com/c/1370485 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615393}
-
Eric Roman authored
Bug: 657115 Change-Id: I70526b30ea51fe77343d1e8783cc01cc84a4c68e Reviewed-on: https://chromium-review.googlesource.com/c/1369005 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615392}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/149eb33bb49f..f5c88e7e1c1a git log 149eb33bb49f..f5c88e7e1c1a --date=short --no-merges --format='%ad %ae %s' 2018-12-11 jmadill@chromium.org Refactor and inline DrawElements validation. Created with: gclient setdep -r src/third_party/angle@f5c88e7e1c1a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id37a1c48477c00e1fd96feab087f6c8c52a1ff91 Reviewed-on: https://chromium-review.googlesource.com/c/1371188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615391}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddee6ce9c58a..7f98851124b4 Created with: gclient setdep -r src-internal@7f98851124b4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:889221 TBR=mmoss@chromium.org Change-Id: Id4d6a4f17c58d47d1568e5a7ebb3f3d4d37cbac0 Reviewed-on: https://chromium-review.googlesource.com/c/1371184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615390}
-
Tina Wang authored
Setting the max height of the title container, so the title container won't change size while zooming out. Screenshots: https://screenshot.googleplex.com/7EO54hxQi5N https://screenshot.googleplex.com/kiDgYGzWrW9 https://screenshot.googleplex.com/uEgd1xRDOF4 Bug: 912861 Change-Id: I4f49488965584b8bef0f0203b7e4291df967e706 Reviewed-on: https://chromium-review.googlesource.com/c/1368591Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#615389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/faae590fff1a..53a0082b847f git log faae590fff1a..53a0082b847f --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com Merge "Find src directory in same directory as fuzzer." Created with: gclient setdep -r src/third_party/perfetto@53a0082b847f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6eaa7e7f2d57961e3a43dd1a5ed0514e5a4fee6 Reviewed-on: https://chromium-review.googlesource.com/c/1370649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615388}
-
Sunny Sachanandani authored
This reverts commit c19106d1. Original change's description: > Remove WaitSyncTokenCHROMIUM command > > After migrating InProcessCommandBuffer to use GPU scheduler, most tasks > are scheduled after their sync token dependencies are satisifed (see > crrev.com/c/1157874). > > The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer > for pepper, which specifies a sync token, and waits while handling the > message. > > Change ReturnFrontBuffer to contain the sync token, and use it to > specify the dependency to the scheduler. > > Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are > specified as task metadata in all cases. > > Make other cleanups such as removing unnecessary sync token tests, and > make sure the sync token code paths are not used where unsupported by > using NOTREACHED. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 > Bug: 778753 > Reviewed-on: https://chromium-review.googlesource.com/c/1168155 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599849} Bug: 778753, 895984 TBR=dcheng@chromium.org,boliu@chromium.org,piman@chromium.org Change-Id: I07943fdcbb131566718d51e78f134975ec53b62e Reviewed-on: https://chromium-review.googlesource.com/c/1361870Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615387}
-
dpapad authored
The test flakes because of PolymerTest.testIronIcons() which is problematic in multiple ways: 1) It only works with Shadom DOM v0 (tracked by https://crbug.com/885401) 2) It suffers from timing issues, where the iron-icon being checked has not been fully populated yet (for example missing the internal <svg> element by the time the check occurs). Clearing the DOM in teardown() works around the problem by effectively making testIronIcons() a no-op for this test. Bug: 913708 Change-Id: I643f2cf457e7bd2f3f4056452f7ccce308556972 Reviewed-on: https://chromium-review.googlesource.com/c/1371083Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615386}
-
Jason Guo authored
migration dialog per UX requirements. Bug: 897998 Change-Id: Id68513c6ad568767359d40f09b7a71abefc7118a Reviewed-on: https://chromium-review.googlesource.com/c/1361708Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615385}
-
Eugene But authored
This bug is a regression, because ios/web started presenting error pages if hasControllerForURL: returns NO and the URL is not a WebUI URL. ios/web change was a reasonable change, but BVC did not follow API contract and returned NO from hasControllerForURL: even if controller existed. Return YES from hasControllerForURL: for kChromeUIExternalFileHost if NativeController actually exists. This change enforces existing API constract for CRWNativeContentProvider. EG tests do not have good infrastructure to write end-to-end test for external URLs. BVC is also not testable, so this CL does not include tests. Bug: 902271 Change-Id: I81c08b439460bcbf81f0e7234f9cdbe57938e6fe Reviewed-on: https://chromium-review.googlesource.com/c/1370931 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615384}
-
Sunny Sachanandani authored
Other decoder implementations (VDA, ffmpeg, etc.) use the aspect ratio from the config when setting natural size of video frames. Duplicate the logic from VDA to D3D11VideoDecoder. Found due to failing Pixel_Video_MP4_FourColors_Aspect_4x3 test in CL to enable D3D11VideoDecoder (and decode swap chain) on waterfall: https://chromium-review.googlesource.com/c/chromium/src/+/1364341 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/145995 Bug: 837337 Change-Id: I54a3928646f6d71dec26e9995efe4eb7bda458d7 Reviewed-on: https://chromium-review.googlesource.com/c/1368774 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615383}
-
Shu Chen authored
Bug: 910036 Change-Id: If84c2e82863edc2057c46e81ad1feb35a86e4a53 Reviewed-on: https://chromium-review.googlesource.com/c/1370155Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615382}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/60a61e85fed1..74c92bb22076 git log 60a61e85fed1..74c92bb22076 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 benjhayden@chromium.org Add SparseDiagnostic index for _FindOrInsertDiagnosticsOutOfOrder Created with: gclient setdep -r src/third_party/catapult@74c92bb22076 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:906685 TBR=sullivan@chromium.org Change-Id: I4195a550775a54f26d803d6c4c7350be20f692f0 Reviewed-on: https://chromium-review.googlesource.com/c/1370984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615381}
-
Melissa Zhang authored
This CL defines the app struct and gives apps from the user's profile to AppManagement. It also informs the AppManagement UI of any updates to apps, including uninstallation. BUG=906508 Change-Id: I20f1483563d8252c1060212dbbfd9cb9d560f790 Reviewed-on: https://chromium-review.googlesource.com/c/1365090 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615380}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2ee9340..09253406 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7af414e692d261a6dfe48f734f5c4309e0b47ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1371018Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615379}
-
Ned Nguyen authored
Bug: 913625 Change-Id: I6d9f28e374b1751afcdd2ffb40d03d3c8ee87434 Reviewed-on: https://chromium-review.googlesource.com/c/1370495Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#615378}
-