- 28 Aug, 2020 40 commits
-
-
Maksim Moskvitin authored
This CL adds access token fetching functionality, that can be used on trusted vault backend sequence. Implementation consists of: TrustedVaultAccessTokenFetcherFrontend: * this class must be used on the UI thread * it allows asynchronous access token fetching * it supports multiple ongoing FetchAccessToken() calls (e.g. the method can be called before |callback| passed to the previous one was run) * it observes primary account changes and reply with empty access token to callbacks which correspond to non-primary account TrustedVaultAccessTokenFetcherImpl: * created on the UI thread and its ownership transferred to the backend sequence * plumbs backend FetchAccessToken() attempts to the frontend * handles invalidation of TrustedVaultAccessTokenFetcherFrontend WeakPtr Bug: 1113597 Change-Id: I72d5962c374b3141d8a20a2ad2a4b42a378bbfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379734 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#802650}
-
Alex Ilin authored
This reverts commit 7d8ab070. Reason for revert: NavigationBrowserTest.DestroyTabInNavigation fails on Android P, https://crbug.com/1123021 Original change's description: > weblayer: make it possible to delete tab in OnNavigationFailed... > > and OnNavigationCompleted. > > Content does not allow WebContents to be deleted from > WebContentsObserver::DidFinishNavigation(). Unfortunately we > keep seeing crashes because of this restriction, so I'm > inclined to provide some mitigation. > > This patch takes the approach of detecting this scenario > and delaying deletion of the WebContents. All the surrounding > WebLayer classes are deleted/destroyed and ownership of the > WebContents is passed to the Profile and deleted from a > post-task. > > Doing this may introduce it's own set of problems. For example, > if a callback/notification is still in flight from content that gets > processed before the deletion, and the code assumes there is a Tab > associated with the WebContents, then there will be problems. > > My preference is still to fix this in content, but in the mean > time this should work. > > BUG=1111127 > TEST=covered by test > > Change-Id: I9dbd9f90b88cbdbdfbab9aab81840b986fcdc410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377552 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802416} TBR=sky@chromium.org,jam@chromium.org Change-Id: I3a52b345d649e48ae0d9b6a4e480cf602214d2c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111127, 1123021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380657Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802649}
-
Brendan Shanks authored
When running 64-bit Windows binaries on macOS using Wine, there is a conflict between macOS's use of GS to point to pthread thread-specific data, and Windows' use of GS to point to the TEB. Apple has reserved some TSD slots for use by Wine to store commonly-used TEB members (such as 0x30, the 'Self' pointer to the TEB). But, other direct GS accesses by Windows programs (such as to 'StackBase') will return macOS pthread data rather than the TEB member. This was causing 64-bit Chrome to crash on macOS under Wine. Using NtCurrentTeb() gets the 'Self' pointer first, then dereferences it to access the correct 'StackBase', fixing the crash. This turns GetStackStart() from one instruction into two. Crashpad also uses NtCurrentTeb(). The 32-bit change isn't needed, but is just for consistency. Bug: 1121842 Change-Id: Id794030eb22b292530865f940bef8f0705bfd542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380425 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802648}
-
Fredrik Söderqvist authored
Add forward declarations for almost all SVGAnimated* types - the notable exception being SVGAnimatedEnumeration, which because of its templated setup is slightly more complicated to deal with. Switch SVGScriptElement to using LegacyHrefString() - which it can do because its 'href' reference should not be animated (this enforces this even more strictly). This allows making SVGURIReference::href() return a SVGAnimatedString rather than the slight more specific SVGAnimatedHref, allow the latter to be forward declared as well. Change-Id: I6e48226520c8e7e800c971111e8ddbb1a2d09611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379835Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#802647}
-
Renato Silva authored
Make the PIN input field on the login screen read only during an authentication attempt. Correctly focus the PIN input field when the login screen is shown. Bug: 663982, 1122694 Change-Id: Ib7f25e190281ce78ca9e33d19c06e4e574c7ef6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379772Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#802646}
-
Marc Treib authored
Bug: none Change-Id: I5d0aedcef0e54707c3f10376b2ca48524353358a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379895 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#802645}
-
Yann Dago authored
Bug: 1119703 Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802644}
-
danakj authored
This moves a big chunk of BlinkTestRunner out to TestRunner (for global stuff) or WebViewTestProxy (for stuff tied to each view for now). R=avi@chromium.org Bug: 866140 Change-Id: Ife09e15ed65abedfeb462546bfb0fb0498d8b32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378635Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802643}
-
Ben Mason authored
This reverts commit dbecad0d. Change-Id: I032d41a62c0a0072bab3383404604d1ea572b7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375690Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802642}
-
Bill Carr authored
Updating the expiry date and ownership for Net.MediaCache.Response.EnabledOrDisabled histogram. Bug: 1109936 Change-Id: Ifa13dc1de3aad161387a29fb4386aaad34836db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380740 Auto-Submit: William Carr <wicarr@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#802641}
-
Ben Mason authored
This reverts commit 2cb22072. Change-Id: Idf50820ec0e3898bf0e6bc722315e4aa7931d56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375929Reviewed-by:
-
Jan Krcal authored
This CL tweaks the logic on startup that decides whether the profile picker should be displayed. After this CL, it is skipped in these cases: - Guest mode is requested, - a incognito window is requested, - a concrete profile is requested (such as by Windows shortcuts), - a notification for a concrete profile is handled (Win), - a concrete URL is requested. Bug: 1122553 Change-Id: I1b3cbdf4ef74b84ffe687978b6b293e9e6ff4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379913 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802639}
-
Alan Cutter authored
This CL is a mechanical change that renames launch_url to start_url in the WebAppSpecifics proto. This is to make "start_url" more closely match the app manifest field and to make room for a separate "launch_url" in a follow up CL that includes additional query params added to the start_url. Bug: 1045537 Change-Id: I76c079d3b2b930ecc781536b95977591529b2438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374189 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I7ecc0518bedfdea0768f6e47d50864dd9e29c73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377982Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#802637}
-
Benoit Lize authored
The direct-mapped allocations' metadata layout was only explained in comments, but relied upon in several places. Document it by introducing a new struct for the metadata. Note that the comments were previously wrong, and the layout strange as well: there was a hole in the metadata (in the new struct, this would be equivalent to adding an empty PartitionPage-sized hole before |direct_map_extent|). This was not a correctness issue as the whole page can be used for metadata, but is still confusing, undocumented and strange. Also removes an outdated comment which came as part of a rebase in https://chromium-review.googlesource.com/c/chromium/src/+/2335443 in the unit tests. Bug: 787153, 1092288 Change-Id: Ibe0024ac94008ad94b3706d9f9bd754b6f07977f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379912 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802636}
-
Eric Willigers authored
The web-share policy is currently only for use counters https://groups.google.com/a/chromium.org/d/msg/blink-dev/fgme9KOd8CU/0xJW9MAPAgAJ We ensure it is not visible by introspection using document.featurePolicy Bug: 1121034 Change-Id: I3ff271efa45eca43055e975fefc4a8db43960b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371447Reviewed-by:
Ian Clelland <iclelland@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#802635}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33a6332a9232..a1be3faad1c6 2020-08-28 fmayer@google.com Merge "Make all wire protocol structs stable across ABI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0c445e61ab026dfbfc2e6655aca14ca3ee525dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802634}
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2353116 ([ozone/wayland] zaura_shell initial support). BUG=1113900 R=msisov@chromium.org Change-Id: I547f66e49e8ae4161ed15a7359f91b8b7ea17019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381253Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#802633}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fde4d2f7457e..5c8601ed8285 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cac2574c240a to af56d31487bb (5 revisions) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 0654095b63fb to d846ea5a2427 (4 revisions) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from c472fa2f0330 to 1b0bbd1550ed (1 revision) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1f48854dae26 to ec3650f56ca2 (1 revision) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from bceab9fab4bc to 08291a3a9e22 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I78c4b1bc7430b4ddda789f58473ee7828bc1b4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381438Reviewed-by:
-
nohe@chromium.org authored
This adds a ChromeOS feature flag disabled-by-default. This will allow users the capability to copy images to the clipboard as an experiemental features from the ChromeOS Files App. This will be enforced in the javascript chrome.fileManagerPrivate API. Bug: 827333 Change-Id: Ic04ebd75ac2d38e527f2682fbe1ab4a87c644853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375702 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#802631}
-
Hans Wennborg authored
TBR=thakis Bug: 1122969 Change-Id: Iee48f90cb68ea8088101bfdf37b432f99729af95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380655Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#802630}
-
Yunke Zhou authored
Bug: 1122717 Change-Id: I960a3bdffda9f0a2f19cca30dfc6c15acdb33dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379842 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
-
Ulan Degenbaev authored
Subsequent CLs will add support for workers. Since each worker has its own V8 instance and its own heap, a new PerIsolateV8MemoryUsage level is added to the result. Changes: - V8IsolatedWorldMemoryUsage is removed. - PerFrameV8MemoryUsageData is renamed to PerContextV8MemoryUsage. - PerIsolateV8MemoryUsage is added and contains data which used to be directly in PerProcessV8MemoryUsage. - PerProcessV8MemoryUsage now contains an array of PerIsolateV8MemoryUsage, which right now always has 1 entry but in the future we will instrument more isolates. The support for extension contexts (isolated worlds) is removed until they get their own V8ContextTokens. Bug: 1085129 Change-Id: I273f06ec839e509f73cff6a1692d06d9ed36d752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359069 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#802628}
-
Roman Aleksandrov authored
Bug: 1119399 Change-Id: Id94e7d2fe95ae94bd26f027ecffb170c4b701251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368555Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1597611060-adf0ab6d7715dfdb592c8864718732c417ac4f3f.profdata to chrome-win32-master-1598601518-e5c4427f7e0d3b1c20c8bd75b29ccde9f832fa2b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id4f9b54037e807d8c6975fc88cc1aca238c1df36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381433Reviewed-by:
-
Adithya Srinivasan authored
In preparation for restricting cross-origin portal post messaging, this CL changes portal-host-exposure.sub.html to use Stash to communicate from a cross-origin portal to its embedder, instead of using postMessage. Bug: 1108793 Change-Id: Ib3dbb7cc56277cf28ac7a12ccf369a7ea9ce9f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377323 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#802625}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598594188-9fa81c93dd83e8129d07cc38e4d22506253a8a4e.profdata to chrome-mac-master-1598613564-5098a3febf11f8ec7b96c750766d9c7bc759629e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I4e4a14ff583875435d2f25aef6378fd9154bf775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381441Reviewed-by:
-
Edward Jung authored
Part of Chrome efforts to remove oppressive language in the codebase. Change-Id: I21dacf6759dbf840692127e1a30eb08a724549ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380273Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#802623}
-
Swapnil authored
Some protos are not meeting the guidelines and raise a warning on the server side as the firt entry should have some predefined keywords in it. The keywords that are allowed according to the guidelines are: https://source.corp.google.com/piper///depot/google3/devtools/staticanalysis/pipeline/analyzers/proto_best_practices/analyzer/service/enum_utils.cc;l=15 Change-Id: I8c152bf9892c62e09dda49e1b3115c845687db8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368552Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#802622}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/89760badbdb0..7ab9c51e8047 2020-08-28 sakal@webrtc.org Update gradle wrapper & gradle plugin. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4eb99eced16169ac18edf7d61476a6014e29ba7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381437Reviewed-by:
-
Noel Gordon authored
Videos are container formats that contain a video stream and its audio stream. The streams may be in any order. So if the audio is the first, mime type sniffing detects audio/* mime content. Not quite right given the main content is "video/*". After CL:2379424, the metadata system can reliably detect "video/*" if we include media metadata types in a metadata request [1]. Change the quick view metadata request for local video to do that, and change the expected mime type to "video/ogg" in the integration test. [1] See apitest of the expected behavior added in CL:2345936 testGetContentMetadataVideoResetsAudioMime Test: browser_tests --gtest_filter="QuickView/FilesApp*" Bug: 1114622 Fixes: 1114622 Change-Id: If9b62f9be1f51c760253c85e396ea2cf4cf741eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381333 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#802620}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6b329fd516bd..d4a7e12496b5 2020-08-28 tvanderlippe@chromium.org Typecheck persistence/AutoMapping.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5c3c853cb9b05601cb0da711d1793148b30b2565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381435Reviewed-by:
-
David Roger authored
This function can be called from within the ProfileManager destructor. The profile manager is destroyed by the g_browser_process doing profile_manager_.reset(). When this happens, the profile_manager_ member is first set to nullptr, and then the ProfileManager object is destroyed. As a result calling g_browser_process->profile_manager() within the profile manager destruction is a null pointer dereference. Fixed: 1122243 Change-Id: I3ac7a41e8d36212ddc78403eb4c830ceb1059b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379758 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#802618}
-
Andrew Shulaev authored
Bug: 156903151 Change-Id: I45898f934ba8b8487532cd452bbb59eca7b644ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366723 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#802617}
-
Alex Ilin authored
This reverts commit a1ee3eea. Reason for revert: SwitchToTabTest#testSwitchToTabSuggestionWhenIncognitoTabOnTop is failing fails on O and P bots Original change's description: > TabModel type should same as Tab type when switching tab > > We were use getCurrentModel() to switch tab, and this will be a problem > in multi window mode. We should choose the model(incognito or not) same > as the tab which we will switch to. > > Bug: 1121102 > Change-Id: Ie9742fb4a1b38f921c01d7f8ffd47a813b1b5a14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379093 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802295} TBR=tedchoc@chromium.org,gangwu@chromium.org Change-Id: Ic897ac3efff8f859fb1c2eb6b94997185145820e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121102, 1122985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379899Reviewed-by:
-
Yunke Zhou authored
Bug: 1121252 Change-Id: I808c1b4ec6519997751710990fead37d2ca7f5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374786Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e855d43. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I5002ac5a689e29597fd503af3ce23296f0bbb1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380552Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802614}
-
Jan Krcal authored
This CL fixes a regression in the user menu that the title and the subtitle stopped appearing. This was likely caused by some change in general UI code how views without layout manager are handled. This CL defines a proper layout manager for the container making the title and the subtitle appear correctly again. Bug: 1119719 Change-Id: I97cc2f7dbfff7a75d69c438e4dc31d87dd09191c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379725 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Alex Chau authored
chrome/services/sharing/* - Introduced ConnectionsOptions for RequestConnection - ConnectionsOptions includes bluetooth MAC address and medium selector chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of the above APIs Medium availability is determined by DataUsage setting and network status Bug: 1076008 Change-Id: I20a3f6ab3258d657984356aa3576d9a407350721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379893 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802612}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I845ef2c5bf23f4206f30993697bc1ff750772eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381430Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802611}
-
