- 19 May, 2020 40 commits
-
-
Takashi Toyoshima authored
Disable OOR-CORS by default on Android again to mitigate risks on launching the feature on WebView M83. Bug: 1084380 Change-Id: Idd1a1aa9ef2ce813de78fe7d6ea3d5835bf8f2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206565 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#769990}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36aad447..416580cd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffab7c1075eb5b6ed7d0abd795ccc4d458eca31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208491Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769989}
-
David Tseng authored
|cell_size| was not initialized during the test which expected it to be. The parameter is optional according to idl, but in this context, it probably should be initialized. Tested locally on an msan build. Original change https://chromium-review.googlesource.com/c/chromium/src/+/2206198 TBR=dtseng@chromium.org Change-Id: Ie623a55ad298c9e6522102338fe7357dd28c521e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208024Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#769988}
-
Xianzhu Wang authored
This avoids composited layer of the relative position element in the following example when the scroller is composited: <div style="width: 100px; height: 100px; overflow: scroll"> <div style="position: relative">layer in non-stacking-context scroller</div> ... </div> Stacked elements contained by a non-stacking-context composited scroller can be squashed into the scrolling contents layer if there are no other non-squashable layers interlacing between the scrolling contents layer and the candidate layer. This avoids unnecessary composited layers under composited scroller. Also avoids composited scrolling of non-stacking-context causing losing of LCD-text of layers like the relative position element above. The next step will remove MainThreadScrollingReason::kIsNotStackingContextAndLCDText, so that the situation won't block composited scrolling when LCD text is preferred. Bug: 1080056 Change-Id: Id1faafa567b67aae1d6d07dc93091b4d18620a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194791 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769987}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e79dd6ea5f3..9d8c46579122 git log 4e79dd6ea5f3..9d8c46579122 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@9d8c46579122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie220a9b06666dfde49ef654b12a8da9f1bcb99a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769986}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d12fe258b55..41d405e9fe05 git log 4d12fe258b55..41d405e9fe05 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 chonggu@google.com [Fuchsia] Add flag support for web-engine-shell on Fuchsia Created with: gclient setdep -r src/third_party/catapult@41d405e9fe05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1075696 Tbr: oysteine@google.com Change-Id: I7b9eef9125a9a7b2f3ec3c5fbd10d0ef13f67bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208458Reviewed-by:
-
Xianzhu Wang authored
We no longer need scrolling_layer_ after BGPT launched. For squashing_containment_layer_, we can remove it by ensuring squashing_layer_ is always the last child of graphics_layer_. There is still one dummy layer: overflow_controls_host_layer_ which is needed for convenience of reparenting overflow control layers. Change-Id: Ibdafef32d918e66a12c35d2a5726c50ea374f7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205518 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#769984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b10c593. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie7af8d42cc61bb20bf136e4be9ce766a578a9959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208490Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769983}
-
Keishi Hattori authored
Removes pre finalizer from HeapMojoRemote. HeapMojoUniqueReceiverSet, and HeapMojoAssociatedRemote. It turns out they weren't necessary as we do not store raw pointers to GCed objects inside mojo::Remote, UniqueReceiverSet, or AssociatedRemote. Change-Id: Ie44a9ef1ab9398e58dd972993663470ac0581881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206059Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769982}
-
Willie Koomson authored
This changes removes cmtm@ from ArcProcessService OWNERS, since he no longers works on ARC, and adds wvk@ as a new owner. BUG=b:156981234 TEST=none Change-Id: I1082825aa594ef2a30a316d731d2b9b7fb43d2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208260 Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by:
Chris Morin <cmtm@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769981}
-
Charlene Yan authored
for the collapsed TabWidthConstraint. When the tab group collapses, the available tabstrip width is not updated to reflect the collapsed group. Also easier and less code >_> Bug: 1018230 Change-Id: If3e0907ce3b881e736c748a6db7b040e66a5c172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207617 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#769980}
-
Carlos IL authored
A bug was fixed in page info that invalidates the previous test goldens (in crrev.com/c/2199989), this increments the RenderTestRule revision in affected VR tests. Bug: 1083342 Change-Id: I22075e6373514a493cadbe43eb10d1b7d06ef403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207932Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#769979}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/cnqGc0zHoLZzSKNvwi5e6XGyrYFhP1ILa3OsLp_g0PMC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202005180800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ibe09e7cdd19c34bb211a41a450c7b70349b6c279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208150Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769978}
-
George Burgess IV authored
Running this callback twice seems unintended, given that we `std::move` it at each call. Bug: None Change-Id: I0e9a19fd0caf255bcd817fffa6cf95b621fb6eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203477Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#769977}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a90905cc0c8..7a960b632510 git log 8a90905cc0c8..7a960b632510 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src aaba2f0ac575..3e390a159761 (1 commits) Created with: gclient setdep -r src/third_party/angle@7a960b632510 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I75f6242e4ea70edb7262d963e22663ef793b4f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208207Reviewed-by:
-
Tom Anderson authored
This CL removes XAtom from x11_types.h and replaces all usages with x11::Atom. This means that ui/gfx/x/connection.h needs to be included everywhere x11_types.h was included, so it's just included from x11_types.h directly. This causes a problem: xproto_undef.h undefines a bunch of Xlib macros like CopyFromParent, so these usages are replaced with "0 /* CopyFromParent */" until further refactoring. There are a couple of cases where macros are not undefined (eg. Bool), so direct inclusions of ui/gfx/x/x11.h are added to fix these. Unfortunately, this CL introduces a lot of ugly static_cast's to convert from x11::Atom to uint32_t for Xlib APIs, which will be removed as usage of these Xlib APIs are removed. I also fixed any clang-tidy warnings that showed up in my editor along the way. BUG=1066670 R=sky Change-Id: Ifdc3c1a137a39cbbb37407e4299026c70da5281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202789 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#769975}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I0dbc1032169d826868ea0969c61563dcf814bba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208269Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769974}
-
Asami Doi authored
This CL makes offline capability check for navigation preload return a network error. |preload_handler_| is set up with dummy URLLoader and URLLoaderClient and it always calls OnComplete() with a network error. There are 2 new browser tests to make sure if offline capability is supported. Bug: 1031950 Change-Id: I6e74c02707305e4c654d1077c7cdd28d30aa4939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186871Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769973}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/21bceb888974..9f35145a1ed0 git log 21bceb888974..9f35145a1ed0 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 thestig@chromium.org Replace remaining FX_ArraySize() usage with pdfium::size(). 2020-05-18 tsepez@chromium.org Remove pdfium::MakeUnique() 2020-05-18 tsepez@chromium.org Remove stray includes of ptr_util.h 2020-05-18 tsepez@chromium.org Convert remaining pdfium::MakeUnique<> to std::make_unique<> in xfa 2020-05-18 thestig@chromium.org Update third_party/base/optional.h. 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxfa 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in testing 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::MakeUnique<> in fpdfdoc. 2020-05-18 thestig@chromium.org Replace FX_ArraySize() with pdfium::size() in fpdfapi. 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxge 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxcrt 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxcodec 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fpdfapi 2020-05-18 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fxbarcode 2020-05-18 thestig@chromium.org Replace FX_ArraySize() with pdfium::size() outside of core/. Created with: gclient setdep -r src/third_party/pdfium@9f35145a1ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1435 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I259eca44111c5692312159c9e00138806315fdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208208Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98bc22c68981..7a4ea2baf5df git log 98bc22c68981..7a4ea2baf5df --date=short --first-parent --format='%ad %ae %s' 2020-05-19 reed@google.com Revert "Cache hb_face." Created with: gclient setdep -r src/third_party/skia@7a4ea2baf5df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I2e0cdb9337eb915ac3c52dea058b2352366ec704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208455Reviewed-by:
-
Joe Downing authored
I originally fixed these as part of a different CL but that change turned out to be unnecessary due to my change last week to cleanly close the PeerConnection. So here is a super-minor clean-up CL that fixes some comments. Change-Id: I588239e74f341d87a2468d7d47eccb00161fb5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208091 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#769970}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ca609c305ed1..763905cc6884 git log ca609c305ed1..763905cc6884 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 rwkeane@google.com Code Coverage: Add missing buildbot config Created with: gclient setdep -r src/third_party/openscreen/src@763905cc6884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I36ed0d1538c473889fb42ac54e3a943ddebe50a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208452Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4fb1974191f..e67e41aa8994 git log c4fb1974191f..e67e41aa8994 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e67e41aa8994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9aa0d705414ff873b0d6946a87e8bb54d1f50ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208451Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d136b6ae..36aad447 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieee40203f8fbcb98722738b2d52c0c5834808817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206919Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3aab09d9c915..1c8cab8f9441 Created with: gclient setdep -r src-internal@1c8cab8f9441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I46196649f4348308b213f9315fc60d3c160dea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208200Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769966}
-
Eric Willigers authored
This CL is in preparation for enabling the Bookmark Apps without Extensions (BMO) flag "DesktopPWAsWithoutExtensions", to maximize time on Canary. Each unit test that does not yet pass with the DesktopPWAsWithoutExtensions flag enabled is parameterized and a TODO is added. We will work over the next few weeks to update these unit tests, or their test intrastructure, so they pass with the flag enabled. Bug: 877898 Change-Id: I1835b78c12429d2372377b609ae9b7d187aec695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206298 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#769965}
-
Dominic Mazzoni authored
The goal is that when we enable kEnableAccessibilityExposeHTMLElement, relatively few tests will be affected. In this tests, there was an assumption about nodes being an immediate child of the root element. Bug: 1063155 Change-Id: I5c906ac6a518755b48cefd12a6e3bef7b2c59aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206225Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#769964}
-
Hiroki Sato authored
Bug: None Test: git cl lint Change-Id: I52cc6c0c8191417f394e03e971a31c594cd424e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206140Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#769963}
-
Chong Gu authored
Allow skipping specific tests that aren't supported on Fuchsia. Remove the logic for supports_swiftshader in gpu_process tests, since we only run those tests on platforms that support swiftshader. Bug: 1058255 Change-Id: I423a376ef9c25bd36ed39349399a9d327e425683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207939Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Hui Yingst authored
Bug: 1039520 Change-Id: I34c324b776b0248a907f45d1a74b5d72d3cb59cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203151 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#769961}
-
David Munro authored
Bug: chromium:1084374 Test: Manual, deploy and look for yellow colour. Change-Id: I870d458dd7ca179cea0a6b5317fd1c04613fbcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208330 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#769960}
-
danielng authored
Always forwarding ports on wlan0 isn't ideal, this commit makes it so that ports are forwarded on the interface of the highest priority network. It makes use of network handler, to ensure it is only looking at physical networks/devices and trusts the prioritization used there. Bug: 848127 Tests: Manual testing with eth, wlan, tether and VPN networks. Change-Id: Iabd15c717b3cc7792fa39909c2f34809d4aeac89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200303 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#769959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbcf680f8fd3..98bc22c68981 git log dbcf680f8fd3..98bc22c68981 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 reed@google.com add fontmetrics to custom typeface Created with: gclient setdep -r src/third_party/skia@98bc22c68981 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I5d8adc4c1f628fe3700e7506dec01b1cf3e4df5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208203Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/24dcbd1b1f68..0ab78114a9e1 git log 24dcbd1b1f68..0ab78114a9e1 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 laddoc@outlook.com Add check for DOUBLE in low versions (#2223) 2020-05-18 greg@lunarg.com Flatten all interface variables (#2217) 2020-05-18 cepheus@frii.com Bump version. Created with: gclient setdep -r src/third_party/glslang/src@0ab78114a9e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I34180d1f6ec67df3ded3e3a00c196404498cc2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206894Reviewed-by:
-
Aaron Colwell authored
There are several tests that were implicitly making assumptions about lock URLs and didn't really need to have those details. This change has a variety of lock URL related changes that make tests less dependent on the actual implementation of process locks and fixes a few cases where site URLs were being used as lock URLs. Bug: 1015882 Change-Id: Iad9304cd7464a3cddbff61d72c33a707cde5081b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196858 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#769956}
-
Avi Drissman authored
The fallback task provider triggers and provides a task for a render process if the render process has a service worker in it but no tabs. Add the ability for the fallback task provider to fall back for a collection of providers, not just one. Use that to fall back for both the tabs and the workers. Bug: 1083664 Change-Id: Ia7d9d0248fb40df3c25c43ec2bcd915f78c159ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204363 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#769955}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2af35ab984e3..ef93a2618066 git log 2af35ab984e3..ef93a2618066 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 handellm@webrtc.org RtpVideoStreamReceiver::RtcpFeedbackBuffer: remove lock recursions. Created with: gclient setdep -r src/third_party/webrtc@ef93a2618066 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9578ca2de72d65de9f81faa1eaa864e5c6d744b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208199Reviewed-by:
-
Hirokazu Honda authored
This retrofits DecoderBufferValidator to video_encode_accelerator_tests. It inherits DecoderBufferProcessor and validates a bitstream by parsing it and check some compressed info (e.g. visible rectangle and profile) are expected. Bug: 1045825 Test: vea_tests on eve Change-Id: I33d324ae647e5199144a9910e5f699af831222a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109577Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769953}
-
Miyoung Shin authored
WebViewPlugin didn't have the implementation of blink::mojo::WidgetHost, it was able to access the null pointer access when the mouse pointer is moved to on the plugin view, so this CL implements blink::mojo::WidgetHost in WebViewPlugin and adds WebWidget::GetTooltipText for the web test. Fuzzer report: https://clusterfuzz.com/testcase?key=5128177771413504 Bug: 1081999, 1082648 Change-Id: Ia24d71b687850d796bff02bcca496dc04217c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198517Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I072bf5ae65b0b69db8f725c86ac9e6ca179183d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208270 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#769951}
-
