- 04 Dec, 2020 40 commits
-
-
Yifan Luo authored
Bug: 1116418 Change-Id: I4753f5f077a861501088ce6797d99402de4558de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574637Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#833766}
-
Dominique Fauteux-Chapleau authored
This should address the concerns raised in crrev.com/c/2391514 without regressing crbug.com/1100902. Bug: 1151724, 1139050, 1100902 Change-Id: I2180278fec307555eb9714aed6f3644520838326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556587Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833765}
-
Palak Agarwal authored
This is a reland of 5aea6042 New changes: - Visibility client needs to be set for parent widget in ChromeOS platforms which otherwise causes uninitialised memory error. Original change's description: > Implement the confirmation-box for getCurrentBrowsingContextMedia API. > > Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 > > UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing > UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing > > This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. > > This is an API for capturing the current tab. > > Design doc: > go/get-current-browsing-context-media > > Intent-to-Prototype: > https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ > > PR against spec: > https://github.com/w3c/mediacapture-screen-share/pull/148 > > > Bug: 1136942 > > Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 > Commit-Queue: Palak Agarwal <agpalak@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831017} Bug: 1136942 merging Reland "Implement the confirmation-box for getCurrentBrowsingContextMedia API." This is a reland of 5aea6042 Original change's description: > Implement the confirmation-box for getCurrentBrowsingContextMedia API. > > Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 > > UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing > UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing > > This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. > > This is an API for capturing the current tab. > > Design doc: > go/get-current-browsing-context-media > > Intent-to-Prototype: > https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ > > PR against spec: > https://github.com/w3c/mediacapture-screen-share/pull/148 > > > Bug: 1136942 > > Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 > Commit-Queue: Palak Agarwal <agpalak@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831017} Bug: 1136942 Change-Id: I441da788396f9b74253df7d7bb2573483502688f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561622Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#833764}
-
Abigail Klein authored
Introduce a Live Caption toggle image button in the volume slider. This UI follows the Android pattern of offering a Live Caption button in the volume controls, enabling easy access to toggle the feature on and off. This CL does a few things: 1. Moves the live_caption icon from chrome/app/vector_icons to components/vector_icons so that it can be shared with chrome and ash, and renames it as live_caption_on. 2. Introduces a new icon, live_caption_off. 3. Introduces a LiveCaptionButton in the UnifiedVolumeView. 4. Since the new LiveCaptionButton shares code with the MoreButton, introduces a new template, UnifiedVolumeViewButton, which contains the shared ink drop and color code. 5. Defines the kLiveCaptionEnabled pref name in ash (synced with the chrome pref). 6. Introduces a new toggle_background to the ToggleImageButton which allows buttons to toggle their background color when the toggled state changes. Screenshots: Live Caption off: https://screenshot.googleplex.com/BRoxxFsssg9f6ix Live Caption on: https://screenshot.googleplex.com/58TfboB96UU273Z Bug: 1055150, 1111002 AX-Relnotes: N/A (feature has not launched yet) Change-Id: Ie8b3736eaee3a2fc4ba841de8d98dd8c95495e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571481Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#833763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a58c14025a27..fa8d6915cbbf 2020-12-04 jvanverth@google.com Remove Metal Perf bots running on MacOS 10.13. 2020-12-04 johnstiles@google.com Simplify various logic around multi-dimensional arrays. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I36cdd6615adcfff3a3d89c47389579a69ba23ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833762}
-
Stepan Khapugin authored
Reenables this test. It should now pass. Fixed: 1037651, 1029255 Change-Id: I982814eb592f227562947fdcd25972885739d1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574936 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#833761}
-
Yu Su authored
Change-Id: I4c5fdbd3648e088353db5491084c3247b0f40968 Bug: 1155490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574478Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#833760}
-
Vladimir Levin authored
This patch adds a transition directive class to viz. It isn't currently used outside of unittests, but will be referenced in cc and indirectly from Blink in order to construct the right directive for viz to execute. R=kylechar@chromium.org Bug: 1150461 Change-Id: I9cbe63507148405b0a363ee6d957d76b1a18b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568985 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833759}
-
rbpotter authored
This largely seems to create a bunch of noise for screenreaders whenever the preview is reloaded, unless another element is explicitly focused. The message is also generally unhelpful, e.g. Chrome Vox reads out the name of the underlying WebContent, iframe, and the names of all the plugin buttons, which seems unlikely to be useful. Bug: 987370 Change-Id: I97b7d25b859e50bd51b82ffa6760571ae8319a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573881Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833758}
-
Zhaoliang Ma authored
Bug: 1126811 Test: apprtc on atlas Change-Id: I903dac22f3504f2cc142e3fcad1feb93b12ed58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574069Reviewed-by:
-
Robert Sesek authored
Bug: 1153883 Change-Id: I54580da3620bc97a5dd5d812ff798fc7aaeedf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571812Reviewed-by:
-
Norman Rosas authored
//components/w…, and//components/z.., also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I2ebce402c335ad9d8f54120ba41860832eeef621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570554 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e12f9222902..b917ab64e84b 2020-12-04 tvanderlippe@chromium.org Update third_party/wasmparser to 4.0.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I965621fc0a40a702c44e0a7f979f1cf05bdeb8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573526Reviewed-by:
-
Camille Lamy authored
Add a WebFeature use counters tracking embedding of cross-origin subframes without a CSP frame-ancestor header. Bug: 1153118 Change-Id: Idbffecd04bb90ad8278ef945fb31a5d2d1bd20f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562300 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#833753}
-
Yifan Luo authored
Reversed order of fuzzer proto file to make the corpus files more useful. Bug: 1116418 Change-Id: I8f2f789b014ec252a072dfbb037e543f0a39b3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574636 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
-
Ryan Keane authored
This CL picks up a bugfix integrated into protobuf as part of commit: http://cl/342360226 This fix is responsible for fixing a bug in the serialization code when trying serialize/deserialize protobuf messages at the end of an iostream Change-Id: I7608174a083b6b63c152c1250d3ccd1fd53914c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535667Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#833751}
-
Gavin Williams authored
Show the new status icons for local CrOS enterprise destinations in the dropdown and in the destination dialog. http://screen/Ar4TwJzsnGBmQeo http://screen/49UeCL7e9KMmuUy Bug: 1146550 Change-Id: Iaa5c2933db43f32fe054619863b71c7483af62b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572396Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833750}
-
Josh Nohle authored
At login, and if the user has Nearby Share enabled, record the user's chosen degree of visibility to their contacts, which was selected during onboarding or updated in settings. Note: Any changes made to the visibility setting will not be logged until the next sign-in. Bug: 1105579 Change-Id: I5f78dbdc841b83d09a2e30c6c1b68c813453df3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568535Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#833749}
-
Pavel Yatsuk authored
This CL updates Clank save password message's title and description to match the spec and iOS behavior: https://docs.google.com/presentation/d/1g1kh48QQI83Smn6Nyq0AaRJ8ZVcURagRgIrZh02dF00/edit#slide=id.g88ba208385_0_43 The title depends on whether the user has enabled password sync. The description contains username and masked password. R=lazzzis@chromium.org BUG=1153925 Change-Id: Ideefa29e86d6f710012d82f440e38b7fe9073b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564329Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#833748}
-
Norman Rosas authored
also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I7928d67f53992d10fe108f369210c345511a8008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570550 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
-
Omar Morsi authored
After CL:2566756, enterprise.platformKeys API tests are ready to use mixins. Using ExtensionForceInstallMixin will make it easier and cleaner when extending enterprise.platformKeys API tests. Bug: 1148294 Change-Id: I4ffa1b0cc8422695ad75fd5057020269f561447c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569510 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833746}
-
Curt Clemens authored
- Give error divs role=alert so that errors get announced. - Make progress wheel accessible by setting role=progressbar and and providing progress via aria-valuenow. Set tabindex=0 during progress so that it can be focused and the percentage read. - Add a label for the device name. - Make the confirmation token an aria-live region so it gets read when it shows up. - Hide the add contact section when the error section is visible to prevent overflow. (Add contact isn't implemented yet -- the elements are on the page, but they're never visible.) Bug: 1148475 Change-Id: I49cbcb8c7930a3eddad042ce1ea5389306a6d067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Asanka Herath authored
Blink bindings generate use counter names in several locations. This change updates the name calculation logic to match what's used in generating the web_feature.mojom file. In addition, the change also introduces logic to perform a rudimentary parse step on the web_feature.mojom file and extract the feature value constants. These are the values that will be used eventually for locating usage metrics for identifiable APIs. Bug: 1144960 Change-Id: Id40ccab032f1fb04e1c06bd763847f73180df8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552722Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#833744}
-
Andrew Xu authored
Currently menu items may be disabled due to lack of access to clipboard data. In fact, the code in the DLP side should decide whether pasting clipboard data should work and abort the paste if the paste destination has no data access. Hence, disabling menu items in the view side is meaningless. In this CL, the code of disabling menu items is removed. Bug: 1151497 Change-Id: Iaf140ac9151a21a4ff17859d6702cafe3a5ebe08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561105Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833743}
-
Benoit Lize authored
The thread cache can accumulate a bounded but non trivial amount of memory. Add a periodic (from a a timer) reclaiming mechanism. However, since the timer should not wake up an otherwise idle process, it stops unless there were enough allocations on the main thread since the last purge was called. Bug: 998048 Change-Id: I7e2bb6126b03a00d9c6723d1105d53fe728f8c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527172 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#833742}
-
Javier Fernández García-Boente authored
Change-Id: I76e09c657256bd734c15cc9cde65c68c72f07c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573142Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#833741}
-
Sophie Chang authored
Bug: 1146151 Change-Id: Ic327827d7c3fb65c1baaf92562320062372ca8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573520Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833740}
-
Alice Wang authored
This CL hides the dismiss button of the account picker bottom sheet behind a feature flag for UX experiment. Bug: 1155517 Change-Id: I8d595c5e1797cf86ab17de98bf9a68c8b128450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573083Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833739}
-
Andrew Grieve authored
This reverts commit 49606d08. Reason for revert: Official builds are taking too long. Original change's description: > Reland #2 "Android: Enable use_debug_fission for official builds" > > This reverts commit d4c88d4c. > > Reason for reland: Fixed in 9ab29d69 > > Original change's description: > > Revert "Reland "Android: Enable use_debug_fission for official builds"" > > > > This reverts commit 30f14e92. > > > > Reason for revert: official bot breaking > > https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 > > > > Original change's description: > > > Reland "Android: Enable use_debug_fission for official builds" > > > > > > This reverts commit 86befdda. > > > > > > Reason for reland: Bugs fixed in other CLs (see issue) > > > > > > Original change's description: > > > > Revert "Android: Enable use_debug_fission for official builds" > > > > > > > > This reverts commit 9d3a4611. > > > > > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > > > > > Original change's description: > > > > > Android: Enable use_debug_fission for official builds > > > > > > > > > > Bug: 1122182 > > > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: 1122182,1144538 > > > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > > > Commit-Queue: Krishna Govind <govind@chromium.org> > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#823080} > > > > > > Bug: 1122182 > > > Bug: 1144538 > > > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#827946} > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1122182 > > Bug: 1144538 > > Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#830755} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182 > Bug: 1144538 > Change-Id: If770c3864f5c9bf6e90a25bd1985d358d42f2b2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560912 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831414} TBR=agrieve@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122182 Bug: 1144538 Bug: 1153349 Change-Id: I37a427096c04c4c461170580dc6ded2ae6c2ffd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574436Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833738}
-
Michael Bai authored
Simple patch, just move the implementation, no functionality change. Bug: 1151542 Change-Id: I0f8c72bc244d10ed1ed0faf82694cd437deb4009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573457Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#833737}
-
David Bienvenu authored
Replace with CancelCallbackOnce/Repeating, as appropriate. Bug: 1007788 Change-Id: Ice87e5485f2d5c51ba13162c16162b53f6bcb09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560785Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833736}
-
Rainhard Findling authored
When the password check found only weak passwords, but no compromised passwords, show an info icon instead of a warning icon in password check. Bug: 1128904 Change-Id: I43729548e36e7d263ca6e2465f9d733c6a920bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573101Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833735}
-
Andrei Pascovici authored
VolumeControlAndroid should be allowed to perform these operations. See internal bug #15 for details. Bug: internal b/174680080 Test: on device Change-Id: I654c8c33c5991894cd44ba2bedfa08f2f1eb7288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572131Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#833734}
-
Frédéric Wang authored
content::IsPotentiallyTrustworthyOrigin is just directly calling network::IsOriginPotentiallyTrustworthy. This CL removes content::IsPotentiallyTrustworthyOrigin, move tests for network::IsOriginPotentiallyTrustworthy to is_potentially_trustworthy_unittest.cc and updates callers accordingly. There is no behavior change. Bug: 1153336 Change-Id: Ifc3a45d0d444225e763bb87935d503a882f8a09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563759 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
ckitagawa authored
"&cs=0" is only sometimes appended to the url. Use startsWith instead. Bug: 1155558 Change-Id: I4b4c617dd1a49777792f7b4f5edd5a823ef8eacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572907Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#833732}
-
Joe Downing authored
This is needed in order to instantiate COM objects on the current thread (otherwise the underlying Chromium libraries will complain). I'm not sure why this wasn't needed in the past but AFAICT there have been other changes in the underlying libraries which prevent our solution from working (I have a follow-up CL to fix a crash in //media once this issue has been resolved). If the H.264 encoder performs well and we decide to enable it via the client UI, then I'll look into updating the autothread it runs on to own the scopedCOMInitializer instance. Change-Id: I5ae3aa3a97f3f3f57733e6c00cae3b7281ea950c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572794Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#833731}
-
Dominic Battre authored
It's a common mistake that developers just remove Register...Pref() calls for preferences they don't need anymore. If they do this, the preference stays in the prefs files on disk for ever. A proper approach is to first ClearPref() the preference for some releases and then to remove the code. This CL introduces a presubmit warning if we detect that a Register...Pref() call is removed from a non-unittest. Bug: 1153014 Change-Id: If8f19933de039553ef47e0ddce12eb194df45ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560205 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
These are ported to Karma unit tests in https://crrev.com/c/2573372 R=yangguo@chromium.org Bug: 983851 Change-Id: Iafd49b402b98b6f1797b1a55ef75a1ab405f0e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572843 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#833729}
-
Matt Falkenhagen authored
Tbr: timvolodine Change-Id: Ief88cd6583a4a0777e6672b5abe161b8699ea420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569293 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833728}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606996231-fb1aa25fe6cd29fd31733f8199da138cbb1f5caf.profdata to chrome-win32-master-1607061555-42057a46d6898e28766e44cc3eff7a0d211d34f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I001ab32553afdfb4fd5b9666cd67447d7839169b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573644Reviewed-by:
-
