- 13 Aug, 2019 7 commits
-
-
Mia Bergeron authored
This CL rearranges the different components of the CrOS lock screen media controls based on the newest mocks. This involves resizing most of the child views and their spacings. The artwork was also resized and re-positioned. Additionally, the close button was moved from the main view to the header row child view. Artist and title data about the current session will eventually be placed to the right of the artwork, but right now this space is empty. See the bug for before and after pictures. Bug: 991647 Change-Id: I7b97f31982ccf2912bd2564d5241bfd849d21d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746554Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#686253}
-
Bettina authored
Follows the cr/1673863 and cr/1693188. Also renamed the SyncPasswordHashChange to GaiaPasswordHashChange. Bug: 914410 Change-Id: Ib581bbfe1c284292b322adcc4101056fa51d7d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709873 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#686252}
-
Antonio Gomes authored
The next step is to merge it into MediaStreamDispatcherEventHandler class MediaStreamDeviceObserver, its only implementer. BUG=704136 R=haraken@chromium.org Change-Id: Ifbb3ed41dc5a9b7315bc4210e76961c98a098b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749622 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686251}
-
Antonio Gomes authored
Since this API is used by content/renderer/pepper code, which is not intended to be Onion souped at this point, this API will last, and should avoid using std types where possible. BUG=704136 R=haraken@chromium.org Change-Id: I860a2d9cb1ceb58bdb4861f285e57104f3e7abc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749106 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#686250}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/913dbe6a85c5..a3112d1c5e9f git log 913dbe6a85c5..a3112d1c5e9f --date=short --no-merges --format='%ad %ae %s' 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a3112d1c5e9f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ia25c5e728c8e4b4167dfcd9ab7af9d0af93b1296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686249}
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: I3b6b60db3bf5d83de36ea7f5f0f8dee40b8c3b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742769 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#686248}
-
Maggie Cai authored
Currently the intent picker bubble is align with the intent picker icon, this CL changed it to align with the edge of the omnibox. BUG=986145 Change-Id: I95d79e857c344287ff4d73ef09fcf7866cd34d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746332Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686247}
-
- 12 Aug, 2019 33 commits
-
-
Evan Stade authored
Bug: 268984 Change-Id: Idd1b13ad08f66f029706a1b04ad811aa148e29a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719275 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686246}
-
Danan S authored
Also removed unused string Bug: 989218 Change-Id: I0cafa7c7e305cf84342c29eaab9058ee544573bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746627 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686245}
-
Jon Mann authored
Bug: 966270 Change-Id: Ied62d75d12bdfd44e83015513d1d6e524b261312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633973 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686244}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ef342fb6645..7de6837222dd Created with: gclient setdep -r src-internal@7de6837222dd The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:803846 Change-Id: Ia7c5138c048394452069d8f3c1fa473d4b7fef58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686243}
-
Mike Frysinger authored
Python 3 moved this to html.entities. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I90e1f0173105fbe07757fc9f7e983645920711c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700505 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#686242}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0fc887f5682..b2142949264d git log f0fc887f5682..b2142949264d --date=short --no-merges --format='%ad %ae %s' 2019-08-12 treehugger-gerrit@google.com Merge "processor: Ignore misordered slice events." Created with: gclient setdep -r src/third_party/perfetto@b2142949264d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I718e65d4492e717d2545dfd94ed03e70aad5f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686241}
-
Manas Verma authored
If the user chooses to opt-in for FIDO authentication for card unmasking, and Payments servers respond with PublicKeyCredentialCreationOptions, then invoke WebAuthn registration prompt. Bug: 949269 Change-Id: I36f24de438e19118389253ca526e587494e4c448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731142 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#686240}
-
David Grogan authored
They need to be transposed from what the underlying flex algorithm generates. Bug: 845235 Change-Id: Ib967035798a148bce0e853656598bba366d45b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749668 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#686239}
-
Raymond Toy authored
When the exponential ramp event ends, we must propagate the end value, even if the previous event ended with a value with the opposite sign as the end value of the exponential ramp. Previously, we just propagated the value of the preview event forever. This is wrong. We should propagate that value until we reach the end of the exponential ramp, and then propagate the end value of the exponential ramp. Bug: 992682 Test: webaudio/AudioParam/audioparam-negative-exponentialRamp.html Change-Id: I97ebad4303a94074cc625d528b1785b8a4b28da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747734Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686238}
-
Evan Stade authored
Both GoogleRed600 and GoogleRed700 were in use. Consolidate on 600. Both GoogleGreen600 and GoogleGreen700 were in use. Consolidate on 700. Change some code that hardcodes these colors to instead consult the NativeTheme. Bug: 990402 Change-Id: Ie99d58859bac22df7f71134650ab094ce8c1a94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733094 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#686237}
-
Xiaocheng Hu authored
NoTry: True Change-Id: Ib22428b110b43557bce515880d4007a3c3f83fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749960 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#686236}
-
Brandon Wylie authored
This change gives StatusMediator access to ToolbarDataProvider which allows omnibox dse logo showing logic to be consolidated to the StatusMediator class. This eliminates many special cases throughout the codebase. Bug: 989775,991017,989773 Change-Id: Iab3d21a03e680790a01b0a7a2164618aeb1ce753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741443 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686235}
-
Bettina authored
Previously, showing interstitials depended on whether or not the account is syncing. However, the policy should apply to Gsuite account regardless of syncing or not. Follows cr/1693188. Bug: 914410 Change-Id: Icd90c0c5b7d6491ff5ab72c8681c57251594ebc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710801 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#686234}
-
Yi Fan authored
To check whether dump file size is too big to be uploaded. Bug: b/130366217 Test: build and run; file feedback and check logcat Change-Id: I12ddd67a48255319b31725b36f9c28285465f233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625899Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yi Fan <yfa@chromium.org> Cr-Commit-Position: refs/heads/master@{#686233}
-
Bettina authored
This is a follow up CL after cr/1673863 and cr/1719975. The CL is large because adding functionality for non sync users require retrieving and passing around the username. Previously, the primary account is easily accessed. Now, to get the non syncing accounts, all the signed in accounts needs to be traversed to figure out which account password was reused. This CL includes several functionality: -Recording metrics for non-sync users -Applies the same functionality as the primary account to the content area accounts -Add two malicious states and two safe browsing states that replaces the original SIGN_IN_PASSWORD_REUSE state -Refactored most methods to take in ReusedPasswordAccountType instead of PasswordType and username. -Changed kSafeBrowsingUnhandledSyncPasswordReuses to kSafeBrowsingUnhandledGaiaPasswordReuses -Saves a username variable inside the ChromePasswordProtectionService in order to retrieve the content area account info to see if the account is GMAIL, GSUITE, syncing, etc. Bug: 914410 Change-Id: I86d807c6fb25c5bb6e9075411be44bf42451a859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693188 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686232}
-
Christy Chen authored
Two tests are failing on newer versions of Mac OS X (e.g. 10.13.6) CaptureScreenshotTest.TransparentScreenshots CaptureScreenshotArea.CaptureScreenshotArea When Emulation.setDeviceMetricsOverride is called with device_scale_factor = 0 (meaning not override it), it should respect the default device scale. The tests were failing because the they assumed the default device scale factor to always be 1. However the scale factor is not always 1 when mac is running on version 10.7+ or later. see https://cs.chromium.org/chromium/src/third_party/webrtc/modules/desktop_capture/mac/desktop_configuration.mm?rcl=5cd13415882ec8048f3c14c35009e9501603b1c7&l=61 for the following comment "If the host is running Mac OS X 10.7+ or later, query the scaling factor between logical and physical (aka "backing") pixels, otherwise assume 1:1" This change gets the default device scale if the Emulation.setDeviceMetricsOverride is called with device_scale_factor = 0, and send it for the screenshot comparison Change-Id: Icaf06ef2c10045cca1f102751c8f79c14d145e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715741 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#686231}
-
Jarryd authored
AccumulateOriginUsage() receives an optional |origin|, which is expected to be non-empty if set, but sometimes we receive an empty |origin| so cope gracefully with that case. Bug: 941480 Change-Id: I43d4312f26ddd14c097f1f09e0557db2c6b909ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733424 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686230}
-
Khushal authored
This was inadvertantly removed with change [1]. The reason it likely hasn't been an issue in practice is the use-cases which rely on this API are updates to GMBs on the CPU. We already need to wait on fences to ensure the GPU side work is complete before writing to the memory on the CPU so the sync token wait ends up being moot. Still restoring the code for now since I don't understand all the use-cases that rely on it to decide whether it can be removed. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1611102 R=ericrk@chromium.org Bug: 900706 Change-Id: I174716cad94bae7f33ef80d79b677af7ea1e6d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750103 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686229}
-
Mike Frysinger authored
This file was moved in https://crrev.com/c/1281243 Change-Id: Ib87d03f0552b3c21f52bcc389313ecf216728f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750047Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b56460d..b7b9bb01 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I525ae173fc05b3b961b29c8397d69d9176ba4172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749406Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686227}
-
Suzy Li authored
Currently, clank is using the isUVPAA that gmscore supports, and the behavior of isUVPAA is intentionally narrowed to return true only if fingerprint is available. Since gmscore is going to change the behavior of isUVPAA to return true if fingerprint or screen lock is available, clank should reland its own isUVPAA implementation to return true only if fingerprint is available. This CL is the first of 3 CLs to add isUVPAA implemenration on clank and remove the flow to call isUVPAA that gmscore supports. Bug: n/a Change-Id: I7f0a025b49597fe73e070562bf96921e64c24622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739973Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#686226}
-
Jenna Himawan authored
Change-Id: I281bb273a2052743beae656fbb357e46613f8e52 Bug: 993066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716959 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#686225}
-
yilkal authored
Updates chromium_strings.grd, google_chrome_strings.grd, browser_resources.grd to use "enable_supervised_users" flags. Bug: 969748 Change-Id: I43ef65083d80eafb18c580613746bb399a363fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731911 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686224}
-
Jesse Schettler authored
Add a new test to verify that the Add button of the manufacturer dialog is disabled after clicking it. Bug: 990755 Test: browser_tests --gtest_filter=OSSettingsPrintingPageTest* Change-Id: Id7cb8014595ae1a6c6abd1dd1cbd3dcbb403c79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749823Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#686223}
-
Caitlin Fischer authored
Bug: 991988 Change-Id: I08c6e5a06a09a0c52963e42e9b9f106b15d2ae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744332 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#686222}
-
Mike Frysinger authored
The syntax for raising a custom exception with all three args is different between Python 2 & Python 3 to the point where we can't even do it inline because an incompatible version throws syntax errors during parsing. Utilize six's reraise helper for it. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I2489dfe588c4c650661ece327c5d86e8754269ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700504Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686221}
-
Peter Kotwicz authored
BUG=None Change-Id: I828b22e468bb1b7b0c0aeb7f76869b9be00aa5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750104 Auto-Submit: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686220}
-
Francois Doray authored
A developer reported a failure in the DCHECK that verifies that LocalSiteCharacteristicsDataStore::OnURLsDeleted() receives details for the origin of all deleted URLs. This CL transforms the DCHECK into a CHECK to determine whether this can happen in production. Bug: 966059 Change-Id: Ia3328ca7d832935ee906ddb5570aa3035a65c0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749248 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#686219}
-
Vlad Tsyrklevich authored
The chrome_app_unittests target was missing a dependency on //components/gwp_asan. Bug: 993092 Change-Id: I9bb082156a810487333974745a61995ef9423a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745573 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#686218}
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/388, this CL removes some unnecessary nullables, specifically in resolveTarget from GPURenderPassColorAttachmentDescriptor. Bug: 877147 Change-Id: Ib24b76ba65c22273b2d7bfef50ef8cc22e09daad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748666 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686217}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f815301b1ad2..913dbe6a85c5 git log f815301b1ad2..913dbe6a85c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-12 bsalomon@google.com Don't use color type derived from GrPixelConfig to determine proxy texture swizzle. 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-12 mtklein@google.com inline helpers in SkDashPath.cpp cull_path() Created with: gclient setdep -r src/third_party/skia@913dbe6a85c5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ib98c6f73c382fc819270c7782331409448c09d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686216}
-
John Lee authored
This CL also removes some accessibility features as tabs are not focusable only through the keyboard, and overall accessibility is still being decided on. Bug: 989131 Change-Id: I4aae2fd35000866dca0c641ce59c93a05e191a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747732Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#686215}
-
Dave Tapuska authored
Some configurations fail to build, limits should have been included. BUG=992832 Change-Id: I894ba0543bfcef101c93259e39a31d12ae6d035c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747981 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#686214}
-