- 30 Mar, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c6f382df3f5..6d09641ba7b1 Created with: gclient setdep -r src-internal@6d09641ba7b1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Icecc839e1a953194bdddbafc7635b05eef8ebcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546644Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646111}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6dd1ebd42cf..2fdbeae32785 git log a6dd1ebd42cf..2fdbeae32785 --date=short --no-merges --format='%ad %ae %s' 2019-03-30 reed@google.com Start to unify signatures: return bool Created with: gclient setdep -r src/third_party/skia@2fdbeae32785 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I1dfb227193d7904f0d7aa615ccb9acfcd7f2aacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646110}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea7df7146c5e..4c6f382df3f5 Created with: gclient setdep -r src-internal@4c6f382df3f5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I696244717b8f297d755bdf798e1ded60e161b813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546642Reviewed-by:
-
Khushal authored
Allow only 1 unacked transaction to be in flight. This ensures that the next transaction is submitted only after the previous one was latched and prevents transactions from getting merged, which effectively drops frames by the framework. TBR=piman@chromium.org R=ericrk@chromium.org Change-Id: I350d9944dea681a54aa576bf382e73ee3be70390 Bug: 946849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546774 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#646108}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c160bdb22d02..ea7df7146c5e Created with: gclient setdep -r src-internal@ea7df7146c5e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Idbe1298128cd63f37a3ad2393d6d1f8b828538a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546983Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9822a1818ba..a6dd1ebd42cf git log c9822a1818ba..a6dd1ebd42cf --date=short --no-merges --format='%ad %ae %s' 2019-03-30 reed@google.com Revert "Reland "GPU support for SkMixers"" Created with: gclient setdep -r src/third_party/skia@a6dd1ebd42cf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I80da89b78342cda563289cc334634aaa250c8483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546985Reviewed-by:
-
Eric Karl authored
Currently, we send BeginFrames to the browser/renderer in an arbitrary order. During a gesture, the browser will then send input to the renderer. In cases where the browser gets the BeginFrame first, it can occasionally send input to the renderer before the renderer gets its BeginFrame. When this happens sporadically it can lead to jank. This CL ensures that we send BeginFrame to root frame sinks last, which greatly reduces the chances of the above scenario ocurring, and removes all observed jank. Longer term this code will be removed and we'll replace this with a more robust system of tagging input. However this CL is designed to have no downside (the order of BeginFrames is currently arbitrary, so chosing a different one should be safe) and be merge safe. Bug: 947717 Change-Id: I85b11aedabb4fa8888e7ddc11ae1b9a839db1e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546427Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#646105}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/265fd3de3527..c9822a1818ba git log 265fd3de3527..c9822a1818ba --date=short --no-merges --format='%ad %ae %s' 2019-03-30 reed@google.com Reland "GPU support for SkMixers" Created with: gclient setdep -r src/third_party/skia@c9822a1818ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ib11f3ca715b92a9cc22f2aa176c50c5d49b59564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546982Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bc25b14a3bf..c160bdb22d02 Created with: gclient setdep -r src-internal@c160bdb22d02 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I75525e07eb83197c4f14f8b6b9e188359c6339cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546981Reviewed-by:
-
Maggie Chen authored
This is for underlay video power optimization. The damage rect on top of a video quad is calculated in surface aggregation and saved in the share quad state. The Overlay Processor can use this info to reduce the damage rect to zero if possible. The function ProcessOverlayOccludingDamage() is called at each surface in CopyPasses(). Each surface damage rect is transformed to the frame root target space and added to |damage_rects_union_of_surfaces_on_top_|. To get the occluding damage rect, just intersect |damage_rects_union_of_surfaces_on_top_| with the overlay in root target space. Because surfaces are processed from top to bottom in CopyPasses(), we only need to look at |damage_rects_union_of_surfaces_on_top_| for this calculation. When NeedsNonZeroOverlayOccludingDamageRect() is false, no transformation is performed. It only checks if damage_rects_union_of_surfaces_on_top_ is empty and returns this case. Currently, NeedsNonZeroOverlayOccludingDamageRect() is true for Windows only. This CL will fix an issue from the previous implementation with |has_surface_damage| where damage info cannot be passed down to the overlay processor when there is no quad in a render pass. |has_surface_damage| will be deleted when no one uses it. Bug:868561 Change-Id: I00bfaa13a4b6c374cc42e9bbe6b7f64c350ef76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510075Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#646102}
-
Robert Liao authored
Change-Id: I22d7c01c04fc926fb29b41c699c3937ecb48718c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546772 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#646101}
-
chaopeng authored
Some HTML input element check active state when handle key event. Tests added in crrev.com/c/1538739. Bug: 938552 Change-Id: Id20d3164c82b2943d6ae85bfbf93e9a4f80f6848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541471Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#646100}
-
A Olsen authored
The js2gtest rule with test_type = "unit" relies on this behavior when gen_include_files are used - but until now it didn't work. Bug: 947036 Change-Id: Ieed195c9be9d3c0873e66592d99ace64ccdf8b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543529Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#646099}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea7b903baf6c..9bc25b14a3bf Created with: gclient setdep -r src-internal@9bc25b14a3bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ibefb4001d9085036581cb7a3aa44f9489aa2bea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546979Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f003bbb. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 6f2e9bd4 "webrtc wpt: add test for ice disconnection" be4bce5d "[WPT] Merge subresource scripts into common/security-features" d1ac10ff "Revert "webrtc wpt: add test for ice disconnection"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie79b67560673b78f5d23dcae616712594c3605fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545687Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646097}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee319536..3003370e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I18e7483162e62bf77122eadabe0f02e8de30b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545688Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2228d3836523..ea7b903baf6c Created with: gclient setdep -r src-internal@ea7b903baf6c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: If02f1b5eef505b9d5364241fcfeb7e00e32a5247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546977Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/274c82fc5378..2228d3836523 Created with: gclient setdep -r src-internal@2228d3836523 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I22d4f5b2e20f9ef748e9b180a7187eb2fa46b13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546974Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a46c6ae7a64f..7dda200ba41b git log a46c6ae7a64f..7dda200ba41b --date=short --no-merges --format='%ad %ae %s' 2019-03-30 dhanyaganesh@chromium.org generic_stages: Stop sending stage_id to test commands 2019-03-30 akeshet@chromium.org test_stages: fix account inference for CQ jobs Created with: gclient setdep -r src/third_party/chromite@7dda200ba41b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5b1a3e5ea79696e1eb7e6754e68fdbae19f46d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546975Reviewed-by:
-
Hanfeng Zhu authored
Bug: 946332 Change-Id: Ic418c0b48653a8478e20c678366f125063e305d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546790Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Cr-Commit-Position: refs/heads/master@{#646092}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c826554a049..274c82fc5378 Created with: gclient setdep -r src-internal@274c82fc5378 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ia7cebdd6f96dd12d1492c2d30e49ae475823698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546973Reviewed-by:
-
Andrew MacPherson authored
Now that the AudioContext supports the optional sampleRate parameter MediaStreamTrack data needs to be resampled to this rate and not the hardware rate. Bug: 945305 Change-Id: If34b72f0aee864148aa44531e87e3816ae05a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541078Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#646090}
-
Alex Clarke authored
We want to prioritize because ResourceExtractor is on the critical path. To facilitate the use of traits in ui/ we split UiThreadTaskTraits.java off into a new content_java_task_traits library. Bug: 863341 Change-Id: Ia2adc4ce58480b07a84e4f7e1f96283df2035b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526187Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#646089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bc36bade1e16..21d000094ade git log bc36bade1e16..21d000094ade --date=short --no-merges --format='%ad %ae %s' 2019-03-30 thestig@chromium.org Roll third_party/skia/ ea8900e74..191e64b6c (73 commits) 2019-03-30 thestig@chromium.org Roll tools/clang/ 207fd1e5d..adc6ac450 (14 commits) 2019-03-30 cliffsmo@microsoft.com Update IsGdiAvailable to check for Win32k lockdown Created with: gclient setdep -r src/third_party/pdfium@21d000094ade The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8e8d8ad9a3353280dc8a548a0e980ddfa86dba56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546971Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11eb51b11e4e..5c826554a049 Created with: gclient setdep -r src-internal@5c826554a049 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I830434db19bbf0f57cab78f2ebac46f830ef5cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546970Reviewed-by:
-
Mike West authored
As per the conversation in mikewest/sec-metadata#23 and mikewest/sec-metadata#19, this patch drops the `Sec-Fetch-User` header for non-navigational requests, and for navigational requests that are not user-activated. Bug: 947444 Change-Id: Ica4846bda6ccf4e8bce1323803954f4fef9c18a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545871Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#646086}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59b733715141..265fd3de3527 git log 59b733715141..265fd3de3527 --date=short --no-merges --format='%ad %ae %s' 2019-03-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@265fd3de3527 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I395ec1d47ce40572a7d8e87b6018f2c18182a454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546348Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90699aaf784a..11eb51b11e4e Created with: gclient setdep -r src-internal@11eb51b11e4e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I9794bf84a65de54a51d7b8f9532df7c06b5c0ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546347Reviewed-by:
-
Peter Kasting authored
This is more performant and avoids invalidating outstanding iterators. Bug: none Change-Id: I73a340c6c16ce8f5c9dd0d28e7cd66a9e5f16aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526299 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#646083}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3553b10..ee319536 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3df449d93538aeb4aa20775a35248c3dc4300aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546639Reviewed-by:
-
Peter Kasting authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1526311 , AddChildView() was supposedly changed to "always add to end". However, due to an oversight, that didn't actually occur, because it mapped to ReorderChildView(v, child_count()), which would be treated as a no-op. This CL makes ReorderChildView() accept child_count() as a synonym for "add to end", which matches the behavior of AddChildViewAtImpl(), and makes AddChildView(existing_child) actually move to end like the other CL claimed it would. It also allows larger values, since doing so seems harmless, and would be useful if we ever change ReorderChildView() to take |index| as a size_t. Bug: 942298 Change-Id: I5ea26f34f66aeb303e11eceb81490bc4eaaa023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531609 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3295c01df233..0c7a9cae28ed git log 3295c01df233..0c7a9cae28ed --date=short --no-merges --format='%ad %ae %s' 2019-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3265fd12..0dd6679b (645967:646074) Created with: gclient setdep -r src/third_party/webrtc@0c7a9cae28ed The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf6cfe12da08e4541750e7a19f8bc0d05b815518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546346Reviewed-by:
-
Peter Kasting authored
The behavior of AddChildView() on an already-existing child is in flux. In this case, either the addition was pointless extra work (likely) or else it caused bugs (less likely); just avoid doing it. Bug: none TBR: jamescook Change-Id: Ifcf5ed631fb7fcdfb89e6f22cb1fe5d9d9d7c0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545515Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#646079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6512b3755d9..90699aaf784a Created with: gclient setdep -r src-internal@90699aaf784a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ic6f981bd1b51ec15068ca08ddc1a67b6a09276cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546345Reviewed-by:
-
Aleks Totic authored
Another fix for "Legacy OOF descendant did not get laid out" The cause here was: - if #container had a legacy descendant, and - legacy descendant had an oof descendant whose containing block was #container, that oof descendant would get added to #container's list of legacy oof, but would never get laid out. This bug was hidden, because it would not happen if layout happened twice, which we often do. Seen in the wild at https://www.humblebundle.com/ when scrolling down. Bug: 946986 Change-Id: I183f3d5dfe79b49c5c6aadad0ee2cfcb8bb6849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546713 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#646077}
-
Findit authored
This reverts commit 6af49b04. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 646061 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmFmNDliMDQ5ZDEwZTMzZTYyNjY0MzY0YjAzNjMzMjE3NjhhOTE0Mww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/22098 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: RecommendAppsScreenTest.SelectionChange Original change's description: > Add browser tests for RecommendAppsScreen > > Note that recommned_apps_fetcher implementation has not really changed, > except for: > * Made RecommendAppsFetcherImpl implement RecommendAppsFetcher > interface > * Moved some logic from RecommentAppsFetcherImpl ctor to newly > introduced Start() method > > Added methods to check whether an element is enabled/disabled to > js_checker, and new methods for checking element visibility that > test element's offsetHeight and offsetWidth - the approach with > checking hidden property does not work for elements that are hidden > using "display: none" CSS (e.g. recommend_apps screen buttons). > > BUG=947203 > > Change-Id: Ib38d07e7f75bed64ff909c927d29d0c2e365c815 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544794 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646061} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=947203 Change-Id: I344e73e283dd76578637d521ceffb94f3126f498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546638 Cr-Commit-Position: refs/heads/master@{#646076}
-
Findit authored
This reverts commit 48169718. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 645809 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDgxNjk3MTgzOWYwMTgxNmY3ZjAxMjYwMGU3OTg2YTA0NWQxZjQ1NQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32395 Sample Failed Step: browser_tests Sample Flaky Test: ExistingUserControllerActiveDirectoryTest.PolicyChangeTriggersFileUpdate Original change's description: > Fix ExistingUserControllerActiveDirectoryTest tests > > Likely fix for flakiness in PolicyChangeTriggersFileUpdate and > UserKerberosFilesChangedSignalTriggersFileUpdate tests. Properly waits > for Kerberos file changes. > > BUG=chromium:865206 > TEST=ExistingUserControllerActiveDirectoryTest.* tests pass for me. > > Change-Id: I56558fa5a2f853591e2d3ec5496103cba32f7ff7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482454 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645809} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:865206 Change-Id: If8d6bc824a56718c5446608aeb57b2cdf0d607a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546637 Cr-Commit-Position: refs/heads/master@{#646075}
-
Andrew Grieve authored
This doesn't fix any problems that we have, but is technically more correct and uses a bit less reflection as well. Noticed this was happening when running unit tests, as we have multidex-related code in a custom instrumentation that was not being run. It now gets run (but is a no-op since multidex isn't needed for incremental install). Change-Id: Iee914ec40b98417e7e1ab74aa2fe2afba8bd98c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546141Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#646074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/823aaabfd18c..d6512b3755d9 Created with: gclient setdep -r src-internal@d6512b3755d9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I0bf849d99cdd9f8bfd16c549b0994c2368eb3905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546344Reviewed-by:
-
Jeffrey Cohen authored
SendTabToSelf's MVP is changing to target a specific other device, I'm adding this field as the first step towards implementing that. Bug: 946224 Change-Id: I70fc16995e1675a33777fd2965555a218b6b8d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540293 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#646072}
-
