- 03 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bef95c091b2d..f76c76d25df8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093825 Tbr: wjmaclean@google.com,dfried@google.com Change-Id: I30afebe67bad7b84f8aaa0dd81a579b3a50813cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391408Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804088}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4dd8ba9285c..d9c616f80fb6 2020-09-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1786e370e9cdb5594148c48d9a943300bbb26bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804087}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/444c13c078a7..0ade98316c21 2020-09-02 peah@webrtc.org Cleanup of the APM creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e237fbab86da1d600c3a84bd3e7a3a70e2b11c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804086}
-
Paul Moy authored
Expose a new routine through cros_healthd's ServiceConnection. Bug: chromium:1094018 Change-Id: I25d2b2e1eb6652d127dcfb50925e75950423b6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388432 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804085}
-
Jit Yao Yap authored
This CL prevents Remote Apps from being pinned when dragging the launcher item onto the shelf. Remote Apps already do not have a context menu item for pinning, so this CL makes Remote Apps unpinnable. Bug: 1101208 Change-Id: Iaa25530dc84d20cc420a8a407898979ef7a558de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382606 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804084}
-
Vladimir Levin authored
This patch moves two fields from RenderPassInternal into AggregatedRenderPass, effectively removing them from CompositorRenderPass since they are not used there. R=weiliangc@chromium.org Bug: 1106418 Change-Id: I46a156420b0dd53fe44afae012011c4e040258d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389421Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804083}
-
Etienne Pierre-doray authored
Relaxed ordering is insufficient since the resulting task id is used by the caller for order operations. Test case written by omerkatz@ demonstrates the race: TEST_F(ConcurrentMarkingTest, JobTaskIds) { static constexpr size_t kNumTasksToRun = 2; static size_t tmp[kNumTasksToRun] = { 0 }; base::JobHandle handle = base::PostJob( FROM_HERE, {base::ThreadPool(), base::TaskPriority::USER_VISIBLE}, ConvertToBaseRepeatingCallback(WTF::CrossThreadBindRepeating( [](base::JobDelegate* job) { uint8_t id = job->GetTaskId(); size_t& slot = tmp[id]; slot++; })), ConvertToBaseRepeatingCallback(WTF::CrossThreadBindRepeating( [](size_t) { return kNumTasksToRun; }))); handle.Join(); } Thread 1 can release its task id and thread 2 immediately pick it up, which causes a data race on tmp when both thread access the same idx with no memory fence in between. Adding memory_order_seq_cst on Release/AcquireTaskId ensures that different thread with same task id are sequential. Bug: 1119518 Change-Id: Ifa35ca03e3663f53f76ee830bcaa8654bc48838c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387554Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#804082}
-
David Maunder authored
CriticalPersistedTabData is a replacement for TabState which usess protocol buffers to serialize persisted Tab metadata in a file. It is imperative we compare the old and the new methods of persisting Tab metadata across restarts. Bug: 1122220 Change-Id: I649fe8271c1301c76e9a7c9bb317ab03c30b2fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380603 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#804081}
-
Joshua Pawlicki authored
The profile sign-in state is reported via UMA and can be accessed at go/chrome-sync-signin (Googlers only, sorry). The number of Google accounts on the device is no longer relevant, since Play Store can update Chrome without a Google Account on modern devices. Bug: 1110338 Change-Id: I130f2a6b3edffd1f1f730dbaad0f65784f9fb5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346725 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804080}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/482642324c4e..00e17f2cebef 2020-09-02 rharrison@google.com Start SPIRV-Tools v2020.4 2020-09-02 rharrison@google.com Finalize SPIRV-Tools v2020.3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ie038bca4c16cfb0e0fa6f51c877a3695af304793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804079}
-
Keishi Hattori authored
not_loaded_image_resources_ is being modified while iterating. If this CHECK doesn't catch anything, it means weak processing is triggering while iterating even though it shouldn't be. Bug: 1108676 Change-Id: Iae00862b28fe3e324ac654c1e57834071ce5ddc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392021Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804078}
-
David Maunder authored
We now enforce that Tab attributes are acquired on the UI thread Bug: 1117396 Change-Id: Ia7d41be25ae3dc201e8ad7a7f96255b7ca09f60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390869Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#804077}
-
Kyle Horimoto authored
The ConnectionMedium enum was previously only used within the SecureChannel implementation, since there was only a single medium (i.e., BLE). This CL moves the enum to a public directory where it can be used from outside the directory. This CL is in preparation for clients being able to specify the connection medium by passing a parameter to connection attempts facilitated by SecureChannel. Bug: 1106937 Change-Id: I8a8ab2d862b02ab88d3db0b8485c64d59fbf3d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391517 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804076}
-
Makoto Shimazu authored
This reverts commit f5793ebb. Reason for revert: Random (but high frequency) failure of untar tast-cmd-0.0.1-r771.tbz2. Example build: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/19679 Original change's description: > Roll Chromite from 168986591cc1 to dcb0e91ca94b (4 revisions) > > https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..dcb0e91ca94b > > 2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes > 2020-09-02 chrome-bot@chromium.org Update config settings by config-updater. > 2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed. > 2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/chromite-chromium-autoroll > Please CC chrome-os-gardeners@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel > Tbr: chrome-os-gardeners@google.com > Change-Id: Ib815a99e16e81b13f2680639a71b7d223cb94498 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390894 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804026} TBR=bpastene@chromium.org,newcomer@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I92ec34d95ac27ae60f262cf20abb58c3052f2f6d No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390606Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804075}
-
Evan Stade authored
This change introduces a client interface for Media Router which separates the embedder specific actions from shared behavior, MediaRouterClient. The term "client" is used over "delegate" because it's a singleton. Additionally, symbol names that use "Chrome" are updated to use "Browser" instead. After this change, all of [...]chrome.browser.media.router (save the new client, ChromeMediaRouterClient, which is Chrome specific) can be moved to [...]components.media_router. Bug: 1057100 Change-Id: I94b538b4fdb5868eda2149847b5e23c048f3cd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373293Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804074}
-
Marijn Kruisselbrink authored
Rather than relying on the root of an isolated file system to determine the scope of permission grants, explicitly expose the scope of permission grants. This will make it easier to support special volumes on Chrome OS. Bug: 1093653 Change-Id: I17ef72864af6441a9f5f4392d537f7d7f7328cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391384Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804073}
-
Orin Jaworski authored
This reverts commit f0b702c0. Reason for revert: The CL being reverted was attempting to fix a presentation issue, but ended up breaking mouse handling for all button row buttons. Original change's description: > [omnibox] Fix pedal buttons misplacement > > The first time when match changes its height, pedal button is misplaced > and overlaps with another match. This was caused by setting wrong bounds > for button row. > > Bug: 1121934 > Change-Id: I297a3551c370f8efd7c4079e14b9c6fcace70e84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385378 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/master@{#803217} TBR=tommycli@chromium.org,bsep@chromium.org,olesiamarukhno@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121934 Change-Id: Ic32e7cc083e06285348a2857e201d1da268de077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391107Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804072}
-
Luciano Pacheco authored
Change Files app to navigate to the directory when a "selectionURL" provided in the launch params. Before this CL Files app would only show the directory selected. This change is to support the workflow from Issue:1090211. From ARC++ the intent to "ACTION_VIEW_DOWNLOADS" will open the Files app in the Downloads folder. Bug: 1090211 Change-Id: Ic6b9d290936f4a25576f3bfd5a799c37f6fa2195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379345Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#804071}
-
James Hawkins authored
Bug: 1045266 Test: NetworkComponentsNetworkConfigTest* Change-Id: Ic585489fae7711e483e1759d6dcda5473b43d418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353557 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804070}
-
Liquan (Max) Gu authored
After crrev.com/c/2372888, all cases of mMerchantSupportsAutofillCards are accessed after defined, we can limit that it's used only after it's not null. Bug: 1107039 Change-Id: Iea978142c9a9e7d755cb294d9acf3eff80f13d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388561 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804069}
-
Joe DeBlasio authored
Change-Id: Iff940839243bf27974860e1e32b5fe25d8a59b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391730 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#804068}
-
Eugene Zemtsov authored
Change-Id: I1a32006dc0d91102b24a16bc591284dc88ca7ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387415Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#804067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ef21edffb35..683beccf6776 2020-09-02 johnstiles@google.com Migrate inliner-related tests to a separate unit-test file. 2020-09-02 egdaniel@google.com Don't require secondary command buffers on mali vk. 2020-09-02 michaelludwig@google.com Revert "Add idea of DataType to SkYUVAPixmapInfo." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Replace RRect objects with TypedArrays." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Change SkRects to be arrays, not objects." 2020-09-02 michaelludwig@google.com Revert "[canvaskit] Add drawRect4f as example 'fast path' API" 2020-09-02 johnstiles@google.com Remove pipeline-stage workarounds from the GLSL code generator. 2020-09-02 mtklein@google.com update INHERITED style 2020-09-02 nifong@google.com Fix GL loading bug in wasm debugger. 2020-09-02 kjlubick@google.com [canvaskit] Add drawRect4f as example 'fast path' API 2020-09-02 kjlubick@google.com [canvaskit] Change SkRects to be arrays, not objects. 2020-09-02 kjlubick@google.com [canvaskit] Replace RRect objects with TypedArrays. 2020-09-02 johnstiles@google.com Replace empty Block with Nop statement. 2020-09-02 herb@google.com simplify fill vertex calculations 2020-09-02 brianosman@google.com Disallow some combinations of program element and program kind 2020-09-02 johnstiles@google.com Ensure that inlined if/else blocks are properly scoped. 2020-09-02 ethannicholas@google.com Disallow a bare ';' at the top level of SkSL files 2020-09-02 brianosman@google.com Remove some leftover double types from SkSLContext 2020-09-02 johnstiles@google.com Add unit tests for inlining if/else blocks. 2020-09-02 egdaniel@google.com Remove unused GrVkDescriptorSetManager factor. 2020-09-02 johnstiles@google.com Ensure that inlined statements are properly scoped. 2020-09-02 mtklein@google.com add missing clamp to SkColorFilter_Matrix 2020-09-02 mtklein@google.com update SkNx allTrue/anyTrue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Icdeb51709f2e37d30368b29f3aa912e66ddf3ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804066}
-
Sasha McIntosh authored
This is a reland of 08ad21a9 Original change's description: > blink: Enable JPEG YUV decoding on TOT > > The JPEG YUV decoding experiment has concluded and can now be enabled on > TOT. This change enables YUV decoding for JPEG images by default and > removes the field trial testing config. > > Bug: 919627 > Change-Id: Ic3742750af59fa3b4e6dedc2f55424d4a87afcad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216712 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772724} Bug: 919627 Change-Id: Ib162ea913ab0fdf588206d8ea0560cbbf259cb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386487Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804065}
-
Xianzhu Wang authored
When a caret is active, now we always paint it in either the desired color or the transparent color according to the blinking state. This prepares for composited caret which will use an opacity effect node to control the visibility during blinking. The always painted display item for the active caret won't cause performance issue because the paint opearation is trivial. It may actually make PaintController and RasterInvalidator more efficient when matching display items sequentially (without appearing/disappearing display items). Bug: 1123630 Change-Id: I507e1f5014040e8aecceb83346e5f28973f16c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391002Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804064}
-
Natalie Chouinard authored
Use ICU case folded full font names as keys for the font lookup table to be consistent with the local unique name matching done by Blink for firmware font files. Bug: 1111148 Change-Id: Ia94b11e10ffa53582c46020eeafb5524108e9914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389224 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#804063}
-
Ben Pastene authored
Telemetry shouldn't touch ARC on the system, so these suites on this bot are unnecessary since we have them running on the normal eve bot. Bug: None Change-Id: I6ab0ec3de5d5bd9569858fb8ffa850e5c800fb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391659 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804062}
-
Daniel Cheng authored
Bug: 1122072 Change-Id: Ic89dc4c0ff343da1cc989f242070735a11811644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381066 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804061}
-
Daniil Lunev authored
Factored out from https://chromium-review.googlesource.com/c/chromium/src/+/2379383/ Bug: b:151176984 Change-Id: Ia089d35ab8c5597732af5b136b75db5a50d9ff97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379460 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804060}
-
Hui Yingst authored
setDocumentMetadata_() has 3 parameters, which all comes from the same structure MetadataMessageData. This CL makes setDocumentMetadata_() only takes one MetadataMessageData type parameter instead. Bug: 177188 Change-Id: I59c53252d91996ac13824c60ae1e7b276feb940e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386297 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804059}
-
Sahir Vellani authored
This change implements percent based scrolling for mousewheels on linux as part of the scrolling roadmap. If percent based scrolling is enabled, mousewheel scrolls will now be percent based scrolls. This is already implemented on Windows. Bug: 1101535 Change-Id: I91cf774a2dc3fe5e129939c64a0e5bc645b8fe9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354663Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804058}
-
Akihiro Ota authored
Text content was originally added to the tab order with the intention to make it more accessible. However, this goes against common practices on the web and could lead to confusion. Therefore, we are removing text content from the tab order. Bug: 1124064 Change-Id: I3e6ff0868b8d7c02ebc41a6a87b202602dfc5968 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390870 Auto-Submit: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#804057}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9bc506e0ab0..c35e2ba3798e 2020-09-02 rharrison@chromium.org Remove usages of SPVC 2020-09-02 enga@chromium.org Cleanup: always clear Vulkan textures with vkCmdClear*Image 2020-09-02 enga@chromium.org Cleanup: Make TexelBlockInfo a member of Format, not superclass 2020-09-02 cwallez@chromium.org Make ShaderModule reflection go through EntryPointMetadata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iacaf0959b87260b636fc1d6f08fbce7b2fb13ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804056}
-
Tommy Li authored
No one is looking at these histograms anymore, and they are blocking removal of ZeroSuggestVariant. Also anything that simplifies ZeroSuggestProvider is a good thing. I checked with ender@ already, who originally added these histograms, and it's fine to remove these. Bug: 1123688 Change-Id: Idcb760d0969ad74577c0f3555d2020730a1dda1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388898 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804055}
-
Kyle Horimoto authored
This was missed when originally creating the class. Bug: 1106937 Change-Id: Iad47abb34673a5556518f03fe82ed4c04f74d729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391650 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804054}
-
Evan Stade authored
This relands commit 78a7ace4. The original change somehow passed the CQ, and was reported to be flaky, but I believe it was deterministically failing. The failure was on a new assert in SelectFileDialog. This CL fixes the issue by moving the onPhotoPickerDismissed call into PhotoPickerListener, so that the tests, which don't involve SelectFileDialog, won't call into it. This also has the nice effect of removing the direct dependency from photo_picker on SelectFileDialog. Original change's description: > Remove ApplicationStatus usage from PhotoPicker. > > ApplicationStatus only works in //chrome. See crbug.com/470582 > > Bug: 1110930 > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803247} TBR=dtrainor@chromium.org Bug: 1123848,1110930 Change-Id: Id5c0ae00b85d97cb5121acf1ece8d37ac8e2d021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387624Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804053}
-
Wei Li authored
Remove the last few uses of set_owned_by_client() in tests. After this change, the only one case left is testing the set_owned_by_client()'s behavior itself. Bug: 1044687 Change-Id: I29a5d3aa307040899dbfab10bed7f2bf834bc8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388990Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#804052}
-
mhasank authored
In order to better understand the feedback reports, adding logging in key events of arc provisioning process. BUG=b:162221783 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: I3f5cbfd0cb023c43982e15a5aba724901a4fe3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377229 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#804051}
-
Jon Mann authored
Fixed: 1123781 Change-Id: I45458f24df0c77f97f2997a7384618262b18af47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387309 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804050}
-
Amr Aboelkher authored
Executes PSM determination if its switch is enabled during the initial enrollment. Then, upon completion, it will execute hash dance. As the whole PSM functionality is being controlled by a switch, its possible to split its basic functionality and its tests in follow up CLs. Test: Will be added in a follow-up CL Bug: chromium:1119581 Binary-Size: Increase is temporary. Change-Id: I4473ef0617cc9f7e4594130bcefe57bab12ed7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365952Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#804049}
-