GitLab

Some build envs don't understand OVERRIDE without that header.

Review URL: https://codereview.chromium.org/165693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251463 0039d316-1c4b-4281-b951-d872f2087c98

Just tweaking the backoff constants to better reflect what to do in case of
server error. Future patches will introduce alternative policies for different
kinds of errors.

BUG=284553

Review URL: https://codereview.chromium.org/164183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251462 0039d316-1c4b-4281-b951-d872f2087c98

This CL does a number of things:
1) Extracts an AndroidKeyStore interface which specifies the API needed by the
native OpenSSL engine from an AndroidKeyStore. Also changes from using
PrivateKey to AndroidPrivateKey to provide a layer of indirection needed for a
remote PrivateKey
2) Renames the previous AndroidKeyStore to AndroidKeyStoreLocalImpl as it's
used for interacting with an in-process Android KeyStore
3) Provides a new class AndroidKeyStoreRemoteImpl and corresponding
IAndroidKeyStoreRemote.aidl that together specify the interface and interaction
with a remote process managing an Android KeyStore
4) Alters the PKCS11-based authentication flow to only use out a remote Android
KeyStore
5) Adds a new method to the previous AndroidKeyStore interface to facilitate
clean up of remote keys

BUG=341500
CONTRIBUTOR=ppi@chromium.org
R=bulach@chromium.org, klobag@chromium.org
TBR=rsleevi
NOTRY=true

Review URL: https://codereview.chromium.org/166143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251461 0039d316-1c4b-4281-b951-d872f2087c98

The line endings were introduced at r251144

BUG=none
TBR=scottmg@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/168063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251460 0039d316-1c4b-4281-b951-d872f2087c98

The setuid sandbox waits on its one child and then dies
afterwards.

When receiving SIGABRT, instead of dumping core, simply exit the
process. There is no interesting information to be gathered from
knowing that the process is inside waitid(2), one should look at
the child process instead.

This patch is in hope to reduce red herrings.

BUG=334345
TBR=jorgelo
NOTRY=true

Review URL: https://codereview.chromium.org/167583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251459 0039d316-1c4b-4281-b951-d872f2087c98

When there is more than 1 core in the system, request extra temp files
and use LLC's StreamInitWithSplit rpc to enable module splitting.
If the RPC fails, fall back to StreamInitWithOverrides.

Add a private Pepper interface to get the cpu count rather than
duplicating base::SysInfo in the plugin.

TEST=browser_tests --gtest_filter=NaClBrowserTstPnacl.*
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3777
R=jschuh@chromium.org, jvoung@chromium.org, teravest@chromium.org

Review URL: https://codereview.chromium.org/165433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143230

Review URL: https://codereview.chromium.org/150943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251457 0039d316-1c4b-4281-b951-d872f2087c98

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/164493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251456 0039d316-1c4b-4281-b951-d872f2087c98

This CL partially reverts r242570 and r243346.

The functionality added in those patches has been removed while some refactoring part
has been kept because those make sense and also because some code came later would have
to be moved otherwise.

The suspend/resume fullscreen video logic does not work well when the browser
activity is destroyed when it is in the background. Unfortunately I could not
find a way to make it work for that case yet so it's better remove it.

BUG=323697

Review URL: https://codereview.chromium.org/157783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251455 0039d316-1c4b-4281-b951-d872f2087c98

This shouldn't be happening, but we got some crash reports suggesting it
does. Unable to repo locally so this stat will verify it does occur and
then can be used to verify our fixes actually fix it.

TBR=asvitkine@chromium.org
BUG=329023

Review URL: https://codereview.chromium.org/166953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251454 0039d316-1c4b-4281-b951-d872f2087c98

That way we can easily change the size later. Security says 64 may be overkill.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251306

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/138763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330631
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/167643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251452 0039d316-1c4b-4281-b951-d872f2087c98

- easier to read
- safer since gpu::Mailbox is constant size and checked in the ParamTraits

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251207

R=danakj@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/148003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251451 0039d316-1c4b-4281-b951-d872f2087c98

Unit-tests cover HTTP case of a response received before post completes,
and websocket case of a CLOSE frame with SPDY FIN set (client should
still send a websocket CLOSE).

Also rename SpdyStream::IsIdleTemporaryRename() back to IsIdle().

TEST=Also tested with Fedor's test case from the ticket.
BUG=330860

Review URL: https://codereview.chromium.org/129543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251450 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the script to be used with files in directories other than tools/metrics/histograms. Furthermore, print the relative path of the histograms.xml file actually used to avoid
confusion.

BUG=None

Review URL: https://codereview.chromium.org/163473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251449 0039d316-1c4b-4281-b951-d872f2087c98

This helps to avoid confusion when wrench menu zoom affects DevTools instead
of the page.

BUG=343816

Review URL: https://codereview.chromium.org/165213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343311

Review URL: https://codereview.chromium.org/161933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251447 0039d316-1c4b-4281-b951-d872f2087c98

The old version parses the main.html file to get the list of JS files
to verify. Since we're moving to auto-generate this file, we can safely get
the Js files from the same gypi since that's the same source being used
to generate the HTML file.

This also adds the WCS sandbox files to the list of JS files being checked --
they were not being checked as part of the old target because they are not
used in the main.html file.

BUG=
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/163953011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251446 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a level of indirection around ProfileOAuth2TokenService
(ProfileOAuth2TokenServiceWrapper) to eliminate PO2TS being a BCKS. The only
purpose of the wrapper class is to glue a PO2TS instance to a Profile; the
wrapper has no public API. In particular, PO2TSFactory still vends PO2TS
instances.

BUG=334187
TBR=jochen

Review URL: https://codereview.chromium.org/148513010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251444 0039d316-1c4b-4281-b951-d872f2087c98

Since the UI thread is the audio thread on OSX, we should be careful
about what we execute during startup.  Device enumeration and creation
of the device listener can be expensive, so don't do them until the
first stream is created.

BUG=288759
TEST=none

Review URL: https://codereview.chromium.org/154543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251443 0039d316-1c4b-4281-b951-d872f2087c98

All new suggestion types will be a Google Search URL with https. In some cases,
url may contain additional identifying parameter.

BUG=339270
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/134853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251442 0039d316-1c4b-4281-b951-d872f2087c98

We use the swap-buffers for normalizing in benchmarks, so this is the only trace labelled for now.

TBR=nduca
BUG=342635
NOTRY=true

Review URL: https://codereview.chromium.org/148613014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251441 0039d316-1c4b-4281-b951-d872f2087c98

Tabpose has been behind a flag for 3 years, and UMA shows usage is very low.
It is the unique user of the RenderWidgetSnapshotTaker, and the only user of
RWH::PaintAtSize, which we want to remove.

XIB changes:
* Remove Tabpose menu entry "Show Tab Overview..."

BUG=251960, 223336
R=cevans@chromium.org, jamesr@chromium.org, sky@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/154083008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251439 0039d316-1c4b-4281-b951-d872f2087c98

> Valgrind: Disable failing test: InputMethodManagerImplTest.TestEnableLayoutsAndCurrentInputMethod.
> 
> BUG=344008
> NOTRY=true
> TBR=groby@chromium.org
> 
> Review URL: https://codereview.chromium.org/167383004

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/167853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251438 0039d316-1c4b-4281-b951-d872f2087c98

> Reland of: Split out InputMethodMenuManager from InputMethodManager.
> 
> Rename input_method_property to input_method_menu_item, and move to ash/ime.
> 
> This is a reland of https://codereview.chromium.org/150203015,reverted by https://codereview.chromium.org/165453002
> 
> Use Singleton<> instead of trying to maintain my own singleton.
> 
> BUG=342336, 343044
> 
> Review URL: https://codereview.chromium.org/165783002

TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/167823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251436 0039d316-1c4b-4281-b951-d872f2087c98

> event-rewrite: Clean up how events are rewritten.
> 
> Notable changes:
>  * Make the EventRewriter a MessagePumpObserver. This is necessary to make sure
>    that the event-rewrite happens before the event is dispatched.
>  * Move the EventRewriter in chrome/browser/chromeos (and in chromeos namespace),
>    since it does nothing on other platforms.
>  * Get rid of the event-rewrite code from ash, since it just adds an extra layer
>    of abstraction for no added value.
> 
> BUG=343639
> R=derat@chromium.org, sky@chromium.org, stevenjb@chromium.org
> 
> Review URL: https://codereview.chromium.org/165463002

This was causing the following check failure

[3943:3943:0214/135331:FATAL:event_rewriter.cc(858)] Check failed:
xievent->evtype == XI_ButtonPress || xievent->evtype == XI_ButtonRelease. 
Aborted (core dumped)

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/167273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251433 0039d316-1c4b-4281-b951-d872f2087c98

Apparently, couldn't be the cause. Reverting my revert.

> Revert 251054 "Make all the files mapped in when running unit_te..."
> 
> Speculative revert, to see if this fixes CrOS MergeSession tests.
> 
> > Make all the files mapped in when running unit_tests read only on Linux and OSX.
> > 
> > This means no file can be opened for write during the test run.
> > 
> > Windows can't be done at the moment due to bug 342913.
> > 
> > R=vadimsh@chromium.org
> > BUG=116251
> > BUG=342913
> > 
> > Review URL: https://codereview.chromium.org/136973003
> 
> TBR=maruel@chromium.org
> 
> Review URL: https://codereview.chromium.org/166483006

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/164183010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344008
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/167383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251425 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251424 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12758: (dschuff) llvm-test.py: Use msys make when running regression tests on Windows
r12759: (mcgrathr) Give sel_ldr an option (-d) to raise a no-op signal at startup
r12761: (dyen) Removed extra TLS flags passed into our toolchain
r12762: (mcgrathr) Update chrome_rev to current LKGR
r12763: (mcgrathr) Update tools_rev in DEPS
r12765: (mcgrathr) toolchain_build: Use new version of isl
r12766: (teravest) Remove Log() in ReverseService.
r12767: (bradnelson) Switching perf graph units to "standard" units.
r12768: (mseaborn) Remove unused code relating to a never-finished ARM Thumb sandbox
r12769: (bradnelson) Fixing escaping issue in r12768.
r12770: (jvoung) Update TOOL_REVISIONS for PNaCl r12737->r12765

BUG=none
TEST=nacl_integration
NOTRY=true
(ran try jobs already)

Review URL: https://codereview.chromium.org/163433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251423 0039d316-1c4b-4281-b951-d872f2087c98

Make the TopContainerView always fully overlap the window header because we use the TopContainerView bounds in computing the find bar's position

BUG=341636
TEST=BrowserViewHostedAppTest.Layout

Review URL: https://codereview.chromium.org/160093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251422 0039d316-1c4b-4281-b951-d872f2087c98

And expose prefs::kLanguageSendFunctionKeys via
ChromeOSInfoPrivate for apps that need the function keys.

BUG=338390

Review URL: https://codereview.chromium.org/162783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251421 0039d316-1c4b-4281-b951-d872f2087c98

R=nasko@chromium.org
TBR=estade@chromium.org
BUG=330811
TEST=See bug comment 9 for repro steps.

Review URL: https://codereview.chromium.org/166033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317741,338563

Review URL: https://codereview.chromium.org/167153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339790
R=marja@chromium.org

Review URL: https://codereview.chromium.org/166303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251418 0039d316-1c4b-4281-b951-d872f2087c98

generating invalid JavaScript bindings. We now translate an enum value like
FOO_VALUE in a mojom file to proper_namespace.EnumName.FOO_VALUE in JS.

I also fixed enum declarations in JS so an enum value can be defined in terms
of itself, e.g.
  enum Foo { FOO_1, FOO_2 = FOO_1 * 2 };

BUG=320082
R=darin@chromium.org

Review URL: https://codereview.chromium.org/164873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251416 0039d316-1c4b-4281-b951-d872f2087c98

This is a clone of https://codereview.chromium.org/166753002/ + changes to handle OPT_RTP_SENDTIME_EXTN_ID in ipc_socket_factory.cc.

R=mallinath@chromium.org, wjia@chromium.org, xians@chromium.org
TBR=sergeyu

Review URL: https://codereview.chromium.org/167313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251415 0039d316-1c4b-4281-b951-d872f2087c98

Revert reason: cros unit test failures

See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29

Sample output:

ersiveModeControllerAshTest.TabAndBrowserFullscreen (run #3):
[ RUN      ] ImmersiveModeControllerAshTest.TabAndBrowserFullscreen
Xlib:  extension "RANDR" missing on display ":9".
[21038:21038:0214/121606:1047752665:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752835:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752914:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
Received signal 11 SEGV_MAPERR 00020000002d
 [0x7f0b3aa767ce] base::debug::StackTrace::StackTrace()
 [0x7f0b3aa76cf8] base::debug::(anonymous namespace)::StackDumpSignalHandler()
 [0x7f0b34340cb0] \u003Cunknown>
 [0x00000379579c] PermissionBubbleViewViews::~PermissionBubbleViewViews()
 [0x00000373aafb] BrowserView::~BrowserView()
 [0x00000373ad69] BrowserView::~BrowserView()
 [0x7f0b38da5de2] views::View::~View()
 [0x7f0b38dbbcf0] views::NonClientView::~NonClientView()
 [0x7f0b38dbbd69] views::NonClientView::~NonClientView()
 [0x7f0b38da5bed] views::View::DoRemoveChildView()
 [0x7f0b38da5ce5] views::View::RemoveAllChildViews()
 [0x7f0b38da9dd8] views::internal::RootView::~RootView()
 [0x000003734aa0] BrowserRootView::~BrowserRootView()


> [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed.
> 
> This bug meant that subsequent calls to AddRequest wouldn't show the bubble, since the manager still believed it was being shown.
> 
> R=leng@chromium.org
> 
> Review URL: https://codereview.chromium.org/162423002

TBR=gbillock@chromium.org

Review URL: https://codereview.chromium.org/167533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251414 0039d316-1c4b-4281-b951-d872f2087c98

This cl rearranges the directory layout for the memory_inspector tests.
This is to ensure that:
 - Every unittest lives side-by-side with the module being tested.
 - The mocks/helper class live in the unittest package.
 - Nobody has to hack the sys.path ever.
 - Every (test and non) module uses the "import memory_inspector.submodule"
   pattern consistently, without creating any namespace ambiguities.

BUG=340294

Review URL: https://codereview.chromium.org/167223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251413 0039d316-1c4b-4281-b951-d872f2087c98