- 06 Oct, 2020 40 commits
-
-
Ian Wells authored
When enable_jdk_library_desugaring=true, this change allows shrinking of the generated "j$" dex from ~400 KB to 36 KB. ConcurrentHashMap is available before before Java 8 but with a bug: crbug.com/905903 Bug: 1056751 Change-Id: Ibaaeba2f714c0e8b17295cbe48098786ad173448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446989Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#814363}
-
Hazem Ashmawy authored
Add tests for toggling flags and the persistent notification. Also remove test batching for flags fragment tests to so the flags service is killed when the process is killed leaving a clean state. Fixed: 1130599 Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" Change-Id: I0cb416471d3b79e98ed9ef8ad5e760b4bfaa1083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438534 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814362}
-
Ian Kilpatrick authored
As above. Previously this was handled by LayoutFlexibleBox. Bug: 845235 Change-Id: Id4899b487c92b723341c8251601f317abb6618c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451732Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814361}
-
Eugene But authored
Notable changes: - Record pending URL for chrome://inducebrowsercrashforrealz to distinguish self inflicted UTEs - Extend PreviousSessionInfo to store navigation URLs - PreviousSessionInfo only stores URL origins as requested by Privacy team - Use URLs from PreviousSessionInfo for synthetic crash reports Bug: 1103752 Change-Id: Idbde05b634e840fe377c4803b357fbef03c36170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451298 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814360}
-
Wenbin Zhang authored
Reference build has been disabled everywhere on perf waterfall. This CL removes the footprints of it in the sharding logic. Bug: chromium:1130157 Change-Id: If64f8435f705710305a0c6fe24610ceac7cf6275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451514 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814359}
-
John Williams authored
This change prevents a blank media notification from being shown (due to a partially implemented feature) unless the appropriate feature flags are enabled. Bug: 1134356, b/169946872 Change-Id: I54a0575a302e4215f9d3fd98cd39af4d38f944ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453893Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#814358}
-
Collin Baker authored
This removes ReopenTabPromoController an instead invokes reopen tab IPH through FeaturePromoController. Bug: 1133016 Change-Id: Ie90b8fb509bbed3a3898d08d48ec33242d7caeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446993 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814357}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ib8f8d20263a3d51627f00a47261adae1b519bd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446150 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814356}
-
Gil Dekel authored
This CL simplifies and cleans up the way ConfigureDisplayTask manages its state over sync/async callbacks to reduce complexity and race-risk by tightening up the way calls to Run() and OnConfigure() are handled. In addition, this CL adds a test to ensure that we attempt to reconfigure displays when any of them fail, not just the last one. Finally, it removes ConfigureDisplaysTaskTest.ConfigureWithNoDisplays, since this case should never occur in reality. TEST=display_unittests Change-Id: Icf34b00205e980df2bb5facbe6da5387a3e9dce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422559 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#814355}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I254a1151506e3ef5c0d1e0b6ae665fb63da472cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814354}
-
Alex Turner authored
The XRSystem is currently provided its document's ukm::SourceId in its constructor, which is then stored in a member variable. Instead, we can simply get it from the document/execution context as needed. Follows from comments in crrev.com/c/2267639. Bug: 1100349 Change-Id: Ie89c7fa55ee27aa07cc799666c83443122d721fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451384Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814353}
-
Luke Zielinski authored
This rolls up to 4b8a64638b4c06fb38eb562b754eae389b381ec0 Assorted changes, including webkitgtk_minobrowser support and mojojs improvements Change-Id: I2a806f1a0040394541fbe52f749f3ab69d3820a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453794Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814352}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/afe6ca45b6da..a3b213595b36 2020-10-06 zzyiwei@google.com Update Vulkan headers to version 1.2.156 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I425401446975ec5f1034ad89ef6423a99fd0b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453312Reviewed-by:
-
David Black authored
We originally force closed the holding space bubble because the view hierarchy was being destroyed asynchronously which caused a crash when views attempted to notify HoldingSpaceViewDelegate of their destruction. That code has been transitioned to use scoped ViewObservers so this is no longer an issue. By allowing the holding space bubble to async close, we allow it to run its default window animation. Bug: 1134374 Change-Id: I2211373c7519163619f7be3988c8ddcfa7e1b8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449832Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#814350}
-
Sven Zheng authored
Can't repro the flaky test locally. Re-adding to FYI bot for further debugging and remain disabled for CI/CQ bot. Bug: 1131319 Change-Id: Id0efb7067480d668dd7caad1cbb6763cb0a1ae84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446025Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814349}
-
Dominique Fauteux-Chapleau authored
This reverts commit a60f7247. Reason for revert: Breaks Cast Audio Linux builder Original change's description: > ozone: fix expectations in clipboard test > > In case of Ozone, we support more types. > > Bug: 1134495 > Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#814303} TBR=sky@chromium.org,msisov@igalia.com Change-Id: I2d22d47498697b92e4fc486a90730b1268357bac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134495, 1135697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453432Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814348}
-
Rune Lillesveen authored
Take color-scheme meta tags into account and set the content background color for the page to the dark background before we start committing frames for the document. This way we can avoid white flashes navigating between dark schemed pages if there are e.g. slow render blocking stylesheets blocking rendering. Bug: 1103667 Change-Id: I1ed110bf652dd4936bf6669e6b9cd634c0f73b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438532Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#814347}
-
Shawn Quereshi authored
Update Cast API Bindings to be agnostic of MessagePort implementation with platform-specific definitions. A common interface is exposed except for construction, which requires different artifacts. On non-Fuchsia, MessagePortCast still uses blink::WebMessagePort. On Fuchsia, MessagePortFuchsia wraps fuchsia::web::MessagePort instead of requiring an adapter to blink::WebMessagePort. R=halliwell@chromium.org, jbroman@chromium.org, kmarshall@chromium.org Bug: 1126571 Change-Id: Ice36b32949f45a8d1c12daa6b4a33e4b1e885a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441663 Commit-Queue: Shawn Quereshi <shawnq@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814346}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //skia. Bug: 1113033 Change-Id: I499666a82df15d1ebeb429643a9ef9ddd2faefea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451327Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814345}
-
Xiaocheng Hu authored
This test converts the two web tests with W3C testharness.js, which is a more preferred test framework. It's also a preparation for crrev.com/c/2451598 Bug: 1087854 Change-Id: Ibd58fe188c75258f66568f93a41ea4b994915b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453491 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814344}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e5cf441141c..33b42e12ab71 2020-10-06 mtklein@google.com retry retry absl 2020-10-06 bsalomon@google.com Start removal of tool usage of SkSurface::MakeFromBackendTextureAsRenderTarget. 2020-10-06 mtklein@google.com find cxxabi headers in Android ASAN builds 2020-10-06 bungeman@google.com Add SkTypeface::getPostScriptName. 2020-10-06 herb@google.com Add flag to switch op allocation to new If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I51f7bc69ad7c63740380dcafabf5ade411e989e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453170Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I21bfac28a135911ecad7c0153de245ca6a326dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445498Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814342}
-
cfredric authored
creations. Bug: 973801 Change-Id: Ib43f01e672c137a47f7595416e3f75cf943c7456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344625 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#814341}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ieabe95e93699c6dc4cebe120c55caf16d11c705f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453316Reviewed-by:
-
Peter Kotwicz authored
Running android-androidx-packager daily will make it easier to identify and address any teething issues. BUG=1064277 Change-Id: I8eec68c068635514a3014404edc2aaad8bb9a9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453449Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814339}
-
Dominique Fauteux-Chapleau authored
TBR=liberato@chromium.org Bug: 1135512 Change-Id: Icadabfb00b630a5a82beb2e8191d4928b66db83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453871Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fca083c57b5f..3a384ed186dd 2020-10-06 thestig@chromium.org Use DCHECK_IS_ON() in cfx_char.cpp. 2020-10-06 nigi@chromium.org Roll v8/ c577d027e..88d84cce1 (632 commits) 2020-10-05 nigi@chromium.org Roll buildtools/ ff93f3ea1..4be464e05 (3 commits) 2020-10-05 nigi@chromium.org Roll third_party/instrumented_libraries/ 3c52ccdd3..6ba978ccb (1 commit) 2020-10-05 nigi@chromium.org Roll third_party/skia/ d20e8e933..4c3486e6f (572 commits; 1 trivial rolls) 2020-10-05 nigi@chromium.org Disable embedder tests which fail with Skia/SkiaPaths enabled. 2020-10-05 nigi@chromium.org Roll third_party/libjpeg_turbo/ 9d4f8005b..d5148db38 (12 commits) 2020-10-05 nigi@chromium.org Roll third_party/zlib/ d53accfbd..26211a5a8 (6 commits) 2020-10-05 tsepez@chromium.org Pass spans of floats to CPDF_ColorSpace::GetRGB(). 2020-10-05 thestig@chromium.org Make variable naming consistent in CPDF_TextPage::GetRectArray(). 2020-10-05 thestig@chromium.org Replace ASSERT() with DCHECK() in various xfa dirs. 2020-10-05 nigi@chromium.org Roll third_party/icu/ 79326efe2..aba3f0dfe (8 commits) 2020-10-05 thestig@chromium.org Move FPDFText_GetLooseCharBox() logic into cpdf_textpage.cpp. 2020-10-05 nigi@chromium.org Roll third_party/depot_tools/ ed15af5c4..422c039e8 (82 commits; 44 trivial rolls) 2020-10-05 thestig@chromium.org Move CAgg_PathData out of fx_agg_driver.h. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I038dfa9e8e3698c23760cf6e816c229b84fddc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453315Reviewed-by:
-
Robert Sesek authored
Prior to macOS 10.15, an inherited, open, writable FD could not be ftruncate()d without an explicit sandbox rule. This verifies that behavior and will catch any regressions in the future. Bug: 1084565 Change-Id: I9b3d6b0f3b8e9cb1a02f975b33e16501482f23f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451315Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#814336}
-
Haiyang Pan authored
Bug: 1099916 Change-Id: Ifd0b48f342744ed2d7f44cc34c2de412dad7af4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452989Reviewed-by:
-
Sven Zheng authored
Remove duplicate keys and update the arg. See http://crbug.com/1131319#c6 Bug: 1131319 Change-Id: Id113f4b1ce34c3b6b9a74a0fc49ffd7afc188853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446660Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814334}
-
Maksim Sisov authored
When Ozone/X11 starts to use emulated ui events, it's required that X11Window is able to send out those events further to aura. Thus, restrict this limit only to ChromeOS as it uses different approach for ui tests (it basically sends events using UiControlsAsh). Bug: 1134495 Change-Id: Ifa4d143b178be0e49449cfd843981a375d71a74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444310Reviewed-by:
-
Xianzhu Wang authored
Bug: 1128440 Change-Id: I9f64c6d8bbe0228dae3ecf6f49caaed2a785f970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451849Reviewed-by:
-
mark a. foltz authored
It's possible for the extension ID to be unset on the EventPageRequestManager while requests are incoming for the event page. In that case, avoid calling into extensions::ProcessManager to wake the event page with an empty extension ID. Bug: 1105702 Change-Id: I9017c0c6af7697fb0ac3d82fcb4e49d261993884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446712Reviewed-by:
-
Daniele Castagna authored
UI resources are rastered in sRGB, if the screen has a different color space, a color conversion step will be added to the fragment shader. This CL creates UI resources directly in the color space used by the final compositing step, so that the conversion can be skipped. Bug: 1129243 Change-Id: Ia9659cbb993ebb16097079daf6c7e67aecf0525f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441932 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#814330}
-
Matt Wolenetz authored
Replaces remaining direct usage of the attached HTMLMediaElement from MediaSource and SourceBuffer, relying instead on the attachment to moderate that communication. Specifically, this change: * Adds attachment helpers to enable SourceBuffers to create their audio and video tracklist members, including a same-thread attachment implementation. Cross-thread attachment implementation of this is deferred until TrackListBase and TrackBase can be owned off the main thread (in a worker thread), and until they can function without themselves directly accessing an HTMLMediaElement. * Removes superfluous usage in SourceBuffer of `source_->MediaElement()` in DCHECKs; other DCHECKs already suffice. * Removes MediaSource::MediaElement() and `attached_element_`. Removes their superfluous implementation and usage from MediaSource. * Fixes outdated assumptions in various DCHECKs that all attachments use a tracer. Only same-thread attachments use a tracer. BUG=878133 Change-Id: I346b320804a0ffbf731788b7ea7c344588f660b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439677 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#814329}
-
Tom Anderson authored
This is in preparation for removing Xlib error functions. BUG=1066670 R=sky Change-Id: I495065cabcefff11dc63fb282dc0af1bdcf41342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443790Reviewed-by:
-
Mike Wasserman authored
A speculative fix for flakiness in the Accept test fixture. Await getScreens() and then await the permission status. That should run permission context logic before checks. Bug: 1134240 Test: No WindowPlacementPermissionContextTest flakes Change-Id: I21f1e4b2019112d79adf28d8609728fdbe5eaf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446844 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Sreerenj Balachandran authored
This is a workaround to match with iHD media driver that shifts the quantization values by 50 while encoding. https://github.com/intel/media-driver/blob/master/media_driver/linux/common/codec/ddi/media_ddi_encode_jpeg.cpp#L694 The patch ensures the shifted value in the middleware generated packed header. Linux media stack test cases claiming to have a significant psnr improvement in Y plane (41.27 to 48.31) with this quirk. BUG=None TEST=./jpeg_encode_accelerator_unittest Change-Id: Ie2316cce2b5c86fefeb3879872c881868687011b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446208 Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814326}
-
George Steel authored
This updates the name to reflect the fact that the function now returns multiple true values indicating which size axis (width/height) the transform depends on. This is a pure refactor follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2422088 requested by vollick@. Change-Id: I2649186d9378bc34faa59f9866f6dcf049493a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453590 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814325}
-
Leonid Baraz authored
Remove immediate Status returning, make fully asynchronous. Bug: None Change-Id: I6d8619e5a90641b645f6109a6a6e7db42e16aced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453489 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#814324}
-
