- 22 May, 2014 40 commits
-
-
dgozman@chromium.org authored
When paused in debugger on mouse move, we can send ack as it has no side effects apart from new mouse moves being sent to renderer. Debugger already causes nested input events handling (because of different event types don't wait for each other's ack). This, and mouse move being the event without side effects, means there should be no harm in allowing nested mouse moves. BUG=374183 Review URL: https://codereview.chromium.org/288393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272230 0039d316-1c4b-4281-b951-d872f2087c98
-
anton@chromium.org authored
Needed for 64-bit which is using a newer version of the runtime. Prior to this CL the test requires that Infinity is converted to the string "Inf" and NaN is converted to the string "NaN". However, these conversions are done by a format %g option which is defined as providing a lower case string (http://en.wikipedia.org/wiki/Printf_format_string). As LiveConnect provides "no guarantee" as to number formatting (https://jdk6.java.net/plugin2/liveconnect/#JS_NUMBER_VALUE) it seems best to just relax these tests. BUG=346626, 354405 Review URL: https://codereview.chromium.org/292183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272229 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
BUG=339355 TEST=Run unittests. TBR=jamesr@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/267723008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272228 0039d316-1c4b-4281-b951-d872f2087c98
-
fukino@chromium.org authored
- Pass the reference to the metadata cache to the Directory Tree. - When a tree item needs redraw, check the metadata and toggle css class 'shared'. BUG=264812 TEST=manually confirmed Review URL: https://codereview.chromium.org/292183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272227 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/296933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272225 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/292663007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272224 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
The help text is supposed to contain a link ("saved passwords"). In order to implement this using HyperlinkTextView, convert the code to using subviews rather than rendering the text manually in drawRect:. BUG=114092 Review URL: https://codereview.chromium.org/289413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272223 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272222 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
This also rolls the NSS deps to include the RSA-OAEP support backported for Windows/Mac BUG=372917 R=eroman@chromium.org Review URL: https://codereview.chromium.org/275943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272221 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=375900 Review URL: https://codereview.chromium.org/294903010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272220 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
These were broken due to the WS_CAPTION style always being applied. Now the style is not applied if the window has transparency enabled. BUG=373541 Review URL: https://codereview.chromium.org/295933011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272219 0039d316-1c4b-4281-b951-d872f2087c98
-
mateuszs@opera.com authored
If window is positioned on right monitor in multimonitor setup tooltips for items to the left of Chromium window appear on left screen. This is because screen on which to display the tooltip is calculated from DIP coordinates. BUG= Review URL: https://codereview.chromium.org/225403022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272218 0039d316-1c4b-4281-b951-d872f2087c98
-
naiem.shaik@gmail.com authored
LanguageState is currently owned by ContentTranslateManager, but it should be moved under TranslateManager BUG=345690 TEST=unittests --gtest_filter=Translate* TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/290573013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272217 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
We added this to RenderWidgetCompositor, but forgot to add it to the WebLayerTreeViewForTesting, which we must before we add the pure virtual to the WebLayerTreeView base class. TBR=piman Review URL: https://codereview.chromium.org/296043011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272216 0039d316-1c4b-4281-b951-d872f2087c98
-
armansito@chromium.org authored
This CL implements the onDescriptorValueChanged event of the bluetoothLowEnergy API. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Review URL: https://codereview.chromium.org/287673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272215 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
Change MediaStreamVideoSource to output different resolutions do different tracks depending on the track constraints. This cl introduce a new class VideoTrackAdapter. The adapter is responsible for forwarding frames on the IO-thread from a MediaStreamVideoSource to a the tracks connected to the source. It has the ability to wrap media::VideoFrames with new visible_rect and natural_size to match max width and height resolutions as well as min and max aspect ratio per track. Note that this does not yet work for textures. It also changes the WebrtcVideoCaptureAdapter to use libyuv::Scale instead of libyuv::I420Copy. This is needed to allow the video frames sent on a PC to be both cropped and scaled. BUG= 346616 Review URL: https://codereview.chromium.org/246433006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272214 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
Add WOW64 support to DeleteKey. Add DeleteEmptyKey to mimic SHDeleteEmptyKey. Add lots of WOW64 tests. Add a DeleteKey and a CreateKey test. These additions are needed to support Win64 installer logic. BUG=338706,348626 TEST=base_unittests --gtest_filter=Registry* on XP (x86), Vista (x86/x64), Win7 (x86/x64). TEST=installer_util_unittests R=cpu@chromium.org, grt@chromium.org Review URL: https://codereview.chromium.org/275103012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272213 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
This was broken by r269506. Added additional tests to prevent this from happening in the future. BUG=372789 Review URL: https://codereview.chromium.org/295843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272212 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
Previously the custom binding in JS would prevent an image that's larger than the size of the template from being sent to the browser process. This relaxes the maximum to be the largest supported scale factor of the machine. BUG=239676 Review URL: https://codereview.chromium.org/256503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272211 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
TempFile quota management only serves to limit the write limits of the llc and ld processes when translating PNaCl pexe files. There are many other ways to fill the disk, so this doesn't serve much purpose, and the code will be simpler to understand without it. I hope to remove MakeFileDescQuota() from native_client after making that change, and removing the implementation, including the necessary methods in nacl::ReverseInterface. BUG=239656 R=jvoung@chromium.org Review URL: https://codereview.chromium.org/290993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272210 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
R=sky@chromium.org http://crbug.com/365012 Review URL: https://codereview.chromium.org/287053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272209 0039d316-1c4b-4281-b951-d872f2087c98
-
ernstm@chromium.org authored
TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadStats. This should now be fixed for real: https://codereview.chromium.org/289163004/ R=jyasskin@chromium.org,glider@chromium.org NOTRY=True BUG=370244 Review URL: https://codereview.chromium.org/292103006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272207 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Make ordinals be immediately after the member name, (possibly) followed by a default value. E.g., "int32 foo@12 = 345;" instead of "int32 foo = 345 @12". Also make the usual style "foo@12" instead of "foo @12". (Leave a few of the latter in tests, to check that whitespace is permissible.) R=sky@chromium.org Review URL: https://codereview.chromium.org/295973007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272204 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
This wraps sendmsg() and allows FDs to be sent. It will replace PlatformChannelSendHandles(). R=yzshen@chromium.org Review URL: https://codereview.chromium.org/297803008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272203 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Clean up and prettify the unittests in content/renderer/device_sensors/ to conform with preferred coding practice, i.e. private members, DISALLOW_COPY_AND_ASSIGN.. BUG= Review URL: https://codereview.chromium.org/297513009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272202 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
if there is at least one extension that can be allowed for each, and exclude policy and unpacked extensions. BUG=372047 R=jar@chromium.org, rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/297533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272198 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
param, just don't set a value. BUG=368129 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/266353009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272194 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
Only Blink can accurately determine what node is under the user's finger. Implement this by sending a hit test request every time the user does touch exploration, and returning a hover event on the appropriate accessible node in response. The test is meant to be a good sanity test and a skeleton, it tests that the hit test request returns a hover event in response, and I intend to follow this up with more specific tests of behavior as we tweak the algorithm. BUG=357371 Review URL: https://codereview.chromium.org/290633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272193 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
R=jar@chromium.org, rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/299853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272192 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272191 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
Please reply to the V8 sheriff jkummerow@chromium.org in case of problems. R=jkummerow@chromium.org TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/298973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272190 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/292323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272189 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
This provides a test for a Blink fix at https://codereview.chromium.org/288423002/ The test copies exactly the reproduction steps from http://crbug.com/372595: 1. Saves credentials for a form. 2. Reloads the form, letting the credentials be autocompleted. 3. As the very first user interaction, taps on the submit button. 4. Checks that the autofilled password was correctly submitted. The test could not be done in Blink, because it relies on password autocompletion. BUG=372595 R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/297693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272188 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=374232 R=isherman@chromium.org Review URL: https://codereview.chromium.org/293023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272184 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
The logic where we treated an empty URL as home page is outdated. This CL contains the following additional fixes: 1) Disallow using empty URLs to denote anything (home page, new tab page...) and force the callers of chrome::Navigate to specify which URL they want to open. Using empty URLs was hiding bugs (see below). 2) Fixed StartupBrowserCreatorTest.UpdateWithTwoProfiles and ProfilesWithoutPagesNotLaunched so that they don't work by accident (about:blank used to be the home page - it wasn't restoring the previous session, but launching the home page). 3) There was some code passing GURL("new_tab_page") around, and comparing against that. But that's an invalid URL, so GURL will just make it empty, and the result is not what is expected. (E.g,. GURL("foo") == GURL("new_tab_page")). 4) Fixed other places which were passing GURL("something_invalid") around and pretending it's something meaningful. It was just a coincidence that nothing was broken. BUG=371852 R=sky@chromium.org Review URL: https://codereview.chromium.org/292713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272182 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272180 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272178 0039d316-1c4b-4281-b951-d872f2087c98
-
fmalita@chromium.org authored
https://code.google.com/p/skia/source/list?num=9&start=14839 TBR= BUG= Review URL: https://codereview.chromium.org/296933006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272177 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
TEST=manually on login/lock/user adding screens. BUG=361861 NOTRY=true Review URL: https://codereview.chromium.org/297663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272176 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
Now that manifest parsing has been moved to components/nacl, the trusted plugin no longer depends on jsoncpp. BUG=239656 R=dmichael@chromium.org Review URL: https://codereview.chromium.org/291173007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272174 0039d316-1c4b-4281-b951-d872f2087c98
-