GitLab

Binding to 127.0.0.1 is instant. Binding to all interfaces takes 5s on my MBP.
The part about closing the sockets is just a precaution.

BUG=388256

Review URL: https://codereview.chromium.org/480643002

Cr-Commit-Position: refs/heads/master@{#290135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290135 0039d316-1c4b-4281-b951-d872f2087c98

Set the cast simulator same default values as the extensions.
This means 400 ms target latency and 2 - 2.5mbits/s bitrate.

TBR=miu

Review URL: https://codereview.chromium.org/473373002

Cr-Commit-Position: refs/heads/master@{#290134}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290134 0039d316-1c4b-4281-b951-d872f2087c98

The timeout was recently changed from None (wait forever) to 5 seconds.
On slow bots, even after _WaitForBrowserToComeUp returns, the launch of
the first renderer can take considerable time. The next request for the
browser's state is subject to the timeout here, and the browser does not
respond until the renderer's launch completes.

Increasing the timeout to 30 seconds should not regress the original fix
and should fix the flakiness.

BUG=403981
TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/474413002

Cr-Commit-Position: refs/heads/master@{#290133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401266

Review URL: https://codereview.chromium.org/473293002

Cr-Commit-Position: refs/heads/master@{#290132}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290132 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a function to modify file system sandbox rules to replace the
\??\ NT prefix with the correct escaped form \/?/?\ for the wildcard matching
rules in the broker. This is done generally as it's a common mistake in the
sandbox code and so provides some defence in depth.

BUG=334882

Review URL: https://codereview.chromium.org/432543005

Cr-Commit-Position: refs/heads/master@{#290131}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290131 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/473363003

Cr-Commit-Position: refs/heads/master@{#290130}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290130 0039d316-1c4b-4281-b951-d872f2087c98

Implements the HostExtension[Session] interfaces for WebRTC Peer Connection
support in the Chromoting host. 

The CastExtension represents the "casting" capability of the Chromoting
host. The CastExtensionSession encapsulates the WebRTC PeerConnection
architecture needed to set up a peer connection with the client, using
protocol::ExtensionMessages as the signaling channel for the connection.

Review URL: https://codereview.chromium.org/399253002

Cr-Commit-Position: refs/heads/master@{#290129}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290129 0039d316-1c4b-4281-b951-d872f2087c98

The new FakePacketSocketFactory allows to simulate fake 
network with given latency/bandwidth parameters.

BUG=394067

Review URL: https://codereview.chromium.org/427613005

Cr-Commit-Position: refs/heads/master@{#290128}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290128 0039d316-1c4b-4281-b951-d872f2087c98

Currently, Hangouts sends a hello message to the webapp before establishing a long-lived connection.
After this CL, Hangouts will establish the connection first and then send a hello message.  If the
webapp is not installed, Hangouts will receive a disconnect event on the port.  If the webapp is
installed, Hangouts will receive a hello response with the list of supported features.

Review URL: https://codereview.chromium.org/473073002

Cr-Commit-Position: refs/heads/master@{#290127}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290127 0039d316-1c4b-4281-b951-d872f2087c98

Max outstanding frame used to be 60 to work around an issue with 8-bits
integer wrap around for frame IDs. Now the logic for handling wrap
around us less buggy we can increase the limit to 120 frames.

TBR=hubbe

Review URL: https://codereview.chromium.org/476303004

Cr-Commit-Position: refs/heads/master@{#290126}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403618

Review URL: https://codereview.chromium.org/465153003

Cr-Commit-Position: refs/heads/master@{#290125}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290125 0039d316-1c4b-4281-b951-d872f2087c98

This saves about 5s on my MBP. Hard to say what the savings'll be on the bots.
This might also help reliability.

BUG=388256

Review URL: https://codereview.chromium.org/476373002

Cr-Commit-Position: refs/heads/master@{#290124}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290124 0039d316-1c4b-4281-b951-d872f2087c98

This saves about 6s on my MBP.

BUG=388256

Review URL: https://codereview.chromium.org/473323003

Cr-Commit-Position: refs/heads/master@{#290123}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290123 0039d316-1c4b-4281-b951-d872f2087c98

This adds a creation flag for extensions which tracks if they
were installed from a potentially untrusted source.

The flag is currently set for extensions which are installed
via the Windows registry from a CRX on the local filesystem.

No enforcement action is being taken yet and no additional metrics are being collected.

BUG=325469

Review URL: https://codereview.chromium.org/479513004

Cr-Commit-Position: refs/heads/master@{#290122}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334407

Review URL: https://codereview.chromium.org/472053004

Cr-Commit-Position: refs/heads/master@{#290121}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290121 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/478833002

Cr-Commit-Position: refs/heads/master@{#290120}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=dialog title no longer wraps
R=tbarzic@chromium.org

Review URL: https://codereview.chromium.org/480653002

Cr-Commit-Position: refs/heads/master@{#290119}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290119 0039d316-1c4b-4281-b951-d872f2087c98

[EasyUnlock] Update settings string from "Chrome device" to "Chromebook" or "Chromebox" as appropriate.

BUG=397280
TEST=Open settings UI, search for "Easy unlock", should see "Chromebook" rather than "Chrome device" in the description string.
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/479733002

Cr-Commit-Position: refs/heads/master@{#290118}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/476303003

Cr-Commit-Position: refs/heads/master@{#290117}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290117 0039d316-1c4b-4281-b951-d872f2087c98

The texture filtering mode of backing texture of offscreen
framebuffer is used for rendering Pepper Graphics3D contents.
If GL_NEAREST is used, the contents looks bad when it is scaled
(e.g. CSS transform, changing display resolution on ChromeOS).
This CL changes the texture filtering mode of backing textures
to GL_LINEAR to prevent the contents from looking bad in such cases.

TEST=Set display resolution to 1024x680 on Pixel
TEST=Apply CSS transform to NaCl emebed element
TEST=Apply CSS transform to Flash content
BUG=384687

Review URL: https://codereview.chromium.org/472443002

Cr-Commit-Position: refs/heads/master@{#290116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290116 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290115}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290115 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180366:180394&mode=html
TBR=adamk@chromium.org,mkwst@chromium.org
BUG=

Review URL: https://codereview.chromium.org/478013002

Cr-Commit-Position: refs/heads/master@{#290114}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290114 0039d316-1c4b-4281-b951-d872f2087c98

Fixes SyncManagerImpl::GetAllNodesForType's handling of a rare error
case.  Its callers expect it to return an empty list on failure, rather
than a NULL pointer.

BUG=404261

Review URL: https://codereview.chromium.org/480633002

Cr-Commit-Position: refs/heads/master@{#290113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290113 0039d316-1c4b-4281-b951-d872f2087c98

No need to have unittests repeatedly check the USB devices.

BUG=388256
TBR=baxley@chromium.org

Review URL: https://codereview.chromium.org/480613002

Cr-Commit-Position: refs/heads/master@{#290112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290112 0039d316-1c4b-4281-b951-d872f2087c98

This time, figure out what IDS entries are in a .grd file + .grdp files.
Then look for files that have the associated #include, but does not use
any of those entries.

Review URL: https://codereview.chromium.org/468233004

Cr-Commit-Position: refs/heads/master@{#290111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290111 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290110}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290110 0039d316-1c4b-4281-b951-d872f2087c98

Previously texture resource sync points were waited on
a just-in-time basis, just before drawing with the texture.

This change moves all sync point waits ahead of drawing a
frame, to ensure that we don't switch GLContexts in the
middle of drawing.

BUG=394547

Review URL: https://codereview.chromium.org/411643002

Cr-Commit-Position: refs/heads/master@{#290109}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290109 0039d316-1c4b-4281-b951-d872f2087c98

Add new histograms to confirm that PINGs are outstanding when a QUIC connection times out with open streams.

Review URL: https://codereview.chromium.org/464363005

Cr-Commit-Position: refs/heads/master@{#290108}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290108 0039d316-1c4b-4281-b951-d872f2087c98

Tentatively trigger haptic feedback when ContentViewCore is directed to show the
the paste popup. While there are no guarantees that such a commend was triggered
by a long press gesture, it should still be a usability improvement. Also
trigger feedback when the selection is updated via a repeated long press gesture.

BUG=150151,399619

Review URL: https://codereview.chromium.org/467303002

Cr-Commit-Position: refs/heads/master@{#290107}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290107 0039d316-1c4b-4281-b951-d872f2087c98

Slight improvement to QUIC version negotation debug logging.

Merge internal change: 73319950
https://codereview.chromium.org/477813003/


Improve QUIC's SentEntropyManagerTest and removing a test from
QuicConnectionTest that tests no code in QuicConnection.

Merge internal change: 73298415
https://codereview.chromium.org/479463002/


quic_session.h doesn't need to include util/gtl/linked_hash_map.h.

Merge internal change: 73256287
https://codereview.chromium.org/477863003/


Fix comment for QUIC handshake message tag COPT.

Merge internal change: 73256108
https://codereview.chromium.org/474133002/


Not used in production. Add InRecovery() method to QUIC send algorithm
interface, and pass slow start bool to bandwidth recorder.

We still want to generate bandwidth estimates while in slow start, and
include this information in the STK proto. We also need to know when we
are in recovery mode so we can avoid calculating estimates.

Merge internal change: 73239536
https://codereview.chromium.org/479443002/


Add a flag to enable QUIC's BBR congestion control by default instead of
Cubic in order to test and gather logs on internal servers.

Merge internal change: 73146298
https://codereview.chromium.org/477863002/


Add a QuicSustainedBandwidthEstimator class. Not yet used.

Followup change list in progress (not ready for review, but in case you
want to see intended usage) which does the following:

1) Use this in the QuicSentPacketManager.
2) Detect substantial differences between subsequent sustained bandwidth
   estimates.
3) Send estimates to client in server config update.

internal change list: 72831442

Merge internal change: 73132177
https://codereview.chromium.org/477053002/


Re-add the QUIC DCHECK to ensure packets are always sent in the order of
increasing sequence number.

Merge internal change: 73128051
https://codereview.chromium.org/469383004/


Change to optimize QUIC's RetransmittableFrames::HasCryptoHandshake by
storing it once when the crypto frame is added to RetransmittableFrames.

Merge internal change: 73125935
https://codereview.chromium.org/467263003/


Add an Update method on QuicAlarm which contains a granularity.  Also
change the idle network timeout to be 1 second shorter on the client and
1 second longer on the server.

Change saves ~2% of CPU according to an EndToEndTest profile.

Merge internal change: 73125905
https://codereview.chromium.org/471313002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/476023002

Cr-Commit-Position: refs/heads/master@{#290106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290106 0039d316-1c4b-4281-b951-d872f2087c98

provider API

When an extension/app with notificationProvider permission shows a user
information about sources of the notifications, the notifiers. When the
user wants to allow or disallow one notifier, NotifyOnPermissionLevelChanged
can be used to inform the notifier that its permission level was changed.

BUG=397197

Review URL: https://codereview.chromium.org/468813002

Cr-Commit-Position: refs/heads/master@{#290105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290105 0039d316-1c4b-4281-b951-d872f2087c98

For each interface Foo, the Mojo JavaScript bindings now generate
a pair of functions: |validateFooRequest(validator)| and 
|validateFooResponse(messageValidator)|.

For each Mojo struct type, an additional |validate(validator)|
method is generated.

All of the validate methods return a validationError;
validationError.NONE if the message is valid or not recognized.

The JS validator class has been extended to validate structs, arrays,
and handles.

The generated methods are unit tested, in the same way as their C++
counterparts, by reading test messages and expected results from 
/mojo/public/interfaces/bindings/tests/data/validation/.

Currently the two pointer overflow test cases are skipped because
they depend on reading 64 uints, which the test message file parser
can't handle at the moment. JS doesn't support 64 bit integers. 53
bits is the limit for integer Numbers.

The message router still only checks the validity of incoming message
headers. I'd like to integrate the router with the new validation code
in a separate commit.


BUG=386808

Review URL: https://codereview.chromium.org/468713002

Cr-Commit-Position: refs/heads/master@{#290104}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290104 0039d316-1c4b-4281-b951-d872f2087c98

Keep track of which Surfaces were included in a Display last
frame, so if a new frame is enqueued in a Surface the Displays containing it will tell their clients to redraw. This way the browser compositor
doesn't have to commit if only the renderer contents changed.

BUG=

Review URL: https://codereview.chromium.org/432093003

Cr-Commit-Position: refs/heads/master@{#290103}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290103 0039d316-1c4b-4281-b951-d872f2087c98

The Perf bots don't invoke these tests via isolates.

BUG=401985

Review URL: https://codereview.chromium.org/481473003

Cr-Commit-Position: refs/heads/master@{#290102}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290102 0039d316-1c4b-4281-b951-d872f2087c98

(Hopefully for the last time).
This is based on treib's patch 476703002

The problem that this CL is fixing is that it was a mess to tell whether
a user had a default name/avatar (Lemonade) because we randomly assigned
it at a profile creation time (in old, legacy cases), and then they synced
it because that's what sync does, or because they did that on purpose.
The idea being, of course, that if we randomly called them Lemonade and they
have a Gaia name, we should use the latter, but if they synced "bob", we should
use the sync name.

Ok. Here's how this works now:
- there's a preference for the profile name, and a preference "if it's default"
- if this preference is not set, we assume this is a legacy created profile, so
if it is named First User or Lemonade, the user probably didn't change that.
This sets a "kIsUsingDefaultNameKey" preference in the ProfileInfoCache
- if the ProfileInfoCache has a profile with a kIsUsingDefaultNameKey, then it
uses a Gaia name if it's available.
- the moment the user changes the name of a profile, it stops being default. So
even if I change the profile name from Lemonade to Pickles, even though Pickles
is one of the default profile names, we allow this insanity. 
- a similar dance is done for the default avatar/gaia avatar, only here we maintain
two preferences, because the ProfileInfoCache holds both the gaia and the profile avatar.

Profiles, right? <3

BUG=394586

Review URL: https://codereview.chromium.org/476993002

Cr-Commit-Position: refs/heads/master@{#290101}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290101 0039d316-1c4b-4281-b951-d872f2087c98

0.9.35 contains a couple of fixes for the CoreText shaper
backend, which are required to work on removing the CoreText
codepaths in Blink.

Review URL: https://codereview.chromium.org/475363002

Cr-Commit-Position: refs/heads/master@{#290100}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290100 0039d316-1c4b-4281-b951-d872f2087c98

TrimString ftw.

BUG=403753

Review URL: https://codereview.chromium.org/474123002

Cr-Commit-Position: refs/heads/master@{#290099}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394644

Review URL: https://codereview.chromium.org/469803005

Cr-Commit-Position: refs/heads/master@{#290098}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290098 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a mapping between m3u8 extension and its mime type.
For android, we need to handle HLS streams separately later on

BUG=400145

Review URL: https://codereview.chromium.org/471193002

Cr-Commit-Position: refs/heads/master@{#290097}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290097 0039d316-1c4b-4281-b951-d872f2087c98

When user clicks on the easy-unlock icon on "Click to enter" lock screen
(i.e. when lock screen auth type is USER_CLICK), the lock screen changes to
state in which password is required to unlock the screen.
This adds new auth state FORCE_OFFLINE_PASSWORD which, unlike OFFLINE_PASSWORD,
can't be changed to any other.

BUG=397363
TBR=asargent@chromium.org

Review URL: https://codereview.chromium.org/456943003

Cr-Commit-Position: refs/heads/master@{#290096}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290096 0039d316-1c4b-4281-b951-d872f2087c98