GitLab

Move actual tests out of chrome/tests,
closer to code being tested.

Remove empty directory.

BUG=90905
Review URL: http://codereview.chromium.org/7576018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95623 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix needed for experiments with using unpatched sqlite.

BUG=22208

Review URL: http://codereview.chromium.org/7575027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95622 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Review URL: http://codereview.chromium.org/7584004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95621 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7464040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95620 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7582007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95619 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas
Review URL: http://codereview.chromium.org/7461141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7491059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95617 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95616 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7541041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95614 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Review URL: http://codereview.chromium.org/7572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95611 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman

BUG=91799
TEST=NetInternalsTest.NetInternalsPrerenderView
Review URL: http://codereview.chromium.org/7491058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95610 0039d316-1c4b-4281-b951-d872f2087c98

This replaces a lot of custom code with an implementation that reuses the
architecture of the menubar Bookmarks menu.

This CL introduces two minor regressions (bugs pending):
* Hover state is lost after menu is opened. Mousing out/back over fixes.
* The off-the-side menu contains all items from the bookmark bar.

BUG=78151
TEST=Click on a bookmark folder button. A menu opens.

Review URL: http://codereview.chromium.org/7465090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95609 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkBarEnabled policy also sets the kShowBookmarkBar pref, so that the pref is disabled in the preferences UI.

BUG=90731
TEST=Set the BookmarkBarEnabled policy. When true, the bookmark bar is always shown on the NTP. When false, it is never shown anywhere. In either case, it can't be modified by the user.


Review URL: http://codereview.chromium.org/7564011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88644
TEST='BrowsingDataQuotaHelperTest.*'


Review URL: http://codereview.chromium.org/7387007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95607 0039d316-1c4b-4281-b951-d872f2087c98

Testing infrastructure and tests for the cloud policy subsystem.

Review URL: http://codereview.chromium.org/7264019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95606 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=canary

Review URL: http://codereview.chromium.org/7541039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95604 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
Review URL: http://codereview.chromium.org/7569007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18611
TEST=Manual

Review URL: http://codereview.chromium.org/7566039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=canary
TBR=jianli

Review URL: http://codereview.chromium.org/7583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7562006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95597 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
BUG=79933,76354,78784,82716,88640,91465
Review URL: http://codereview.chromium.org/7491051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95596 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mkwst
TEST=builds OK
Review URL: http://codereview.chromium.org/7583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95595 0039d316-1c4b-4281-b951-d872f2087c98

Toplevel widgets need to be a native widget even when --use-pure-views.

BUG=None
TEST=No crashes on start-up with --use-pure-views.


Review URL: http://codereview.chromium.org/7574007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90996
TEST=test_shell_tests


Review URL: http://codereview.chromium.org/7533013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95591 0039d316-1c4b-4281-b951-d872f2087c98

A tiny fallout from issue 7489038

BUG=none
TEST=green bots

Review URL: http://codereview.chromium.org/7511008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95581 0039d316-1c4b-4281-b951-d872f2087c98

Enum may take 3 values:
* ENABLED (default) - both normal and incognito modes are allowed.
* DISABLED - incognito mode cannot be used.
* FORCED - browsing is only possible in incognito mode.

Mapped IncognitoEnabled::false to IncognitoModeAvailability::DISABLED when IncognitoModeAvailability policy/pref is not set.
Removed IncognitoEnabled pref (no longer used).

BUG=69580
TEST=


Review URL: http://codereview.chromium.org/7520023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95580 0039d316-1c4b-4281-b951-d872f2087c98

This CL disables/enables the Windows pre-read optimization based on a client-side coin-toss. The base::FieldTrial mechanism has not been used as it is not available until *after* chrome.dll is loaded, and this needs to occur before.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7508034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95579 0039d316-1c4b-4281-b951-d872f2087c98

This CL depends on http://codereview.chromium.org/7497028/.

BUG=None
TEST=manual, ran unit_tests

Review URL: http://codereview.chromium.org/7493077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=compiles

Review URL: http://codereview.chromium.org/7566053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95577 0039d316-1c4b-4281-b951-d872f2087c98

When share groups and pooled IDs are in use, a race condition exists when destroying resources since
the IDs are marked as free before the resource is actually freed.  Consider:

Context A creates a framebuffer with id 1
Context B is created in the same sharegroup as A
Context A destroys its framebuffer:
- the ID is freed (via FreeIDs(), which is a synchronous call)
- a DeleteFrameBuffersImmediate command is entered into A's command buffer but does not immediately execute
Context B creates a framebuffer
- genFramebuffer() makes a sync call to the service side, which reports that id 1 is available

At this point, if the service side processes and commands in context B's command stream, it will throw kInvalidArguments
because as far as the service side is concerned framebuffer 1 has never been released.

This patch adds a Flush() after destroying a resource so that the service side will process the resource destruction
command before servicing other command streams.  There's still a potential race condition if multiple contexts in the
same share groups are making calls from different threads, but today all contexts in the same share group are on the same thread.

BUG=80703
TEST=none


Review URL: http://codereview.chromium.org/7574024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95576 0039d316-1c4b-4281-b951-d872f2087c98

Revert 95534 - Creat BrowsingDataCookieHelper and CannedBrowsingDataCookieHelper for logging cookies at UI thread.
BUG=XXX
TEST=XXX

Review URL: http://codereview.chromium.org/7355025

TBR=ycxiao@chromium.org
Review URL: http://codereview.chromium.org/7491049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=stevenjb@chromium.org

Review URL: http://codereview.chromium.org/7575001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95574 0039d316-1c4b-4281-b951-d872f2087c98

Current implementation of RenderWidgetViewHostGtk::OnGrabNotify()
records the focus state obtained by gtk_widget_is_focus() when
other window get a grab, and set the stored state to the
input context on ungrab notification.

This CL changes to store the focus state of input context rather
than gtk_widget_is_focus(), and resolves the inconsistency issue.

BUG=chromium-os:15773
TEST=http://crosbug.com/15773#c20

Review URL: http://codereview.chromium.org/7548008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95573 0039d316-1c4b-4281-b951-d872f2087c98

-  Actually reuse BrowserAccessibility's when we receive an AXLoadComplete notification (switch from using CreateAccessibilityTree to UpdateNode).
-  add a check in BrowserAccessibilityManager::SetFocus to ensure we never try and ref count the same element.  This means we released an element (and thereby destroy it) before we add ref it again.  As it stands, the code does not encounter this case, since there's an implicit assumption that the focus_ element has ref count >= 2.
-  add logic to BrowserAccessibilityCocoa so that it can inherit directly from NSObject; this brings us in line with the way Webkit's AccessibilityObjectWrapper on Mac works.

This will hopefully set us up to solve the problem of VoiceOver not acknowledging page transitions.  The remaining issue is that RWHV's get destroyed on page transitions, thereby destroying our BrowserAccessibilityManager.  This is likely why VoiceOver won't honor our AXLoadComplete notification.

BUG=none
TEST=manual.


Review URL: http://codereview.chromium.org/7461104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95572 0039d316-1c4b-4281-b951-d872f2087c98

Revert 95552 - Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>.

We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with.

BUG=87457
TEST=none
R=abarth
TBR=darin

Review URL: http://codereview.chromium.org/7542029

Sorry about this. The tree stubbornly refuses to go green and yours is the only remaining patch in the blamelist.

TBR=erg@google.com
Review URL: http://codereview.chromium.org/7575035

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7550025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95571 0039d316-1c4b-4281-b951-d872f2087c98

Histograms that "clip" data (discard samples
over a given point) make it hard or impossible
to contrast results (such as via trimmed means).
As a result, a long standing note asked that these
histogram form no longer be used.
This CL removes all remaining uses, and discards
so histograms that are no longer significant (to
SDCH experimentation).  We transition to 
CUSTOM_HISTOGRAMS for all cases where the data
appears to be useful (and we provide new names
for the histograms).

r=rtenneti,wtc

Review URL: http://codereview.chromium.org/7553025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95570 0039d316-1c4b-4281-b951-d872f2087c98