- 01 Oct, 2018 40 commits
-
-
Jeremy Klein authored
Avoid installing the Android Messages PWA if prohibited by policy or if either the phone or Chromebook does not support it. Also listen for changes in feature state to install the app if something changes. Bug: 884290 Change-Id: I527828e68c3578e54a1ce15cace64e4ed2c81745 Reviewed-on: https://chromium-review.googlesource.com/1250209 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595466}
-
Mohsen Izadi authored
In HeadlessContentMainDelegate::RunProcess(), if the headless browser instance is destroyed before browser runner is shut down, GPU clients might end up accessing the destroyed object in the meantime. An example is when a client tries to establish a GPU channel ending up accessing destroyed HeadlessBrowserImpl::options in order to instantiate viz::GpuHostImpl. This CL changes the ordering to fix the race condition. BUG=881211 TEST=headless_browsertests --gtest_filter=HeadlessBrowserTest.* Change-Id: I2518eeefcc1e446a59d680fa78eab88e26765404 Reviewed-on: https://chromium-review.googlesource.com/1251331Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595465}
-
François Doray authored
This reverts commit 6caca443. Reason for revert: I suspect that this CL is causing https://crbug.com/890850 Original change's description: > Enable AudioServiceSandbox flag in audio service field trial testing. > > Bug: 832666 > Change-Id: I3ec5dbea8e34f3a9295723def845e49b2bb59af3 > Reviewed-on: https://chromium-review.googlesource.com/1240280 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595397} TBR=holte@chromium.org,marinaciocea@chromium.org Change-Id: I5e6d1a9e153003c086ce8c2f247230d4832ce99b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832666, 890850 Reviewed-on: https://chromium-review.googlesource.com/1254746Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595464}
-
Francois Doray authored
Multiple recent failures: Win7 Tests (1) - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84175 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84165 See failure log on the bug. TBR=droger@chromium.org Bug: 879443 Change-Id: Id3300df55adc2336c338cfeb0a3fd8c8e75d51b9 Reviewed-on: https://chromium-review.googlesource.com/1254562Reviewed-by:
-
Mario Sanchez Prada authored
There are no references to either ProfileOAuth2TokenServiceFactory or ProfileOAuth2TokenService, so these includes can be safely removed. Bug: 890237 Change-Id: If484fd41a20ef88b59a91777d741c368fc36ba17 Reviewed-on: https://chromium-review.googlesource.com/1251045Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595462}
-
Weidong Guo authored
This is a reland of e39c47e5 Original change's description: > Install app to first available position in app list > > Changes: > 1. Calculate the first available position in AppListModelUpdater for > newly added item. > 2. Add test coverage. > > Bug: 883939 > Test: AppListSyncableServiceTest.FirstAvailablePosition > Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319 > Reviewed-on: https://chromium-review.googlesource.com/1231193 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592539} Bug: 883939,887636 Change-Id: Id630fd99023a670ddcec52c977f20f3e1092f8b6 Reviewed-on: https://chromium-review.googlesource.com/1237256Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595461}
-
Eric Stevenson authored
The android-binary-size bot blocks CLs that do one of the following: * Increase normalized_apk_size > 16 kb * Add more than 50 Java methods * Add/increase the size of an uncompressed pak > 1 kb The trybot emits useful debugging information as bot steps and includes a link to an interactive Supersize HTML report. These checks are skipped for autorollers and for CLs with "Binary-Size:" in the commit message. Bug: 702625 Change-Id: I3e9dee26e96fd0d1cfe5f86ec1b8c717fa1abf2f Reviewed-on: https://chromium-review.googlesource.com/1254502Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595460}
-
Vaclav Brozek authored
The separation of the sync layer from the core has been a failed experiment. There has not been an embedder of the core which did not use sync, and in fact the core itself depends on a lot of sync-related code. Having the separate sync layer is now just confusing. Bug: 515108 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I65cc70b6a5e1ea1332ac9ae22de704cf757dc25e Reviewed-on: https://chromium-review.googlesource.com/1252583Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595459}
-
Chris Lu authored
AtrributesProvider was used in legacy reading list logic. FaviconLoader is now the preferred method. Bug: 878796 Change-Id: I009c762dfe7053e149c6b94b2145c4f68008a304 Reviewed-on: https://chromium-review.googlesource.com/1252523 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595458}
-
Robert Ma authored
This change appends the pinned depot_tools in Chromium checkout (at //src/third_party/depot_tools) to PATH so that the wpt_{import,export} scripts always work as long as we have a `gclient sync`ed checkout. The main reason for the change is to fix the scripts on LUCI, where depot_tools is no longer in PATH by default. Bug: 803111 Change-Id: I9242befa3dbc9e735ae3a618dcd5b8f5eff5579d Reviewed-on: https://chromium-review.googlesource.com/1252532Reviewed-by:Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#595457}
-
James Cook authored
The assertions were unclear because the test window was being created partially outside the display work area, resulting in it being moved from its initial coordinates. Make the simulated display bigger so the window isn't moved. Clarify and document the expectations. Bug: 890633 Test: ash_unittests Change-Id: Ie0ba065bc4d8f46a2cfd6ad24250d808845e8cd5 Reviewed-on: https://chromium-review.googlesource.com/1252384 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#595456}
-
Charlie Harrison authored
Web Speech API is not implemented on WebView. Bug: 890499 Change-Id: I0f8e94c5662f7213ff1d5ce5e13dbcab515bed66 Reviewed-on: https://chromium-review.googlesource.com/1254466Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#595455}
-
erikchen authored
The original CL didn't allow negative time skew from the time server. While this is likely correct, this caused unit tests to fail as they relied on negative time skew. This CL allows negative time skew, and also removes another source of non-determinism from the tests. Original change's description: > Use accurate X11 event timestamp computation. > > X events have a timestamp which is only well defined relative to the X11 Server > time. The previous computation for timestamp for X11 events was making the > assumption that Server time and Chrome time were the same. This assumption is > not always true -- this is likely the root cause of "bad" timestamps observed in > https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 > > This CL changes event timestamp computation to make a roundtrip to the X11 > Server to get an accurate base::TimeTicks. This logic was lifted out of the > responsiveness calculator, which was already doing this computation. The latter > will subsequently be changed to use the computation in this CL. > > Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 > Bug: 859155 > Reviewed-on: https://chromium-review.googlesource.com/1249383 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594844} Change-Id: I6595f6aa163a18c9724c50546ac8c84bc5c84a03 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1252685Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595454}
-
erikchen authored
The logic in NSMenuItem(ChromeAdditions) attempts to mimic Cocoa's logic for determining whether a NSMenuItem will fire for a given NSEvent. In keyboard layouts that produce non-ascii characters, Cocoa uses the event's "characters" property to process keyEquivalents, and will manually apply the shift modifier if necessary. Our logic was failing to do so. This meant that key combinations such as [cmd + shift + t] on 2-Set Korean would attempt to match a NSMenuItem with keyEquivalent "t" rather than a NSMenuItem with keyEquivalent "T". Bug: 889970 Change-Id: I81fdf11c4ffa6322d78e981cdbff6956cd8f4b79 Reviewed-on: https://chromium-review.googlesource.com/1254462Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595453}
-
Nicolas Ouellet-Payeur authored
This new method can be used to set a second source of rules for BrowserSwitcherSitelist, in addition to the 'url_list' and 'url_greylist' prefs. Once the IEEM sitelist download code is ready, we can use this method to apply the downloaded rules. Bug: 884837 Change-Id: I0e6d20a03fb27425dd3e9d7b9fd9b2b9fa19d163 Reviewed-on: https://chromium-review.googlesource.com/1249524Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#595452}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f340fa01e33..3ff52ffa22ae git log 4f340fa01e33..3ff52ffa22ae --date=short --no-merges --format='%ad %ae %s' 2018-10-01 kwiberg@webrtc.org Remove the useless ACMTest base class Created with: gclient setdep -r src/third_party/webrtc@3ff52ffa22ae The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7129aeef2d853d055268b2a313c96833930d8330 Reviewed-on: https://chromium-review.googlesource.com/1254183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595451}
-
David Jean authored
Bug: 889504 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I47312aad809a26534a9c7df8bb69a269837a65f2 Reviewed-on: https://chromium-review.googlesource.com/1250921 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#595450}
-
Mikel Astiz authored
The purpose of the two new tests is to verify whether the test fixture itself has flakiness issues, since most tests in the suite experience occasional flakes, see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_sync_shell_test_apk&tests=SyncCustomizationFragmentTest Bug: 879246 Change-Id: I616f075f56c91c19642b06c80a5af1f47653026b Reviewed-on: https://chromium-review.googlesource.com/1254203Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595449}
-
W. James MacLean authored
This CL removes crashkeys that were used in the debugging of the associated bug, and are now obsolete. TBR=creis@chromium.org Bug: 824774 Change-Id: If487ad93c55f0e32a87298e87af86a627e2b053c Reviewed-on: https://chromium-review.googlesource.com/1254143Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#595448}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 768f08a9. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25732 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If5475eecb78439fd3538198b1a2ab0a050bd04bb Reviewed-on: https://chromium-review.googlesource.com/1254241 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595447}
-
Mathias Carlen authored
R=rouslan@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: I0e45696a6946e33312190498c9b1c89877a4d58e Reviewed-on: https://chromium-review.googlesource.com/1245706Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595446}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Ic3deb3353377e950fadc0d011c75f7ed91ca5366 Reviewed-on: https://chromium-review.googlesource.com/1250923 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Nothing special, just doing some garderning. TBR=rjkroege@chromium.org Bug: 859012 Change-Id: I2f750bbf2438521109b48be5932c74f93a80dc35 Reviewed-on: https://chromium-review.googlesource.com/1254263Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595444}
-
Rayan Kanso authored
- Set is_resumable in the OfflineItem to true so that paused downloads can be resumed. - Fix deallocated memory access in the Abort workflow which was causing the browser to crash. Change-Id: I2369ffe517796c245b6d3351e4d90aa6b4a1510b Reviewed-on: https://chromium-review.googlesource.com/1253624 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595443}
-
chrome://sync-internalsMarc Treib authored
Additionaly, when RequestStart is triggered from sync-internals, also set first setup compelete to true (since a previous RequestStop(CLEAR_DATA) might have cleared it). (though this should help with investigating bugs like 890361 or 885211) Bug: none Change-Id: Ie670ee055f177304a824b29d7e625d06c67a6b59 Reviewed-on: https://chromium-review.googlesource.com/1251423 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595442}
-
Vaclav Brozek authored
There are two flags guarding support for detecting sync password reuse: (1) password_reuse_detection_support in components/password_manager/core/browser/BUILD.gn, and (2) SYNC_PASSWORD_REUSE_DETECTION_ENABLED in components/password_manager/core/browser/password_reuse_defines.h Those got out of sync, with the former excluding Android and the latter not. This can cause compilation errors. Furthermore, at some places, direct mentions of OS_* macros are used instead of SYNC_PASSWORD_REUSE_DETECTION_ENABLED. This breaks compilation if SYNC_PASSWORD_REUSE_DETECTION_ENABLED is changed. Therefore this CL defines (2) by (1) and abolishes password_reuse_defines.h completely. It also replaces OS_* macros with SYNC_PASSWORD_REUSE_DETECTION_ENABLED as appropriate. Finally, it adds "// nogncheck" to conditional #includes which would otherwise cause troubles, following the guidance of [1], and also adds a missing #include, which was found when switching password_reuse_detection_support to exclude Linux instead. [1] https://chromium.googlesource.com/chromium/src/+/eca97f87e275a7c9c5b7f13a65ff8635f0821d46/tools/gn/docs/reference.md#controlling-includes-individually Bug: 706392 Change-Id: I40113777be9440faccb4e80fbca2a3571e2f6110 Reviewed-on: https://chromium-review.googlesource.com/1252585Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bba2921c1970..e8e2bb1384ad git log bba2921c1970..e8e2bb1384ad --date=short --no-merges --format='%ad %ae %s' 2018-10-01 robertphillips@google.com Test YUV images in DDL Created with: gclient setdep -r src/third_party/skia@e8e2bb1384ad The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: If838c87135789ec6c9684b5144d4ed165a63f8b8 Reviewed-on: https://chromium-review.googlesource.com/1254182Reviewed-by:
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Ia158d98717cf0360870f46eeabca0777b1954ec1 Reviewed-on: https://chromium-review.googlesource.com/1243143Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#595439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/279decb72e03..8dfa5c869e08 Created with: gclient setdep -r src-internal@8dfa5c869e08 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iecbf708d862a34c46e9c8ca04a45e6369514992c Reviewed-on: https://chromium-review.googlesource.com/1254181Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595438}
-
Hirokazu Honda authored
Add DCHECK(thread_checker_.CalledOnValidThread()) so that a reader can figure out easily what thread should execute a function. BUG=None TEST=VEA unittest on eve and veyron_minnie with dcheck_always_on Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0f3f0a777f97cbb095d498fe8c70355377cdcf21 Reviewed-on: https://chromium-review.googlesource.com/1005374Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595437}
-
Maksim Sisov authored
It turned out that it was not a good idea to try to guess buffer formats if a Wayland compositor had not announced supported buffer formats. If such a case happened (the Wayland compositor did not announce the formats), guessing them resulted in crashes in YouTube videos for example. Thus, it's better to fallback to software GpuMemoryBuffers rather than crashing. What is more, the Wayland spec says it must announce the supported formats once zwp_linux_dmabuf interface is bound, but in some versions of the compositors it does not happen. It looks more like a bug, which must be reported. Bug: 890284 Change-Id: I9bd20019709b0cbd82fa9654627b825adceb479b Reviewed-on: https://chromium-review.googlesource.com/1253641Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595436}
-
Alex Clarke authored
The bug was operator++ shouln't assume index zero is the front of the ring's buffer. This patch also improves test coverage of LazilyDeallocatedDeque. Change-Id: I8d8a6dd50177a44ab78ef4262a794d6175898864 Reviewed-on: https://chromium-review.googlesource.com/1253982Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595435}
-
Vaclav Brozek authored
Presubmit checks flag some deprecated functions in the sync layer of password_manager component. This CL fixes those issues to unblock merging that layer with the core layer in a separate CL. The two most frequent fixes here are: * Replacing base::Closure with base::RepeatingClosure in cases when this seems intended. Note 1: Closure is currently an alias for RepeatingClosure, so this results in no change. Note 2: There was also one case when OnceClosure was more appropriate. This was handled in https://crrev.com/c/1252582. * arraysize -> base::size; this is the encouraged and a straightforward change Bug: 515108 Change-Id: I554cff1c1ef1965eab82f87bbd3fceb92c2ebd41 Reviewed-on: https://chromium-review.googlesource.com/1252745Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595434}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I4ed9022a181156fdfb13210d00c1b947a9a0df51 Reviewed-on: https://chromium-review.googlesource.com/1253168Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#595433}
-
Javier Ernesto Flores Robles authored
Adds iOS usage key for face ID to the plist file. Bug: 889430 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I75aaeb919f6d68c105e8a7711c5d0ca1a70aec3d Reviewed-on: https://chromium-review.googlesource.com/1245371 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595432}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ba5eaee9a23e..4f340fa01e33 git log ba5eaee9a23e..4f340fa01e33 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 mbonadei@webrtc.org Compile audio_device without -Wno-global-constructors. 2018-10-01 srte@webrtc.org Adds allocated rate without feedback to new congestion controller. 2018-10-01 mbonadei@webrtc.org Remove runtime_enabled_feature. Created with: gclient setdep -r src/third_party/webrtc@4f340fa01e33 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc3b81b65922aadfc6419963a7e1ee38434a3c17 Reviewed-on: https://chromium-review.googlesource.com/1253823Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e133d78eb6b1..279decb72e03 Created with: gclient setdep -r src-internal@279decb72e03 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6058f86d81c3de197723c8fc93413d3848481c80 Reviewed-on: https://chromium-review.googlesource.com/1253824Reviewed-by:
-
Greg Kraynov authored
In order to remove unrelevant clutter from TaskQueue which eventually will become a lean interface. TBR=gab@chromium.org Bug: 865411 Change-Id: Ia0e2284c745895cf2869308be8af3fa164438dff Reviewed-on: https://chromium-review.googlesource.com/1245469 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78374c5b9264..ac93684421fa git log 78374c5b9264..ac93684421fa --date=short --no-merges --format='%ad %ae %s' 2018-10-01 dtu@chromium.org [pinpoint] Make "patch not found" an HTTP 400 instead of a 500. 2018-10-01 perezju@chromium.org [pinpoint_cli] Add command to download results as csv 2018-10-01 perezju@chromium.org [pinpoint_cli] Cache locally content from isolate digests Created with: gclient setdep -r src/third_party/catapult@ac93684421fa The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:889875,chromium:879526,chromium:879526 TBR=sullivan@chromium.org Change-Id: I08d1f0e25bfc78f84b5b97b380f52d85f6e1a53b Reviewed-on: https://chromium-review.googlesource.com/1253822Reviewed-by:
-
Hans Wennborg authored
Bug: none Change-Id: I7c267cf630c6e8ee29bbf39b295adc6c9e4bbd93 Reviewed-on: https://chromium-review.googlesource.com/1252589Reviewed-by:
-
