- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1a3011cd912..469db8fabd5f 2021-01-12 rainhard@chromium.org Disable testPressEndAndHome on linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1165318 Tbr: sadrul@google.com Change-Id: I507eabd6da83e22b561277640efcdab39d6d683b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842501}
-
Harald Alvestrand authored
Bug: chromium:1165692 Change-Id: Ie4ae544d1814384af134080541a60a6778ccbc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623210 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842500}
-
Viktor Semeniuk authored
This change adds an API to retrieve the insecure credentials information for a specific password form primary key. Follow up patches will use this API to sync such information across devices. Bug: 1137775 Change-Id: I1c29809d53abdb0c501c00904dc506963b69beb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592996 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842499}
-
Karandeep Bhatia authored
Autogenerated header portion: https://paste.googleplex.com/5925546069327872 Autogenerated cc file portion: https://paste.googleplex.com/5362596115906560 BUG=1113513 Change-Id: I237b6fe5744059296754d5dc93213c9b9d5ea83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616814Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842498}
-
Rune Lillesveen authored
Bug: 1146097 Change-Id: I73f285c2c8cc828ae11132ae3c57148670b30b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621813Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#842497}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. This is a follow up CL that allows usage of policy enforced update URL in chrome/browser/extensions/. Bug: b:175767492 Change-Id: Ib3904683fc3dcec0e4690e3c558a9346e859ae45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593101 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a60056fee789..7297ea89b095 2021-01-12 almuthanna@google.com Add E2E test for syntax highlighting test case 2021-01-12 janscheffler@chromium.org [JSDOC2TS]: Migrate web_audio If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic49458489c10dc62b2a8c4179bbf6b2c19934095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623830Reviewed-by:
-
Hiroki Nakagawa authored
Callers of GetPrerenderMode() don't have to know PrerenderMode. They just want to know if the render frame is used for prerendering (NoStatePrefetch). Therefore, this CL replaces GetPrerenderMode() calls with PrerenderHelper::IsPrerendering() for code simplification. Bug: 755921 Change-Id: Ibaf7ab7a2b1759a8f18d3a6488444f9edd832de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596285Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa6859ae9056..019ddccc581e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: Ib0262a202f935160db28fdadceed58319a347499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623831Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842493}
-
Hans Wennborg authored
The LLVM code keeps running into issues with the GCC version we've been using so far (5.3.0). Try a more recent version to hopefully get fewer problems. This was built on a Trusty machine, according to the recipe at https://bugs.chromium.org/p/chromium/issues/detail?id=929645#c9 Bug: 1164952 Change-Id: If5e015d011417bc5b9669829ceefae3266808e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622968 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842492}
-
Thomas Tellier authored
Bug: 1136092 Change-Id: Ibe736b6ad40c343c1a7b3d946328849916583a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601374Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#842491}
-
Ulan Degenbaev authored
They were marked as tentative because they were written before the spec. Now the spec is completed and the tests align with the spec. Bug: 1085129 Change-Id: Ieee736a0f54af97e6f0cf2d6bad3c0a7afec2738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620565 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842490}
-
Ian Kilpatrick authored
Bug: 1164135, 1164474 Change-Id: I8c74220ba1d613b3723c56a3c5960e2061f9d16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623675 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842489}
-
sauski authored
Extends the survey cooldown period to 180 days for both any survey, and any particular survey. Also moves the preference to be synced so that the survey cooldowns apply across synced user devices. Bug: 1110888 Change-Id: Ic04d18d9551b809ae4ee10fe7b174a1b60567a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599534 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#842488}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..bd6bd346f677 2021-01-12 skyostil@google.com Merge "tracing: Allow passing custom timestamp types into TRACE_EVENT" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id13b6c92fa67a4c8302b8e5e63ee4d6d749b9e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623032Reviewed-by:
-
Maksim Moskvitin authored
Significant part of components/invalidation was under syncer namespace, while other part was under invalidation namespace. This CL makes components/invalidation content consistently using invalidation namespace. This CL is a pure refactoring. Bug: 1031125 Change-Id: I37614c39c79b05cca457a2f8619d1f5bfdf1546d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617850Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#842486}
-
Rainhard Findling authored
This reverts commit db11bed9. Reason for revert: 1165728 Original change's description: > [Subresource Filter] Add content settings-based adjustment to WebLayer > > This CL incorporates Chrome's adjustment of subresource filter page > activation decisions based on content settings within WebLayer. To do > so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle > directly invoke the logic in question rather than having > ChromeSubresourceFilterClient do so. That change necessitates some > others, also made in this CL: > - WebLayer brings up ProfileInteractionManager. > - SubresourceFilterClient provides an accessor for > ProfileInteractionManager. > - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment > logic via a new Delegate interface rather than doing so via > SubresourceFilterClient. This interface is implemented by > ProfileInteractionManager in production while allowing for porting of > tests that provide custom (or nil) stub logic. > > We also add browsertests of this interaction in //weblayer. > > Note that this CL does not do any incorporation of the relevant *UI* > for content/site settings of ad blocking in WebLayer; that will be > followup work. > > This CL is a reland. The original CL was reverted as the introduced > tests were flaky. I have since debugged the source of the flake; the > fix is contained in the diff between PS1 and PS2. It turned out to be > a pre-existing problem in //weblayer's > subresource_filter_browsertest.cc that the new tests simply tickled: > I was holding the TestRulesetCreator in a local variable and sending > the temporary files that it creates to renderer processes, but it > destroys those temporary files when it is destroyed. D'oh! > > Bug: 1116095 > Change-Id: I25f5dca647761f652c9d5a2dfc41db1a4d7712b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622215 > Auto-Submit: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842429} TBR=blundell@chromium.org,csharrison@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic15653af6a972ec0f8e8e66d274bd99aeb8f6179 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621758Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842485}
-
Matthew Mourgos authored
This change implements the events added to the virtual keyboard private api. These events include onClipboardHistoryChanged and onClipboardItemUpdated. onClipboardHistoryChanged will notify api listeners whenever the list of items in the clipboard history has any changes. onClipboardItemUpdated will notify api listeners when an existing item in the clipboard history has changed, and will send the new data for that existing item. Bug: 1099318 Change-Id: If788cc2f168b14c43096a395ac9c1e1a03e0eed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595258 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842484}
-
Rune Lillesveen authored
Traverse child if we are updating container query dependent descendants even if the child is not affected. Bug: 1146097 Change-Id: I4beeee65b9c25469ef052abef75701f077f5cc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621757Reviewed-by:
-
Jack Franklin authored
https://crrev.com/c/2622193 removes Set#firstValue from the DevTools utils as it is not used in the codebase - this layout test is the only place to use it across Chromium, so I've rewritten it to inline the functionality. Bug: chromium:1050549 Change-Id: I86093d63aa9cf086fbc06092f8dcc4eb7c4b86f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623928 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842482}
-
Igor authored
The policy for device account is passed to Lacros through LacrosInitParams. The data is used by the new class, PolicyLoaderLacros. The implementationis based on prototype from https://chromium-review.googlesource.com/c/chromium/src/+/2353454 Bug: chromium:1114069 Test: Manual testing on the device Change-Id: Ifbd6c930ae4ce17ab85c808d8d7783e6c6fc7ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521121 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73995827981d..aa6859ae9056 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: Ib034281d18830581a2aeb7b659dec2338ac0e8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623829Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610420273-ecb28c29a45742c5cbc86dad1c6df0817cb1d9b6.profdata to chrome-win64-master-1610431066-60b154442ebb054827e182b9c834d6f36e05d2b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icb4685754298b32747fe454ca2a9eb79dd009a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624054Reviewed-by:
-
Makoto Shimazu authored
The method has been introduced for ServiceWorkerOnUI. The feature has already fully launched, so let's remove it. Unfortunately, I found a few methods still need to be called from the IO thread. Instead of changing the callsites, this CL simply keeps those methods callbable from any threads. Updated the comment along with that. Bug: 1138155 Change-Id: If919c1f87fc2d6d5ce5e74f1254eb0f41676acc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599573 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842478}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12cf8695092d..a60056fee789 2021-01-12 jacktfranklin@chromium.org Migrate Number.toFixedIfFloating to utilities 2021-01-12 patrick.brosset@microsoft.com Don't emulate screen size for fullsize shots to avoid unwanted resizing 2021-01-12 szuend@chromium.org Show error icon in the Trust Token tab label if the operation failed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1126824,chromium:1158735 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f20e763e9f00ee9a21062443d2837e6f81d88ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622598Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bdbcbe94074d..7f0e7d0d262a 2021-01-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 734de1a6 to 2a7e78c7 (67 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I429eec61d1ba6b6c89a999b202a2e93bd93df3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624058Reviewed-by:
-
Stephane Zermatten authored
With this change when scroll-to-hide is enabled in the JITT UI, scrolling down on the browser page hides the bottom sheet and scrolling up reveals it again. Change-Id: I92f9753b09d25443293e5a1b4cb23bc8c3cfb3d3 Bug: b/171792266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599864 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#842475}
-
Jordan Demeulenaere authored
This CL changes the height and margins of the details placeholders so that it looks better when multiple placeholders are displayed. The height and margins are fixed, to optimize the case where we have 2 or 3 text placeholders displayed [1]. [1] b/174652960#comment14 Bug: b/174652960 Change-Id: I2e33570dee7767c58ba531b10e250ec50b23e0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600819 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
Prior to this change PasswordForm's IsPossibleChangePasswordForm() simply checked whether the new_password_field member was not the empty string. This relied on setting it to a non-empty name during form parsing if a new password field was found. However, it thus was unable to disinguish missing new password fields from existing ones without a name. This change fixes this issue by checking that new_password_field_renderer_id is set instead. Fixed: 1164971 Change-Id: Icb0c6ab8d7841b7ecc3f7c09088be659b240f7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622432Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842473}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e5a5d24..72490734 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If560c3e36b8bb28699727c5914ec37fbad2f6504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624051Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842472}
-
Benoit Lize authored
ThreadCacheRegistry::StartPeriodicPurge() can be called several times, triggering a DCHECK(), or posting multiple tasks on non-DCHECK() builds. This happens in particular when the browser is first started in minimal mode, then in regular mode on Android. Make sure that only one task is posted. Issue discovered by tasak@. Bug: 998048 Change-Id: I7cea58fa0f49487504869f87fec8490e04616aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613840Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842471}
-
Daniel Cheng authored
When committing a navigation with no frame swap, unload handlers would run before the new Document commits. However, when committing a navigation with a frame swap, unload handlers would not run until after the new Document had already committed, since //content was responsible for swapping out the old frame only after Blink reported that the navigation committed in the new frame. This CL moves the logic for triggering the swap into Blink, so that unload handlers run with the same timing whether or not a frame swap is involved. Bug: 1063150 Fixed: 1153043 Change-Id: Ifa3364affc11861f1a5485b163205af128612c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603041 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842470}
-
Heng-Ruey Hsu authored
This is a reland of db6fcd22. Original change's description: > Creates a virtual device when CCA opens a camera. > > Bug: b:151047537 > Test: Manually test > Change-Id: I3a2196e32e18ecfb127553f47178f8ebe43656c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351933 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837425} TBR=wtlee@chromium.org,rsesek@chromium.org Bug: b:151047537 Test: Manually test. Change-Id: I3d06b0aecd972024b89582ce4847075da3b55b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612314Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842469}
-
Dan Elphick authored
Now that v8 declares V8_USE_PERFETTO as an external definition that appears whenever including the main V8 headers (https://chromium-review.googlesource.com/c/v8/v8/+/2621083), we can remove its definition from gin. Bug: 1006541 Change-Id: I5b48bedfce1588c078fda0c307c0f345dcb222ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622096 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#842468}
-
Marc Treib authored
This adds a new feature param which, when set to true, sets the default password store to the account store when the user opts in to the account storage. This is mostly meaningful together with the |kSaveToProfileStoreByDefault| feature param. This is a follow-up to https://crrev.com/c/2599529. Bug: 1160655 Change-Id: Ia3a39ee1002b456ff09bec04b774e6f37ec85d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622115Reviewed-by:
-
Minoru Chikamune authored
[MBI] Return per-AgentSchedulingGroup default task runner from ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() The MBI project is introducing a scheduling boundary called AgentSchedulingGroup (ASG in short). Per-thread task runners are implicitly used by calling base::ThreadTaskRunnerHandle::Get() (TTRH::Get() in short) and base::SequencedTaskRunnerHandle::Get() (STRH::Get() in short). This CL changes the contract of TTRH::Get() and STRH::Get() to return per-ASG task runners instead of per-thread task runners so that the callsites of TTRH::Get() and STRH::Get() use the per-ASG task runners when there is an active ASG. [Design Doc] https://docs.google.com/document/d/1zHkk2z-iwUrTczayT3xkL3gz12xxjJ_aOtVjqKsBCvw/edit?ts=5fbf2f4b&resourcekey=0-4Sbdx2v7kLvdawkNpp3DdQ Bug: 1105403 Change-Id: I153c3bf72e66580d838cf053de48d4d7048fa542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550326 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Tal Pressman <talp@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#842466}
-
Alice Wang authored
This CL refactors and tests ForcedSigninProcessor. Bug: 1045525 Change-Id: Id4948e2c546ddb7e0bee374e5ff2fdf5530f6afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617941 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842465}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13694cecae39..73995827981d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: I141896158ba767997140f075e6ab9b6e52ae6bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624147Reviewed-by:
-
Sanja Perisic authored
Added support for disabling Chrome Web Store if SystemFeaturesDisableList policy is set Bug: 1142785 Test: SystemFeaturesPolicyTest.DisableWebStoreBeforeInstall, SystemFeaturesPolicyTest.DisableWebStoreAfterInstall, SystemFeaturesPolicyTest.DisableCameraAndWebStoreAfterInstall Change-Id: Iab279d250a07bdd866b4d8dfb6761f55507d8848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606351 Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#842463}
-
Jordan Demeulenaere authored
Before this CL, only the details image could be replaced by an animated placeholder. This CL exposes a new PlaceholdersConfiguration in the DetailsProto to configure the placeholders shown in the details, so that we can also have a placeholder behind the title and descriptions. Some UI changes will still need to be done in a follow-up CL, given that right now there is no space between the placeholders, which looks a bit weird. Bug: b/174652960 Change-Id: Iededbae9e7393d9fe9d505faa33b5dee6da83c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599860Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#842462}
-
